Files
PaperClipAI/tests/runner-e2e/chat-flow.test.ts
T
f4337bb5fb test(evals): land the chat catalog eval harness on master (#19614)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - The chat-feature evals measure whether agents complete real chat
requests through the product
> - The chat catalog eval harness and its repairs live on the
`chat-eval/master-candidate` branch, not on master
> - Today's work made 139 of 242 chat evals pass in verified single-case
live runs. Each product fix landed on master as its own pull request
> - The eval-side changes (setups, graders, fault seams, evidence
capture) still exist only on the candidate
> - This pull request lands the harness on master. Master stays the
source of truth for product behavior
> - The benefit is one tree: evals run against master commits, and
product fixes reach the evals as soon as they merge

## Linked Issues or Issue Description

Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs
#20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409

**What existing behavior does this improve?**
The chat catalog eval harness and the product it evaluates live on a
long-running branch outside master. Eval fixes do not reach master, so
master-based eval runs use old setups and graders.

**Subsystem affected**
`tests/runner-e2e` chat catalog harness, plus a small set of product
changes that exist only on the candidate.

**Proposed change**
Land the harness on master. Every product fix from this eval work
already merged to master as its own pull request. Conflicts keep
master's product behavior.

## What Changed

- Most of the diff (808 of 851 files) is under `tests/runner-e2e/`:
chat-catalog domains, scenarios, descriptors, the TestOps manifest,
private evidence tooling, and their tests.
- Graders now check saved state, setup literals and rendered or clicked
links. Many keyword and regex checks on free-form replies are removed.
Each changed grader has a bumped `oracleVersion` and calibration tests
(a valid reply, a reworded valid reply, and broken variants that must
fail).
- The shared link helper `hasLink` no longer treats a list link (for
example `/COM/issues?view=mine`) as a link to every task without a URL
key.
- Setup fixes build real state through supported product routes: routine
history, agent grants through the board grant route, budget holds with a
real cap, and a storage-layer archive fault for
`inbox-search.archive-partial-failure`.
- Browser boundary journeys (sign-in, chat-disabled, onboarding) now
write the standard pass evidence files.
- Retargeted cases, approved by the maintainer:
`agent-chat.chat-disabled` (Conference Room gate),
`agents.restore-instructions` (no saved instruction history),
`access.manage-membership` (member permission edits stay board-only).
- The private evidence trusted files (`manual-private-handoff.ts`,
`manual-private-retention.ts`, `manual-private-report-assets.ts`) are
byte-identical to master.
- Product files outside `tests/` (43 files, +1,328 −49) carry
candidate-only changes that master does not yet have. Most are tests.
The main code changes are in `request-human-input.ts`,
`heartbeat-run-summary.ts`, `native-completion-feedback.ts`,
`native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and
`IssueChatLongThreadPerf.tsx`.

## Verification

- `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts
chat-catalog-consistency.test.ts unit-launcher.test.mjs
--testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests
pass.
- `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass.
- `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`:
no change.
- `tsc` for `server` and `tests/runner-e2e`: clean.
- Live single-case verification: 139 of 242 cases passed on paid runs,
and a person read the saved evidence for each. These are single-case
runs, not one full-cohort run.

## Risks

- Large diff. Most of it is test-only, but the 43 non-test files change
product code paths. Review those files first.
- Some graders are now less strict on reply wording. A person must read
replies for meaning on those cases.
- 42 cases need disposable outside accounts (Notion, Slack, GitHub,
Daytona and others) and stay blocked. `access.invite-teammate` stays
failing until local agent isolation lands, because the runner's durable
state keeps a live invite token.
- The paid workflow compares the trusted private-evidence files with
master. They are unchanged, so this risk is low.

## Model Used

Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code
execution, in Claude Code. Subagents used the same model.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-11-10 08:02:11 -06:00

510 lines
24 KiB
TypeScript

import { describe, it, expect, vi } from "vitest";
import type { AskUserQuestionsPayload } from "../../packages/shared/src/types/issue.js";
import {
assertChatBacklogCreation,
assertChatHandoff,
assertChatReassignment,
assertChatTaskHandoff,
chatQuestionPresentation,
chatRunFailure,
chatTaskCompletionFailure,
createChatIdleFailureDetector,
collectChatRunEvidence,
readRunningChatLog,
readChatOutputDocument,
isChatClarificationReply,
assertChatExecutionOutput,
isResetRun,
type ChatIssue,
type ChatRun,
} from "./chat-flow.js";
import type { RunnerApi } from "./api.js";
import { chatMarker } from "./chat-cases.js";
import { runnerMatrix } from "./catalog.js";
import { isPublicRunnerScreenshotRoute } from "./screenshot-policy.js";
import { classifyFailure, shouldRetryFailure } from "./failure-classifier.js";
const source: ChatIssue = {
id: "chat",
companyId: "co",
title: "Chat",
status: "in_review",
assigneeAgentId: "agent",
};
const task: ChatIssue = {
...source,
id: "work",
parentId: null,
projectId: "project",
};
const plan = {
body: "# Relevant plan",
latestRevisionId: "revision",
updatedAt: "2026-09-11T10:00:00Z",
};
const run: ChatRun = {
id: "run",
companyId: "co",
agentId: "agent",
status: "succeeded",
startedAt: "2026-09-11T10:00:01Z",
};
describe("chat acceptance contracts", () => {
it("accepts concrete information requests without requiring question punctuation", () => {
expect(isChatClarificationReply("What is the club name?")).toBe(true);
expect(
isChatClarificationReply(
"Before assigning the welcome-note work, please share:\n\n1. Club name and intended readers.\n2. Format, length, and tone.\n3. Required details, sender, and deadline.",
),
).toBe(true);
expect(
isChatClarificationReply("Tell me the intended audience and format."),
).toBe(true);
expect(
isChatClarificationReply(
"Thanks — before assigning the welcome-note drafting work, I need a compact brief covering:\n\n- Club and audience: club name and intended readers.\n- Purpose: welcome or next steps.\n- Required content: dates, links, and contacts.\n- Voice: tone and sender.\n- Delivery constraints: format, length, and deadline.\n- Examples or policies: existing notes and approval requirements.",
),
).toBe(true);
expect(isChatClarificationReply("I'll need your details about the audience and format.")).toBe(true);
expect(isChatClarificationReply("We need some information about the club and intended readers.")).toBe(true);
expect(isChatClarificationReply("I needed a compact brief before I assigned the work.")).toBe(false);
expect(isChatClarificationReply("I need a compact brief:")).toBe(false);
expect(isChatClarificationReply("I need information.")).toBe(false);
expect(isChatClarificationReply("I need to create the task and write the note.")).toBe(false);
expect(isChatClarificationReply("Please share:")).toBe(false);
expect(isChatClarificationReply("Please share.")).toBe(false);
expect(
isChatClarificationReply("Asked the user clarifying questions about their club."),
).toBe(false);
expect(
isChatClarificationReply("I created the task and started writing the welcome note."),
).toBe(false);
});
it("recognizes the retained clarification list without treating empty requests or execution plans as clarification", () => {
// Reduced public reply from gha-36307603818-1 / agent-chat.legacy-codex.local.clarify-reuse.
expect(isChatClarificationReply(`Absolutely. Before I assign the writing, I need:
- Club name and what the club is about
- Who the note welcomes (new members, event guests, website visitors, etc.)
- Where the note will appear and your preferred length
- Tone (warm, formal, playful, energetic, or another style)
- Any must-include details: benefits, meeting information, values, next step, or signatory
If you only have the club name, audience, and tone, that is enough to begin; I can make sensible assumptions about the rest.`)).toBe(true);
expect(isChatClarificationReply("We need:\n1. Intended readers\n2. Delivery date")).toBe(true);
for (const body of ["I need:", "I need:\n- .\n- ...", "I needed:\n- Audience\n- Tone",
"I need:\n- to create the task\n- to write the note", "I need to create the task and write the note.",
"I need:\n- Create the task\n- Write the note", "We need:\n1. **Build** the page\n2. **Publish** the site",
"I need:\n- Plan the note\n- Draft it", "I need:\n- [ ] Create task\n- [ ] Write note"]) {
expect(isChatClarificationReply(body), body).toBe(false);
}
});
it("checks the requested information list separately from a later plan", () => {
expect(isChatClarificationReply("I need:\n- Audience\n- Tone\n\nOnce you answer, the plan is:\n- Create the task\n- Write the note")).toBe(true);
});
it("requires information fields or questions rather than arbitrary non-blacklisted bullets", () => {
expect(isChatClarificationReply("I need:\n- Set up the project\n- Install dependencies")).toBe(false);
expect(isChatClarificationReply("I need:\n- Gather the audience details\n- Decide the tone")).toBe(false);
expect(isChatClarificationReply("I need:\n- Audience\n- Install dependencies")).toBe(false);
expect(isChatClarificationReply("I need:\n- **Audience**: intended readers\n\n- [ ] Preferred format\n- When this is due")).toBe(true);
});
it("accepts logistical brief fields and wrapped information items", () => {
expect(isChatClarificationReply("I need:\n- Budget\n- Location")).toBe(true);
expect(isChatClarificationReply("I need:\n- Audience, including age range\nand whether these are new or existing members\n- Tone\n\nOnce you answer, I can:\n- Draft the note\n- Publish it")).toBe(true);
expect(isChatClarificationReply("I need:\n- Audience, including age range\n and whether these are new or existing members\n- Tone")).toBe(true);
});
it("rejects superseded plan requirements in executed output, independently of plan history", () => {
expect(() => assertChatExecutionOutput("Welcome CHAT123.", "CHAT123", "DRAFT123")).not.toThrow();
expect(() => assertChatExecutionOutput("Welcome DRAFT123 and CHAT123.", "CHAT123", "DRAFT123")).toThrow();
expect(() => assertChatExecutionOutput("Welcome DRAFT123.", "CHAT123", "DRAFT123")).toThrow();
});
it("keeps chat markers literal across rich-text and Markdown boundaries", () => {
for (const prefix of ["CHAT", "DRAFT", "OLDCONTEXT"] as const) {
expect(chatMarker(prefix, "abc123-1")).toBe(`${prefix}abc1231`);
expect(chatMarker(prefix, "abc_123-1")).toMatch(/^[a-zA-Z0-9]+$/);
}
expect(chatMarker("OLDCONTEXT", "one-1")).not.toBe(
chatMarker("CHAT", "one-1"),
);
expect(chatMarker("CHAT", "one-1")).not.toBe(chatMarker("CHAT", "two-1"));
});
it("covers existing workflows and native reassignment on the chosen local profiles", () => {
const matrix = runnerMatrix.filter(
(cell) => cell.suite.id === "agent-chat",
);
expect(matrix).toHaveLength(28);
expect(new Set(matrix.map((cell) => cell.profile.id))).toEqual(
new Set([
"legacy-codex",
"legacy-claude",
"runner-codex",
"runner-acpx-claude",
]),
);
expect(new Set(matrix.map((cell) => cell.task.id)).size).toBe(8);
expect(
matrix.every(
(cell) =>
cell.environment.id === "local" &&
cell.task.expectedTerminalState.issue === "in_review",
),
).toBe(true);
});
it("rejects missing plan, chat children, wrong assignments, and execution before the plan", () => {
expect(() => assertChatHandoff(task, plan, [run], source)).not.toThrow();
for (const invalid of [
{ ...task, parentId: "chat" },
{ ...task, projectId: null },
{ ...task, assigneeAgentId: "other" },
])
expect(() => assertChatHandoff(invalid, plan, [run], source)).toThrow();
expect(() =>
assertChatHandoff(task, { ...plan, body: "" }, [run], source),
).toThrow();
expect(() =>
assertChatHandoff(
task,
{ ...plan, updatedAt: "2026-09-11T10:00:02Z" },
[run],
source,
),
).toThrow();
expect(() => assertChatHandoff(task, plan, [], source)).toThrow();
});
it("requires a plan for plan handoff, while direct requests need only normal task assignment", () => {
expect(() => assertChatTaskHandoff(task, [run], source)).not.toThrow();
expect(() =>
assertChatHandoff(task, { ...plan, body: "" }, [run], source),
).toThrow();
expect(() =>
assertChatTaskHandoff({ ...task, projectId: null }, [run], source),
).toThrow();
});
it("still rejects completed chat work that has lost its assignee", () => {
expect(() => assertChatTaskHandoff({ ...task, status: "done" }, [run], source)).not.toThrow();
expect(() => assertChatTaskHandoff({ ...task, status: "done", assigneeAgentId: null }, [run], source)).toThrow();
});
it.each(["project-description", "welcome-note", "output"])("finds committed %s output without accepting a copied plan or a claim", async (key) => {
const output = {
...plan,
id: "description-doc",
issueId: "work",
key,
body: "A completed description with CHAT123.",
createdByAgentId: "agent",
};
const get = vi.fn(async (path: string) => {
if (path === "/api/issues/work/documents")
return [{ key: "plan" }, { key }];
if (path === `/api/issues/work/documents/${key}`)
return output;
throw new Error(`Unexpected document read: ${path}`);
});
const api = { get } as Pick<RunnerApi, "get">;
await expect(readChatOutputDocument(api, "work", "CHAT123")).resolves.toBe(
output,
);
await expect(readChatOutputDocument(api, "work", "WRONG123")).rejects.toThrow(
"no non-plan output document",
);
get.mockImplementation(async () => [{ key: "plan" }]);
await expect(readChatOutputDocument(api, "work", "CHAT123")).rejects.toThrow(
"document keys: plan",
);
});
it("uses durable free-text labels, multi-selection, and the supplied submit label", () => {
const payload: AskUserQuestionsPayload = {
version: 1,
submitLabel: "Send brief",
questions: [
{
id: "audience",
prompt: "Who is it for?",
selectionMode: "multi",
required: true,
options: [
{ id: "members", label: "New members" },
{
id: "custom",
label: "Another audience or occasion",
freeText: true,
},
],
},
],
};
const presentation = chatQuestionPresentation(payload);
expect(presentation.submitLabel).toBe("Send brief");
expect(presentation.questions[0]).toMatchObject({
answerMode: "multi_select",
customAnswer: { enabled: true, label: "Another audience or occasion" },
});
const nativePayload: AskUserQuestionsPayload = {
...payload,
questionSet: {
schema: "paperclip.question_set.v1",
submitLabel: "Continue",
questions: [
{
id: "audience",
prompt: "Who is it for?",
required: true,
answerMode: "text",
},
],
},
};
expect(chatQuestionPresentation(nativePayload)).toBe(
nativePayload.questionSet,
);
});
it("retains reset events without requesting a provider log, and does not hide missing real logs", async () => {
const get = vi.fn().mockResolvedValue([{ seq: 1, type: "session_reset" }]);
const reset = { ...run, resultJson: { conversationReset: true } };
await expect(collectChatRunEvidence({ get, getRunObservation: get }, reset)).resolves.toEqual({
runId: run.id,
log: null,
events: [{ seq: 1, type: "session_reset" }],
});
expect(get.mock.calls).toEqual([
[`/api/heartbeat-runs/${run.id}/events?afterSeq=0&limit=1000`],
]);
get.mockRejectedValue(new Error("Run log not found"));
await expect(collectChatRunEvidence({ get, getRunObservation: get }, run)).rejects.toThrow(
"Run log not found",
);
});
it("retains the tail of a long chat run for invariant checks", async () => {
const firstPage = Array.from({ length: 1000 }, (_, i) => ({ seq: i + 1, eventType: "item.delta" }));
const tail = { seq: 1001, eventType: "run.terminal" };
const get = vi.fn().mockResolvedValueOnce({ content: "fixture log" })
.mockResolvedValueOnce(firstPage).mockResolvedValueOnce([tail]);
const evidence = await collectChatRunEvidence({ get, getRunObservation: get }, run);
expect(evidence.events).toEqual([...firstPage, tail]);
expect(get.mock.calls).toEqual([
[`/api/heartbeat-runs/${run.id}/log?limitBytes=1048576`],
[`/api/heartbeat-runs/${run.id}/events?afterSeq=0&limit=1000`],
[`/api/heartbeat-runs/${run.id}/events?afterSeq=1000&limit=1000`],
]);
});
it("retains a superseded queued run's events without requesting a provider log that was never created", async () => {
const get = vi.fn().mockResolvedValue([{ seq: 1, eventType: "lifecycle" }]);
const suppressed = { ...run, status: "cancelled", errorCode: "issue_assignee_changed", startedAt: null,
resultJson: { stopReason: "issue_assignee_changed", timeoutSource: "stale_queued_run_gate", timeoutFired: false } };
expect(await collectChatRunEvidence({ get, getRunObservation: get }, suppressed)).toMatchObject({
runId: run.id, log: null, logOmissionReason: "assignee_changed_before_start", events: [{ seq: 1, eventType: "lifecycle" }],
});
expect(get.mock.calls).toEqual([[`/api/heartbeat-runs/${run.id}/events?afterSeq=0&limit=1000`]]);
get.mockRejectedValue(new Error("Run log not found"));
for (const patch of [{ startedAt: "2026-10-26T10:00:15Z" }, { startedAt: undefined },
{ errorCode: "cancelled" }, { resultJson: {} }, { nativeIssueId: "task" }]) {
await expect(collectChatRunEvidence({ get, getRunObservation: get }, { ...suppressed, ...patch })).rejects.toThrow("Run log not found");
}
});
it("retains a wake retired by a terminal issue before admission without requesting a log it never had", async () => {
const get = vi.fn().mockResolvedValue([{ seq: 1, eventType: "lifecycle" }]);
const retired = { ...run, status: "cancelled", errorCode: "issue_terminal_status", startedAt: null, logStore: null, logRef: null };
expect(await collectChatRunEvidence({ get, getRunObservation: get }, retired)).toMatchObject({
runId: run.id, log: null, logOmissionReason: "issue_terminal_before_start", events: [{ seq: 1, eventType: "lifecycle" }],
});
expect(get.mock.calls).toEqual([[`/api/heartbeat-runs/${run.id}/events?afterSeq=0&limit=1000`]]);
get.mockRejectedValue(new Error("Run log not found"));
for (const patch of [{ startedAt: "2026-10-26T10:00:15Z" }, { startedAt: undefined }, { status: "failed" },
{ errorCode: "cancelled" }, { logStore: "local_file" }, { logRef: "recorded-log" }]) {
await expect(collectChatRunEvidence({ get, getRunObservation: get }, { ...retired, ...patch })).rejects.toThrow("Run log not found");
}
});
it("records legitimate pre-provider log absence only with explicit bootstrap and storage evidence", async () => {
const stopped = { ...run, status: "interrupted", runtimeMode: "legacy", runtimeModeResolvedAt: null, logStore: null, logRef: null,
resultJson: { executionRecovery: { kind: "bootstrap", providerWorkStarted: false } } };
const get = vi.fn().mockResolvedValue([]);
expect(await collectChatRunEvidence({ get, getRunObservation: get }, stopped)).toMatchObject({ log: null, logOmissionReason: "provider_not_started", events: [] });
expect(get).toHaveBeenCalledTimes(1);
get.mockRejectedValue(new Error("Run log not found"));
for (const change of [{ resultJson: {} }, { runtimeMode: "native" }, { logRef: "recorded-log" }, { logStore: undefined },
{ runtimeModeResolvedAt: "2026-09-28T00:00:00Z" }, { resultJson: { executionRecovery: { kind: "bootstrap", providerWorkStarted: true } } }]) {
await expect(collectChatRunEvidence({ get, getRunObservation: get }, { ...stopped, ...change })).rejects.toThrow("Run log not found");
}
});
it("retains events for an unstarted dependency-blocked wake without asking for a nonexistent log", async () => {
const get = vi.fn().mockResolvedValue([]);
const suppressed = { ...run, status: "cancelled", errorCode: "issue_dependencies_blocked", startedAt: null };
expect((await collectChatRunEvidence({ get, getRunObservation: get }, suppressed)).log).toBeNull();
expect(get).toHaveBeenCalledTimes(1);
get.mockRejectedValue(new Error("Run log not found"));
await expect(collectChatRunEvidence({ get, getRunObservation: get }, { ...suppressed, startedAt: "2026-09-18T00:00:00Z" })).rejects.toThrow("Run log not found");
await expect(collectChatRunEvidence({ get, getRunObservation: get }, { ...suppressed, errorCode: "provider_transport_failed" })).rejects.toThrow("Run log not found");
});
it("waits for a newly running provider's log file without swallowing server failures", async () => {
const get = vi.fn().mockResolvedValue({ status: () => 404 });
const api = { request: { get } } as unknown as Pick<RunnerApi, "request">;
await expect(readRunningChatLog(api, "starting")).resolves.toBeUndefined();
get.mockResolvedValue({
status: () => 200,
ok: () => true,
json: async () => ({ content: "streamed reply" }),
});
await expect(readRunningChatLog(api, "running")).resolves.toBe(
"streamed reply",
);
get.mockResolvedValue({ status: () => 500, ok: () => false });
await expect(readRunningChatLog(api, "broken")).rejects.toThrow(
"log returned 500",
);
});
it("fails terminal execution errors without preempting active retries or recovery", () => {
const failed = {
...run,
status: "failed",
error: "provider rejected request",
};
expect(chatTaskCompletionFailure(task, [failed])).toContain(
"provider rejected request",
);
expect(
chatTaskCompletionFailure(task, [failed, { ...run, status: "queued" }]),
).toBeUndefined();
expect(
chatTaskCompletionFailure({ ...task, scheduledRetry: { id: "retry" } }, [
failed,
]),
).toBeUndefined();
expect(
chatTaskCompletionFailure(
{ ...task, activeRecoveryAction: { id: "recovery" } },
[failed],
),
).toBeUndefined();
});
it("fails stable contradictory idle states promptly without paid retries or transient false alarms", () => {
const detect = createChatIdleFailureDetector(3);
const settled = {
resolved: true,
status: "blocked",
conversationState: "waiting",
providerRunCount: 3,
activeRuns: [] as string[],
};
expect(detect(settled)).toBeUndefined();
expect(detect({ ...settled, activeRuns: ["running"] })).toBeUndefined();
expect(detect(settled)).toBeUndefined();
const failure = detect(settled);
expect(failure).toContain("chat_idle_state_invariant");
expect(classifyFailure(failure)).toBe("candidate_failure");
expect(shouldRetryFailure(classifyFailure(failure))).toBe(false);
expect(detect({ ...settled, status: "in_review" })).toBeUndefined();
expect(detect(settled)).toBeUndefined();
expect(detect({ ...settled, providerRunCount: 2 })).toBeUndefined();
expect(detect({ ...settled, status: "in_progress" })).toBeUndefined();
expect(detect(settled)).toBeUndefined();
});
it("fails promptly on terminal provider failures while permitting only expected cancellations", () => {
expect(chatRunFailure([run])).toBeUndefined();
expect(chatRunFailure([{ ...run, status: "running" }])).toBeUndefined();
expect(
chatRunFailure([
{
...run,
status: "failed",
errorCode: "permission_denied",
error: "sandbox unavailable",
},
]),
).toContain("run run failed (permission_denied): sandbox unavailable");
expect(chatRunFailure([{ ...run, status: "cancelled" }])).toContain(
"cancelled",
);
expect(
chatRunFailure([{ ...run, status: "cancelled" }], true),
).toBeUndefined();
});
it("separates reset control runs from provider runs without treating failures as resets", () => {
expect(isResetRun(run)).toBe(false);
expect(isResetRun({ ...run, status: "failed" })).toBe(false);
expect(
isResetRun({ ...run, contextSnapshot: { conversationReset: true } }),
).toBe(true);
});
it("only publishes screenshots of the exact disposable chat", () => {
const target = {
issuePrefix: "E2E",
issueId: "chat",
issueIdentifier: null,
chatAgentId: "fixture-agent",
};
expect(
isPublicRunnerScreenshotRoute(
"http://127.0.0.1:3199/E2E/chats/fixture-agent",
target,
),
).toBe(true);
expect(
isPublicRunnerScreenshotRoute(
"http://127.0.0.1:3199/E2E/chats/another-agent",
target,
),
).toBe(false);
expect(
isPublicRunnerScreenshotRoute(
"https://example.com/E2E/chats/fixture-agent",
target,
),
).toBe(false);
});
});
describe("reassignment outcome oracle", () => {
const evidence = () => ({ readyId: "ready", queuedId: "queued", teammateId: "riley",
tasks: [{ id: "ready", companyId: "co", title: "Ready", status: "done", assigneeAgentId: "riley" }, { id: "queued", companyId: "co", title: "Later", status: "backlog", assigneeAgentId: "riley" }],
runs: [{ id: "successor", companyId: "co", agentId: "riley", status: "succeeded", runtimeMode: "native", contextSnapshot: { issueId: "ready" } }],
audit: [{ action: "issue.reassigned", details: { source: "paperclip_runner_protocol" } }], outputBody: "Launch CHECK123", marker: "CHECK123",
});
it("accepts persisted ownership and exactly one successful successor", () => {
expect(() => assertChatReassignment(evidence())).not.toThrow();
});
it.each(["owner", "duplicate", "missing-run", "missing-audit", "backlog-started", "missing-output"])("rejects %s evidence", defect => {
const data = evidence();
if (defect === "owner") data.tasks[0]!.assigneeAgentId = "old";
if (defect === "duplicate") data.tasks.push({ ...data.tasks[0]!, id: "replacement" });
if (defect === "missing-run") data.runs = [];
if (defect === "missing-audit") data.audit = [];
if (defect === "backlog-started") data.runs.push({ ...data.runs[0]!, id: "early", contextSnapshot: { issueId: "queued" } });
if (defect === "missing-output") data.outputBody = "I reassigned it";
expect(() => assertChatReassignment(data)).toThrow();
});
});
describe("backlog creation outcome oracle", () => {
const evidence = () => ({
tasks: [{ id: "held", companyId: "co", title: "Later", status: "backlog", parentId: null, assigneeAgentId: "planner" }],
runs: [] as ChatRun[], ownerId: "planner", marker: "PLAN123",
plan: { body: "Three steps PLAN123", latestRevisionId: "revision-1", updatedAt: "2026-09-19T00:00:00Z" },
activity: [{ action: "issue.created", details: { status: "backlog", source: "paperclip_runner_protocol" } }],
});
it("accepts one planned backlog task with no execution", () => {
expect(() => assertChatBacklogCreation(evidence())).not.toThrow();
});
it("does not mistake the creating conversation for task execution", () => {
const data = evidence();
data.runs.push({ id: "creator", companyId: "co", agentId: "planner", status: "succeeded", contextSnapshot: { issueId: "conversation" } });
expect(() => assertChatBacklogCreation(data)).not.toThrow();
});
it.each(["duplicate", "status", "started-then-stopped", "corrected-after-creation", "owner", "plan"])("rejects %s", defect => {
const data = evidence();
if (defect === "duplicate") data.tasks.push({ ...data.tasks[0]!, id: "duplicate" });
if (defect === "status") data.tasks[0]!.status = "todo";
if (defect === "started-then-stopped") data.runs.push({ id: "early", companyId: "co", agentId: "planner", status: "cancelled", contextSnapshot: { issueId: "held" } });
if (defect === "corrected-after-creation") data.activity[0]!.details.status = "todo";
if (defect === "owner") data.tasks[0]!.assigneeAgentId = "other";
if (defect === "plan") data.plan.body = "I saved a plan";
expect(() => assertChatBacklogCreation(data)).toThrow();
});
});