mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-13 15:55:46 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - When a task's run fails, the board recovers it with a Retry button, so that button must either start work or say why it did not > - An audit of every Retry-type button found three gaps. The task Retry shown during a scheduled retry's countdown returned "accepted" but changed nothing. A stale Retry looked like success in the Inbox. "Retry now" skipped the task's read and change checks, so a member who cannot see a private task could start its retry > - This pull request makes the task Retry start a scheduled retry immediately, makes every Retry that did not start work say why, and gives "Retry now" the same authorization as the task Retry > - The benefit is that no Retry click silently does nothing ## Linked Issues or Issue Description Refs #19831. The board reported a dead Retry button. A read-only audit of every Retry button confirmed: - **Task Retry during a scheduled retry was a no-op.** `TaskInterruptionPresentation.canRetry` is true in `retry_scheduled`, so `ExecutionBlockerNotice` shows Retry. `requestTaskRetry` treats `scheduled_retry` as busy and inserts a `coalesced` wake pointing at that run. `resumeTaskRetry` reads only `deferred_issue_execution`, and dispatch uses coalesced user wakes only to carry comments. Nothing promoted the run: the API answered 202 `accepted: true` and the countdown did not change. - **A stale Retry looked like success.** `accepted: false, stale: true` comes back as HTTP 200. The Inbox ignored `accepted` and opened the task as if work had started. The task page showed no reason. - **"Retry now" checked less than the task Retry.** It ran only `assertBoard` and `getAccessibleResource`, skipping `assertIssueReadAllowed` and `issue:mutate`. A company member who cannot read a private task could promote that task's scheduled retry. - **"Retry now" said nothing for some outcomes.** It toasted only `promoted` and `gate_suppressed`. ## What Changed - `server/src/services/task-retry.ts`: when the Retry coalesces into the task's latest run and that run is `scheduled_retry` (with no other Retry already active), the receipt returns `scheduledRetryRunId`. - `server/src/routes/issues.ts`: - `POST /issues/:id/retry` then promotes that run through the existing `retryScheduledRetryNow`, the same path "Retry now" uses. It logs `issue.scheduled_retry_retry_now` with `source: "task_retry"` and returns `scheduledRetry: { outcome, message }`. - `POST /issues/:id/scheduled-retry/retry-now` now runs `assertIssueReadAllowed` and `decideIssueAccess("issue:mutate")`, matching `/retry`. A private task the member cannot read now answers 404. - `ui/src/hooks/useTaskRetry.ts`: new `taskRetryNotStartedReason`. When a Retry did not start work (stale, or a scheduled retry that is gate-suppressed, waiting, or gone), the hook returns that reason as its error. `ExecutionBlockerNotice` and `StalledDependencyNotice` already display it. - `ui/src/pages/Inbox.tsx`: a task Retry that did not start work shows the reason in the error toast and does not navigate. - `ui/src/hooks/useRetryNowMutation.ts` and `IssueScheduledRetryCard.tsx`: every "Retry now" outcome now shows its headline and message, including `no_scheduled_retry` on the card. - `ui/src/api/issues.ts`: `retryTask`'s response type includes `scheduledRetry`. ## Verification Red/green (each new test fails against master and passes with this PR): - `server/src/__tests__/issue-scheduled-retry-routes.test.ts`: - "starts a scheduled retry now when the task Retry is clicked during its countdown": 202 with `scheduledRetry.outcome: "promoted"`, the same run becomes `queued`, and no second retry run is created. - "refuses Retry now on a private task the member cannot see, like the task Retry": on master "Retry now" answers 200 `promoted`; now both routes answer 404 and the run stays `scheduled_retry`. - The seed now adds the board user's membership, which the stricter route needs. All 33 tests pass. - `ui/src/hooks/useTaskRetry.test.tsx`: a replaced attempt, a gate-held scheduled retry and a waiting scheduled retry each show their reason; a promoted one shows nothing extra. - `ui/src/pages/Inbox.test.tsx`: an Inbox Retry that did not start work (stale, or gate-held) toasts the reason and does not navigate. - `ui/src/components/IssueScheduledRetryCard.test.tsx`: "explains when there was no scheduled retry left to start". Other Retry buttons: the chat failed-run Retry already reports stopped and failed retries (`agents.test.ts`). Agent lifecycle "Retry now" and cost "Retry accounting" start no task work and already surface their API errors. Regression and static checks: - UI: 7 files, 168 passed. Server: task-retry and scheduled-retry suites, 149 passed. `issue-agent-mutation-ownership-routes.test.ts` passed. - `maintenance-server-routes.test.ts` "assembled maintenance server production wiring" fails identically on master on this Mac (`ensure-build-deps`). - `tsc --noEmit` passes for `server` and `ui/src`. `pnpm check:token-gates` is clean. ## Risks - A task Retry during a scheduled retry now starts the run immediately, through the existing "Retry now" promotion gates (pause, budget, cleanup waits). A gate that holds it is reported, not bypassed. - "Retry now" is stricter: a member without read or change access to the task gets 404 or 403, as on `/retry`. - No schema change. ## Model Used - Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, via Claude Code with tool use (shell, file edits). ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
205 lines
8.0 KiB
TypeScript
205 lines
8.0 KiB
TypeScript
import { Clock, RotateCcw, AlertCircle, Loader2, CheckCircle2 } from "lucide-react";
|
|
import { Link } from "@/lib/router";
|
|
import { Button } from "@/components/ui/button";
|
|
import { cn, formatDateTime } from "@/lib/utils";
|
|
import { formatMonitorOffset } from "@/lib/issue-monitor";
|
|
import { formatRetryReason } from "@/lib/runRetryState";
|
|
import type { IssueScheduledRetry } from "@paperclipai/shared";
|
|
import { useRetryNowMutation, type RetryNowError } from "../hooks/useRetryNowMutation";
|
|
import { Badge } from "@/components/ui/badge";
|
|
import { describeError } from "@/api/errors";
|
|
|
|
const MAX_TURN_CONTINUATION = "max_turns_continuation";
|
|
|
|
function isContinuationReason(reason: string | null | undefined) {
|
|
return reason === MAX_TURN_CONTINUATION;
|
|
}
|
|
|
|
function shortRunId(runId: string | null | undefined) {
|
|
return typeof runId === "string" && runId.length >= 8 ? runId.slice(0, 8) : runId ?? "";
|
|
}
|
|
|
|
interface IssueScheduledRetryCardProps {
|
|
issueId: string | null | undefined;
|
|
scheduledRetry: IssueScheduledRetry | null | undefined;
|
|
}
|
|
|
|
export function IssueScheduledRetryCard({
|
|
issueId,
|
|
scheduledRetry,
|
|
}: IssueScheduledRetryCardProps) {
|
|
const retryNow = useRetryNowMutation(issueId);
|
|
|
|
if (!scheduledRetry || !issueId) return null;
|
|
if (scheduledRetry.status !== "scheduled_retry") return null;
|
|
|
|
// Workspace contention is a transient wait with nothing for the user to do.
|
|
// The composer strip and properties row carry the quiet status instead.
|
|
if (scheduledRetry.scheduledRetryReason === "workspace_busy") return null;
|
|
|
|
const continuation = isContinuationReason(scheduledRetry.scheduledRetryReason);
|
|
const dueAtIso = scheduledRetry.scheduledRetryAt
|
|
? new Date(scheduledRetry.scheduledRetryAt).toISOString()
|
|
: null;
|
|
const relative = dueAtIso ? formatMonitorOffset(dueAtIso) : null;
|
|
const absolute = scheduledRetry.scheduledRetryAt
|
|
? formatDateTime(scheduledRetry.scheduledRetryAt)
|
|
: null;
|
|
const reason = formatRetryReason(scheduledRetry.scheduledRetryReason);
|
|
const attempt =
|
|
typeof scheduledRetry.scheduledRetryAttempt === "number"
|
|
&& Number.isFinite(scheduledRetry.scheduledRetryAttempt)
|
|
&& scheduledRetry.scheduledRetryAttempt > 0
|
|
? scheduledRetry.scheduledRetryAttempt
|
|
: null;
|
|
|
|
const badgeLabel = continuation ? "Continuation scheduled" : "Retry scheduled";
|
|
const titleAction = continuation ? "Automatic continuation" : "Automatic retry";
|
|
let titleSuffix: string;
|
|
if (relative === "now") {
|
|
titleSuffix = "due now";
|
|
} else if (relative) {
|
|
titleSuffix = relative;
|
|
} else {
|
|
titleSuffix = "pending schedule";
|
|
}
|
|
const title = `${titleAction} ${titleSuffix}`;
|
|
|
|
const helperIdle = continuation
|
|
? "Pulls continuation forward immediately"
|
|
: "Pulls retry forward immediately";
|
|
const isError = retryNow.isError || retryNow.lastError !== null;
|
|
const isSuccessTransient = retryNow.isSuccess
|
|
&& (retryNow.data?.outcome === "promoted" || retryNow.data?.outcome === "already_promoted");
|
|
|
|
return (
|
|
<div
|
|
data-testid="issue-scheduled-retry-card"
|
|
className="mb-3 rounded-lg border border-blue-500/30 bg-blue-500/5 px-3 py-3"
|
|
>
|
|
<div className="flex flex-col gap-2 sm:flex-row sm:items-start sm:justify-between">
|
|
<div className="min-w-0 flex-1">
|
|
<div className="flex flex-wrap items-center gap-2 text-xs">
|
|
<Badge variant="outline" className="border-blue-500/30 bg-blue-500/10 text-blue-700 dark:text-blue-300">
|
|
<Clock className="h-3 w-3" aria-hidden="true" />
|
|
{badgeLabel}
|
|
</Badge>
|
|
{attempt !== null ? (
|
|
<span className="text-muted-foreground">Attempt {attempt}</span>
|
|
) : null}
|
|
{reason ? (
|
|
<span className="text-muted-foreground">{reason}</span>
|
|
) : null}
|
|
</div>
|
|
<div className="mt-1 text-sm font-medium text-foreground">{title}</div>
|
|
{(absolute || scheduledRetry.retryOfRunId) ? (
|
|
<div className="mt-0.5 text-xs text-muted-foreground">
|
|
{absolute ? <span>{absolute}</span> : null}
|
|
{absolute && scheduledRetry.retryOfRunId ? <span>{" · "}</span> : null}
|
|
{scheduledRetry.retryOfRunId ? (
|
|
<span>
|
|
Replaces run{" "}
|
|
<Link
|
|
to={`/agents/${scheduledRetry.agentId}/runs/${scheduledRetry.retryOfRunId}`}
|
|
className="font-mono text-foreground hover:underline"
|
|
>
|
|
{shortRunId(scheduledRetry.retryOfRunId)}
|
|
</Link>
|
|
</span>
|
|
) : null}
|
|
</div>
|
|
) : null}
|
|
{scheduledRetry.error ? (
|
|
<div className="mt-1 text-xs text-muted-foreground">
|
|
Last attempt failed: {scheduledRetry.error}{/[.!?]$/.test(scheduledRetry.error.trim()) ? "" : "."} Paperclip will retry automatically.
|
|
</div>
|
|
) : null}
|
|
{isError ? ( // query-error-ok: mutation result
|
|
|
|
<RetryErrorBand
|
|
error={retryNow.lastError}
|
|
onRetry={() => {
|
|
retryNow.reset();
|
|
retryNow.mutate();
|
|
}}
|
|
/>
|
|
) : null}
|
|
</div>
|
|
<div className="flex flex-col items-stretch gap-1 sm:items-end">
|
|
<Button
|
|
type="button"
|
|
variant="outline"
|
|
size="sm"
|
|
className="shrink-0 shadow-none"
|
|
onClick={() => retryNow.mutate()}
|
|
disabled={retryNow.isPending || isSuccessTransient}
|
|
data-testid="issue-scheduled-retry-card-retry-now"
|
|
>
|
|
{retryNow.isPending ? (
|
|
<span className="inline-flex items-center gap-1.5">
|
|
<Loader2 className="h-3.5 w-3.5 animate-spin" aria-hidden="true" />
|
|
Retrying…
|
|
</span>
|
|
) : isSuccessTransient ? (
|
|
<span className="inline-flex items-center gap-1.5">
|
|
<CheckCircle2 className="h-3.5 w-3.5" aria-hidden="true" />
|
|
{retryNow.data?.outcome === "already_promoted" ? "Already promoted" : "Promoted"}
|
|
</span>
|
|
) : (
|
|
<span className="inline-flex items-center gap-1.5">
|
|
<RotateCcw className="h-3.5 w-3.5" aria-hidden="true" />
|
|
Retry now
|
|
</span>
|
|
)}
|
|
</Button>
|
|
<span className="text-right text-xs text-muted-foreground sm:max-w-(--sz-12rem)">
|
|
{retryNow.isPending
|
|
? "Promoting scheduled retry"
|
|
: isSuccessTransient
|
|
? retryNow.data?.outcome === "already_promoted"
|
|
? "Already promoted — run starting"
|
|
: "Promoted — run starting"
|
|
: (retryNow.data?.outcome === "waiting" && retryNow.data.scheduledRetry?.runId === scheduledRetry.runId)
|
|
|| retryNow.data?.outcome === "no_scheduled_retry"
|
|
? retryNow.data.message
|
|
: helperIdle}
|
|
</span>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
interface RetryErrorBandProps {
|
|
error: RetryNowError | null;
|
|
onRetry: () => void;
|
|
className?: string;
|
|
}
|
|
|
|
export function RetryErrorBand({ error, onRetry, className }: RetryErrorBandProps) {
|
|
if (!error) return null;
|
|
return (
|
|
<div
|
|
className={cn(
|
|
"mt-2 flex items-start gap-2 rounded-md border border-rose-500/30 bg-rose-500/5 px-2 py-1.5 text-xs text-rose-700 dark:text-rose-300",
|
|
className,
|
|
)}
|
|
role="alert"
|
|
data-testid="issue-scheduled-retry-error-band"
|
|
>
|
|
<AlertCircle className="mt-0.5 h-3.5 w-3.5 shrink-0" aria-hidden="true" />
|
|
<div className="min-w-0 flex-1">
|
|
<div className="font-medium">Couldn't retry now</div>
|
|
<div className="mt-0.5 text-muted-foreground">{describeError({ status: error.status, body: { message: error.message } }).body}</div>
|
|
</div>
|
|
<button
|
|
type="button"
|
|
onClick={onRetry}
|
|
className="shrink-0 font-medium text-rose-700 hover:underline dark:text-rose-300"
|
|
>
|
|
Try again
|
|
</button>
|
|
</div>
|
|
);
|
|
}
|