Files
PaperClipAI/ui/src/components/IssueLinkQuicklook.tsx
T
DottaandClaude Opus 5.5 7329eaf353 perf(ui): open sidebar Recents tasks from cache (#20450)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - The board UI sidebar has a Recents list of the tasks a person opened
last
> - The Recents list renders from a local snapshot, but its links had no
warm-up. A click waited for the task-detail code and about nine
first-frame reads
> - Task lists (Inbox, Tasks) already warm a task on hover, press and
click, and #20355 added a batched `chat-bootstrap` read that had no UI
consumer
> - The hosted database is CPU-bound, so a fix must add at most one read
per page load and must not compete with the page's own reads
> - This pull request gives Recents the same open-intent prefetch as
task lists, warms the task-detail code, and preloads the top ten recent
tasks with one `chat-bootstrap` request after the page is idle
> - The benefit is that a click on a recent task shows its chat from
cache, without a wait for the API

## Linked Issues or Issue Description

Refs #20355 (server read this PR consumes). Builds on #20389, #20398 and
#20419.

**Is your feature request related to a problem?**
Opening a task from the sidebar's Recents was slower than opening it
from a task list. The Recents links had no prefetch. The task page
waited for its first-frame reads after the click.

**Describe the solution you'd like**
Recents links use the task lists' open-intent prefetch. When the page is
idle, one batched request loads the first frame of the most recent tasks
into the task page's caches.

**Describe alternatives you've considered**
Per-task prefetch of every recent task. That makes up to ten times nine
requests per page load, which the hosted database cannot afford.

**Additional context**
I searched open PRs and remote branches for "chat-bootstrap" and
"instant task opens". The only related work is the server-side branches
that merged as #20355. There is no other in-flight UI consumer of
`chat-bootstrap`.

## What Changed

- `ui/src/hooks/useIssueNavigationPrefetch.ts`: the open-intent handlers
from `IssueLinkQuicklook` move into one hook (light warm on pass-over;
`history: true` on a resting hover or focus, a mouse or pen press, and a
click). `IssueLinkQuicklook` now uses the hook. Its behavior does not
change.
- `ui/src/components/RecentTaskNavItem.tsx`: one Recents link wrapper
that applies the hook. The classic list (`SidebarRecentTasks`), the
Coordinator task rows and `DesignSidebar` use it. `SidebarNavItem`
accepts the handlers through a new optional `linkHandlers` prop.
- Classic Recents links now open `/issues/<identifier>` (Coordinator
already did). The old UUID link remounted the task page after a redirect
to the identifier route.
- `ui/src/hooks/useRecentTaskOpenWarmup.ts`: when Recents shows a task,
it fires the task-detail code warm-up (`useWarmTaskDetailCode`). After
two frames, a visible tab, no fetching queries and an idle callback, it
sends one `issues/chat-bootstrap?ids=` request for the ten most recent
tasks. It skips tasks whose first frame is cached and fresh. It sends no
request for an empty list or a hidden tab. It sends at most one request
per account per page load. Unmount or an account change aborts the
request.
- `ui/src/lib/issueChatBootstrapCache.ts`: `seedIssueChatBootstrap`
writes each field under the keys the task page reads, for the requested
ref, the id and the identifier: core issue, recent comments, comment
input facts (one batch, through the new `seedIssueIdBatch`), recent
activity, the recent run window (through the new shared
`buildRecentIssueRunWindow`), interactions, attachments, live runs and
active run. An explicit `null` active run is stored. A missing field is
not stored. It does not replace data that is as new or newer, data with
a read in flight, or data with a pending invalidation. Keys whose page
merges observed history (comments, activity, runs, input facts) are
filled only when empty. Items for another company are ignored.
- The seed fills the `?view=core` key, not the full detail key.
`seedIssueDetailCache` is not used: the core payload cannot stand in for
the detail read's related data, and seeding it there would suppress that
read.
- `issuesApi.chatBootstrap` client method.
- `tests/perf/collections/recent-task-open.spec.ts` and its README
section.

## Verification

Local disposable instance (`local_trusted`, production UI build,
embedded PostgreSQL, collection fixture plus 12 comments on each of 8
recent tasks, streamlined UI with the Coordinator sidebar). Journey:
open Projects with 8 Recents, wait for network idle plus 3 s, click a
recent task, measure until its latest comment is on screen. Each run
uses a fresh browser context (empty HTTP cache and storage apart from
Recents). Median of 5 runs, same server and fixture for both arms:

| Arm | Click to first chat frame | Idle page API requests |
| --- | --- | --- |
| `master` (b6f4008f9b), loopback | 227 ms (first run: 249 ms) | 24
(range 21–25) |
| This PR, loopback | 134 ms | 22 (range 21–27) |
| `master`, +150 ms on each API response | 455 ms | 19 |
| This PR, +150 ms on each API response | 135 ms | 20 (+1
`chat-bootstrap`) |

With added latency, the first frame no longer depends on API latency.

- `PAPERCLIP_COLLECTION_PERF_BASE_URL=http://127.0.0.1:<port> pnpm exec
playwright test --config tests/perf/collections/playwright.config.ts
recent-task-open.spec.ts recent-task-summaries.spec.ts`: 5 passed. On
`master` the two assertion cases fail (0 `chat-bootstrap` requests; 10
first-frame reads after the click).
- Reads that still follow a click on a preloaded task: full detail (`GET
/issues/:id`), `work-products`, `documents`, `feedback-votes`,
`tree-control/state`, `tree-holds`, `runner-goal`, `browsers`, and the
`read` mark. The `chat-bootstrap` payload does not cover them. None
gates the chat's first frame (the frame shows at 135 ms while every API
response waits 150 ms).
- Unit tests: `RecentTaskNavItem.test.tsx` (intent levels, href),
`useRecentTaskOpenWarmup.test.tsx` (one request for the top ten, code
warm-up, wait for page reads, hidden tab, fresh entries skipped, once
per account, user isolation, abort on unmount),
`issueChatBootstrapCache.test.ts` (each key in the endpoint shape,
`null` versus missing fields, company isolation, no downgrade of newer,
in-flight or invalidated data, merge keys filled only when empty).
- `ui` Vitest: `src/components src/hooks src/lib src/api` 694 files
passed; `src/pages src/App src/context` 188 files passed. `pnpm
check:token-gates`: clean. `pnpm verify` exits 2 because a `tests/` file
is a global CI input; required CI supplies the broad coverage.

## Risks

- Low to medium. One extra read per page load when Recents has tasks
without a fresh cached first frame. The read starts only after the
page's own queries settle, and the server reads at most two tasks at a
time.
- A live event that arrives while the preload is in flight, for a task
with no cached keys, can leave seeded data up to 30 s old until the next
live event or the next open after the stale time. Inbox hover prefetch
has the same window.
- Classic Recents links now use the identifier route instead of the UUID
route. The task page already redirected UUID links to this route.
- `tests/perf/collections` is a manual suite. CI does not run it.

## Model Used

- Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, in Claude Code with
tool use (shell, file edits, browser automation through Playwright).
Standard context window.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [ ] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-10 08:00:13 -06:00

465 lines
17 KiB
TypeScript

import * as React from "react";
import { useMemo } from "react";
import * as RouterDom from "react-router-dom";
import type { Issue } from "@paperclipai/shared";
import { useQuery, useQueryClient } from "@tanstack/react-query";
import { timeAgo } from "@/lib/timeAgo";
import { createIssueDetailPath, withIssueDetailHeaderSeed } from "@/lib/issueDetailBreadcrumb";
import {
getIssueDetailQueryOptions,
ISSUE_DETAIL_STALE_TIME_MS,
} from "@/lib/issueDetailCache";
import { ISSUE_HISTORY_HOVER_PREFETCH_DELAY_MS, useIssueNavigationPrefetch } from "@/hooks/useIssueNavigationPrefetch";
import { queryKeys } from "@/lib/queryKeys";
import { cn } from "@/lib/utils";
import { Popover, PopoverContent, PopoverTrigger } from "@/components/ui/popover";
import { StatusGlyph } from "@/components/StatusGlyph";
import { ProjectTile } from "@/components/ProjectTile";
import { useFlyoutAppearance } from "@/components/ui/flyout-appearance";
/* ------------------------------------------------------------------ */
/* Single-flight quicklook store */
/* */
/* Every issue link renders its own Radix Popover. In a dense list */
/* (e.g. the Conference Room agent feed) independent per-card open */
/* state lets popovers overlap, linger, and stack — two flyouts at */
/* once, sometimes showing the wrong card. This module-level store */
/* enforces exactly one open quicklook across the whole tree: opening */
/* one closes any other. */
/* ------------------------------------------------------------------ */
let activeQuicklookId: symbol | null = null;
const quicklookListeners = new Set<() => void>();
function emitQuicklookChange() {
for (const listener of quicklookListeners) listener();
}
function openQuicklookId(id: symbol) {
if (activeQuicklookId === id) return;
activeQuicklookId = id;
emitQuicklookChange();
}
function closeQuicklookId(id: symbol) {
if (activeQuicklookId !== id) return;
activeQuicklookId = null;
emitQuicklookChange();
}
function subscribeQuicklook(listener: () => void) {
quicklookListeners.add(listener);
return () => {
quicklookListeners.delete(listener);
};
}
function useIsQuicklookOpen(id: symbol) {
return React.useSyncExternalStore(
subscribeQuicklook,
() => activeQuicklookId === id,
() => false,
);
}
/** Hover-intent delay (ms) before a quicklook opens — prevents flicker
* as the pointer crosses cards on its way somewhere else. */
const QUICKLOOK_OPEN_DELAY_MS = 120;
/**
* Distance from the quicklook's outer edge to its first column of text: the
* `p-3` padding in `QUICKLOOK_CONTENT_CLASS` (12px) plus the 1px border that
* `PopoverContent` draws. Both sit between the box edge and the content, so
* both have to be cancelled to line the text up with the trigger's.
*/
const QUICKLOOK_CONTENT_INSET_PX = 12 + 1;
/** Shared shell for every surface that renders `IssueQuicklookCard`. */
export const QUICKLOOK_CONTENT_CLASS = "w-72 p-3";
/**
* Cancel the card's own inset along the align axis, so the preview lines up
* with the *text* that opened it rather than with that text's box.
*
* Radix aligns box to box: with `align="start"` the card's left edge meets the
* trigger's left edge, which leaves the card's text pushed right by its border
* and padding — visibly off against the task key above it. Pulling the box back
* by exactly that inset puts the card's first column of text on the same
* vertical line as the trigger's. `end` needs the mirror of it; `center` has no
* edge to line up with, so it gets nothing.
*/
export function quicklookAlignOffset(align: "start" | "center" | "end" = "start"): number {
if (align === "start") return -QUICKLOOK_CONTENT_INSET_PX;
if (align === "end") return QUICKLOOK_CONTENT_INSET_PX;
return 0;
}
export type IssueQuicklookIssue = Pick<Issue, "id" | "title" | "updatedAt"> & {
identifier?: string | null;
status: string;
priority: string;
description?: string | null;
blockerAttention?: Issue["blockerAttention"];
projectId?: string | null;
project?: { name?: string | null } | null;
originKind?: string;
originId?: string | null;
};
function summarizeIssueDescription(description: string | null | undefined) {
if (!description) return null;
const summary = description
.replace(/!\[[^\]]*]\([^)]+\)/g, " ")
.replace(/\[([^\]]+)\]\([^)]+\)/g, "$1")
.replace(/[#>*_`~-]+/g, " ")
.replace(/\s+/g, " ")
.trim();
if (!summary) return null;
return summary.length > 180 ? `${summary.slice(0, 177).trimEnd()}...` : summary;
}
/** "·" between facts in the quicklook's meta and status lines. */
function QuicklookSeparator({ className }: { className?: string }) {
return (
<span className={cn("text-xs", className)} aria-hidden>
·
</span>
);
}
/** "in_review" -> "In review". The card states the status as a word, not a chip. */
function statusLabel(status: string): string {
const words = status.replace(/_/g, " ");
return words.charAt(0).toUpperCase() + words.slice(1);
}
/**
* The standard task preview card. Every hover preview of a task in the app
* renders this, so the same three rows appear in the same order everywhere:
*
* 1. meta — status glyph · task key [· project] .......... last activity
* 2. title
* 3. summary — first lines of the description
*
* The meta row splits: identity on the left, recency pinned right. Identity
* leads because a preview answers "which task is this?", and the title alone
* does not.
*
* Status carries no word of its own — the glyph is the status, exactly as it is
* on task rows and decision cards. Because that leaves shape and colour as the
* only visual signal, the glyph is given a `title`, so it renders as
* `role="img"` with the status as its accessible name. The status stays
* available to a screen reader without spending a line on it.
*
* Three shapes the row must hold, per the design mock:
* 1. no project — glyph, key, and the timestamp hard right
* 2. project — a "·" and the project tile plus name join the left group
* 3. truncation — a long project name ellipsizes; the key and the timestamp
* never do, so the two facts that identify the task survive
* at any width
*/
export function IssueQuicklookCard({
issue,
linkTo,
linkState,
compact = false,
}: {
issue: IssueQuicklookIssue;
linkTo: RouterDom.To;
linkState?: unknown;
compact?: boolean;
}) {
const appearance = useFlyoutAppearance();
const description = useMemo(() => summarizeIssueDescription(issue.description), [issue.description]);
const projectName = issue.project?.name;
return (
<div className={appearance === "refreshed" ? "task-hover-card" : cn("space-y-2", compact && "space-y-1.5")}>
<div data-slot="task-preview-meta" className="flex items-center gap-1">
<div data-slot="task-preview-identity" className="flex min-w-0 flex-1 items-center gap-1">
<StatusGlyph status={issue.status} size="md" title={statusLabel(issue.status)} />
<span data-slot="task-preview-id" className="shrink-0 font-mono text-(length:--text-micro) text-muted-foreground">
{issue.identifier ?? issue.id.slice(0, 8)}
</span>
{projectName && appearance !== "refreshed" ? (
<>
<QuicklookSeparator className="shrink-0 text-muted-foreground" />
<span
className="flex min-w-0 max-w-(--sz-12rem) flex-1 items-center gap-1 text-(length:--text-micro) text-muted-foreground"
title={projectName}
data-testid="quicklook-project"
>
<ProjectTile size="xs" />
<span className="truncate">{projectName}</span>
</span>
</>
) : null}
</div>
<span data-slot="task-preview-time" className="shrink-0 text-(length:--text-micro) text-muted-foreground">
{timeAgo(new Date(issue.updatedAt))}
</span>
</div>
<RouterDom.Link
data-slot="task-preview-title"
to={linkTo}
state={linkState ?? withIssueDetailHeaderSeed(null, issue)}
className="block text-sm font-medium leading-snug hover:underline line-clamp-2"
>
{issue.title}
</RouterDom.Link>
{description ? (
<p data-slot="task-preview-description" className="text-xs leading-5 text-muted-foreground [display:-webkit-box] [-webkit-box-orient:vertical] [-webkit-line-clamp:4] overflow-hidden">
{description}
</p>
) : null}
</div>
);
}
export { ISSUE_HISTORY_HOVER_PREFETCH_DELAY_MS };
export const IssueLinkQuicklook = React.forwardRef<
HTMLAnchorElement,
React.ComponentProps<typeof RouterDom.Link> & {
issuePathId: string;
disableIssueQuicklook?: boolean;
issuePrefetch?: Issue | null;
issueQuicklookSide?: React.ComponentProps<typeof PopoverContent>["side"];
issueQuicklookAlign?: React.ComponentProps<typeof PopoverContent>["align"];
}
>(function IssueLinkQuicklookImpl(
{
issuePathId,
to,
children,
className,
state,
disableIssueQuicklook = false,
issuePrefetch = null,
issueQuicklookSide = "top",
issueQuicklookAlign = "start",
onClick,
onClickCapture,
onMouseEnter,
onMouseLeave,
onPointerDown,
onFocus,
onBlur,
onTouchStart,
...props
},
ref,
) {
const queryClient = useQueryClient();
const instanceId = React.useMemo(() => Symbol("issue-quicklook"), []);
const open = useIsQuicklookOpen(instanceId);
const openTimerRef = React.useRef<ReturnType<typeof setTimeout> | null>(null);
const triggerRef = React.useRef<HTMLAnchorElement | null>(null);
const contentRef = React.useRef<HTMLDivElement | null>(null);
// Keep the caller's ref working while we also hold our own handle on the
// trigger node (needed by the pointer-escape guard below).
const setTriggerRef = React.useCallback(
(node: HTMLAnchorElement | null) => {
triggerRef.current = node;
if (typeof ref === "function") ref(node);
else if (ref) ref.current = node;
},
[ref],
);
const cancelScheduledOpen = React.useCallback(() => {
if (openTimerRef.current) {
clearTimeout(openTimerRef.current);
openTimerRef.current = null;
}
}, []);
// Open immediately (keyboard focus, or re-entering the open popover).
const openNow = React.useCallback(() => {
cancelScheduledOpen();
openQuicklookId(instanceId);
}, [cancelScheduledOpen, instanceId]);
// Open after the hover-intent delay (pointer entering a card).
const scheduleOpen = React.useCallback(() => {
cancelScheduledOpen();
openTimerRef.current = setTimeout(() => {
openTimerRef.current = null;
openQuicklookId(instanceId);
}, QUICKLOOK_OPEN_DELAY_MS);
}, [cancelScheduledOpen, instanceId]);
const close = React.useCallback(() => {
cancelScheduledOpen();
closeQuicklookId(instanceId);
}, [cancelScheduledOpen, instanceId]);
// Clear any pending timer and release the active slot on unmount.
React.useEffect(() => {
return () => {
cancelScheduledOpen();
closeQuicklookId(instanceId);
};
}, [cancelScheduledOpen, instanceId]);
// Pointer-escape guard.
//
// The only close paths are `mouseleave` on the trigger and on the content,
// and a leave event is not guaranteed: when the layout shifts, the element
// moves out from under a stationary pointer rather than the pointer moving
// off the element, and no leave fires. Expanding a decision row does exactly
// that, stranding an open quicklook on screen until something else happens
// to open one.
//
// Rather than enumerate the ways a leave can be missed, re-check the
// browser's own hover state on every pointer move and close as soon as the
// pointer is over neither the trigger nor the card. Keyboard use is exempt:
// a quicklook opened by focus stays put while focus remains inside it.
React.useEffect(() => {
if (!open) return;
// Slack around each box, so crossing the 4px gap between the trigger and
// the card does not read as leaving.
const EDGE_SLACK_PX = 12;
const nearBox = (element: Element | null, x: number, y: number) => {
if (!element) return false;
const rect = element.getBoundingClientRect();
return (
x >= rect.left - EDGE_SLACK_PX
&& x <= rect.right + EDGE_SLACK_PX
&& y >= rect.top - EDGE_SLACK_PX
&& y <= rect.bottom + EDGE_SLACK_PX
);
};
const stillEngaged = (x: number, y: number) => {
const trigger = triggerRef.current;
const content = contentRef.current;
// Two independent signals, and closing needs both to agree the pointer is
// gone: `:hover` is authoritative about stacking and overlap, geometry
// survives the cases where hover state is not updated. Either one holding
// keeps the card open, so a real pointer resting on it is never dropped.
if (trigger?.matches(":hover") || content?.matches(":hover")) return true;
if (nearBox(trigger, x, y) || nearBox(content, x, y)) return true;
// Opened by keyboard: hold while focus is still inside.
const active = document.activeElement;
return trigger === active || (!!content && !!active && content.contains(active));
};
const onPointerMove = (event: PointerEvent) => {
if (!stillEngaged(event.clientX, event.clientY)) close();
};
document.addEventListener("pointermove", onPointerMove, { passive: true });
return () => document.removeEventListener("pointermove", onPointerMove);
}, [open, close]);
const prefetchedState = issuePrefetch ? withIssueDetailHeaderSeed(state, issuePrefetch) : state;
const { data, isLoading } = useQuery({
...getIssueDetailQueryOptions(queryClient, issuePathId, { placeholderIssue: issuePrefetch ?? undefined }),
enabled: open,
staleTime: ISSUE_DETAIL_STALE_TIME_MS,
});
const detailPath = createIssueDetailPath(issuePathId);
const prefetchHandlers = useIssueNavigationPrefetch(issuePathId, issuePrefetch);
const link = (
<RouterDom.Link
ref={setTriggerRef}
to={to}
state={prefetchedState}
className={className}
onMouseEnter={(event) => {
prefetchHandlers.onMouseEnter(event);
onMouseEnter?.(event);
}}
onMouseLeave={(event) => {
prefetchHandlers.onMouseLeave(event);
onMouseLeave?.(event);
}}
onPointerDown={(event) => {
prefetchHandlers.onPointerDown(event);
onPointerDown?.(event);
}}
onFocus={(event) => {
prefetchHandlers.onFocus(event);
openNow();
onFocus?.(event);
}}
onBlur={(event) => {
prefetchHandlers.onBlur(event);
// Let clicks inside the portaled quicklook content finish before closing.
setTimeout(() => close(), 0);
onBlur?.(event);
}}
onTouchStart={(event) => {
prefetchHandlers.onTouchStart(event);
onTouchStart?.(event);
}}
onClickCapture={(event) => {
prefetchHandlers.onClickCapture(event);
onClickCapture?.(event);
}}
onClick={(event) => {
close();
onClick?.(event);
}}
{...props}
>
{children}
</RouterDom.Link>
);
if (disableIssueQuicklook) {
return link;
}
return (
<Popover open={open} onOpenChange={(next) => (next ? openNow() : close())}>
<PopoverTrigger
asChild
// The link's own hover handler warms the task; history waits for a dwell.
onMouseEnter={scheduleOpen}
onMouseLeave={close}
>
{link}
</PopoverTrigger>
<PopoverContent
ref={contentRef}
// Opts into the scale-from-trigger motion defined in index.css.
data-quicklook
className={QUICKLOOK_CONTENT_CLASS}
side={issueQuicklookSide}
align={issueQuicklookAlign}
alignOffset={quicklookAlignOffset(issueQuicklookAlign)}
onMouseEnter={openNow}
onMouseLeave={close}
// A preview must not move focus in either direction. Opening already
// declined to take focus; closing has to decline to hand it back, or
// Radix focuses the trigger on the way out — and because this link
// opens the quicklook `onFocus`, that focus immediately reopens the
// card that was just dismissed. Hovering away then leaves it up
// permanently: close, refocus, reopen, forever.
onOpenAutoFocus={(event) => event.preventDefault()}
onCloseAutoFocus={(event) => event.preventDefault()}
>
{data ? (
<IssueQuicklookCard issue={data} linkTo={detailPath} linkState={prefetchedState} compact />
) : (
<div className="space-y-2">
<div className="h-4 w-24 rounded bg-accent/50" />
<div className="h-4 w-full rounded bg-accent/40" />
<div className="h-4 w-3/4 rounded bg-accent/30" />
{!isLoading ? (
<p className="text-xs text-muted-foreground">Unable to load task preview.</p>
) : null}
</div>
)}
</PopoverContent>
</Popover>
);
});