mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-25 17:45:53 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Agent runs need credentials for a specific provider and sign-in method. > - Connections already owns accounts, grants, and access permissions. > - AI authentication should use those same boundaries. > - This pull request adds the storage, API, adoption, and runtime foundation. > - Legacy agents keep their authentication until they explicitly adopt a managed connection. ## Linked Issues or Issue Description **Problem or motivation** AI credentials are configured separately from Connections. Agents cannot consistently reuse a responsible user's account or a permitted shared account. **Proposed solution** Manage AI accounts with the existing Connections grants and permissions. Keep model and harness selection independent from credential selection. Preserve legacy authentication until validated adoption. **Alternatives considered** A separate credential registry would duplicate ownership and access policy. Automatic fallback would risk using the wrong account. **Roadmap alignment** This extends the shipped Apps, multi-user, secrets, and agent-runtime capabilities. The maintainer requested the feature and reviewed the UI. Related groundwork: #11899 (connection permissions), #10910 (connection wizard), #11692 (Claude subscription profiles), and #11854 (Codex account rotation). ## What Changed - Add AI-purpose/runtime-auth contracts and an additive, idempotent migration. - Add Claude, OpenAI, OpenRouter, and Grok provider capabilities and catalog entries. - Store credentials on grants. Resolve responsible-user defaults or explicit permitted grants. - Isolate managed credentials and provider sessions across accounts. Block missing credentials without ambient fallback. - Keep imported legacy secrets unchanged during reconnect. Use independent local Codex/Grok sign-in attempts for rotating credentials. - Add authorization, migration, concurrent refresh, retry, cancellation, and legacy-compatibility tests. This is part 1 of a two-PR stack. The app UI follows in #13248. Merge the foundation first. ## Verification - Updated against master `04e364236`, preserving upstream provider login and connector workflows. - Full workspace typecheck, production build, Storybook build, and token gates passed on the integrated branch. Final local-login changes passed 59 focused tests; new-agent and inbox regression suites passed 63 tests. - Browser checks verified automatic local Claude account detection, resumable Codex login commands, retry, focus restoration, and desktop/phone layouts. Commands create their isolated directory before invoking the CLI. - All current-head CI checks passed on `2a996560a`, including all server/workspace tests, browser shards, runner verification, typecheck, build, and canary dry run. Greptile reviewed that commit at 5/5 with no unresolved threads. Earlier local full-suite attempts hit the Mac PostgreSQL shared-memory limit; the complete suites passed in CI. - Renumbered the additive AI migration to `0276` after upstream migrations and regenerated its snapshot. Existing legacy agents retain their configuration. - Added local login status checks, owner-scoped retry, managed OpenCode remote homes, credential-aware model discovery, and task connection-repair delivery. ## Risks - Managed credential failures intentionally block execution. They do not restore legacy fallback. - Preview-era copied Codex/Grok subscriptions require independent reconnect. - The integrated branch has live provider acceptance coverage. This update verifies local Claude detection and Codex API-key task repair; it does not add a new subscription authorization/refresh or Daytona stress pass. - Runtime-auth connections must stay excluded from tool and channel handling. ## Model Used OpenAI GPT-6 through Codex, with reasoning, repository tools, code execution, and browser testing. The exact runtime model identifier and context-window size are not exposed in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
258 lines
8.9 KiB
TypeScript
258 lines
8.9 KiB
TypeScript
import { APP_DEFINITIONS } from "./app-definitions.generated.js";
|
|
import { SELF_SERVE_MCP_CANDIDATES } from "./self-serve-mcp-research.js";
|
|
import type { AppDefinition, ConnectionMethodDef, FieldDef } from "./types/app-definition.js";
|
|
import type { ToolConnectionOwnership } from "./types/tool-access.js";
|
|
|
|
export const CONNECTABLE_APP_SLUGS = new Set([
|
|
"anthropic", "openai", "openrouter", "xai",
|
|
"agentmail",
|
|
...SELF_SERVE_MCP_CANDIDATES.map((entry) => entry.slug),
|
|
"zapier",
|
|
"slack",
|
|
"notion",
|
|
"posthog",
|
|
"linear",
|
|
"google-sheets",
|
|
"context7",
|
|
"shopify",
|
|
"composio",
|
|
"gmail",
|
|
"google-drive",
|
|
"google-docs",
|
|
"google-slides",
|
|
"google-calendar",
|
|
"google-chat",
|
|
"google-people",
|
|
"google-workspace-search",
|
|
"github",
|
|
"discord",
|
|
"microsoft-teams",
|
|
"telegram",
|
|
"imessage-photon",
|
|
]);
|
|
|
|
export const CONNECTABLE_APP_DEFINITIONS = APP_DEFINITIONS.filter((app) =>
|
|
CONNECTABLE_APP_SLUGS.has(app.slug)
|
|
);
|
|
|
|
/**
|
|
* Definitions retained for existing connections and later verification, but
|
|
* intentionally withheld from the customer-facing store. Keeping visibility
|
|
* separate from recognition avoids breaking saved connections when a provider
|
|
* is pulled from Browse or reserved for a future first-party experience.
|
|
*/
|
|
export const APP_STORE_HIDDEN_SLUGS = new Set([
|
|
"beehiiv",
|
|
"bitly",
|
|
"brex",
|
|
"candid",
|
|
"coda",
|
|
"composio",
|
|
"context7",
|
|
"egnyte",
|
|
"embat",
|
|
"kernel",
|
|
"local-falcon",
|
|
"make",
|
|
"manufact",
|
|
"oreilly",
|
|
"planetscale",
|
|
"razorpay",
|
|
"sanity",
|
|
"similarweb",
|
|
"ticket-tailor",
|
|
"ticktick",
|
|
"xero",
|
|
]);
|
|
|
|
export const APP_STORE_DEFINITIONS = CONNECTABLE_APP_DEFINITIONS.filter((app) =>
|
|
!APP_STORE_HIDDEN_SLUGS.has(app.slug)
|
|
);
|
|
|
|
export const DEFAULT_OWNERSHIP_AVAILABILITY: Record<ToolConnectionOwnership, boolean> = {
|
|
platform_shared: false,
|
|
platform_provisioned: false,
|
|
customer: true,
|
|
dcr: true,
|
|
};
|
|
|
|
export function getConnectableAppDefinition(slug: string): AppDefinition | null {
|
|
return CONNECTABLE_APP_DEFINITIONS.find((app) => app.slug === slug) ?? null;
|
|
}
|
|
|
|
export function getAppStoreDefinition(slug: string): AppDefinition | null {
|
|
return APP_STORE_DEFINITIONS.find((app) => app.slug === slug) ?? null;
|
|
}
|
|
|
|
export function isAppStoreVisibleSlug(slug: string | null | undefined): boolean {
|
|
return Boolean(slug && !APP_STORE_HIDDEN_SLUGS.has(slug) && CONNECTABLE_APP_SLUGS.has(slug));
|
|
}
|
|
|
|
function wildcardPatternToRegExp(pattern: string): RegExp {
|
|
const escaped = pattern.replace(/[.+?^${}()|[\]\\]/g, "\\$&").replace(/\*/g, ".*");
|
|
return new RegExp(`^${escaped}$`, "i");
|
|
}
|
|
|
|
export function getAppDefinitionForUrl(
|
|
link: string,
|
|
definitions: readonly AppDefinition[] = CONNECTABLE_APP_DEFINITIONS,
|
|
): AppDefinition | null {
|
|
let normalized: string;
|
|
try {
|
|
normalized = new URL(link.trim()).toString();
|
|
} catch {
|
|
return null;
|
|
}
|
|
return definitions.find((app) =>
|
|
app.urlPatterns.some((pattern) => wildcardPatternToRegExp(pattern).test(normalized))
|
|
) ?? null;
|
|
}
|
|
|
|
export function getAvailableConnectionMethods(app: AppDefinition): ConnectionMethodDef[] {
|
|
const availability = app.ownershipAvailability ?? DEFAULT_OWNERSHIP_AVAILABILITY;
|
|
return app.methods.filter((method) =>
|
|
method.ownershipModes.some((ownership) => availability[ownership] !== false)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Pick the method that gives a new connection the app's useful write surface.
|
|
*
|
|
* Google Workspace publishes separate read and write capability groups. The
|
|
* read method is intentionally listed first for documentation, but treating
|
|
* array order as a product default silently created read-only connections and
|
|
* left every write action Off. Capability metadata is the durable signal; apps
|
|
* without an explicit write/draft capability retain their declared order.
|
|
*/
|
|
export function getRecommendedConnectionMethod(
|
|
methods: readonly ConnectionMethodDef[],
|
|
): ConnectionMethodDef | null {
|
|
const recommendedCapability = (candidates: readonly ConnectionMethodDef[]) => candidates.find((method) => {
|
|
const capabilityKey = method.capabilityProfile?.key;
|
|
return capabilityKey === "write" || capabilityKey === "draft";
|
|
});
|
|
const managedMethods = methods.filter((method) =>
|
|
method.oauthStrategy === "paperclip_cloud_connector"
|
|
|| method.oauthStrategy === "paperclip_id_connector"
|
|
);
|
|
|
|
// When a managed pilot advertises only read access, defaulting to a
|
|
// customer-owned write method would turn the available one-click path into
|
|
// an OAuth client setup form. Capability-specific callers pass only the
|
|
// selected group, so explicit write/draft choices keep their own fallback.
|
|
return recommendedCapability(managedMethods)
|
|
?? managedMethods[0]
|
|
?? recommendedCapability(methods)
|
|
?? methods[0]
|
|
?? null;
|
|
}
|
|
|
|
export function getAvailableConnectionMethod(
|
|
app: AppDefinition,
|
|
methodKey?: string | null,
|
|
): ConnectionMethodDef | null {
|
|
const methods = getAvailableConnectionMethods(app);
|
|
return methodKey
|
|
? methods.find((method) => method.key === methodKey) ?? null
|
|
: getRecommendedConnectionMethod(methods);
|
|
}
|
|
|
|
export function connectionMethodSupportsAutomaticOAuth(method: ConnectionMethodDef | null | undefined): boolean {
|
|
return method?.auth === "oauth" && (
|
|
(method.oauthStrategy === "paperclip_cloud_connector" || method.oauthStrategy === "paperclip_id_connector")
|
|
|| method.ownershipModes.includes("dcr")
|
|
);
|
|
}
|
|
|
|
export function connectionMethodAcceptsCustomerOAuthClient(method: ConnectionMethodDef | null | undefined): boolean {
|
|
return method?.auth === "oauth"
|
|
&& !method.oauthStrategy
|
|
&& method.ownershipModes.includes("customer");
|
|
}
|
|
|
|
export function connectionMethodSupportsCatalogSetup(method: ConnectionMethodDef | null | undefined): boolean {
|
|
if (!method) return false;
|
|
if (method.transport === "runtime_auth") return Boolean(method.ai);
|
|
if (method.auth === "none" || method.auth === "api_key") return true;
|
|
return connectionMethodSupportsAutomaticOAuth(method)
|
|
|| connectionMethodAcceptsCustomerOAuthClient(method);
|
|
}
|
|
|
|
export function connectionMethodRequiresConfiguration(method: ConnectionMethodDef | null | undefined): boolean {
|
|
if (!method) return false;
|
|
const visibleTenantFields = method.tenantFields?.filter((field) => !field.hidden) ?? [];
|
|
const visibleExtensionFields = method.extensionFields?.filter((field) => !field.hidden) ?? [];
|
|
return Boolean(
|
|
method.credentialFields?.length
|
|
|| visibleTenantFields.length
|
|
|| visibleExtensionFields.length
|
|
|| method.configRequirements?.atLeastOneOf?.length
|
|
// "Use your own OAuth app" is an advanced alternative when DCR/CIMD is
|
|
// available, not a required setup field. Only customer-client-only methods
|
|
// must stop on the configuration screen.
|
|
|| (
|
|
connectionMethodAcceptsCustomerOAuthClient(method)
|
|
&& !connectionMethodSupportsAutomaticOAuth(method)
|
|
),
|
|
);
|
|
}
|
|
|
|
export function appSupportsCatalogSetup(app: AppDefinition | null | undefined): boolean {
|
|
return Boolean(app && getAvailableConnectionMethods(app).some(connectionMethodSupportsCatalogSetup));
|
|
}
|
|
|
|
export function isConnectableAppSlug(slug: string | null | undefined): boolean {
|
|
return Boolean(slug && CONNECTABLE_APP_SLUGS.has(slug));
|
|
}
|
|
|
|
export function appSupportsAutomaticOAuth(app: AppDefinition | null | undefined): boolean {
|
|
return Boolean(app && getAvailableConnectionMethods(app).some(connectionMethodSupportsAutomaticOAuth));
|
|
}
|
|
|
|
export function appAcceptsCustomerOAuthClient(app: AppDefinition | null | undefined): boolean {
|
|
return Boolean(app && getAvailableConnectionMethods(app).some(connectionMethodAcceptsCustomerOAuthClient));
|
|
}
|
|
|
|
export function credentialConfigPath(field: FieldDef): string {
|
|
return `credentials.${field.key}`;
|
|
}
|
|
|
|
export function resolveConnectionMethodServerUrl(
|
|
method: ConnectionMethodDef,
|
|
configValues: Record<string, string | boolean>,
|
|
): string | null {
|
|
const template = method.defaults?.serverUrlTemplate;
|
|
if (!template) return method.defaults?.serverUrl ?? null;
|
|
|
|
let missingValue = false;
|
|
const resolved = template.replace(/\{([a-zA-Z0-9_-]+)\}/g, (_placeholder, key: string) => {
|
|
const value = configValues[key];
|
|
if (value === undefined || String(value).trim().length === 0) {
|
|
missingValue = true;
|
|
return "";
|
|
}
|
|
return encodeURIComponent(String(value).trim());
|
|
});
|
|
if (missingValue) return null;
|
|
|
|
try {
|
|
return new URL(resolved).toString();
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
export function recommendedDefaultsForApp(app: AppDefinition, methodKey?: string | null): Record<string, unknown> {
|
|
// Keep the parameters in the public contract: callers resolve defaults for a
|
|
// concrete app/method even though the initial policy is now uniform. This is
|
|
// an open default, not an approval bypass: connection finalization remains a
|
|
// configure-authorized, audited operation, and Ask first stays available as
|
|
// an operator-selected policy for any action after the connection is made.
|
|
void app;
|
|
void methodKey;
|
|
return {
|
|
access: "all_agents",
|
|
askFirstRiskLevels: [],
|
|
};
|
|
}
|