Files
PaperClipAI/ui/src/pages/Issues.tsx
T
4550253dc9 feat(ui): rename Needs you to Inbox and move Mine into Tasks (#19363)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work.
> - Coordinator gives people navigation for conversations, tasks, and
decisions.
> - The decision entry is called Needs you, while a separate Inbox
remains under More.
> - Coordinator's personal task filter does not retain the full behavior
of the original Mine view.
> - This pull request names the decision entry Inbox and hosts the
original personal work views inside Tasks.
> - People keep their triage tools and saved choices without moving
between two task destinations.

## Linked Issues or Issue Description

**What existing behavior does this improve?**

Coordinator navigation and the personal Mine view in Tasks.

**Subsystem affected**

UI navigation, task view routing, task collection preferences, and
browser coverage.

**Current behavior**

Needs you opens the decision feed. More contains another Inbox
destination. The default Coordinator task filter matches task creators
and assignees. It does not use the full personal participation rules,
archive behavior, shortcuts, grouping, or saved columns of the original
Mine view. The organization task table also resets its column choices on
reload.

**Proposed behavior**

Inbox opens the same decision feed with the inbox icon. Tasks defaults
to Mine and remembers a person's selected view per company. Mine uses
the existing personal Inbox implementation and preferences. It retains
read/unread title weights, keyboard navigation, read/unread shortcuts,
archive and undo, mobile swipe-to-archive, grouping, and saved columns.
Old Inbox links open the matching task view. The organization task table
saves its columns and order per person and company.

**Reason and benefit**

People get Chat, Tasks, and Inbox as distinct navigation entries.
Personal work remains a view within Tasks without losing the existing
triage behavior.

**Breaking changes**

Coordinator no longer offers the previous Inbox destination under More.
Old Inbox URLs redirect into Tasks and retain query parameters and
fragments. The Needs you label becomes Inbox; its decision feed, count,
history, and resolution paths stay in place. Classic retains its
separate optional combined-list setting.

**Additional context**

Refs: #19360, the workspace-defaults PR now integrated from master.
Refs: #10620, related Inbox attention ordering. Duplicate searches found
no open PR for this navigation and Mine integration. Roadmap review
found no separate new execution feature in this scope.

## What Changed

- Rename Coordinator's desktop and mobile decision entry and page to
Inbox. Use the inbox icon. Remove the old Inbox item under More. Clarify
that the combined-list experiment applies only to Classic.
- Add one Coordinator task-view router. Host Mine, Unread, Recent,
Blocked, and Everything through the existing Inbox owner. Keep
organization views in the task table and board. Normalize legacy
filtered URLs before mounting a collection so clearing the last filter
preserves the current layout and local filters.
- Reuse the existing Mine API, participation, read state, archive cache,
undo, keyboard, mobile gesture, grouping, and preference paths. Existing
personal column choices carry over.
- Save organization task-table columns and order per person and company.
Keep controls usable if browser storage fails.
- Update navigation tests, routing and persistence regressions,
exact-run retry browser coverage for each workspace variant, product
documentation, and the affected Storybook notes. Keep existing story
IDs.

## Verification

- Preference, routing, navigation, task table, and inherited Inbox
regression tests pass in focused runs. After integrating master and
addressing the review finding, all 187 focused tests, UI typecheck, and
token gates pass.
- Full build and repository typecheck pass after integrating master. The
full UI suite previously passed: 894 files, 11,169 tests passed, and one
skipped. All 14 desktop/mobile triage and exact-run retry browser cases,
including a fresh production UI build, pass after integrating master.
- The full repository test suite was not run locally for this UI-only
change; full PR CI is running.
- Browser checks use a fresh isolated local instance and a deterministic
process agent for real run-attributed unread activity. They exercise
legacy URLs, title weights, saved grouping and columns, read/unread
shortcuts, archive/undo, and a real mobile touch gesture.
- Earlier browser fixtures were corrected: own activity is read, agent
comments need valid run attribution, and undo uses `u` after the archive
refresh completes. The Inbox content heading is scoped separately from
the layout heading.
- The final settings wording correction passes all 63 settings tests.
- The [next CI browser
run](https://github.com/paperclipai/paperclip/actions/runs/42137377960/job/127629100535)
caught an old URL assertion for denied run retries. The test now pins
each workspace variant and covers Coordinator Tasks explicitly. The old
expectation fails deterministically for Coordinator; all 12 retry cases
pass with the corrected destination, preserving exact run identity and
truthful queued, deferred, and denied feedback.
- Token gates, map checks, and Storybook catalog checks pass. All 30
map/catalog script tests pass. Storybook play tests were not run.
- Greptile reviewed [the final
commit](https://github.com/paperclipai/paperclip/commit/5f2f3789b83af259f694f379afb769465688fb72)
at **5/5** with no new actionable findings. Its sort-only link finding
is fixed and resolved: three cases fail before the fix and pass after
it. `sortField` and `sortDir` keep organization links on the
organization table. [Current-head
CI](https://github.com/paperclipai/paperclip/actions/runs/42139668774)
is running.
- [CI exposed a routing
race](https://github.com/paperclipai/paperclip/actions/runs/42135293421/job/127621981587)
when removing the last label from a legacy Everything link. Four
deterministic regressions failed before the fix and now pass:
collections only mount after URL normalization. The existing end-to-end
component cases confirm local filters, board layout, fragments, and
history survive the change.
- The [initial server shard 4
run](https://github.com/paperclipai/paperclip/actions/runs/42131163087/job/127608751620)
failed an unchanged monitor-drain idleness assertion: two active
operations remained instead of zero. The complete scheduling suite
passes locally (54 tests). One isolated CI retry passed, including its
dependent verification gate. The original timing failure's root cause is
not established.

## Risks

- Mine includes the existing tasks, approvals, failed runs, and join
requests, preserving the original personal participation and attention
rules.
- Shared URLs with organization filters or table sort parameters still
open the organization task collection. Task back-links retain their
original fragments.
- Saved preferences are browser-local. Mine keeps its existing storage
keys; the organization table and selected Coordinator view use
person/company scopes.
- No database or server API contract changes are included. Existing
company access, personal participation, and decision permissions retain
their owners.

## Model Used

OpenAI Codex, based on GPT-6, with reasoning, repository tools, code
execution, and browser automation. The exact serving revision and
context-window size are not exposed in this session.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Scott Tong <scott@scottsmbpm5max.lan>
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-11-05 17:07:24 -08:00

375 lines
15 KiB
TypeScript

import { QueryErrorState, useQueryView } from "@/components/QueryView";
import { useShowAgentCreatedTasks } from "../hooks/useShowAgentCreatedTasks";
import { useCoordinatorWorkspaceEnabled } from "../hooks/useCoordinatorWorkspaceEnabled";
import { CoordinatorTaskViews } from "./CoordinatorTaskViews";
import { useDesignSandbox } from "../context/DesignSandboxContext";
import { DesignSandboxTasks } from "./DesignSandboxTasks";
import { useEffect, useMemo, useCallback, useRef, useState } from "react";
import type { ReactNode } from "react";
import { useLocation, useNavigate, useSearchParams } from "@/lib/router";
import { useInfiniteQuery, useQuery } from "@tanstack/react-query";
import { issuesApi } from "../api/issues";
import { agentsApi } from "../api/agents";
import { projectsApi } from "../api/projects";
import { heartbeatsApi } from "../api/heartbeats";
import { useCompany } from "../context/CompanyContext";
import { useBreadcrumbs } from "../context/BreadcrumbContext";
import { collectLiveIssueIds } from "../lib/liveIssueIds";
import { usePublishSharedQueryData, useSharedPollingQuery } from "@/hooks/useSharedPolling";
import { queryKeys } from "../lib/queryKeys";
import { createIssueDetailLocationState } from "../lib/issueDetailBreadcrumb";
import { EmptyState } from "../components/EmptyState";
import { IssuesList } from "../components/IssuesList";
import { readIssueSortParams, type IssueSort } from "../lib/issue-sort";
import { TaskViewsMenu } from "../components/TaskViewsMenu";
import { Button } from "@/components/ui/button";
import { CircleDot, Plus } from "lucide-react";
import type { Issue } from "@paperclipai/shared";
import { useStreamlinedUiEnabled } from "../hooks/useStreamlinedUiEnabled";
import { useCombinedInboxTasksEnabled } from "../hooks/useCombinedInboxTasksEnabled";
import { useDialogActions } from "../context/DialogContext";
import { useInboxBadge } from "../hooks/useInboxBadge";
import { Inbox } from "./Inbox";
import {
ORGANIZATION_SCOPED_PARAMS,
TASK_VIEW_PARAM,
loadLastTaskView,
normalizeTaskViewKey,
resolveInitialTaskView,
saveLastTaskView,
taskView,
type TaskViewKey,
} from "../lib/task-views";
import { useUpdateIssueMutation } from "../hooks/useUpdateIssueMutation";
const WORKSPACE_FILTER_ISSUE_LIMIT = 1000;
const ISSUES_PAGE_SIZE = 100;
export const ISSUES_ROW_PRESENTATION = "task" as const;
export const ISSUES_TOOLBAR_PRESENTATION = "collection" as const;
export function resolveIssuesPresentation(streamlinedUiEnabled: boolean) {
return streamlinedUiEnabled
? { rowPresentation: ISSUES_ROW_PRESENTATION, toolbarPresentation: ISSUES_TOOLBAR_PRESENTATION }
: { rowPresentation: "legacy" as const, toolbarPresentation: "legacy" as const };
}
export function getNextIssuesPageOffset(
loadedPageSize: number,
currentOffset: number,
pageSize: number = ISSUES_PAGE_SIZE,
): number | undefined {
return loadedPageSize >= pageSize ? currentOffset + pageSize : undefined;
}
export function mergeIssuePagesStable<T extends { id: string }>(pages: T[][]): T[] {
const seenIssueIds = new Set<string>();
const merged: T[] = [];
for (const page of pages) {
for (const issue of page) {
if (seenIssueIds.has(issue.id)) continue;
seenIssueIds.add(issue.id);
merged.push(issue);
}
}
return merged;
}
export function buildIssuesSearchUrl(currentHref: string, search: string): string | null {
const url = new URL(currentHref);
const currentSearch = url.searchParams.get("q") ?? "";
if (currentSearch === search) return null;
if (search.length > 0) {
url.searchParams.set("q", search);
} else {
url.searchParams.delete("q");
}
return `${url.pathname}${url.search}${url.hash}`;
}
/**
* Tasks — the single task surface after PAP-670 merged Inbox into it.
*
* This component only resolves `?view=` to a view and hands off: My-work views
* render the inbox list, organization views render the task collection. Both
* get the same Views control in their toolbar, so the switch reads as one page.
*/
export function Issues() {
const designSandbox = useDesignSandbox();
const { enabled: streamlinedUiEnabled } = useStreamlinedUiEnabled();
const { enabled: combinedInboxTasksEnabled } = useCombinedInboxTasksEnabled();
const { enabled: coordinatorEnabled } = useCoordinatorWorkspaceEnabled();
// The merged surface is Combined Inbox + Task List only. With the flag off, and always in
// the legacy shell, Tasks is the plain task list and Inbox keeps its pages.
return designSandbox ? <DesignSandboxTasks /> : coordinatorEnabled ? <CoordinatorTaskViews /> : streamlinedUiEnabled && combinedInboxTasksEnabled ? <StreamlinedTasks /> : <OrganizationIssues />;
}
function StreamlinedTasks() {
const navigate = useNavigate();
const [searchParams, setSearchParams] = useSearchParams();
const { selectedCompanyId } = useCompany();
const { openNewIssue } = useDialogActions();
const inboxBadge = useInboxBadge(selectedCompanyId);
const requestedView = searchParams.get(TASK_VIEW_PARAM);
const hasOrganizationScopedParam = ORGANIZATION_SCOPED_PARAMS.some(
(param) => (searchParams.get(param) ?? "").length > 0,
);
// Read the stored view once per mount so a later write can't yank the view
// out from under the user mid-session.
const [lastUsedView] = useState<TaskViewKey>(() => loadLastTaskView());
const view = resolveInitialTaskView(requestedView, hasOrganizationScopedParam, lastUsedView);
const definition = taskView(view);
// Make the resolved view addressable without dropping the params that
// brought the user here — and correct a requested view that was overridden
// (an inbox view carrying an organization filter opens All tasks).
useEffect(() => {
if (normalizeTaskViewKey(requestedView) === view) return;
setSearchParams((current) => {
const next = new URLSearchParams(current);
next.set(TASK_VIEW_PARAM, view);
return next;
}, { replace: true });
}, [requestedView, view, setSearchParams]);
const selectView = useCallback((next: TaskViewKey) => {
saveLastTaskView(next);
// A view switch starts clean: the previous view's search and filters are
// its own, not the new view's.
navigate(`/issues?${TASK_VIEW_PARAM}=${next}`);
}, [navigate]);
const viewsMenu = (
<TaskViewsMenu value={view} onChange={selectView} badgeCount={inboxBadge.inbox} />
);
if (definition.surface === "inbox") {
return (
<Inbox
tab={definition.inboxTab}
surfaceLabel="Tasks"
toolbarContext={(
<div className="flex min-w-0 items-center gap-2">
{viewsMenu}
<Button size="sm" variant="outline" aria-label="New Task" onClick={() => openNewIssue()}>
<Plus className="h-4 w-4 sm:mr-1" />
<span className="hidden sm:inline">New Task</span>
</Button>
</div>
)}
/>
);
}
return <OrganizationIssues toolbarContext={viewsMenu} initialStatuses={definition.statuses} />;
}
function OrganizationIssues({
toolbarContext,
initialStatuses,
}: { toolbarContext?: ReactNode; initialStatuses?: string[] } = {}) {
const { enabled: streamlinedUiEnabled } = useStreamlinedUiEnabled();
const issuesPresentation = resolveIssuesPresentation(streamlinedUiEnabled);
const { selectedCompanyId } = useCompany();
const { setBreadcrumbs } = useBreadcrumbs();
const location = useLocation();
const [searchParams, setSearchParams] = useSearchParams();
const fetchNextPageInFlightRef = useRef(false);
const urlSearch = searchParams.get("q") ?? "";
const [searchOverride, setSearchOverride] = useState<{ search: string; locationSearch: string } | null>(null);
const syncedSearch = useMemo(() => {
if (typeof window !== "undefined" && searchOverride?.locationSearch === window.location.search) {
return searchOverride.search;
}
return urlSearch;
}, [searchOverride, urlSearch, location.search]);
const showAgentCreatedTasks = useShowAgentCreatedTasks(selectedCompanyId, "paperclip:issues-view");
const sort = useMemo(() => readIssueSortParams(searchParams), [searchParams]);
const includeBlockedBy = sort?.sortField === "workflow";
const serverSortField = sort?.sortField === "created" ? "created" : "updated";
const serverSortDir = sort?.sortField === "created" || sort?.sortField === "updated" ? sort.sortDir : "desc";
const handleSortChange = useCallback((nextSort: IssueSort) => {
setSearchParams(current => {
const next = new URLSearchParams(current);
if (syncedSearch) next.set("q", syncedSearch);
else next.delete("q");
next.set("sortField", nextSort.sortField);
next.set("sortDir", nextSort.sortDir);
return next;
}, { replace: true });
}, [setSearchParams, syncedSearch]);
const routineTasksOnly = searchParams.get("originKind") === "routine_execution";
const includeAgentCreatedTasks = showAgentCreatedTasks || routineTasksOnly;
const originKind = routineTasksOnly ? "routine_execution" : undefined;
const handleRoutineTasksOnlyChange = useCallback((checked: boolean) => {
setSearchParams(current => {
const next = new URLSearchParams(current);
if (syncedSearch) next.set("q", syncedSearch);
else next.delete("q");
if (checked) next.set("originKind", "routine_execution");
else next.delete("originKind");
return next;
}, { replace: true });
}, [setSearchParams, syncedSearch]);
const participantAgentId = searchParams.get("participantAgentId") ?? undefined;
const initialWorkspaces = searchParams.getAll("workspace").filter((workspaceId) => workspaceId.length > 0);
const workspaceIdFilter = initialWorkspaces.length === 1 ? initialWorkspaces[0] : undefined;
const handleSearchChange = useCallback((search: string) => {
const nextUrl = buildIssuesSearchUrl(window.location.href, search);
if (!nextUrl) {
setSearchOverride(null);
return;
}
window.history.replaceState(window.history.state, "", nextUrl);
setSearchOverride({ search, locationSearch: window.location.search });
}, []);
const { data: agents } = useQuery({
queryKey: queryKeys.agents.list(selectedCompanyId!),
queryFn: () => agentsApi.list(selectedCompanyId!),
enabled: !!selectedCompanyId,
});
const { data: projects } = useQuery({
queryKey: queryKeys.projects.list(selectedCompanyId!, { includeArchived: true }),
queryFn: () => projectsApi.list(selectedCompanyId!, { includeArchived: true }),
enabled: !!selectedCompanyId,
});
const liveRunsQueryKey = queryKeys.liveRuns(selectedCompanyId!);
const sharedLiveRuns = useSharedPollingQuery({
companyId: selectedCompanyId,
resourceKey: "live-runs",
queryKey: liveRunsQueryKey,
enabled: !!selectedCompanyId,
// Event-sourced via LiveUpdatesProvider (GitHub issue 9627); no interval poll needed.
refetchInterval: false,
leaderOnly: true,
});
const { data: liveRuns, dataUpdatedAt: liveRunsUpdatedAt } = useQuery({
queryKey: liveRunsQueryKey,
queryFn: () => heartbeatsApi.liveRunsForCompany(selectedCompanyId!),
enabled: sharedLiveRuns.enabled,
refetchInterval: sharedLiveRuns.refetchInterval,
});
usePublishSharedQueryData(sharedLiveRuns, liveRuns, liveRunsUpdatedAt);
const issueLinkState = useMemo(
() =>
createIssueDetailLocationState(
"Tasks",
`${location.pathname}${location.search}${location.hash}`,
"issues",
),
[location.pathname, location.search, location.hash],
);
useEffect(() => {
setBreadcrumbs([{ label: "Tasks" }]);
}, [setBreadcrumbs]);
const issuePageSize = workspaceIdFilter ? WORKSPACE_FILTER_ISSUE_LIMIT : ISSUES_PAGE_SIZE;
const issuesQuery = useInfiniteQuery({
queryKey: [
...queryKeys.issues.list(selectedCompanyId!),
"participant-agent",
participantAgentId ?? "__all__",
"workspace",
workspaceIdFilter ?? "__all__",
streamlinedUiEnabled ? "index" : "compact",
"with-routine-executions",
includeAgentCreatedTasks,
originKind,
"infinite",
issuePageSize,
serverSortField,
serverSortDir,
includeBlockedBy,
],
queryFn: ({ pageParam, signal }) => issuesApi.listCompact(selectedCompanyId!, {
projection: streamlinedUiEnabled ? "index" : undefined,
participantAgentId,
workspaceId: workspaceIdFilter,
includeRoutineExecutions: true,
includeAgentCreatedTasks,
originKind,
limit: issuePageSize,
offset: pageParam,
sortField: serverSortField,
sortDir: serverSortDir,
includeBlockedBy: includeBlockedBy || undefined,
}, { signal }),
initialPageParam: 0,
getNextPageParam: (lastPage, _allPages, lastPageParam) =>
getNextIssuesPageOffset(lastPage.length, lastPageParam, issuePageSize),
enabled: !!selectedCompanyId,
placeholderData: (previousData) => previousData,
});
const { data: issuePages, isFetchingNextPage, hasNextPage, fetchNextPage } = issuesQuery;
const issuesView = useQueryView(issuesQuery);
const issues = useMemo(() => mergeIssuePagesStable(issuePages?.pages ?? []) as Issue[], [issuePages]);
const liveIssueIds = useMemo(() => collectLiveIssueIds(liveRuns, issues), [issues, liveRuns]);
const hasMoreServerIssues = syncedSearch.trim().length === 0
&& hasNextPage === true;
const loadMoreServerIssues = useCallback(() => {
if (!hasNextPage || isFetchingNextPage || fetchNextPageInFlightRef.current) return;
fetchNextPageInFlightRef.current = true;
void fetchNextPage({ cancelRefetch: false }).finally(() => {
fetchNextPageInFlightRef.current = false;
});
}, [fetchNextPage, hasNextPage, isFetchingNextPage]);
// Optimistic, rolls back with a readable toast, and resends after an outage.
const updateIssue = useUpdateIssueMutation({ companyId: selectedCompanyId });
if (!selectedCompanyId) {
return (
<EmptyState
icon={CircleDot}
message={streamlinedUiEnabled
? "Select an organization to view tasks."
: "Select a company to view tasks."}
/>
);
}
if (issuesView.kind === "error") return <QueryErrorState size="page" error={issuesView.error} action="load tasks" onRetry={issuesView.retry} retrying={issuesView.isFetching} />;
return (
<IssuesList
issues={issues ?? []}
isLoading={issuesView.kind === "loading" || issuesView.kind === "reconnecting"}
isLoadingMoreIssues={isFetchingNextPage}
agents={agents}
projects={projects}
liveIssueIds={liveIssueIds}
viewStateKey="paperclip:issues-view"
rowPresentation={issuesPresentation.rowPresentation}
toolbarPresentation={issuesPresentation.toolbarPresentation}
issueLinkState={issueLinkState}
initialAssignees={searchParams.get("assignee") ? [searchParams.get("assignee")!] : undefined}
initialWorkspaces={initialWorkspaces.length > 0 ? initialWorkspaces : undefined}
initialStatuses={initialStatuses}
toolbarContext={toolbarContext}
initialSearch={syncedSearch}
onSearchChange={handleSearchChange}
enableAgentCreatedVisibilityFilter
routineTasksOnly={routineTasksOnly}
onRoutineTasksOnlyChange={handleRoutineTasksOnlyChange}
sort={sort}
onSortChange={handleSortChange}
hasMoreIssues={hasMoreServerIssues}
onLoadMoreIssues={loadMoreServerIssues}
onUpdateIssue={(id, data) => updateIssue.mutate({ id, data })}
searchFilters={participantAgentId || workspaceIdFilter || originKind || includeBlockedBy ? { participantAgentId, workspaceId: workspaceIdFilter, originKind, ...(includeBlockedBy ? { includeBlockedBy: true } : {}) } : undefined}
/>
);
}