mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-16 03:31:44 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
110 lines
7.4 KiB
TypeScript
110 lines
7.4 KiB
TypeScript
import { randomBytes } from "node:crypto";
|
|
import { readFile, realpath } from "node:fs/promises";
|
|
import path from "node:path";
|
|
import { reviewedChatExecutionIds } from "./chat-runtime-profile.js";
|
|
import { DOCKER_DATABASE_ENV } from "./docker-postgres.js";
|
|
|
|
/**
|
|
* Test-only storage fault for `inbox-search.archive-partial-failure`.
|
|
*
|
|
* The native runner calls the product API on the server's own loopback
|
|
* listener, so a fault placed in front of PAPERCLIP_API_URL never sees the
|
|
* agent's archive requests. This fault sits below every route instead: a
|
|
* temporary trigger on the case-owned database makes the product's own archive
|
|
* write fail with a Postgres I/O error. The trigger is scoped to one company,
|
|
* person, agent and the three seeded tasks, fails only the write that would be
|
|
* the third archive of that set, counts every injected failure per task in
|
|
* non-transactional sequences, and is dropped before the declared retry. It
|
|
* never writes or edits product rows; all saved state comes from the product.
|
|
*/
|
|
export const ARCHIVE_SCENARIO = "inbox-search.archive-partial-failure";
|
|
export interface ArchiveFaultBinding { companyId: string; agentId: string; personId: string; taskIds: string[] }
|
|
export interface ArchiveStorageFault {
|
|
/** Injected failures per seeded task id, read from rollback-proof sequences. */
|
|
failures(): Promise<Record<string, number>>;
|
|
release(): Promise<void>;
|
|
close(): Promise<void>;
|
|
}
|
|
const uuid = /^[a-f0-9]{8}-(?:[a-f0-9]{4}-){3}[a-f0-9]{12}$/i;
|
|
export function validArchiveFaultBinding(value: ArchiveFaultBinding) {
|
|
return !!value && Object.keys(value).sort().join() === "agentId,companyId,personId,taskIds" && uuid.test(value.companyId) && uuid.test(value.agentId)
|
|
&& typeof value.personId === "string" && /^[A-Za-z0-9_-]{8,128}$/.test(value.personId)
|
|
&& Array.isArray(value.taskIds) && value.taskIds.length === 3 && value.taskIds.every(id => typeof id === "string" && uuid.test(id)) && new Set(value.taskIds).size === 3;
|
|
}
|
|
|
|
/** Statements only; ids are validated above and are the only interpolated values. */
|
|
export function archiveStorageFaultSql(tag: string, binding: ArchiveFaultBinding) {
|
|
if (!/^[a-f0-9]{12}$/.test(tag) || !validArchiveFaultBinding(binding)) throw new Error("Archive storage fault requires an exact owned binding");
|
|
const name = `paperclip_e2e_archive_fault_${tag}`, ids = `'{${binding.taskIds.join(",")}}'::uuid[]`, lock = Number.parseInt(tag.slice(0, 7), 16);
|
|
const sequences = binding.taskIds.map((_, index) => `${name}_hits_${index + 1}`);
|
|
const install = [
|
|
...sequences.map(sequence => `create sequence ${sequence}`),
|
|
`create function ${name}() returns trigger language plpgsql as $fault$
|
|
declare archived integer; position integer;
|
|
begin
|
|
if NEW.company_id <> '${binding.companyId}'::uuid or NEW.user_id <> '${binding.personId}' or NEW.archived_by_actor_type <> 'agent'
|
|
or NEW.archived_by_agent_id is distinct from '${binding.agentId}'::uuid or not (NEW.issue_id = any(${ids})) then
|
|
return NEW;
|
|
end if;
|
|
-- Serialize this person's archive writes for the seeded set so parallel
|
|
-- requests cannot all observe zero prior archives.
|
|
perform pg_advisory_xact_lock(${lock});
|
|
select count(*) into archived from issue_inbox_archives
|
|
where company_id = NEW.company_id and user_id = NEW.user_id and issue_id = any(${ids}) and issue_id <> NEW.issue_id;
|
|
if archived >= 2 then
|
|
position := array_position(${ids}, NEW.issue_id);
|
|
perform nextval(format('${name}_hits_%s', position)::regclass);
|
|
raise exception 'could not write inbox archive row' using errcode = '58030';
|
|
end if;
|
|
return NEW;
|
|
end
|
|
$fault$`,
|
|
`create trigger ${name} before insert or update on issue_inbox_archives for each row execute function ${name}()`,
|
|
];
|
|
return {
|
|
install,
|
|
release: [`drop trigger if exists ${name} on issue_inbox_archives`],
|
|
remove: [`drop trigger if exists ${name} on issue_inbox_archives`, `drop function if exists ${name}()`, ...sequences.map(sequence => `drop sequence if exists ${sequence}`)],
|
|
failures: sequences.map(sequence => `select case when is_called then last_value else 0 end as hits from ${sequence}`),
|
|
};
|
|
}
|
|
|
|
async function ownedDatabaseUrl(env: NodeJS.ProcessEnv) {
|
|
const temporary = env.PAPERCLIP_RUNNER_E2E_TEMP_ROOT, config = env.PAPERCLIP_CONFIG, home = env.PAPERCLIP_HOME, instance = env.PAPERCLIP_INSTANCE_ID;
|
|
if (!(temporary && config && home && instance && path.isAbsolute(temporary) && path.isAbsolute(config) && path.isAbsolute(home) && /^[A-Za-z0-9_-]+$/.test(instance))) throw new Error("Archive storage fault requires the owned runner instance");
|
|
const [root, actualConfig, actualHome] = await Promise.all([realpath(temporary), realpath(config), realpath(home)]);
|
|
if (actualHome !== path.join(root, "paperclip-home") || actualConfig !== path.join(actualHome, "instances", instance, "config.json")) throw new Error("Archive storage fault refuses an unowned instance");
|
|
const { assertRunnerDatabaseIsolation } = await import("./instance-isolation.js");
|
|
const docker = env[DOCKER_DATABASE_ENV];
|
|
await assertRunnerDatabaseIsolation(actualConfig, root, docker || undefined);
|
|
const parsed = JSON.parse(await readFile(actualConfig, "utf8")) as { database?: { mode?: string; connectionString?: string; embeddedPostgresPort?: number } };
|
|
const url = parsed.database?.mode === "postgres" ? parsed.database.connectionString
|
|
: Number.isInteger(parsed.database?.embeddedPostgresPort) ? `postgres://paperclip:paperclip@127.0.0.1:${parsed.database!.embeddedPostgresPort}/paperclip` : undefined;
|
|
if (!url) throw new Error("Archive storage fault could not resolve the owned database");
|
|
return url;
|
|
}
|
|
|
|
export async function armArchiveStorageFault(input: { executionId: string; binding: ArchiveFaultBinding; env?: NodeJS.ProcessEnv }): Promise<ArchiveStorageFault> {
|
|
const env = input.env ?? process.env;
|
|
let selected: unknown; try { selected = JSON.parse(env.PAPERCLIP_RUNNER_E2E_EXECUTION_IDS ?? "null"); } catch { selected = null; }
|
|
if (!reviewedChatExecutionIds(ARCHIVE_SCENARIO).includes(input.executionId) || !Array.isArray(selected) || selected.length !== 1 || selected[0] !== input.executionId)
|
|
throw new Error("Archive storage fault is allowed only when its own case is the single selected execution");
|
|
const statements = archiveStorageFaultSql(randomBytes(6).toString("hex"), input.binding);
|
|
const { createDb } = await import("../../packages/db/src/index.js");
|
|
const db = createDb(await ownedDatabaseUrl(env), { maxConnections: 1, connectTimeoutSeconds: 5 }), client = db.$client;
|
|
let closed = false, released = false;
|
|
const run = async (list: string[]) => { for (const statement of list) await client.unsafe(statement); };
|
|
try { await client.begin(async tx => { for (const statement of statements.install) await tx.unsafe(statement); }); }
|
|
catch (error) { await client.end({ timeout: 5 }); throw error; }
|
|
return {
|
|
async failures() {
|
|
if (closed) throw new Error("Archive storage fault is closed");
|
|
const counts: Record<string, number> = {};
|
|
for (const [index, statement] of statements.failures.entries()) { const [row] = await client.unsafe(statement); counts[input.binding.taskIds[index]!] = Number(row?.hits ?? 0); }
|
|
return counts;
|
|
},
|
|
async release() { if (closed || released) throw new Error("Archive storage fault was already released"); await run(statements.release); released = true; },
|
|
async close() { if (closed) return; closed = true; try { await run(statements.remove); } finally { await client.end({ timeout: 5 }); } },
|
|
};
|
|
}
|