mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-13 07:12:00 +01:00
## Thinking Path > - Paperclip manages work for AI-agent companies. > - Chat connections deliver provider messages and user answers. > - Slack requires a response within its original three-second deadline. > - Forms and their delivery receipts must survive retries and tenant restarts. > - This change uses the existing connector queue and durable form owners. > - Current authorization, exact receipt checks and normal ACK rules stay in force. > - The tenant can settle useful work while keeping the connection enabled. ## Linked Issues or Issue Description Refs #19019 and #19348. Companion Cloud PR: paperclipai/paperclip-cloud#1250. ## What Changed - Preserve form grants, sessions, encrypted evidence, terminal receipts and company-authorized Retry. - Check initial form enrollment before the provider send. Keep a typed preparation wait only while an exact current enrollment obligation exists. - Refund the attempt only when the claimed attempt and credential lease still match and provider invocation has not started. Possible or accepted sends retain uncertain-delivery custody. An ordinary error with the same text still uses the normal five-attempt limit. - Notify the existing publication worker when normal enrollment commits. Reconstruct pending work from durable state after a lost reply or owner restart. - Page settled history before proving idle safety. Keep unfinished, malformed and foreign receipts visible beyond the first 1,000 rows. - Keep Slack callback, answer, receipt and ACK rules in their provider owners. Support body-bound Cloud idle capabilities when a complete catalog exceeds the header budget. - Add focused regression coverage, an enabled quiet/reactivation recipe and explicit fixture port checks. - Keep SDK evidence tests tied to a normally built reviewed reference, with a separate strict refusal for actual unreviewed CI outputs. ## Verification App head: `6284d6881b5dc38a9ee149bcbde35e69a67dd8ca`, including actual master `dff8bed007e01c32f3826144b893ec80603d1335`. Companion Cloud head: `f83b38187dc7e6b2e219fe865dc16d268cc66fdb`, including actual Cloud master `b1dcc3421a91efffee631a61536cf48f357c22fc`. Cloud #1250 is merged at `1d07d81f23d4627ab7b6dcf49176b4128a2f8f9b` after exact-head passing checks and complete Greptile 5/5. Current exact-head CI typecheck, build, tests and aggregate verification are green; the complete edited Greptile review is 5/5 and all 13 review threads and nested comment pages are resolved. - Both latest enrollment findings were reproduced against the preceding product. The pure readiness control returned no wait for the first enrollment. The real-PostgreSQL control observed a provider call while that enrollment was still staged. - The repaired source passes three whole files: 21 readiness controls, 80 real-PostgreSQL milestone controls and 37 tenant-actor middleware controls. All 138 pass with zero excluded or TODO cases. The SQL case reconstructs the worker through seven waits, preserves the attempt budget, recovers a controlled lost enrollment reply, and commits one provider-port call and one exact grant. Replaying the selected attempt does not duplicate them. Authorization, SDK and enrollment-response ports are controlled in that SQL case. - The same files cover ordinary five-attempt exhaustion, accepted and possible sends, stale ownership, malformed bindings, attention states and current actor restrictions. One synthetic mismatched-binding parameter uses generation 2 against current generation 1; it is not evidence for an older-generation control. - The normal server-package typecheck passes at the measured source. It runs the normal Runner TypeScript, protocol, SDK and declaration prerequisites and all seven main App programs. The separate declaration configuration is also recorded. A worker union-narrowing error was found, fixed with an explicit callable/null branch, and verified by that normal compiler. No cast or test relaxation was used. - The normal merge of current master preserves all 78 owned paths and 15,783 unrelated master entries and modes. The three measured test files and their changed feature paths are unchanged. New upstream DB code adds only the normal nonunique concurrent native-session index and its migration classification. Shared and adapter-utils changes alter unrelated prompt or denial wording. The 138-case proof carries for those unchanged behaviors; it is not reported as a rerun after the merge. The normal Shared/SDK ensure, DB build, adapter-utils build and complete server-package check also pass at the current merged head. Their fresh inventory contains 8,143 outputs; canonical SQL and journal copies match. This build did not apply the new index migration. - Earlier real-PostgreSQL retained-history coverage reproduced the missing proof with 1,005 settled rows. Its repair retains the existing two-second/64-query inspection budget, current endpoint bound and exact owner snapshot. The 46 source-bound controls cover unfinished and invalid tails, exact cross-page action references, Retry, rollback and lost receipt responses. - Earlier enabled quiet/reactivation coverage produced ordinary useful work, kept configuration enabled, accepted fresh signed work plus a duplicate, and produced exactly one second useful reply. Its two App-worker windows lasted at least 30 seconds with zero measured PG writes, connection or outbound activity after settlement. That evidence stays tied to its measured revision. A missing worker EXIT marker limits that earlier proof; parent evidence does not replace it. - Earlier three-second callback, terminal ACK, current-question race and complete body-size controls remain source-bound. The 500-owner/1,000-binding body measured 313,875 bytes with a 618-byte JWT; signature tampering failed closed. - Final managed-provider acceptance now passes all five fresh Node boots: A/A, A/AB, B/A rejection, B/AB recovery, B/B final. Two independently configured, challenged, verified, linked and enrolled Slack identities exercise ACK and retirement debt separately. Normal provider factory/materialization delivers the configuration through a controlled external stack-provider boundary. The registered opening returns HTTP 200 in 21 ms within the original 3-second deadline. Two answers persist, normal ACK is accepted, exact retirement and lost acceptance/GC replies recover, and the original canonical snapshot remains unchanged without duplicate provider sends or submissions. - The separate complete committed-preflight case passes. A committed `update_attempted` response is lost before SDK entry; normal service-owner reconstruction after the original lease/deadline recovers the same useful update and one answer without a second trigger. This reconstructs service owners within one App process; the separate five fresh Node boots cover process restart and managed signing-key rotation. - Assertion-time PG socket reports balance 15 opens/15 closes across the five boots and 5/5 in preflight, peak 2 and zero live sockets or unexpected attempts. Worker terminal EXIT markers were missing and are not replaced by parent EXIT markers. These are domain/recovery and assertion-time connection proofs, not a new whole-worker terminal quiet measurement. All known owners/groups closed; independent SQL audits were empty; only successful fixture databases were removed. Earlier failed fixture databases/logs remain retained. No product guard, deadline or assertion was weakened. Exact runtime source and normal outputs are unchanged by the three test files in the current follow-up, so these source-bound proofs carry without repeating those journeys. - The preceding App CI ran 11,312 support cases: 11,289 passed, three SDK-evidence cases failed, and 20 external cases skipped. Normal CI dependency setup resolved six stale Slack patch-hash references and produced an unreviewed lock. The public SDK proof correctly refused that lock; the tests incorrectly assumed the CI output was a reviewed reference. The three-file test repair keeps the protected lock policy, source/compiler/parser/Zod pins, scanner and redaction rules unchanged. It builds an owned reviewed reference using the existing normal Shared/SDK producers for the positive seal test, while a separate negative requires actual unreviewed-build privacy refusal and no retained SDK bytes. It does not relabel the CI build as certified or admit a new lock hash. - All four whole SDK support files pass locally: public type 30, evidence 16, public-input synchronizer 8 and lock preparation 10, totaling 64 with zero excluded/TODO cases in 28.73 seconds. The genuine fresh reference build/positive seal and separate invalidated-reference privacy refusal passed within their original 120-second bounds. Original installed dependencies, SDK outputs/cache and runtime source stayed unchanged; normal global setup produced only its own Runner JavaScript outputs. PostgreSQL was denied throughout, all four worker markers were observed, and the owned process group/private test root closed. The local canonical-lock negative mutates only its own reference; fresh remote CI also passes the actual resolved-CI-lock branch: all 16 evidence and 30 public-type tests pass, including the genuine reviewed-reference positive and the strict actual-unreviewed-build refusal. The upstream synchronizer file runs its current 10 cases in CI. - The first complete CI attempt on this head also exposed two separate 30-second timeouts: one real reporter-artifact test and the `agent-test-environment` module-loading hook. Full original logs remain preserved. Their exact test, sanitizer and evidence source blobs are unchanged from the preceding head; inspection found no deterministic setup cause. After the original run finished, one retry of only the failed jobs passed on the same synthetic merge `168851e210671ebe97e7a778e8cf891807e80502`: Runner support reports 11,304 passes and 20 external skips; serialized shard 6 reports all 395 passes, including all 67 route bodies. No source, timeout or assertion changed. This proves recovery; the original causes remain unexplained. - The final pre-merge tree audit uses actual master `17136a6c25ef6cb7c816a29140a4c48c2c75fb31` (refreshed after the earlier `85dec046` audit). The expected normal squash preserves all 81 owned paths and 15,816 unrelated master entries and modes. Only OpenAPI has edits from both sides, and its complete content composition preserves the new project route and token help alongside this PR's API entries. The shared inbound selection changes preserve the same candidate set; new concurrent indexes, Native/workspace behavior and shutdown changes remain upstream behavior. The scoped form proof uses process agents and does not qualify the new Native/sandbox branches. The latest question-schema change still accepts the explicit version-1 payload exercised here. The last master delta also changes managed AI/Native credential refresh and writeback; those branches are outside the measured process-agent form paths. Existing 8,143 local outputs remain tied to their measured revision; no new whole-tree output equality or deployed suspension is claimed. - Reproduce the public path with `doc/testing/slack-cloud-qualification.md`, the companion Cloud checkout, Node 24/22 and fresh owned fixture databases. Aggregate local `pnpm -r typecheck`, `pnpm test:run` and `pnpm build` were not rerun as one command set. Current exact-head required CI and the complete Greptile 5/5 review now pass; the full edited summaries and all paginated threads were read. Local worker quiet does not prove deployed host or Neon suspension. Photon and Discord remain separate work; this PR completes the described Slack slice. ## Risks Use compatible App and Cloud readers before transferring custody. Signatures prove authenticity; current authorization and exact ownership still control execution. Preserve old targets, secrets and terminal facts until their normal owners release them. Keep the managed seal identity stable while custody remains. The required Slack adapter patch remains pinned. Upstream's concurrent index uses the normal top-level migration path. ## Model Used OpenAI `gpt-6.1-sol` implemented and tested the changes. A GPT-6-based Codex managing agent reviewed and integrated them. The host does not expose the managing agent's exact model ID or context-window sizes. The agents used code execution and test tools. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used, its version and tool capabilities - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have linked public related issues or PRs - [x] I have not referenced internal or instance-local Paperclip issues or links - [x] My branch name describes the change and contains no internal Paperclip ticket id - [x] I have run the local tests listed above and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation - [x] I have considered and documented risks - [x] All Paperclip CI gates are green for the current head - [x] Greptile is 5/5 with no open findings for the current head - [x] I will address all reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
559 lines
24 KiB
TypeScript
559 lines
24 KiB
TypeScript
import type { IdleDeadlineOwners } from "../services/idle-deadline-types.js";
|
|
import { verifiedCloudControlClaims, verifiedIdleCapabilities } from "../middleware/cloud-control.js";
|
|
import { trackIdleWork } from "../services/task-admission.js";
|
|
import { Router, type Request, type RequestHandler } from "express";
|
|
import { companies, type Db } from "@paperclipai/db";
|
|
import {
|
|
patchInstanceSettingsSchema,
|
|
patchInstanceExperimentalSettingsSchema,
|
|
patchInstanceGeneralSettingsSchema,
|
|
startTaskDrainRequestSchema,
|
|
} from "@paperclipai/shared";
|
|
import { conflict, forbidden } from "../errors.js";
|
|
import { assertAgentsReadyForEnvironmentChange } from "../services/plugin-environment-driver.js";
|
|
import {
|
|
cloudTenantPrimaryCompanyId,
|
|
getCloudStackContext,
|
|
isCloudManagedInstance,
|
|
} from "../services/cloud-instance.js";
|
|
import { getHiddenSettings } from "../services/settings-visibility.js";
|
|
import { readIdleSleepSafety } from "../services/idle-sleep-safety.js";
|
|
import { readIdleLocalWork } from "../services/idle-local-work.js";
|
|
import type { PluginWorkerManager } from "../services/plugin-worker-manager.js";
|
|
import { validate } from "../middleware/validate.js";
|
|
import { logger } from "../middleware/logger.js";
|
|
import {
|
|
companyService,
|
|
heartbeatService,
|
|
instanceSettingsService,
|
|
logActivity,
|
|
publishActivity,
|
|
type ActivityPublication,
|
|
} from "../services/index.js";
|
|
import { environmentService } from "../services/environments.js";
|
|
import { assertEnvironmentSelectionForCompany } from "./environment-selection.js";
|
|
import { assertBoard, assertBoardOrgAccess, getActorInfo } from "./authz.js";
|
|
|
|
function sameJsonValue(a: unknown, b: unknown): boolean {
|
|
if (a === b) return true;
|
|
if (typeof a !== "object" || typeof b !== "object" || a === null || b === null) return false;
|
|
if (Array.isArray(a) || Array.isArray(b)) {
|
|
return (
|
|
Array.isArray(a)
|
|
&& Array.isArray(b)
|
|
&& a.length === b.length
|
|
&& a.every((value, i) => sameJsonValue(value, b[i]))
|
|
);
|
|
}
|
|
const aKeys = Object.keys(a);
|
|
const bKeys = new Set(Object.keys(b));
|
|
return aKeys.length === bKeys.size && aKeys.every((key) =>
|
|
bKeys.has(key) && sameJsonValue((a as Record<string, unknown>)[key], (b as Record<string, unknown>)[key]),
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Floor writes to operator-hidden settings. Same-value writes pass so clients
|
|
* that echo a full GET response keep working (the executionMode precedent);
|
|
* only a write that would actually change a hidden setting is rejected.
|
|
*/
|
|
async function assertNoHiddenSettingChanges(
|
|
body: Record<string, unknown>,
|
|
getCurrent: () => Promise<object>,
|
|
isHiddenField: (field: string) => boolean,
|
|
) {
|
|
const hiddenKeys = Object.keys(body).filter(isHiddenField);
|
|
if (hiddenKeys.length === 0) return;
|
|
const current = (await getCurrent()) as Record<string, unknown>;
|
|
for (const key of hiddenKeys) {
|
|
if (sameJsonValue(body[key], current[key])) continue;
|
|
throw forbidden(`${key} is managed by the hosting operator on this instance`, {
|
|
code: "settings_operator_managed",
|
|
});
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Publish activity events for an already-committed mutation. The audit row
|
|
* exists in the database no matter what happens here, so a publish failure
|
|
* must not turn into a route error: that would report the mutation as
|
|
* failed to the caller when it in fact succeeded. Log and swallow instead.
|
|
*/
|
|
function publishActivitiesBestEffort(publications: ActivityPublication[], action: string) {
|
|
for (const publication of publications) {
|
|
try {
|
|
publishActivity(publication);
|
|
} catch (err) {
|
|
logger.error({ err, action, companyId: publication.companyId }, "failed to publish activity event");
|
|
}
|
|
}
|
|
}
|
|
|
|
function assertCanManageInstanceSettings(req: Request) {
|
|
assertBoard(req);
|
|
if (req.actor.source === "local_implicit" || req.actor.isInstanceAdmin) {
|
|
return;
|
|
}
|
|
throw forbidden("Instance admin access required");
|
|
}
|
|
|
|
function assertCanManageExperimentalSettings(req: Request) {
|
|
if (
|
|
req.actor.type === "board"
|
|
&& req.actor.source === "cloud_tenant"
|
|
&& req.actor.canManageExperimentalSettings
|
|
) {
|
|
return;
|
|
}
|
|
assertCanManageInstanceSettings(req);
|
|
}
|
|
|
|
// A task-drain start or stop reads the live drain state, writes an audit
|
|
// transaction, and only then mutates the process-local drain state. The
|
|
// audit write is an async gap: two overlapping requests can commit their
|
|
// transactions in one order but reach the in-memory mutation in the other
|
|
// order, so a stale transition would win, the audit log would not match the
|
|
// live state, and the response for the newer request would not match what
|
|
// actually ended up live. Run each request's whole read-audit-apply
|
|
// sequence through this queue so overlapping requests execute one at a
|
|
// time, in the order they enter it: audit order and apply order then always
|
|
// agree, and each response reports exactly the state its own request
|
|
// produced.
|
|
let taskDrainTransitionQueue: Promise<void> = Promise.resolve();
|
|
|
|
function withTaskDrainTransition<T>(run: () => Promise<T>): Promise<T> {
|
|
const turn = trackIdleWork(taskDrainTransitionQueue.then(run));
|
|
// Normalize to a settled void promise for the next caller in line, so a
|
|
// rejected transition (a failed audit write, for example) cannot wedge
|
|
// every later transition behind it.
|
|
taskDrainTransitionQueue = turn.then(
|
|
() => undefined,
|
|
() => undefined,
|
|
);
|
|
return turn;
|
|
}
|
|
|
|
export function instanceSettingsRoutes(
|
|
db: Db,
|
|
pluginWorkers?: PluginWorkerManager,
|
|
prepareIdleDatabaseBackup?: () => Promise<boolean>,
|
|
deadlineOwners?: IdleDeadlineOwners,
|
|
prepareIdlePluginLifecycle?: (input: { canRetire: () => boolean }) => Promise<"none" | "present" | "unknown">,
|
|
) {
|
|
const router = Router();
|
|
const svc = instanceSettingsService(db);
|
|
const environments = environmentService(db);
|
|
const heartbeat = heartbeatService(db, { pluginWorkerManager: pluginWorkers });
|
|
|
|
router.get("/instance/settings", async (req, res) => {
|
|
assertBoardOrgAccess(req);
|
|
res.json(await svc.get());
|
|
});
|
|
|
|
router.patch(
|
|
"/instance/settings",
|
|
validate(patchInstanceSettingsSchema),
|
|
async (req, res) => {
|
|
assertCanManageInstanceSettings(req);
|
|
if (Object.prototype.hasOwnProperty.call(req.body, "defaultEnvironmentId")) {
|
|
await assertEnvironmentSelectionForCompany(
|
|
environments,
|
|
"instance",
|
|
typeof req.body.defaultEnvironmentId === "string" ? req.body.defaultEnvironmentId : null,
|
|
);
|
|
const previousId = (await svc.get()).defaultEnvironmentId;
|
|
const environmentById = async (id: unknown) => typeof id === "string" ? environments.getById(id) : null;
|
|
await assertAgentsReadyForEnvironmentChange(db, await environmentById(previousId), await environmentById(req.body.defaultEnvironmentId),
|
|
{ inheritsDefault: true });
|
|
}
|
|
// An explicit default write is an ordinary set value: boot only fills an
|
|
// unset, local or dangling default (`fillUnsetInstanceDefault`), and the
|
|
// lock it takes on this row means it never overwrites a concurrent write.
|
|
const updated = await svc.update(req.body);
|
|
const actor = getActorInfo(req);
|
|
const companyIds = await svc.listCompanyIds();
|
|
await Promise.all(
|
|
companyIds.map((companyId) =>
|
|
logActivity(db, {
|
|
companyId,
|
|
actorType: actor.actorType,
|
|
actorId: actor.actorId,
|
|
agentId: actor.agentId,
|
|
runId: actor.runId,
|
|
agentApiKeyId: actor.agentApiKeyId,
|
|
action: "instance.settings.updated",
|
|
entityType: "instance_settings",
|
|
entityId: updated.id,
|
|
details: {
|
|
defaultEnvironmentId: updated.defaultEnvironmentId,
|
|
changedKeys: Object.keys(req.body).sort(),
|
|
},
|
|
}),
|
|
),
|
|
);
|
|
res.json(updated);
|
|
},
|
|
);
|
|
|
|
router.get("/instance/settings/general", async (req, res) => {
|
|
// General settings (e.g. feedbackDataSharingPreference) are readable by any
|
|
// authenticated org member or instance admin. Only PATCH requires instance-admin.
|
|
assertBoardOrgAccess(req);
|
|
res.json(await svc.getGeneral());
|
|
});
|
|
|
|
router.patch(
|
|
"/instance/settings/general",
|
|
validate(patchInstanceGeneralSettingsSchema),
|
|
async (req, res) => {
|
|
assertCanManageInstanceSettings(req);
|
|
// Floor: on cloud-managed instances the execution mode is pinned by the
|
|
// platform (the execution-policy bootstrap writes it at boot). No
|
|
// instance admin — including a computed owner-admin — may change it: a
|
|
// forced provider switch would strand runs on a provider the platform
|
|
// never provisioned. Same-value writes pass so settings forms that echo
|
|
// the full general-settings object keep working. Absent and "any" both
|
|
// mean unrestricted, so they compare equal.
|
|
if (
|
|
isCloudManagedInstance() &&
|
|
Object.prototype.hasOwnProperty.call(req.body, "executionMode")
|
|
) {
|
|
const current = await svc.getGeneral();
|
|
if ((req.body.executionMode ?? "any") !== (current.executionMode ?? "any")) {
|
|
throw forbidden("executionMode is platform-managed on cloud-managed instances", {
|
|
code: "execution_mode_platform_managed",
|
|
});
|
|
}
|
|
}
|
|
const hidden = getHiddenSettings();
|
|
await assertNoHiddenSettingChanges(
|
|
req.body,
|
|
() => svc.getGeneral(),
|
|
(field) => hidden.has(`instance.general.${field}`),
|
|
);
|
|
const updated = await svc.updateGeneral(req.body);
|
|
const actor = getActorInfo(req);
|
|
const companyIds = await svc.listCompanyIds();
|
|
await Promise.all(
|
|
companyIds.map((companyId) =>
|
|
logActivity(db, {
|
|
companyId,
|
|
actorType: actor.actorType,
|
|
actorId: actor.actorId,
|
|
agentId: actor.agentId,
|
|
runId: actor.runId,
|
|
agentApiKeyId: actor.agentApiKeyId,
|
|
action: "instance.settings.general_updated",
|
|
entityType: "instance_settings",
|
|
entityId: updated.id,
|
|
details: {
|
|
general: updated.general,
|
|
changedKeys: Object.keys(req.body).sort(),
|
|
},
|
|
}),
|
|
),
|
|
);
|
|
res.json(updated.general);
|
|
},
|
|
);
|
|
|
|
router.get("/instance/settings/experimental", async (req, res) => {
|
|
assertBoardOrgAccess(req);
|
|
res.json(await svc.getExperimental());
|
|
});
|
|
|
|
router.patch(
|
|
"/instance/settings/experimental",
|
|
validate(patchInstanceExperimentalSettingsSchema),
|
|
async (req, res) => {
|
|
assertCanManageExperimentalSettings(req);
|
|
// Hiding the whole Experimental page floors every toggle; otherwise
|
|
// only individually hidden keys are floored.
|
|
const hidden = getHiddenSettings();
|
|
await assertNoHiddenSettingChanges(
|
|
req.body,
|
|
() => svc.getExperimental(),
|
|
(field) =>
|
|
hidden.has("instance.experimental") || hidden.has(`instance.experimental.${field}`),
|
|
);
|
|
const updated = await svc.updateExperimental(req.body);
|
|
const actor = getActorInfo(req);
|
|
const companyIds = await svc.listCompanyIds();
|
|
await Promise.all(
|
|
companyIds.map((companyId) =>
|
|
logActivity(db, {
|
|
companyId,
|
|
actorType: actor.actorType,
|
|
actorId: actor.actorId,
|
|
agentId: actor.agentId,
|
|
runId: actor.runId,
|
|
agentApiKeyId: actor.agentApiKeyId,
|
|
action: "instance.settings.experimental_updated",
|
|
entityType: "instance_settings",
|
|
entityId: updated.id,
|
|
details: {
|
|
experimental: updated.experimental,
|
|
changedKeys: Object.keys(req.body).sort(),
|
|
},
|
|
}),
|
|
),
|
|
);
|
|
res.json(updated.experimental);
|
|
},
|
|
);
|
|
|
|
const readTaskDrainStatus: RequestHandler = async (req, res) => {
|
|
assertBoardOrgAccess(req);
|
|
if (req.query.upgradeReadiness === "1") {
|
|
// This covers all companies and must not expose instance-wide work to a member.
|
|
assertCanManageInstanceSettings(req);
|
|
res.json({ ...heartbeat.getTaskDrainStatus(), upgradeReadiness: await heartbeat.readUpgradeReadiness() });
|
|
return;
|
|
}
|
|
if (req.query.idleSleepSafety === "1") {
|
|
// The report covers every company in this process. Ordinary company
|
|
// members may read process counters, but not instance-wide work state.
|
|
assertCanManageInstanceSettings(req);
|
|
const domainDeadlines = req.query.scheduledWake === "domain-deadlines-v1";
|
|
const capabilities = verifiedIdleCapabilities(req);
|
|
if (domainDeadlines && capabilities?.deadlineCatalog !== "domain_deadlines_v1") {
|
|
throw forbidden("Domain deadline reports require the signed Cloud deadline catalog");
|
|
}
|
|
const scheduledIssueMonitors = req.query.scheduledWake === "2" || domainDeadlines;
|
|
const scheduledRoutines = req.query.scheduledWake === "1" || scheduledIssueMonitors;
|
|
if (scheduledRoutines && req.actor.source !== "cloud_control") {
|
|
throw forbidden("Scheduled wake reports require Cloud control authority");
|
|
}
|
|
// A checkpoint performs platform-owned backup work. Tenant owners can
|
|
// have instance-admin elevation, but that must not grant the manual
|
|
// backup authority which managed instances deliberately withhold.
|
|
if (prepareIdleDatabaseBackup && isCloudManagedInstance() && req.actor.source !== "cloud_control") {
|
|
throw forbidden("Backup checkpoints are platform-managed on cloud-managed instances", {
|
|
code: "database_backups_platform_managed",
|
|
});
|
|
}
|
|
const idleSleepSafety = await readIdleSleepSafety(db, () => heartbeat.getTaskDrainStatus(), Date.now,
|
|
typeof req.query.ownerId === "string" ? req.query.ownerId : undefined,
|
|
diagnostic => readIdleLocalWork({ backupCheckpoint: Boolean(prepareIdleDatabaseBackup), diagnostic,
|
|
deadlineCapability: domainDeadlines ? capabilities : undefined }),
|
|
pluginWorkers?.inspectIdleSleep?.bind(pluginWorkers), prepareIdleDatabaseBackup, scheduledRoutines, scheduledIssueMonitors,
|
|
{ deadlineOwners, incomingWake: capabilities, deadlineCapability: domainDeadlines ? capabilities : undefined,
|
|
prepareLocalWork: async ({ canPrepare }) => {
|
|
const result = await heartbeat.prepareIdleWarmNativeSessionsForSleep({ canRetire: canPrepare });
|
|
if (result.busy || result.failed) return "present";
|
|
return prepareIdlePluginLifecycle ? prepareIdlePluginLifecycle({ canRetire: canPrepare }) : "none";
|
|
},
|
|
...(req.query.idleSleepDiagnostics === "1" ? { collectDiagnostics: true } : {}) });
|
|
res.json({ ...heartbeat.getTaskDrainStatus(), idleSleepSafety });
|
|
return;
|
|
}
|
|
res.json(heartbeat.getTaskDrainStatus());
|
|
};
|
|
router.get("/instance/task-drain", readTaskDrainStatus);
|
|
router.post("/instance/task-drain/status", async (req, res, next) => {
|
|
if (req.actor.source !== "cloud_control" || verifiedCloudControlClaims(req)?.action !== "task-drain:read-body") {
|
|
throw forbidden("Cloud body-bound read authority is required");
|
|
}
|
|
await readTaskDrainStatus(req, res, next);
|
|
});
|
|
|
|
router.post(
|
|
"/instance/task-drain",
|
|
validate(startTaskDrainRequestSchema),
|
|
async (req, res) => {
|
|
assertCanManageInstanceSettings(req);
|
|
const actor = getActorInfo(req);
|
|
const companyIds = await svc.listCompanyIds();
|
|
const ttlMs = req.body.ttlMs ?? null;
|
|
// The whole read-audit-apply sequence runs as one queued transition
|
|
// (see withTaskDrainTransition above), so an overlapping start or
|
|
// stop cannot commit its audit row, or apply its live state, out of
|
|
// order against this one. computeTaskDrain runs inside the turn so
|
|
// startedAt reflects the moment this request actually took effect,
|
|
// not the moment it arrived and was queued behind another transition.
|
|
const drain = await withTaskDrainTransition(async () => {
|
|
const prior = heartbeat.getTaskDrainStatus();
|
|
if (prior?.ownerId || (req.body.purpose === "idle" && prior?.draining)) {
|
|
throw conflict("Another task drain is already active");
|
|
}
|
|
const computed = heartbeat.computeTaskDrain({ ttlMs,
|
|
...(req.body.purpose === "idle" ? { purpose: "idle" as const } : {}) });
|
|
// One transaction for every company's audit row, so a write that
|
|
// succeeds for one company and fails for another never leaves a
|
|
// partial activity history behind — either every company gets the
|
|
// record, or none does. The drain mutation below runs only after
|
|
// this transaction commits, so a failed write leaves the live
|
|
// drain untouched and there is no partial state to roll back.
|
|
const postCommitActivityPublications: ActivityPublication[] = [];
|
|
await db.transaction((tx) =>
|
|
Promise.all(
|
|
companyIds.map((companyId) =>
|
|
logActivity(tx as unknown as Db, {
|
|
companyId,
|
|
actorType: actor.actorType,
|
|
actorId: actor.actorId,
|
|
agentId: actor.agentId,
|
|
runId: actor.runId,
|
|
agentApiKeyId: actor.agentApiKeyId,
|
|
action: "instance.task_drain.started",
|
|
entityType: "instance_settings",
|
|
entityId: "default",
|
|
details: {
|
|
startedAt: computed.startedAt,
|
|
expiresAt: computed.expiresAt,
|
|
...(computed.ownerId ? { purpose: "idle", ownerId: computed.ownerId } : {}),
|
|
},
|
|
}, postCommitActivityPublications),
|
|
),
|
|
),
|
|
);
|
|
heartbeat.applyTaskDrain(computed);
|
|
// The audit record already committed, so a failure to publish it
|
|
// here is not a reason to undo the drain: reverting the in-memory
|
|
// state at this point would desync it from the committed row.
|
|
// Swallow a publish failure so it cannot turn a committed mutation
|
|
// into a false 500.
|
|
publishActivitiesBestEffort(postCommitActivityPublications, "instance.task_drain.started");
|
|
return computed;
|
|
});
|
|
res.json(drain);
|
|
},
|
|
);
|
|
|
|
router.delete("/instance/task-drain", async (req, res) => {
|
|
assertCanManageInstanceSettings(req);
|
|
const actor = getActorInfo(req);
|
|
const companyIds = await svc.listCompanyIds();
|
|
// See the POST handler above for why the whole read-audit-apply
|
|
// sequence runs inside withTaskDrainTransition: it queues this stop
|
|
// behind any transition already in flight, so it cannot read a status
|
|
// an overlapping request is about to make stale, and its audit row and
|
|
// its live-state mutation always land in the same order as every other
|
|
// queued transition.
|
|
const wasActive = await withTaskDrainTransition(async () => {
|
|
const priorStatus = heartbeat.getTaskDrainStatus();
|
|
if ((priorStatus.ownerId || req.query.ownerId !== undefined) &&
|
|
(typeof req.query.ownerId !== "string" || req.query.ownerId !== priorStatus.ownerId)) {
|
|
throw conflict("Task drain ownership changed");
|
|
}
|
|
// Read wasActive once, here, and use this same value for the audit
|
|
// detail and the response body below. A TTL that expires between two
|
|
// separate reads would otherwise make the two values disagree.
|
|
const wasActive = priorStatus.draining;
|
|
// See the POST handler above for why this is one transaction, and why
|
|
// the drain mutation runs only after it commits.
|
|
const postCommitActivityPublications: ActivityPublication[] = [];
|
|
await db.transaction((tx) =>
|
|
Promise.all(
|
|
companyIds.map((companyId) =>
|
|
logActivity(tx as unknown as Db, {
|
|
companyId,
|
|
actorType: actor.actorType,
|
|
actorId: actor.actorId,
|
|
agentId: actor.agentId,
|
|
runId: actor.runId,
|
|
agentApiKeyId: actor.agentApiKeyId,
|
|
action: "instance.task_drain.stopped",
|
|
entityType: "instance_settings",
|
|
entityId: "default",
|
|
details: {
|
|
wasActive,
|
|
},
|
|
}, postCommitActivityPublications),
|
|
),
|
|
),
|
|
);
|
|
heartbeat.stopTaskDrain();
|
|
pluginWorkers?.releaseIdleSleep?.();
|
|
// See the POST handler above for why a publish failure here is
|
|
// swallowed instead of failing the route: the audit record already
|
|
// committed, so a publish failure here must not undo a drain-stop
|
|
// that is already correct in the database, and must not report the
|
|
// stop as failed when it succeeded.
|
|
publishActivitiesBestEffort(postCommitActivityPublications, "instance.task_drain.stopped");
|
|
return wasActive;
|
|
});
|
|
if (wasActive) {
|
|
void heartbeat.resumeQueuedRunsAfterDrain().catch(err => {
|
|
logger.error({ err }, "failed to resume queued work after task drain; durable work remains queued");
|
|
});
|
|
}
|
|
res.json({ wasActive });
|
|
});
|
|
|
|
// Cloud lifecycle read-back: the harness answers a tenant's archive
|
|
// doorbell by asking this instance what the Cloud-pinned primary
|
|
// company's status actually is, so the shared-token doorbell can stay a
|
|
// hint (see cloud-lifecycle-sync.ts). Reached by the harness with a
|
|
// `lifecycle:read` Cloud control assertion. Instance-admin only for
|
|
// humans: the response summarizes lifecycle state across EVERY company
|
|
// on the instance, which a board member scoped to one company must not
|
|
// be able to infer.
|
|
router.get("/instance/lifecycle", async (req, res) => {
|
|
assertCanManageInstanceSettings(req);
|
|
const stackId = getCloudStackContext()?.stackId;
|
|
if (!stackId) {
|
|
res.status(404).json({ error: "not_cloud_managed" });
|
|
return;
|
|
}
|
|
const primaryCompanyId = cloudTenantPrimaryCompanyId(stackId);
|
|
const rows = await db
|
|
.select({ id: companies.id, status: companies.status })
|
|
.from(companies);
|
|
const primary = rows.find((row) => row.id === primaryCompanyId);
|
|
res.json({
|
|
primaryCompanyId,
|
|
primaryCompanyStatus: primary?.status ?? "missing",
|
|
otherUnarchivedCompanyCount: rows.filter(
|
|
(row) => row.id !== primaryCompanyId && row.status !== "archived",
|
|
).length,
|
|
});
|
|
});
|
|
|
|
// Cloud restore counterpart: "Resume organization" on a stack that was
|
|
// archived because its primary company was archived must bring the
|
|
// company back too, or the tenant's next doorbell would re-archive the
|
|
// stack the customer just resumed. Idempotent: a primary company that is
|
|
// not archived reports changed:false. Reached by the harness with a
|
|
// `lifecycle:unarchive-primary` control assertion; instance admins hold
|
|
// the same power through PATCH /api/companies/:id already.
|
|
router.post("/instance/lifecycle/unarchive-primary", async (req, res) => {
|
|
assertCanManageInstanceSettings(req);
|
|
const stackId = getCloudStackContext()?.stackId;
|
|
if (!stackId) {
|
|
res.status(404).json({ error: "not_cloud_managed" });
|
|
return;
|
|
}
|
|
const primaryCompanyId = cloudTenantPrimaryCompanyId(stackId);
|
|
const companySvc = companyService(db);
|
|
const existing = await companySvc.getById(primaryCompanyId);
|
|
if (!existing) {
|
|
res.status(404).json({ error: "primary_company_not_found" });
|
|
return;
|
|
}
|
|
if (existing.status !== "archived") {
|
|
res.json({ status: existing.status, changed: false });
|
|
return;
|
|
}
|
|
// Attribution: only the harness's synthetic cloud_control actor logs
|
|
// as the Cloud system identity; a human instance admin calling this
|
|
// endpoint is recorded as themselves, exactly like an in-product
|
|
// unarchive.
|
|
const actor = req.actor.source === "cloud_control"
|
|
? { actorType: "system" as const, actorId: "paperclip-cloud", agentId: null, runId: null }
|
|
: (() => {
|
|
const info = getActorInfo(req);
|
|
return {
|
|
actorType: info.actorType,
|
|
actorId: info.actorId,
|
|
agentId: info.agentId,
|
|
runId: info.runId,
|
|
};
|
|
})();
|
|
const updated = await companySvc.update(primaryCompanyId, { status: "active" }, actor);
|
|
res.json({ status: updated?.status ?? "active", changed: true });
|
|
});
|
|
|
|
return router;
|
|
}
|