mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-22 16:51:28 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Managed worktree services run isolated Paperclip instances with cloned databases. > - A reachable service was reported as ready even when its database, runtime identity, or login path was not usable. > - The first candidate added verified database seeding and managed repair in #11665. > - This pull request consolidates that candidate with signed login handoff and a complete readiness contract. > - Post-QA fixes close five defects in repair identity, repair responses, UI retry, seed journal handling, and seed-source trust. > - The benefit is a workspace that either opens safely or reports one accurate recovery action. ## Linked Issues or Issue Description No public GitHub issue exists for this work, so the problem is described here. **What happened** Managed workspace URLs could return HTTP 200 and report ready while login failed. QA also found cases where repair used the wrong instance identity, returned a generic error, left the UI stuck, rejected a safe journal lag, or trusted a mutable workspace manifest. **Expected behavior** Opening a ready workspace signs the board user in to the correct isolated instance. Provisioning and repair use a registered source and report a structured recovery state. **Actual behavior** Entry depended on a password copied into the clone. Several failure paths could publish stale readiness, hide the repair precondition, or trust state that the workspace could modify. **Additional context** This pull request includes the commits first published in #11665. That pull request keeps the original base head for review history. This consolidated pull request is the merge candidate. Related open readiness work includes #11575 and #11621. ## What Changed - Adds a short-lived, signed, single-use login ticket. It binds the user, workspace, instance, and runtime origin. - Exchanges the ticket through Better Auth. It creates the session and cookie through the supported adapter path. - Adds protected workspace readiness fields for the database, clone data, login handoff, seed phase, and runtime identity. - Fails readiness closed when the guest has no company or execution-workspace binding. - Binds ticket issuance to the exact cloned user and active company membership selected for the handoff. - Verifies every current active board identity through the exact-user handoff before publication or reuse. - Gates managed runtime publication on the readiness contract and the recorded worktree instance identity. - Refreshes runtime work products from the live runtime row after a port change. - Adds one workspace access card with ready, degraded, repairing, and failed states. - Uses the runtime response identity for repair. It returns structured repair precondition errors. - Lets a valid source journal lag converge during provisioning. - Binds seed and repair manifests to a source registered outside the agent-writable worktree. - Clears recovered UI errors so a successful retry can open the workspace. - Makes runtime tests register canonical sources and avoid ports owned by live host listeners. - Keeps Vitest on source suites when compiled `dist` trees exist. - Isolates CLI and adapter tests from ambient AWS and runtime API environment variables. - Preserves a 404 response for cross-company workspace ID lookups before runtime authorization. - Makes concurrent single-flight coverage independent of path-canonicalization scheduling order. ## Verification The following checks passed on the integrated head: ```sh pnpm -r typecheck pnpm build pnpm check:token-gates pnpm --filter @paperclipai/db check:migrations ``` - The server source lane passed 420 files and 4,953 tests. Five tests were skipped. - The CLI lane passed 57 files and 385 tests. - The database lane passed 26 files and 97 tests. - The shared package passed 58 files and 506 tests. - The adapter utility lane passed 640 tests. Four tests were skipped. - The Claude adapter passed 220 tests. One test was skipped. - The Codex adapter passed 323 tests. - The OpenClaw adapter passed 13 tests. - The OpenCode adapter passed 42 tests. - The plugin SDK passed 45 tests. - The workspace runtime suite passed 124 tests. - The caller-scoped readiness and handoff suite passed 52 tests. - The workspace provisioning shell suite passed 7 tests. - The runtime exposure suite passed 17 tests while live host mappings occupied fixed test ports. - `git diff --check` passed and the worktree is clean. The serialized route lane will run in GitHub CI with its normal shards. No deployment or active-workspace migration was performed. ## Risks - This is a medium-risk authentication and runtime-readiness change. - The login ticket uses exact origin, workspace, instance, and user binding. It has a short expiry and a one-time nonce. - Runtime publication is stricter. A real readiness, identity, per-user handoff, or control-plane database disagreement now blocks publication. - This pull request supersedes #11665 as the merge candidate. Close #11665 after this pull request merges. - No new database migration is included. The lockfile and workflow files are unchanged. - Deployment and active-workspace migration are intentionally outside this pull request. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used Claude Opus 5 (`claude-opus-5[1m]`), 1M context, extended thinking, tool use, and code execution produced the main candidate. OpenAI GPT-5 (`gpt-5`) through Codex, with agentic reasoning, tool use, and code execution, integrated the post-QA fixes and hardened the test gates. The Codex context-window size was not exposed. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
328 lines
14 KiB
JavaScript
328 lines
14 KiB
JavaScript
import assert from "node:assert/strict";
|
|
import { spawnSync } from "node:child_process";
|
|
import test from "node:test";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const script = new URL("../provision-worktree.sh", import.meta.url).pathname;
|
|
const runtimeScript = new URL("../provision-worktree-runtime.sh", import.meta.url).pathname;
|
|
|
|
// Keep the PATH minimal so the fallback ladder is deterministic: node must be
|
|
// reachable, but a globally installed `paperclipai` must not shadow the paths
|
|
// under test.
|
|
const testPath = [path.dirname(process.execPath), "/usr/bin", "/bin"].join(":");
|
|
|
|
const cleanupDirs = [];
|
|
|
|
function makeTempDir(prefix) {
|
|
const dir = fs.mkdtempSync(path.join(os.tmpdir(), prefix));
|
|
cleanupDirs.push(dir);
|
|
return dir;
|
|
}
|
|
|
|
test.after(() => {
|
|
for (const dir of cleanupDirs) {
|
|
fs.rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
/**
|
|
* Writes a fake base workspace whose "tsx runner" is a plain node script, so
|
|
* the provision script's health check and init call can be steered per test.
|
|
*
|
|
* helpExit: exit code for `... index.ts --help` (the health check boot).
|
|
* initExit: exit code for `... index.ts worktree init ...`; on 0 the fake CLI
|
|
* writes a marker config so tests can tell CLI init from fallback.
|
|
*/
|
|
function makeBaseWorkspace({ helpExit, initExit, ensureExit = 0 }) {
|
|
const baseCwd = makeTempDir("paperclip-provision-base-");
|
|
fs.mkdirSync(path.join(baseCwd, ".paperclip"), { recursive: true });
|
|
fs.writeFileSync(path.join(baseCwd, ".paperclip", "config.json"), "{}\n");
|
|
fs.writeFileSync(path.join(baseCwd, ".paperclip", ".env"), "PAPERCLIP_INSTANCE_ID=base-source\n");
|
|
const runnerPath = path.join(baseCwd, "cli", "node_modules", "tsx", "dist", "cli.mjs");
|
|
const entryPath = path.join(baseCwd, "cli", "src", "index.ts");
|
|
fs.mkdirSync(path.dirname(runnerPath), { recursive: true });
|
|
fs.mkdirSync(path.dirname(entryPath), { recursive: true });
|
|
fs.writeFileSync(entryPath, "// fake CLI entry\n");
|
|
fs.writeFileSync(
|
|
runnerPath,
|
|
`
|
|
import fs from "node:fs";
|
|
const cliArgs = process.argv.slice(3);
|
|
fs.appendFileSync(${JSON.stringify(path.join(baseCwd, "cli-invocations.log"))}, JSON.stringify(cliArgs) + "\\n");
|
|
if (cliArgs.includes("--help")) {
|
|
if (${helpExit} !== 0) console.error("ERR_MODULE_NOT_FOUND: drizzle-orm");
|
|
process.exit(${helpExit});
|
|
}
|
|
if (cliArgs[0] === "worktree" && cliArgs[1] === "init") {
|
|
if (${initExit} !== 0) {
|
|
console.error("fake worktree init failure");
|
|
process.exit(${initExit});
|
|
}
|
|
fs.mkdirSync(".paperclip", { recursive: true });
|
|
fs.writeFileSync(".paperclip/config.json", JSON.stringify({ $meta: { source: "fake-cli" } }));
|
|
fs.writeFileSync(".paperclip/.env", "PAPERCLIP_IN_WORKTREE=true\\n");
|
|
process.exit(0);
|
|
}
|
|
if (cliArgs[0] === "worktree" && cliArgs[1] === "ensure-seeded") {
|
|
if (${ensureExit} !== 0) {
|
|
console.error("fake worktree ensure-seeded failure");
|
|
process.exit(${ensureExit});
|
|
}
|
|
fs.rmSync(".paperclip/seed-pending", { force: true });
|
|
fs.writeFileSync(".paperclip/seed-complete", "{}\\n");
|
|
process.exit(0);
|
|
}
|
|
process.exit(0);
|
|
`,
|
|
);
|
|
return baseCwd;
|
|
}
|
|
|
|
function runProvision(baseCwd, { pathPrefix } = {}) {
|
|
const worktreeCwd = makeTempDir("paperclip-provision-worktree-");
|
|
const worktreesHome = makeTempDir("paperclip-provision-home-");
|
|
const result = spawnSync("bash", [script], {
|
|
cwd: worktreeCwd,
|
|
encoding: "utf8",
|
|
env: {
|
|
PATH: pathPrefix ? `${pathPrefix}:${testPath}` : testPath,
|
|
HOME: os.homedir(),
|
|
PAPERCLIP_WORKSPACE_BASE_CWD: baseCwd,
|
|
PAPERCLIP_WORKSPACE_CWD: worktreeCwd,
|
|
PAPERCLIP_WORKSPACE_BRANCH: "feature/provision-test",
|
|
PAPERCLIP_WORKTREES_DIR: worktreesHome,
|
|
PAPERCLIP_HOME: path.join(worktreesHome, "no-such-instance-home"),
|
|
PAPERCLIP_PROJECT_WORKSPACE_ID: "project-workspace-1",
|
|
PAPERCLIP_SEED_EXPECTED_COMPANY_ID: "company-1",
|
|
},
|
|
});
|
|
return { result, worktreeCwd, worktreesHome };
|
|
}
|
|
|
|
function runRuntimeProvision(baseCwd, worktreeCwd) {
|
|
const worktreesHome = makeTempDir("paperclip-provision-runtime-home-");
|
|
return spawnSync("bash", [runtimeScript], {
|
|
cwd: worktreeCwd,
|
|
encoding: "utf8",
|
|
env: {
|
|
PATH: testPath,
|
|
HOME: os.homedir(),
|
|
PAPERCLIP_WORKSPACE_BASE_CWD: baseCwd,
|
|
PAPERCLIP_WORKSPACE_CWD: worktreeCwd,
|
|
PAPERCLIP_WORKSPACE_BRANCH: "feature/provision-runtime-test",
|
|
PAPERCLIP_WORKTREES_DIR: worktreesHome,
|
|
PAPERCLIP_HOME: path.join(worktreesHome, "no-such-instance-home"),
|
|
PAPERCLIP_PROJECT_WORKSPACE_ID: "project-workspace-1",
|
|
PAPERCLIP_COMPANY_ID: "company-1",
|
|
},
|
|
});
|
|
}
|
|
|
|
function readCliInvocations(baseCwd) {
|
|
const logPath = path.join(baseCwd, "cli-invocations.log");
|
|
if (!fs.existsSync(logPath)) return [];
|
|
return fs
|
|
.readFileSync(logPath, "utf8")
|
|
.trim()
|
|
.split("\n")
|
|
.filter(Boolean)
|
|
.map((line) => JSON.parse(line));
|
|
}
|
|
|
|
function readWorktreeConfig(worktreeCwd) {
|
|
const configPath = path.join(worktreeCwd, ".paperclip", "config.json");
|
|
assert.ok(fs.existsSync(configPath), `expected ${configPath} to exist`);
|
|
return JSON.parse(fs.readFileSync(configPath, "utf8"));
|
|
}
|
|
|
|
test("uses the base CLI when its import graph boots", () => {
|
|
const baseCwd = makeBaseWorkspace({ helpExit: 0, initExit: 0 });
|
|
const { result, worktreeCwd } = runProvision(baseCwd);
|
|
|
|
assert.equal(result.status, 0, result.stderr);
|
|
const config = readWorktreeConfig(worktreeCwd);
|
|
assert.equal(config.$meta.source, "fake-cli");
|
|
assert.equal(
|
|
JSON.parse(fs.readFileSync(path.join(worktreeCwd, ".paperclip", "seed-manifest.json"), "utf8")).state,
|
|
"pending",
|
|
);
|
|
const initInvocation = readCliInvocations(baseCwd).find(
|
|
(args) => args[0] === "worktree" && args[1] === "init",
|
|
);
|
|
assert.ok(
|
|
initInvocation?.includes("--no-seed"),
|
|
`expected --no-seed in ${JSON.stringify(initInvocation)}`,
|
|
);
|
|
});
|
|
|
|
test("falls back to an isolated config when the base CLI cannot boot", () => {
|
|
// Simulates the dangling pnpm symlink incident: the runner and entry files
|
|
// exist, but booting the CLI fails ESM resolution. The base has no
|
|
// package.json/pnpm-lock.yaml, so the repair install is not possible and the
|
|
// script must degrade to the no-CLI fallback config instead of failing.
|
|
const baseCwd = makeBaseWorkspace({ helpExit: 1, initExit: 0 });
|
|
const { result, worktreeCwd, worktreesHome } = runProvision(baseCwd);
|
|
|
|
assert.equal(result.status, 0, result.stderr);
|
|
assert.match(result.stderr, /writing isolated fallback config/);
|
|
const config = readWorktreeConfig(worktreeCwd);
|
|
assert.equal(config.$meta.source, "configure");
|
|
const dataDir = config.database.embeddedPostgresDataDir;
|
|
assert.ok(
|
|
!path.relative(worktreesHome, dataDir).startsWith(".."),
|
|
`expected ${dataDir} to live under ${worktreesHome}`,
|
|
);
|
|
const env = fs.readFileSync(path.join(worktreeCwd, ".paperclip", ".env"), "utf8");
|
|
assert.match(env, /PAPERCLIP_IN_WORKTREE=true/);
|
|
assert.equal(
|
|
JSON.parse(fs.readFileSync(path.join(worktreeCwd, ".paperclip", "seed-manifest.json"), "utf8")).state,
|
|
"pending",
|
|
);
|
|
});
|
|
|
|
test("repairs an unhealthy base install under the lock and then uses the CLI", (t) => {
|
|
const hasTools = ["flock", "git"].every(
|
|
(tool) => spawnSync("bash", ["-lc", `command -v ${tool}`], { env: { PATH: testPath } }).status === 0,
|
|
);
|
|
if (!hasTools) {
|
|
t.skip("flock or git not available on this host");
|
|
return;
|
|
}
|
|
|
|
// The CLI's health is controlled by a flag file, and a fake `pnpm install`
|
|
// creates that flag — modeling a forced reinstall that relinks the store.
|
|
const baseCwd = makeTempDir("paperclip-provision-repair-base-");
|
|
fs.mkdirSync(path.join(baseCwd, ".paperclip"), { recursive: true });
|
|
fs.writeFileSync(path.join(baseCwd, ".paperclip", "config.json"), "{}\n");
|
|
fs.writeFileSync(path.join(baseCwd, ".paperclip", ".env"), "PAPERCLIP_INSTANCE_ID=base-source\n");
|
|
const healthFlag = path.join(baseCwd, "cli-healthy.flag");
|
|
const runnerPath = path.join(baseCwd, "cli", "node_modules", "tsx", "dist", "cli.mjs");
|
|
const entryPath = path.join(baseCwd, "cli", "src", "index.ts");
|
|
fs.mkdirSync(path.dirname(runnerPath), { recursive: true });
|
|
fs.mkdirSync(path.dirname(entryPath), { recursive: true });
|
|
fs.writeFileSync(entryPath, "// fake CLI entry\n");
|
|
fs.writeFileSync(
|
|
runnerPath,
|
|
`
|
|
import fs from "node:fs";
|
|
const cliArgs = process.argv.slice(3);
|
|
if (cliArgs.includes("--help")) {
|
|
process.exit(fs.existsSync(${JSON.stringify(healthFlag)}) ? 0 : 1);
|
|
}
|
|
if (cliArgs[0] === "worktree" && cliArgs[1] === "init") {
|
|
fs.mkdirSync(".paperclip", { recursive: true });
|
|
fs.writeFileSync(".paperclip/config.json", JSON.stringify({ $meta: { source: "fake-cli" } }));
|
|
fs.writeFileSync(".paperclip/.env", "PAPERCLIP_IN_WORKTREE=true\\n");
|
|
process.exit(0);
|
|
}
|
|
process.exit(0);
|
|
`,
|
|
);
|
|
fs.writeFileSync(path.join(baseCwd, "package.json"), "{}\n");
|
|
fs.writeFileSync(path.join(baseCwd, "pnpm-lock.yaml"), "lockfileVersion: '9.0'\n");
|
|
spawnSync("git", ["init", "-q", baseCwd], { env: { PATH: testPath } });
|
|
|
|
const fakeBin = makeTempDir("paperclip-provision-fakebin-");
|
|
const installLog = path.join(baseCwd, "pnpm-invocations.log");
|
|
fs.writeFileSync(
|
|
path.join(fakeBin, "pnpm"),
|
|
`#!/usr/bin/env bash
|
|
if [[ "$1" == "install" ]]; then
|
|
echo "$@" >> ${JSON.stringify(installLog)}
|
|
touch ${JSON.stringify(healthFlag)}
|
|
exit 0
|
|
fi
|
|
exit 1
|
|
`,
|
|
{ mode: 0o755 },
|
|
);
|
|
|
|
const { result, worktreeCwd } = runProvision(baseCwd, { pathPrefix: fakeBin });
|
|
|
|
assert.equal(result.status, 0, result.stderr);
|
|
const config = readWorktreeConfig(worktreeCwd);
|
|
assert.equal(config.$meta.source, "fake-cli");
|
|
const installs = fs.readFileSync(installLog, "utf8").trim().split("\n");
|
|
assert.equal(installs.length, 1, `expected exactly one repair install, got: ${installs.join(" | ")}`);
|
|
assert.match(installs[0], /--force/);
|
|
assert.match(installs[0], /--frozen-lockfile/);
|
|
assert.ok(
|
|
fs.existsSync(path.join(baseCwd, ".git", "paperclip-provision-repair.lock")),
|
|
"expected the repair lock file inside the resolved git dir",
|
|
);
|
|
});
|
|
|
|
test("a failed CLI init fails provisioning instead of being masked as success", () => {
|
|
// Regression test for the masked `return 0` after the init subshell: a CLI
|
|
// that passes the health check but fails `worktree init` signals a real
|
|
// problem, so the script must propagate the failure rather than report
|
|
// success or write an unseeded fallback config over it.
|
|
const baseCwd = makeBaseWorkspace({ helpExit: 0, initExit: 3 });
|
|
const { result, worktreeCwd } = runProvision(baseCwd);
|
|
|
|
assert.equal(result.status, 3, result.stderr);
|
|
assert.match(result.stderr, /fake worktree init failure/);
|
|
assert.ok(!fs.existsSync(path.join(worktreeCwd, ".paperclip", "config.json")));
|
|
});
|
|
|
|
test("runtime provisioning invokes ensure-seeded once and fast-exits after success", () => {
|
|
const baseCwd = makeBaseWorkspace({ helpExit: 0, initExit: 0 });
|
|
const worktreeCwd = makeTempDir("paperclip-provision-runtime-worktree-");
|
|
fs.mkdirSync(path.join(worktreeCwd, ".paperclip"), { recursive: true });
|
|
fs.writeFileSync(path.join(worktreeCwd, ".paperclip", "config.json"), "{}\n");
|
|
fs.writeFileSync(path.join(worktreeCwd, ".paperclip", "seed-pending"), "{}\n");
|
|
|
|
const first = runRuntimeProvision(baseCwd, worktreeCwd);
|
|
assert.equal(first.status, 0, first.stderr);
|
|
assert.ok(fs.existsSync(path.join(worktreeCwd, ".paperclip", "seed-complete")));
|
|
assert.ok(!fs.existsSync(path.join(worktreeCwd, ".paperclip", "seed-pending")));
|
|
|
|
const ensureCallsAfterFirst = readCliInvocations(baseCwd)
|
|
.filter((args) => args[0] === "worktree" && args[1] === "ensure-seeded");
|
|
assert.equal(ensureCallsAfterFirst.length, 1);
|
|
assert.ok(ensureCallsAfterFirst[0].includes("--config"));
|
|
assert.ok(!ensureCallsAfterFirst[0].includes("--from-config"));
|
|
|
|
const second = runRuntimeProvision(baseCwd, worktreeCwd);
|
|
assert.equal(second.status, 0, second.stderr);
|
|
assert.match(second.stderr, /already seeded.*skipping/);
|
|
const ensureCallsAfterSecond = readCliInvocations(baseCwd)
|
|
.filter((args) => args[0] === "worktree" && args[1] === "ensure-seeded");
|
|
assert.equal(ensureCallsAfterSecond.length, 1);
|
|
});
|
|
|
|
test("runtime provisioning leaves seed-pending in place when ensure-seeded fails", () => {
|
|
const baseCwd = makeBaseWorkspace({ helpExit: 0, initExit: 0, ensureExit: 4 });
|
|
const worktreeCwd = makeTempDir("paperclip-provision-runtime-failure-");
|
|
fs.mkdirSync(path.join(worktreeCwd, ".paperclip"), { recursive: true });
|
|
fs.writeFileSync(path.join(worktreeCwd, ".paperclip", "config.json"), "{}\n");
|
|
fs.writeFileSync(path.join(worktreeCwd, ".paperclip", "seed-pending"), "{}\n");
|
|
|
|
const result = runRuntimeProvision(baseCwd, worktreeCwd);
|
|
assert.equal(result.status, 4, result.stderr);
|
|
assert.match(result.stderr, /fake worktree ensure-seeded failure/);
|
|
assert.ok(fs.existsSync(path.join(worktreeCwd, ".paperclip", "seed-pending")));
|
|
assert.ok(!fs.existsSync(path.join(worktreeCwd, ".paperclip", "seed-complete")));
|
|
});
|
|
|
|
test("runtime provisioning does not trust a truncated verified manifest", () => {
|
|
const baseCwd = makeBaseWorkspace({ helpExit: 0, initExit: 0, ensureExit: 4 });
|
|
const worktreeCwd = makeTempDir("paperclip-provision-runtime-truncated-");
|
|
fs.mkdirSync(path.join(worktreeCwd, ".paperclip"), { recursive: true });
|
|
fs.writeFileSync(path.join(worktreeCwd, ".paperclip", "config.json"), "{}\n");
|
|
fs.writeFileSync(
|
|
path.join(worktreeCwd, ".paperclip", "seed-manifest.json"),
|
|
JSON.stringify({ version: 2, state: "verified" }),
|
|
);
|
|
|
|
const result = runRuntimeProvision(baseCwd, worktreeCwd);
|
|
assert.equal(result.status, 4, result.stderr);
|
|
assert.equal(
|
|
readCliInvocations(baseCwd)
|
|
.filter((args) => args[0] === "worktree" && args[1] === "ensure-seeded").length,
|
|
1,
|
|
);
|
|
});
|