mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-14 08:26:46 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Paperclip provides CLI commands and guidance for operators and agents > - The `pnpm paperclipai` script can pass argument values through a shell > - Shell re-parsing can execute command substitutions inside quoted values > - This pull request routes guidance through inert-argv `npx paperclipai` commands and adds regression coverage > - The benefit is safer operator guidance across documentation and runtime hints ## Linked Issues or Issue Description This pull request fixes a command-injection-class defect in Paperclip CLI guidance. **What happened?** The `pnpm paperclipai <sub> --flag "$VALUE"` form can re-parse argument values through a shell. A command substitution inside a quoted value can execute on the host. **Expected behavior** Paperclip guidance must pass CLI values as inert argument values. Host-derived values must not appear in copyable commands. **Steps to reproduce** 1. Run a Paperclip guidance command that uses the `pnpm paperclipai` script. 2. Provide a quoted value that contains a command substitution. 3. Observe that the shell can evaluate the substitution before the CLI starts. 4. Compare the result with the `npx paperclipai` form. **Paperclip version or commit** `5670984b75d109950c968542a0111ebb6967f4da` **Deployment mode** All deployment modes that show or use the affected CLI guidance. **Installation method** Built from source and installed CLI guidance. **Agent adapter(s) involved** Not adapter-specific (core bug). **Database mode** Not database-related. **Access context** Both. **Additional context** The earlier merged PR [#11343](https://github.com/paperclipai/paperclip/pull/11343) used the unsafe `pnpm exec paperclipai` form. This fresh PR replaces that guidance with the safe `npx paperclipai` form. ## What Changed - Standardize documentation and runtime hints on `npx paperclipai`. - Remove the broken `pnpm exec paperclipai` guidance. - Use a static `<host>` placeholder in private-hostname guidance. - Add regression tests for unsafe forms, continued lines, static hosts, and offline guidance. ## Verification - `git diff --check origin/master...origin/fix/paperclipai-cli-npx-safe-invocation` passes. - The branch adds `server/src/__tests__/cli-invocation-safety.test.ts` and updates private-hostname tests. - CI must run the new tests, typecheck, lint, and build checks. - Local Vitest execution was not available because this worktree has no installed Vitest binary. ## Risks - The change affects operator and agent documentation text. - The runtime hints now show `<host>` instead of a request-derived host value. - No database schema or migration changes exist. - CI will detect any missed unsafe invocation or type error. ## Model Used OpenAI GPT-5, exact model ID `gpt-5`, with tool use and code-review assistance. The model used repository inspection, Git operations, and PR preparation. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] CI ran the test suites and they pass; local test execution was unavailable in this worktree - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I addressed all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
178 lines
6.6 KiB
TypeScript
178 lines
6.6 KiB
TypeScript
import { existsSync, readFileSync } from "node:fs";
|
|
import { resolvePaperclipConfigPath, resolvePaperclipEnvPath } from "./paths.js";
|
|
import type { BindMode, DeploymentExposure, DeploymentMode } from "@paperclipai/shared";
|
|
|
|
import { parse as parseEnvFileContents } from "dotenv";
|
|
|
|
type UiMode = "none" | "static" | "vite-dev";
|
|
|
|
type ExternalPostgresInfo = {
|
|
mode: "external-postgres";
|
|
connectionString: string;
|
|
};
|
|
|
|
type EmbeddedPostgresInfo = {
|
|
mode: "embedded-postgres";
|
|
dataDir: string;
|
|
port: number;
|
|
};
|
|
|
|
type StartupBannerOptions = {
|
|
bind: BindMode;
|
|
host: string;
|
|
deploymentMode: DeploymentMode;
|
|
deploymentExposure: DeploymentExposure;
|
|
authReady: boolean;
|
|
requestedPort: number;
|
|
listenPort: number;
|
|
uiMode: UiMode;
|
|
db: ExternalPostgresInfo | EmbeddedPostgresInfo;
|
|
migrationSummary: string;
|
|
heartbeatSchedulerEnabled: boolean;
|
|
heartbeatSchedulerIntervalMs: number;
|
|
databaseBackupEnabled: boolean;
|
|
databaseBackupIntervalMinutes: number;
|
|
databaseBackupRetentionDays: number;
|
|
databaseBackupDir: string;
|
|
};
|
|
|
|
const ansi = {
|
|
reset: "\x1b[0m",
|
|
bold: "\x1b[1m",
|
|
dim: "\x1b[2m",
|
|
cyan: "\x1b[36m",
|
|
green: "\x1b[32m",
|
|
yellow: "\x1b[33m",
|
|
magenta: "\x1b[35m",
|
|
blue: "\x1b[34m",
|
|
};
|
|
|
|
function color(text: string, c: keyof typeof ansi): string {
|
|
return `${ansi[c]}${text}${ansi.reset}`;
|
|
}
|
|
|
|
function row(label: string, value: string): string {
|
|
return `${color(label.padEnd(16), "dim")} ${value}`;
|
|
}
|
|
|
|
function redactConnectionString(raw: string): string {
|
|
try {
|
|
const u = new URL(raw);
|
|
const user = u.username || "user";
|
|
const auth = `${user}:***@`;
|
|
return `${u.protocol}//${auth}${u.host}${u.pathname}`;
|
|
} catch {
|
|
return "<invalid DATABASE_URL>";
|
|
}
|
|
}
|
|
|
|
function resolveAgentJwtSecretStatus(
|
|
envFilePath: string,
|
|
): {
|
|
status: "pass" | "warn";
|
|
message: string;
|
|
} {
|
|
const envValue = process.env.PAPERCLIP_AGENT_JWT_SECRET?.trim();
|
|
if (envValue) {
|
|
return {
|
|
status: "pass",
|
|
message: "set",
|
|
};
|
|
}
|
|
|
|
if (existsSync(envFilePath)) {
|
|
const parsed = parseEnvFileContents(readFileSync(envFilePath, "utf-8"));
|
|
const fileValue = typeof parsed.PAPERCLIP_AGENT_JWT_SECRET === "string" ? parsed.PAPERCLIP_AGENT_JWT_SECRET.trim() : "";
|
|
if (fileValue) {
|
|
return {
|
|
status: "warn",
|
|
message: `found in ${envFilePath} but not loaded`,
|
|
};
|
|
}
|
|
}
|
|
|
|
return {
|
|
status: "warn",
|
|
message: "missing (run `npx paperclipai onboard`)",
|
|
};
|
|
}
|
|
|
|
export function printStartupBanner(opts: StartupBannerOptions): void {
|
|
const baseHost = opts.host === "0.0.0.0" ? "localhost" : opts.host;
|
|
const baseUrl = `http://${baseHost}:${opts.listenPort}`;
|
|
const apiUrl = `${baseUrl}/api`;
|
|
const uiUrl = opts.uiMode === "none" ? "disabled" : baseUrl;
|
|
const configPath = resolvePaperclipConfigPath();
|
|
const envFilePath = resolvePaperclipEnvPath();
|
|
const agentJwtSecret = resolveAgentJwtSecretStatus(envFilePath);
|
|
|
|
const dbMode =
|
|
opts.db.mode === "embedded-postgres"
|
|
? color("embedded-postgres", "green")
|
|
: color("external-postgres", "yellow");
|
|
const uiMode =
|
|
opts.uiMode === "vite-dev"
|
|
? color("vite-dev-middleware", "cyan")
|
|
: opts.uiMode === "static"
|
|
? color("static-ui", "magenta")
|
|
: color("headless-api", "yellow");
|
|
|
|
const portValue =
|
|
opts.requestedPort === opts.listenPort
|
|
? `${opts.listenPort}`
|
|
: `${opts.listenPort} ${color(`(requested ${opts.requestedPort})`, "dim")}`;
|
|
|
|
const dbDetails =
|
|
opts.db.mode === "embedded-postgres"
|
|
? `${opts.db.dataDir} ${color(`(pg:${opts.db.port})`, "dim")}`
|
|
: redactConnectionString(opts.db.connectionString);
|
|
|
|
const heartbeat = opts.heartbeatSchedulerEnabled
|
|
? `enabled ${color(`(${opts.heartbeatSchedulerIntervalMs}ms)`, "dim")}`
|
|
: color("disabled", "yellow");
|
|
const dbBackup = opts.databaseBackupEnabled
|
|
? `enabled ${color(`(every ${opts.databaseBackupIntervalMinutes}m, keep ${opts.databaseBackupRetentionDays}d)`, "dim")}`
|
|
: color("disabled", "yellow");
|
|
|
|
const art = [
|
|
color("██████╗ █████╗ ██████╗ ███████╗██████╗ ██████╗██╗ ██╗██████╗ ", "cyan"),
|
|
color("██╔══██╗██╔══██╗██╔══██╗██╔════╝██╔══██╗██╔════╝██║ ██║██╔══██╗", "cyan"),
|
|
color("██████╔╝███████║██████╔╝█████╗ ██████╔╝██║ ██║ ██║██████╔╝", "cyan"),
|
|
color("██╔═══╝ ██╔══██║██╔═══╝ ██╔══╝ ██╔══██╗██║ ██║ ██║██╔═══╝ ", "cyan"),
|
|
color("██║ ██║ ██║██║ ███████╗██║ ██║╚██████╗███████╗██║██║ ", "cyan"),
|
|
color("╚═╝ ╚═╝ ╚═╝╚═╝ ╚══════╝╚═╝ ╚═╝ ╚═════╝╚══════╝╚═╝╚═╝ ", "cyan"),
|
|
];
|
|
|
|
const lines = [
|
|
"",
|
|
...art,
|
|
color(" ───────────────────────────────────────────────────────", "blue"),
|
|
row("Mode", `${dbMode} | ${uiMode}`),
|
|
row("Deploy", `${opts.deploymentMode} (${opts.deploymentExposure})`),
|
|
row("Bind", `${opts.bind} ${color(`(${opts.host})`, "dim")}`),
|
|
row("Auth", opts.authReady ? color("ready", "green") : color("not-ready", "yellow")),
|
|
row("Server", portValue),
|
|
row("API", `${apiUrl} ${color(`(health: ${apiUrl}/health)`, "dim")}`),
|
|
row("UI", uiUrl),
|
|
row("Database", dbDetails),
|
|
row("Migrations", opts.migrationSummary),
|
|
row(
|
|
"Agent JWT",
|
|
agentJwtSecret.status === "pass"
|
|
? color(agentJwtSecret.message, "green")
|
|
: color(agentJwtSecret.message, "yellow"),
|
|
),
|
|
row("Heartbeat", heartbeat),
|
|
row("DB Backup", dbBackup),
|
|
row("Backup Dir", opts.databaseBackupDir),
|
|
row("Config", configPath),
|
|
agentJwtSecret.status === "warn"
|
|
? color(" ───────────────────────────────────────────────────────", "yellow")
|
|
: null,
|
|
color(" ───────────────────────────────────────────────────────", "blue"),
|
|
"",
|
|
];
|
|
|
|
console.log(lines.filter((line): line is string => line !== null).join("\n"));
|
|
}
|