Files
PaperClipAI/server/src/services/native-runtime/automatic-completion-reviews.ts
T
DottaandPaperclip 5f0da562db fix(server): wake chat lifecycle milestones from committed changes (#17606)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work.
> - Connected chats show safe notices when a run starts, waits,
finishes, or fails.
> - A recurring scan projected these notices even when no eligible work
existed.
> - Eligibility depends on committed run state, conversation lineage,
and current authority.
> - Existing database rows can reconstruct that work after restart.
> - This PR wakes a scoped worker from those writes and removes
lifecycle polling.
> - Native progress events keep their separate existing owner until the
next migration.

## Linked Issues or Issue Description

**What happened?**

The chat maintenance timer repeatedly scanned run lifecycle state. Empty
and settled instances still queried the database. A run-status event
alone cannot replace the scan: prompt receipts, continuation receipts,
identity changes, and restored authority can make a run eligible later.

**What did you expect?**

Committed changes wake projection. Startup reconstructs eligible work. A
completed pass stops until another relevant change arrives. Failed work
retains recovery without scanning settled history forever.

**Steps to reproduce**

Configure an automatic chat endpoint. Finish its work, or leave it
unused. Observe recurring lifecycle projection queries from the chat
maintenance callback.

Stacked on #17592. Related foundation: #15625. This PR owns lifecycle
milestones only.

## What Changed

- Preserve upstream coalesced Cloud membership writes together with
locked membership restoration and its committed chat notification.

- Signal milestone eligibility from the real Slack account-link
transaction.

- Register the lifecycle worker with the existing delivery coordinator.
Remove lifecycle projection from the periodic chat callback. Keep native
progress in a separately named lane and preserve the explicit combined
API.
- Reconstruct company/issue scopes from the existing selector. Drain
bounded batches with company fairness. Retry failures, retain writes
through drain/resume, and disarm settled work.
- Signal from supported run, presentation, interaction, receipt,
lineage, conversation, recovery, and authority writers. Preserve their
transaction ownership, including nested savepoints and uncertain
settlement. No new table is added.
- Preserve provider authorization, authored-final suppression,
responsible-user continuity, deduplication, the 24-hour selection
window, and raw-output restrictions. Keep provider interpretation in its
owner.
- Preserve PostgreSQL timestamp precision in lifecycle pagination.
Rejected submillisecond candidates must not repeat the same page and
starve later notices.
- Document producer coverage and alternate-writer dispositions in
`doc/plans/2026-10-25-chat-run-milestone-sleep-audit.md`.

## Verification

Published head: `1d056f68c5b1005933b9e12de8745bf1c4cbeeca`, targeting
master after #17592 merged at
`7d75ae0569e41786640cf09647ae8849411d2f22`. A normal merge integrates
the actual landed parent. The entire 77-path milestone patch is
binary-identical to the locally verified preparation across that
ancestry reconciliation; both unrelated master paths are preserved. The
four earlier producer/test integration conflicts retain scoped milestone
and voice notices, current onboarding completion admission, and expanded
identity query/read-scope coverage.

- **330 distinct selected cases pass on the verified unchanged patch:**
305 across 14 complete suites (all five milestone worker suites, run
identity, board claim, Cloud provisioning, auth session routes, Cloud
actor authentication, stale-lock recovery, GitHub credentials, project
Git authorization, and app admission wiring), plus 25 selected real chat
producer cases. The remaining 1,590 chat integration cases were skipped,
not passed.
- The real producer cases cover saved milestone discovery, GitHub and
Slack identity changes, account-link rollback/reconfirmation, ordinary
ingress reactivation, post-close action/delivery receipt settlement, all
ten authority-restoration paths including Cloud synchronization, and
changed native review metadata.
- Worker coverage verifies outer commit, rollback, uncertain-write
recovery, restart, bounded batching/fairness, timestamp precision,
retries, drain/resume, and settled SQL quiet. Authorization and existing
publication deduplication remain with their owning services.
- Server production typechecking, build, and module-boundary checks
pass. The tests above were executed separately. Production typechecking
excludes `src/__tests__` and does not replace those runs. Each database
owner uses its own newly created and app-migrated PostgreSQL fixture.
- [Current-parent acceptance and preserved failure
ledger](https://github.com/paperclipai/paperclip/blob/1d056f68c5b1005933b9e12de8745bf1c4cbeeca/doc/plans/2026-10-25-chat-run-milestone-sleep-audit.md#current-parent-integration-and-acceptance-october-28)
records commands, counts, producer scope, conflict dispositions, and
limits. Earlier combined-stack counts and failures keep their original
revision scope; local acceptance does not erase old CI failures.
- No new migration, queue table, dependency, workflow, or shared
scheduler contract is introduced. Parent migration 0397, bounded consent
recovery, voice cleanup/retention repairs, and runner checkpoint
restoration remain present.
- **Exact-head Greptile is 5/5 and all 55 current checks are clean.** No
Ponytail review is present, which is an explicitly authorized
nonblocker; no failing review is waived. Older reviews and parent checks
are not current passes. Actual failing Ponytail findings must be fixed;
an absent/stopped/paused turn without a verdict is an authorized
nonblocker. Active unfinished Ponytail uses its original request/start
timer, with a 25-minute monitor cutoff respecting the user's 30-minute
maximum.
- No complete local repository matrix, live provider tenant, external
alarm, physical host/database suspension, or fleet savings claim is
made. Native progress remains a separate following slice.

## Risks

- A future eligibility writer must notify the existing projection
boundary. Independent SQL writers or another active server process are
outside this process-local signal contract.
- Authority and lineage remain sensitive. The worker uses the existing
selectors and publication policy; it does not grant execution or
disclosure authority.
- Native progress and other publication maintenance still have recurring
work. This PR removes one reason, not the entire chat maintenance timer.
- Worker quiet does not prove database suspension, host sleep, or
external alarm coverage. Cloud sleep blockers remain unchanged.
- Merge eligibility requires passing current-head CI and Greptile 5/5
after this actual-master reconciliation. Subsequent stack slices retain
their own gates.

## Model Used

OpenAI Codex, GPT-6 family. The exact serving model ID and
context-window size are not exposed. Used repository inspection,
reasoning, shell execution, PostgreSQL tests, browser E2Es and GitHub
tools.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details available in this session)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run the documented focused tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-10-28 11:07:54 -05:00

216 lines
7.8 KiB
TypeScript

import { and, eq, inArray, isNull, sql } from "drizzle-orm";
import {
completionContracts,
issueThreadInteractions,
issues,
nativeRunFinalizations,
statusDecisionEffects,
statusDecisions,
workAssessments,
type Db,
} from "@paperclipai/db";
import {
persistActivity,
publishActivity,
type ActivityPublication,
} from "../activity-log.js";
import { enqueueTerminalIssueInteractionChatPublications } from "../chat-interaction-publications.js";
import { notifyChatRunMilestones } from "../chat-run-milestone-notifications.js";
import { issueThreadInteractionService } from "../issue-thread-interactions.js";
import { logger } from "../../middleware/logger.js";
const withdrawalReason = "automatic_completion_review_removed";
const automaticPrompt =
"Review the persisted native-run evidence and confirm whether this issue may be completed.";
/** Identify only proven system fallback cards; this lookup never changes state. */
export async function findAutomaticCompletionReviews(db: Db, issueId?: string) {
return db
.select({ interaction: issueThreadInteractions, decision: statusDecisions })
.from(issueThreadInteractions)
.innerJoin(
statusDecisionEffects,
and(
eq(statusDecisionEffects.companyId, issueThreadInteractions.companyId),
eq(statusDecisionEffects.issueId, issueThreadInteractions.issueId),
sql`${statusDecisionEffects.targetId} = ${issueThreadInteractions.id}::text`,
eq(statusDecisionEffects.targetType, "issue_thread_interaction"),
eq(statusDecisionEffects.effectKind, "bind_reviewer"),
),
)
.innerJoin(
statusDecisions,
and(
eq(statusDecisions.id, statusDecisionEffects.decisionId),
eq(statusDecisions.companyId, issueThreadInteractions.companyId),
eq(statusDecisions.issueId, issueThreadInteractions.issueId),
eq(statusDecisions.runId, issueThreadInteractions.sourceRunId),
),
)
.innerJoin(
workAssessments,
and(
eq(workAssessments.id, statusDecisions.assessmentId),
eq(workAssessments.companyId, statusDecisions.companyId),
eq(workAssessments.issueId, statusDecisions.issueId),
),
)
.innerJoin(
completionContracts,
and(
eq(completionContracts.id, workAssessments.contractId),
eq(completionContracts.companyId, workAssessments.companyId),
eq(completionContracts.issueId, workAssessments.issueId),
),
)
.where(
and(
eq(issueThreadInteractions.status, "pending"),
eq(issueThreadInteractions.kind, "request_confirmation"),
isNull(issueThreadInteractions.createdByAgentId),
isNull(issueThreadInteractions.createdByUserId),
eq(statusDecisions.applicationState, "applied"),
eq(statusDecisions.toStatus, "in_review"),
inArray(statusDecisions.reasonCode, [
"completion_claim_incomplete",
"completion_claim_conflict",
"external_verification_required",
]),
eq(completionContracts.risk, "low"),
eq(completionContracts.completionAuthority, "agent_claim_policy"),
sql`${workAssessments.assessmentJson}->'attentionRequests' = '[]'::jsonb`,
sql`${issueThreadInteractions.idempotencyKey} = 'native-review:' || ${statusDecisions.id}::text`,
sql`${issueThreadInteractions.payload}->'target'->>'key' = 'native_completion_review'`,
sql`${issueThreadInteractions.payload}->'target'->>'revisionId' = ${statusDecisions.id}::text`,
sql`split_part(${issueThreadInteractions.payload}->>'prompt', E'\n', 1) = ${automaticPrompt}`,
...(issueId ? [eq(issueThreadInteractions.issueId, issueId)] : []),
),
)
.limit(100)
.catch((err) => {
logger.warn(
{ err },
"Automatic completion review lookup failed; will retry",
);
return [];
});
}
/** Narrow, replay-safe retirement. Explicit requests and answered cards are immutable here. */
export async function dismissAutomaticCompletionReviews(
db: Db,
issueId?: string,
) {
const candidates = await findAutomaticCompletionReviews(db, issueId);
for (const { interaction, decision } of candidates) {
const publications: ActivityPublication[] = [];
try {
await db.transaction(async (tx) => {
await tx
.select()
.from(nativeRunFinalizations)
.where(
and(
eq(nativeRunFinalizations.runId, decision.runId),
eq(nativeRunFinalizations.companyId, decision.companyId),
),
)
.for("update");
const [issue] = await tx
.select()
.from(issues)
.where(
and(
eq(issues.id, decision.issueId),
eq(issues.companyId, decision.companyId),
),
)
.for("update");
if (!issue) return;
await notifyChatRunMilestones(tx, interaction);
const now = new Date();
const [retired] = await tx
.update(issueThreadInteractions)
.set({
status: "cancelled",
result: {
version: 1,
outcome: "withdrawn",
reason: withdrawalReason,
},
resolvedAt: now,
updatedAt: now,
})
.where(
and(
eq(issueThreadInteractions.id, interaction.id),
eq(issueThreadInteractions.companyId, issue.companyId),
eq(issueThreadInteractions.status, "pending"),
eq(issueThreadInteractions.payload, interaction.payload),
),
)
.returning();
if (!retired) return;
const projected = await issueThreadInteractionService(
tx as unknown as Db,
).getById(retired.id);
if (projected)
await enqueueTerminalIssueInteractionChatPublications(
tx as unknown as Db,
projected,
);
const { publication } = await persistActivity(tx as unknown as Db, {
companyId: issue.companyId,
actorType: "system",
actorId: "native-completion-review-cleanup",
action: "issue.interaction_cancelled",
entityType: "issue",
entityId: issue.id,
issueId: issue.id,
runId: decision.runId,
details: {
source: withdrawalReason,
interactionId: retired.id,
decisionId: decision.id,
},
});
publications.push(publication);
});
for (const publication of publications) publishActivity(publication);
} catch (err) {
logger.warn(
{ err, interactionId: interaction.id },
"Automatic completion review cleanup failed; will retry",
);
}
}
}
/** A durable trigger survives a restart between withdrawing a card and reassessment. */
export async function decisionHasRetiredAutomaticReview(
db: Db,
decision: typeof statusDecisions.$inferSelect,
) {
const effects = decision.decisionJson.effects as
Array<{ kind: string; gate?: { kind: string; id: string } }> | undefined;
const ids =
effects?.flatMap((effect) =>
effect.gate?.kind === "interaction" ? [effect.gate.id] : [],
) ?? [];
const rows = await db
.select({ id: issueThreadInteractions.id })
.from(issueThreadInteractions)
.where(
and(
eq(issueThreadInteractions.companyId, decision.companyId),
eq(issueThreadInteractions.issueId, decision.issueId),
eq(issueThreadInteractions.status, "cancelled"),
sql`${issueThreadInteractions.result}->>'reason' = ${withdrawalReason}`,
sql`(${issueThreadInteractions.payload}->'target'->>'revisionId' = ${decision.id}::text
or ${ids.length ? inArray(issueThreadInteractions.id, ids) : sql`false`})`,
),
)
.limit(1);
return rows.length > 0;
}