mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-13 15:55:46 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
86 lines
8.2 KiB
TypeScript
86 lines
8.2 KiB
TypeScript
import { expect, it, vi } from "vitest";
|
|
import { readFile, writeFile, mkdir, mkdtemp, realpath, symlink, rm } from "node:fs/promises";
|
|
import path from "node:path"; import os from "node:os"; import { createHash } from "node:crypto";
|
|
import pins from "./sdk-canary-build-pins.json" with { type: "json" };
|
|
import { assertSdkCanaryBuild, sdkCanaryOutputManifest, withSdkCanaryPreFixture, assertSdkCanaryFingerprintMatches, SDK_CANARY, type SdkCanaryBuildObservation } from "./sdk-canary-prefixture.js";
|
|
import type { MatrixExecution } from "./types.js";
|
|
const hash = (value: string | Buffer) => createHash("sha256").update(value).digest("hex");
|
|
const revision = "a".repeat(40);
|
|
const build = (): SdkCanaryBuildObservation => ({ ...pins, sourceRevision: revision, retainedManifestSha256: pins.compiledManifestSha256 });
|
|
const execution = () => ({ id: SDK_CANARY, profile: { id: "runner-opencode", provider: "opencode", adapterType: "paperclip_runner", credential: "OPENROUTER_API_KEY", generation: "native", model: "openrouter/deepseek/deepseek-v4.1-flash-1017" }, suite: { id: "chat-features" }, environment: { id: "local" }, task: { id: "plugins.use-plugin-tool", flow: "agent_chat", turnTimeoutMs: 0, expectedRunCount: 2, attemptTimeoutMs: { local: 480_000 } } }) as MatrixExecution;
|
|
type Fingerprint = Parameters<typeof assertSdkCanaryFingerprintMatches>[1];
|
|
// A synthetic value for lifecycle controls only; never computed or reported as an actual case fingerprint.
|
|
const fingerprint = () => ({ fingerprintKind: "complete-execution-and-oracle-closure", digest: "b".repeat(64), definitionDigest: "b".repeat(64), graderDigest: "b".repeat(64), sources: [{ file: "packages/plugins/sdk/dist/index.js", sha256: "c".repeat(64) }] }) as unknown as Fingerprint;
|
|
it("binds authenticated output pins to the diagnostic and500Git+lock-overlay contract", () => {
|
|
expect(pins.authenticatedMetadataSha256).toBe("56e130cadb510a7bbbfc9aea2386a655d83ad7a13e84a326e1019ad856f2068c");
|
|
expect(pins.inputFiles).toBe(501); expect(pins.gitInputFiles).toBe(500); expect(pins.compiledFiles).toBe(1611);
|
|
expect(() => assertSdkCanaryBuild(build())).not.toThrow();
|
|
});
|
|
it.each(["inputFiles", "gitInputFiles", "frozenInputManifestSha256", "copiedInputManifestSha256", "publicInputsFileSha256", "helperSha256", "lockSha256", "compilerPackageSha256", "compiledFiles", "compiledManifestSha256", "retainedManifestSha256", "sourceRevision", "certificates"] as const)("blocks mismatched %s", field => {
|
|
const wrong = build(); Object.assign(wrong, { [field]: typeof wrong[field] === "number" ? 0 : field === "certificates" ? [] : "mismatch" });
|
|
expect(() => assertSdkCanaryBuild(wrong)).toThrow();
|
|
});
|
|
it("captures and privately retains the non-null complete fingerprint before allowing fixtures once", async () => {
|
|
const order: string[] = [], selected = execution(), fp = fingerprint();
|
|
const run = () => withSdkCanaryPreFixture({ execution: selected, sourceRevision: revision,
|
|
capture: async () => { order.push("capture-after-existing-startup-build-retention"); return { build: build(), fingerprint: fp }; },
|
|
retain: async () => { order.push("private-proof"); }, fixtures: async () => { order.push("fixtures-and-possible-hello"); return 7; } });
|
|
expect(await run()).toBe(7); expect(order).toEqual(["capture-after-existing-startup-build-retention", "private-proof", "fixtures-and-possible-hello"]);
|
|
expect(() => assertSdkCanaryFingerprintMatches(selected, structuredClone(fp))).not.toThrow();
|
|
await expect(run()).rejects.toThrow(); expect(order).toHaveLength(3);
|
|
expect(() => assertSdkCanaryFingerprintMatches(selected, { ...fp, digest: "d".repeat(64) } as never)).toThrow();
|
|
});
|
|
it.each(["startup-build-or-retention", "missing-output", "missing-fingerprint", "deferred-fingerprint", "private-retention", "wrong-source"])("never admits fixtures when %s fails", async reason => {
|
|
const fixtures = vi.fn(), fp = fingerprint();
|
|
await expect(withSdkCanaryPreFixture({ execution: execution(), sourceRevision: revision,
|
|
capture: async () => {
|
|
if (["startup-build-or-retention", "missing-output"].includes(reason)) throw new Error("Synthetic startup prerequisite failed");
|
|
return { build: { ...build(), ...(reason === "wrong-source" ? { sourceRevision: "e".repeat(40) } : {}) },
|
|
fingerprint: reason === "missing-fingerprint" ? null as never : reason === "deferred-fingerprint" ? { ...fp, digest: null } as never : fp };
|
|
}, retain: async () => { if (reason === "private-retention") throw new Error("Synthetic private custody failure"); }, fixtures })).rejects.toThrow();
|
|
expect(fixtures).not.toHaveBeenCalled();
|
|
});
|
|
it("rejects a later fingerprint without pre-fixture custody and leaves nonselected cases unchanged", async () => {
|
|
expect(() => assertSdkCanaryFingerprintMatches(execution(), fingerprint())).toThrow();
|
|
const other = { ...execution(), id: "chat-features.runner-opencode.local.plugins.install-plugin" }, capture = vi.fn(), retain = vi.fn(), fixtures = vi.fn(async () => 3);
|
|
expect(await withSdkCanaryPreFixture({ execution: other, sourceRevision: null, capture, retain, fixtures })).toBe(3);
|
|
expect(capture).not.toHaveBeenCalled(); expect(retain).not.toHaveBeenCalled(); expect(fixtures).toHaveBeenCalledOnce();
|
|
});
|
|
it("reads owned synthetic compiled manifests, detects missing output and rejects symlinks without a compiler", async () => {
|
|
const root = await realpath(await mkdtemp(path.join(os.tmpdir(), "sdk-canary-synthetic-")));
|
|
try {
|
|
const rows = [];
|
|
for (const target of pins.certificates) {
|
|
await mkdir(path.join(root, target.target), { recursive: true });
|
|
for (const [file, text] of [["index.js", "export const syntheticUnit=true;\n"], [".paperclip-build-complete", JSON.stringify({ sources: "a".repeat(64), outputs: "b".repeat(64) })+'\n']]) {
|
|
await writeFile(path.join(root, target.target, file!), text!);
|
|
rows.push({ file: `${target.target}/${file}`, size: Buffer.byteLength(text!), sha256: hash(text!) });
|
|
}
|
|
}
|
|
rows.sort((a, b) => a.file.localeCompare(b.file));
|
|
expect(await sdkCanaryOutputManifest(root)).toEqual(rows);
|
|
const synthetic = { ...build(), compiledFiles: rows.length, compiledManifestSha256: hash(JSON.stringify(rows)), retainedManifestSha256: hash(JSON.stringify(rows)) };
|
|
expect(() => assertSdkCanaryBuild(synthetic, { ...pins, compiledFiles: rows.length, compiledManifestSha256: synthetic.compiledManifestSha256 })).not.toThrow();
|
|
expect(() => assertSdkCanaryBuild(synthetic)).toThrow(); // Live immutable1611-file expectations never accept toy outputs.
|
|
await writeFile(path.join(root, pins.certificates[0]!.target, "index.js"), "synthetic mutation");
|
|
expect(hash(JSON.stringify(await sdkCanaryOutputManifest(root)))).not.toBe(synthetic.compiledManifestSha256);
|
|
await rm(path.join(root, pins.certificates[0]!.target), { recursive: true }); await expect(sdkCanaryOutputManifest(root)).rejects.toThrow();
|
|
await symlink(path.join(root, pins.certificates[1]!.target), path.join(root, pins.certificates[0]!.target)); await expect(sdkCanaryOutputManifest(root)).rejects.toThrow();
|
|
} finally { await rm(root, { recursive: true, force: true }); }
|
|
});
|
|
|
|
it.each(["model", "credential", "generation", "suite", "environment", "flow", "turn-clock", "count", "overall-clock"])("rejects changed selected %s before capture or fixtures", async field => {
|
|
const selected = execution(), capture = vi.fn(), fixtures = vi.fn();
|
|
if (field === "model") selected.profile.model = "foreign/model";
|
|
if (field === "credential") selected.profile.credential = "OPENAI_API_KEY";
|
|
if (field === "generation") selected.profile.generation = "legacy";
|
|
if (field === "suite") selected.suite.id = "another-suite";
|
|
if (field === "environment") selected.environment.id = "daytona";
|
|
if (field === "flow") selected.task.flow = "first_task";
|
|
if (field === "turn-clock") selected.task.turnTimeoutMs = 120000;
|
|
if (field === "count") selected.task.expectedRunCount = 3;
|
|
if (field === "overall-clock") selected.task.attemptTimeoutMs = { ...selected.task.attemptTimeoutMs, local: 960000 };
|
|
await expect(withSdkCanaryPreFixture({ execution: selected, sourceRevision: revision, capture, retain: vi.fn(), fixtures })).rejects.toThrow();
|
|
expect(capture).not.toHaveBeenCalled(); expect(fixtures).not.toHaveBeenCalled();
|
|
});
|