mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-13 07:12:00 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
29 lines
3.7 KiB
TypeScript
29 lines
3.7 KiB
TypeScript
/** Explicit offline canary only; normal runner testMatch excludes this file. */
|
|
import { test, expect } from "@playwright/test";
|
|
import { createServer } from "node:http";
|
|
import { readFile } from "node:fs/promises";
|
|
import { finishPrivateWebhook } from "./chat-catalog-domains/integrator-webhook-private.js";
|
|
const routineId = "11111111-1111-4111-8111-111111111111", triggerId = "22222222-2222-4222-8222-222222222222", invocationId = "33333333-3333-4333-8333-333333333333", issueId = "44444444-4444-4444-8444-444444444444";
|
|
test("isolated webhook child keeps synthetic cookie and one-time key out of actual Test reporters", async () => {
|
|
const input = JSON.parse(await readFile(process.env.PAPERCLIP_OFFLINE_API_CANARY_INPUT!, "utf8")) as { cookie: string; credential: string };
|
|
let invoked = false, finished = false;
|
|
const server = createServer(async (req, res) => {
|
|
const url = new URL(req.url!, "http://127.0.0.1");
|
|
const json = (status: number, value: unknown) => { res.writeHead(status, { "content-type": "application/json" }); res.end(JSON.stringify(value)); };
|
|
if (url.pathname === `/api/routine-triggers/${triggerId}/rotate-secret`) { json(200, { secretMaterial: { webhookSecret: input.credential, webhookUrl: `http://${req.headers.host}/api/routine-triggers/public/synthetic/fire` } }); return; }
|
|
if (url.pathname === `/api/routine-triggers/${triggerId}` && req.method === "PATCH") { finished = true; json(200, {}); return; }
|
|
if (url.pathname === `/api/routines/${routineId}/runs`) { json(200, invoked ? [{ id: invocationId }] : []); return; }
|
|
if (url.pathname === "/api/routine-triggers/public/synthetic/fire") { if (req.headers.authorization !== `Bearer ${input.credential}`) { json(401, {}); return; } if (!finished) { json(202, { status: "test_received" }); return; } invoked = true; json(202, { id: invocationId, linkedIssueId: issueId }); return; }
|
|
res.writeHead(200, { "content-type": "text/html" }); res.end(`<button id="generate">Generate new key</button><code hidden></code><button id="check">Check connection</button><button id="finish" hidden>Finish without checking</button><script>document.querySelector('#generate').onclick=async()=>{const r=await fetch('/api/routine-triggers/${triggerId}/rotate-secret',{method:'POST'});const b=await r.json();const c=document.querySelector('code');c.textContent=b.secretMaterial.webhookSecret;c.hidden=false};document.querySelector('#check').onclick=()=>document.querySelector('#finish').hidden=false;document.querySelector('#finish').onclick=()=>fetch('/api/routine-triggers/${triggerId}',{method:'PATCH'});</script>`);
|
|
});
|
|
await new Promise<void>(resolve => server.listen(0, "127.0.0.1", resolve));
|
|
try {
|
|
const address = server.address(); if (!address || typeof address === "string") throw new Error("Synthetic loopback address missing");
|
|
let registered = false;
|
|
const receipt = await finishPrivateWebhook({ baseURL: `http://127.0.0.1:${address.port}`, route: `/ACN/routines/${routineId}`, routineId, triggerId, setupPending: true, signingMode: "bearer", nonce: "synthetic-only", cookies: [{ name: "session", value: input.cookie, domain: "127.0.0.1", path: "/", httpOnly: true, secure: false, sameSite: "Lax", expires: -1 }] }, value => { registered = value === input.credential; });
|
|
expect(registered && receipt.invalidStatus === 401 && receipt.validStatus === 202 && !receipt.invalidCreatedInvocation && receipt.processIsolation && !receipt.testRunnerAttached).toBe(true);
|
|
// Deliberate ordinary Test failure exercises stdout/JUnit/blob/HTML sinks.
|
|
throw new Error("Controlled offline webhook privacy failure; no private values in diagnosis");
|
|
} finally { await new Promise<void>((resolve, reject) => server.close(error => error ? reject(error) : resolve())); }
|
|
});
|