mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-13 15:55:46 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
80 lines
8.8 KiB
TypeScript
80 lines
8.8 KiB
TypeScript
import { validateChatCatalogGrade, type ChatCatalogCase, type ChatCatalogContext, type ChatCompanionResult, type ChatCompanionSurface } from "./chat-catalog-contract.js";
|
|
import { pollUntil } from "./api.js";
|
|
export const companionScenarioId = "assistant-connections.use-scoped-client";
|
|
export function validCompanionDeclaration(value: Pick<ChatCatalogCase, "scenarioId" | "companionSurface" | "expectedRunCount" | "minimumRunCount" | "expectedHumanMessageCount" | "setupHumanMessageCount" | "requiredCredentials" | "queryBindings" | "queryAttachments" | "queryOutcome"> & { journeyKind?: string }): boolean {
|
|
const s = value.companionSurface;
|
|
return value.scenarioId === companionScenarioId && value.journeyKind === "scoped-external-assistant" && !!s
|
|
&& Object.keys(s).sort().join(",") === "kind,maximumModelTurns,maximumOutputTokens,maximumToolCalls,model"
|
|
&& s.kind === "scoped-external-assistant" && /^[a-zA-Z0-9][a-zA-Z0-9._:/-]{0,119}$/.test(s.model)
|
|
&& s.maximumModelTurns === 6 && s.maximumToolCalls === 4 && s.maximumOutputTokens === 2048
|
|
&& value.expectedRunCount === 0 && (value.minimumRunCount ?? 0) === 0 && value.expectedHumanMessageCount === 0 && (value.setupHumanMessageCount ?? 0) === 0
|
|
&& value.requiredCredentials?.includes("OPENAI_API_KEY") === true && !value.queryBindings?.length && !value.queryAttachments?.length && !value.queryOutcome;
|
|
}
|
|
export function companionReceiptChecks(surface: ChatCompanionSurface, query: string, result: ChatCompanionResult, elapsedMs: number, maximumElapsedMs: number) {
|
|
const messages = Array.isArray(result?.messages) ? result.messages : []; const users = messages.filter(message => message.role === "user");
|
|
return [
|
|
{ id: "companion-exact-canonical-query", passed: result?.query === query && users.length === 1 && users[0]?.content === query, detail: "The actual external-model transcript contains the original catalog request as its sole human input, without an Agent Chat substitution." },
|
|
{ id: "companion-declared-model-and-usage", passed: result?.model === surface.model && Number.isSafeInteger(result?.usage?.inputTokens) && result.usage.inputTokens > 0 && Number.isSafeInteger(result?.usage?.outputTokens) && result.usage.outputTokens > 0 && result.usage.outputTokens <= surface.maximumOutputTokens
|
|
&& Array.isArray(result?.providerResponseIds) && result.providerResponseIds.length > 0 && result.providerResponseIds.every(id => typeof id === "string" && !!id && id.length <= 240), detail: "The actual selected model supplies response identities and observed bounded input/output accounting; unknown usage cannot qualify." },
|
|
{ id: "companion-bounded-actual-transcript", passed: messages.length > 0 && messages.every(message => ["system", "user", "assistant", "tool"].includes(message.role) && typeof message.content === "string")
|
|
&& messages.filter(message => message.role === "assistant").length > 0 && messages.filter(message => message.role === "assistant").length <= surface.maximumModelTurns
|
|
&& Array.isArray(result?.toolCalls) && result.toolCalls.length > 0 && result.toolCalls.length <= surface.maximumToolCalls
|
|
&& result.toolCalls.every(call => typeof call.name === "string" && !!call.name && "arguments" in call && "result" in call)
|
|
&& typeof result?.reply === "string" && !!result.reply.trim() && messages.filter(message => message.role === "assistant").at(-1)?.content === result.reply
|
|
&& Array.isArray(result?.links) && result.links.every(link => typeof link === "string") && elapsedMs <= maximumElapsedMs,
|
|
detail: "Actual model turns, scoped tool exchanges, final reply and elapsed time satisfy the predeclared finite companion bounds." },
|
|
];
|
|
}
|
|
/** Sole additional catalog surface, invoked before any Agent Chat send. The
|
|
* domain owns real model/MCP transport and independent saved-product oracles. */
|
|
export async function runScopedCompanionSurface(context: ChatCatalogContext, implementation: ChatCatalogCase, definition: unknown) {
|
|
if (!validCompanionDeclaration(implementation) || !implementation.runCompanionSurface || implementation.act) throw new Error("Invalid finite scoped external-assistant surface");
|
|
const { input, scenario } = context; const attemptStarted = Date.now(); let state: Record<string, unknown> | undefined; let failed = false;
|
|
async function sourceBoundary() {
|
|
await context.refreshIssue(); const source = context.issue();
|
|
const comments = source ? await input.api.get<Array<{ id: string }>>(`/api/issues/${source.id}/comments?order=asc`) : [];
|
|
return { sourceId: source?.id ?? null, commentIds: comments.map(row => row.id), runIds: (await context.allRuns()).map(row => row.id) };
|
|
}
|
|
try {
|
|
await input.evidence("chat-catalog-definition.json", { scenarioId: scenario.id, ...(definition as object), journeyKind: "scoped-external-assistant" });
|
|
state = await implementation.setup(context);
|
|
if (implementation.verifySetup) {
|
|
const prepared = validateChatCatalogGrade(await implementation.verifySetup(context, state)); await input.evidence("chat-catalog-prepared-state.json", prepared);
|
|
if (!prepared.passed) throw new Error("Scoped external-assistant prerequisite failed before model dispatch");
|
|
}
|
|
const before = await sourceBoundary();
|
|
if (before.runIds.length || before.commentIds.length) throw new Error("Scoped external-assistant setup admitted unrelated native/chat work");
|
|
await input.evidence("chat-catalog-setup.json", { scenario, state, expectedRunCount: 0, expectedHumanMessageCount: 0, companionSurface: implementation.companionSurface });
|
|
await input.evidence("chat-catalog-query.json", { query: scenario.query, journeyKind: "scoped-external-assistant", persistedInAgentChat: false });
|
|
const started = Date.now(); const remaining = implementation.attemptTimeoutMs - (started - attemptStarted) - 30_000;
|
|
if (remaining <= 0) throw new Error("Scoped companion setup exhausted its declared attempt deadline");
|
|
const signal = AbortSignal.timeout(Math.min(implementation.turnTimeoutMs, remaining));
|
|
let onAbort: (() => void) | undefined;
|
|
const interrupted = new Promise<never>((_resolve, reject) => { onAbort = () => reject(new Error("Scoped companion exceeded its actual model deadline")); signal.addEventListener("abort", onAbort, { once: true }); });
|
|
let result: ChatCompanionResult;
|
|
try { result = await Promise.race([implementation.runCompanionSurface(context, state, { query: scenario.query, signal }), interrupted]); }
|
|
finally { if (onAbort) signal.removeEventListener("abort", onAbort); }
|
|
const receiptChecks = companionReceiptChecks(implementation.companionSurface!, scenario.query, result, Date.now() - started, implementation.turnTimeoutMs);
|
|
state.companionSurfaceResult = result;
|
|
await input.evidence("chat-companion-transcript.json", result);
|
|
if (signal.aborted || receiptChecks.some(check => !check.passed)) throw new Error("Actual companion transcript or model/usage bounds failed");
|
|
let observation: unknown;
|
|
const observe = async () => {
|
|
observation = await implementation.observe(context, state!); const own = validateChatCatalogGrade(implementation.grade(observation)); const after = await sourceBoundary();
|
|
const checks = [...own.checks, ...receiptChecks,
|
|
{ id: "companion-no-agent-chat-or-native-substitution", passed: !after.runIds.length && !after.commentIds.length && after.sourceId === before.sourceId, detail: "No standing Agent Chat message or native provider admission substitutes for this actual external-assistant measurement." },
|
|
{ id: "catalog-complete-conditions", passed: !implementation.coverageGaps?.length, detail: implementation.coverageGaps?.length ? `Missing conditions: ${implementation.coverageGaps.join(", ")}` : "No known catalog condition is omitted." }];
|
|
const grade = { passed: checks.every(check => check.passed), checks };
|
|
await input.evidence("chat-catalog-observation.json", { scenarioId: scenario.id, observation, grade }); return grade;
|
|
};
|
|
const grade = await pollUntil({ label: scenario.id, deadlineAt: attemptStarted + implementation.attemptTimeoutMs - 30_000, intervalMs: 1000, load: observe, accept: value => value.passed });
|
|
await implementation.verifyResult(context, state, observation);
|
|
const persisted = await observe(); if (!persisted.passed) throw new Error("Scoped external-assistant oracle failed after product inspection");
|
|
for (const check of grade.checks) input.check?.(check.id, check.passed, check.detail);
|
|
} catch (error) { failed = true; throw error; }
|
|
finally {
|
|
try { if (state) await implementation.cleanup?.(context, state); await input.evidence("chat-catalog-cleanup.json", { scenarioId: scenario.id, caseCleanup: "complete", instanceCleanup: "owned by existing launcher" }); }
|
|
catch (error) { await input.evidence("chat-catalog-cleanup.json", { scenarioId: scenario.id, caseCleanup: "failed" }); if (!failed) throw error; }
|
|
}
|
|
}
|