mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-13 15:55:46 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
95 lines
9.5 KiB
TypeScript
95 lines
9.5 KiB
TypeScript
import { chatCatalogNativePhaseDeadline, chatCatalogNativePhaseIsTimely, chatCatalogNativePhaseRemainingBudget } from "../chat-catalog-contract.js";
|
|
import { expect } from "@playwright/test";
|
|
import { pollUntil } from "../api.js";
|
|
import { submitTaskReply } from "../user-actions.js";
|
|
import { readRegisteredArtifacts } from "../registered-artifact.js";
|
|
import { checks, type Entity } from "./internal-support.js";
|
|
import { probeAgentPermission } from "./identity-support.js";
|
|
import { runtimeDefinition, runtimeObservation, observeRuntime, openRuntimeAgentProfile, unchangedAgent, type RuntimeAgent } from "./runtime-support.js";
|
|
import { savedTaskWorkspace } from "./runtime-workspaces.js";
|
|
|
|
export function gradeSessionReset(value: unknown) {
|
|
const c = checks(); const o = runtimeObservation(value);
|
|
c.add("independent-session-reset-evidence", !!o, "Real prior native work, human reset and future execution must be independently observed."); if (!o) return c.result();
|
|
const worker = o.state.worker as RuntimeAgent; const current = o.agents.find(row => row.id === worker.id);
|
|
c.add("human-only-reset", o.state.agentResetStatus === 403 && o.state.sessionPresentBeforeHuman === true
|
|
&& o.state.humanReset === true && o.state.sessionsEmptyAfterHuman === true
|
|
&& o.activity.some(row => row.action === "agent.runtime_session_reset" && row.entityId === worker.id && row.actorType === "user" && !row.agentId),
|
|
"Only the supported human control clears Morgan's actual stored runtime session.");
|
|
c.add("future-execution-fresh", o.state.futureRunFresh === true && o.state.explicitContinuationSaved === true
|
|
&& o.runs.length === 3 && o.runs.filter(run => run.agentId === worker.id && run.status === "succeeded").length === 2,
|
|
"One explicit task continuation starts without the prior session and succeeds with a distinct new session.");
|
|
c.add("durable-history-and-artifact-preserved", o.state.historyRetained === true && o.state.documentsRetained === true
|
|
&& o.state.artifactRetained === true && o.state.fileRetained === true && !!current && unchangedAgent(worker, current)
|
|
&& o.tasks.length === 1 && o.tasks[0]?.id === (o.state.task as Entity).id,
|
|
"Comments, document revisions, downloaded artifact bytes and the original saved file remain readable on the same task and agent.");
|
|
const reply = String(o.state.queryReply ?? "");
|
|
c.add("honest-runtime-versus-history-guidance", /session|runtime context/i.test(reply) && /history|comments|artifacts|files/i.test(reply)
|
|
&& /reset|profile|control/i.test(reply) && !/I(?:'ve| have)? (?:already )?(?:reset|cleared|deleted)/i.test(reply),
|
|
"The canonical query's own attributed answer explains the human control and durable history without claiming a reset by the agent.");
|
|
return c.result();
|
|
}
|
|
|
|
export const runtimeSessionCases = [runtimeDefinition("runs-adapters.reset-session", async ctx => {
|
|
const state = await savedTaskWorkspace(ctx, { artifact: true });
|
|
const sessions = await ctx.input.api.get<unknown[]>(`/api/agents/${state.worker.id}/task-sessions`);
|
|
const initial = (await ctx.allRuns()).find(run => run.id === state.fixtureRunId);
|
|
if (!sessions.length || !initial?.sessionIdAfter) throw new Error("Session reset prerequisite requires a real retained provider session");
|
|
const comments = await ctx.input.api.get<Entity[]>(`/api/issues/${state.task.id}/comments?order=asc`);
|
|
const documents = await ctx.input.api.get<Entity[]>(`/api/issues/${state.task.id}/documents`);
|
|
if (!comments.some(row => row.createdByRunId === initial.id) || !documents.length) throw new Error("Prior native task history is missing");
|
|
const revisions: Entity[] = [];
|
|
for (const doc of documents) revisions.push(...await ctx.input.api.get<Entity[]>(`/api/issues/${state.task.id}/documents/${encodeURIComponent(doc.key!)}/revisions`));
|
|
return { ...state, priorComments: comments, priorDocuments: documents, priorRevisions: revisions };
|
|
}, gradeSessionReset, {
|
|
sourceFiles: ["chat-catalog-domains/runtime-session.ts", "chat-catalog-domains/runtime-workspaces.ts", "chat-catalog-domains/runtime-support.ts", "chat-scenarios/runs-adapters.yaml", "../../ui/src/components/AgentActionButtons.tsx", "../../ui/src/pages/AgentDetail.tsx"],
|
|
expectedRunCount: 3, attemptTimeoutMs: 720_000,
|
|
async act(ctx, state) {
|
|
await pollUntil({ label: "Canonical session guidance settled", deadlineAt: chatCatalogNativePhaseDeadline(ctx, Date.now() + 150_000),
|
|
load: async () => { await ctx.refreshIssue(); return { source: ctx.issue(), runs: await ctx.allRuns() }; },
|
|
accept: value => chatCatalogNativePhaseIsTimely(ctx) && value.source?.conversationState === "waiting" && value.runs.length === 2 && value.runs.every(run => run.status === "succeeded") });
|
|
const worker = state.worker as RuntimeAgent; const task = state.task as Entity;
|
|
const query = await observeRuntime(ctx, state); state.queryReply = query.reply;
|
|
state.agentResetStatus = await probeAgentPermission(ctx, `/api/agents/${worker.id}/runtime-state/reset-session`, "POST", {});
|
|
state.sessionPresentBeforeHuman = (await ctx.input.api.get<unknown[]>(`/api/agents/${worker.id}/task-sessions`)).length > 0;
|
|
const source = ctx.input.page.url(); await openRuntimeAgentProfile(ctx, worker, query);
|
|
// The profile header's h1 is Morgan's title; openRuntimeAgentProfile already confirmed whose
|
|
// profile this is by its named avatar. The reset control lives in the header's actions menu.
|
|
const profile = ctx.input.page.getByRole("main");
|
|
await profile.getByRole("button", { name: `Open actions for ${worker.name}`, exact: true }).click();
|
|
chatCatalogNativePhaseRemainingBudget(ctx)?.();
|
|
await ctx.input.page.getByRole("button", { name: /^Reset sessions$/i }).click();
|
|
await pollUntil({ label: "Human reset clears the real task session", deadlineAt: Date.now() + 30_000,
|
|
load: () => ctx.input.api.get<unknown[]>(`/api/agents/${worker.id}/task-sessions`), accept: rows => rows.length === 0 });
|
|
state.humanReset = true; state.sessionsEmptyAfterHuman = true;
|
|
const beforeRuns = await ctx.allRuns();
|
|
await ctx.input.page.goto(`/${ctx.input.fixtures.company.issuePrefix}/issues/${task.identifier ?? task.id}`, { waitUntil: "domcontentloaded" });
|
|
const followup = "Please continue this same task using your fresh runtime session. Read the existing website-fixture.txt without changing its bytes, inspect our saved task history, and add a brief task comment confirming it is still readable. Keep existing documents and attachments unchanged, then finish this task. Do not create another task.";
|
|
await submitTaskReply(ctx.input.page, followup, chatCatalogNativePhaseRemainingBudget(ctx));
|
|
const future = await pollUntil({ label: "Actual fresh-session continuation", deadlineAt: chatCatalogNativePhaseDeadline(ctx, Date.now() + 180_000),
|
|
load: async () => ({ runs: await ctx.allRuns(), task: await ctx.input.api.get<Entity>(`/api/issues/${task.id}`) }),
|
|
accept: value => chatCatalogNativePhaseIsTimely(ctx) && value.task.status === "done" && value.runs.length === beforeRuns.length + 1
|
|
&& value.runs.filter(run => !beforeRuns.some(prior => prior.id === run.id)).every(run => run.status === "succeeded"),
|
|
reject: value => value.runs.some(run => !beforeRuns.some(prior => prior.id === run.id) && ["failed", "cancelled", "timed_out"].includes(run.status)) ? "Fresh-session continuation failed" : undefined });
|
|
const next = future.runs.find(run => !beforeRuns.some(prior => prior.id === run.id))!;
|
|
const initial = beforeRuns.find(run => run.id === state.fixtureRunId)!;
|
|
state.futureRunFresh = next.agentId === worker.id && !next.sessionIdBefore && !!next.sessionIdAfter && next.sessionIdAfter !== initial.sessionIdAfter;
|
|
const comments = await ctx.input.api.get<Entity[]>(`/api/issues/${task.id}/comments?order=asc`);
|
|
state.explicitContinuationSaved = comments.filter(row => row.body === followup && !row.authorAgentId).length === 1
|
|
&& comments.some(row => row.createdByRunId === next.id && row.authorAgentId === worker.id);
|
|
state.historyRetained = (state.priorComments as Entity[]).every(prior => comments.some(row => row.id === prior.id && row.body === prior.body && row.createdByRunId === prior.createdByRunId));
|
|
const documents = await ctx.input.api.get<Entity[]>(`/api/issues/${task.id}/documents`); const revisions: Entity[] = [];
|
|
for (const doc of documents) revisions.push(...await ctx.input.api.get<Entity[]>(`/api/issues/${task.id}/documents/${encodeURIComponent(doc.key!)}/revisions`));
|
|
state.documentsRetained = (state.priorDocuments as Entity[]).every(prior => documents.some(row => row.id === prior.id && row.latestRevisionId === prior.latestRevisionId))
|
|
&& (state.priorRevisions as Entity[]).every(prior => revisions.some(row => row.id === prior.id && row.body === prior.body));
|
|
const [artifact] = await readRegisteredArtifacts(ctx.input.api, task.id, String(state.fixtureRunId), ["website-fixture.txt"]);
|
|
state.artifactRetained = artifact?.sha256 === (state.artifact as { sha256: string }).sha256;
|
|
const file = await ctx.input.api.get<{ content: { data: string } }>(`/api/issues/${task.id}/file-resources/content?workspace=execution&path=website-fixture.txt`);
|
|
state.fileRetained = file.content.data === state.fileBefore;
|
|
await ctx.input.page.reload({ waitUntil: "domcontentloaded" });
|
|
await expect(ctx.input.page.getByRole("heading", { name: task.title!, exact: true }).first()).toBeVisible();
|
|
await ctx.input.evidence("runtime-fresh-session-task-ui.json", { taskId: task.id, workerId: worker.id, futureRunId: next.id, url: ctx.input.page.url() });
|
|
await ctx.input.page.goto(source, { waitUntil: "domcontentloaded" });
|
|
},
|
|
})];
|