mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-15 18:56:05 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
93 lines
8.2 KiB
TypeScript
93 lines
8.2 KiB
TypeScript
import { expect } from "@playwright/test";
|
|
import { collectRunEvents } from "../run-observations.js";
|
|
import { checks } from "./internal-support.js";
|
|
import { readAgentResource } from "./identity-support.js";
|
|
import { runtimeDefinition, runtimeWorker, runtimeObservation, unchangedAgent, type RuntimeAgent } from "./runtime-support.js";
|
|
import { openRouterCatalogScope, publicOpenRouterCatalogEndpoint, observedModelChoices, modelChoiceMatches, type DiscoveredModel as Model, type OpenRouterCatalogScope } from "./model-option-catalog.js";
|
|
export function gradeModelOptions(value: unknown) {
|
|
const c = checks(); const o = runtimeObservation(value);
|
|
c.add("authorized-model-discovery-evidence", !!o, "Actual agent-authorized discovery and saved account/runtime scope are independently read."); if (!o) return c.result();
|
|
const models = o.state.admittedModels as Model[] | undefined; const worker = o.state.worker as RuntimeAgent | undefined;
|
|
const current = o.agents.find(row => row.id === worker?.id);
|
|
// The agent's own run must read the authorized model discovery route. Which
|
|
// options the reply names, and in what words, is read by a person; only
|
|
// model IDs it does name are graded below.
|
|
c.add("at-least-one-current-discovered-option", Array.isArray(models) && models.length > 0 && o.state.discoveryStatus === 200
|
|
&& Number(o.state.agentDiscoveryReads) > 0 && o.reply.trim().length > 0, "The answering run read the current authorized model discovery route.");
|
|
const publicCatalog = o.state.publicOpenRouterCatalog as Model[] | undefined, savedScope = o.state.publicCatalogScope as OpenRouterCatalogScope | undefined;
|
|
const lead = o.agents.find(row => row.id === o.leadId), currentScope = current && lead ? openRouterCatalogScope(o.companyId, o.leadId, current, lead) : undefined;
|
|
const catalogBound = Array.isArray(publicCatalog) && publicCatalog.length > 0 && publicCatalog.every(model => typeof model.id === "string" && model.id.startsWith("openrouter/"))
|
|
&& o.state.publicCatalogStatus === 200 && !!savedScope && !!currentScope && JSON.stringify(savedScope) === JSON.stringify(currentScope);
|
|
c.add("same-binding-public-catalog-provenance", publicCatalog === undefined || catalogBound,
|
|
"Public catalog choices require the actual unchanged company/CEO/Morgan/environment/OpenCode/OpenRouter key-reference binding; metadata never proves entitlement.");
|
|
const known = [...(models ?? []), ...(catalogBound ? publicCatalog! : [])], mentionedIds = observedModelChoices(o.reply);
|
|
// Model IDs are product output copied into the reply, so they are graded
|
|
// exactly. Whether the reply separates a listed model from a working account
|
|
// binding is prose; a person reads it, and it is not graded by keywords.
|
|
c.add("no-unqualified-model-inventory", !!models && mentionedIds.every(id => modelChoiceMatches(id, known)),
|
|
"The answer does not add model IDs outside the current admitted list or the same-binding public catalog.");
|
|
c.add("restricted-runtime-read-denied", o.state.agentRuntimeInventoryStatus === 403,
|
|
"The actual agent bearer cannot inspect board-only runtime inventory.");
|
|
c.add("configuration-and-permissions-preserved", !!worker && !!current && unchangedAgent(worker, current) && o.tasks.length === 0,
|
|
"Discovery does not mutate Morgan's model, account, authority or task assignment.");
|
|
c.add("private-credential-scan-complete", o.state.secretScanComplete === true && o.state.secretLeaked === false,
|
|
"The private redaction sink is scanned without recording its values.");
|
|
return c.result();
|
|
}
|
|
export const runtimeRunsAdaptersCases = [runtimeDefinition("runs-adapters.list-model-options", async ctx => {
|
|
const worker = await runtimeWorker(ctx);
|
|
const endpoint = modelDiscoveryEndpoint(ctx.input.fixtures.company.id, worker);
|
|
const discovered = await readAgentResource(ctx, endpoint);
|
|
const restricted = await readAgentResource(ctx, `/api/agents/${worker.id}/runtime-state`);
|
|
if (discovered.status !== 200 || !Array.isArray(discovered.data)) throw new Error("Scenario requires admitted real coding model discovery");
|
|
let publicOpenRouterCatalog: Model[] | undefined, publicCatalogScope: OpenRouterCatalogScope | undefined, publicCatalogStatus: number | undefined;
|
|
if (worker.adapterType === "paperclip_runner" && worker.adapterConfig?.provider === "opencode" && String(worker.adapterConfig.model).startsWith("openrouter/")) {
|
|
const lead = await ctx.input.api.get<RuntimeAgent>(`/api/agents/${ctx.input.fixtures.agent.id}`);
|
|
publicCatalogScope = openRouterCatalogScope(ctx.input.fixtures.company.id, ctx.input.fixtures.agent.id, worker, lead);
|
|
if (!publicCatalogScope) throw new Error("Model catalog setup requires the actual same-company OpenRouter account reference and native environment binding");
|
|
const catalog = await readAgentResource(ctx, publicOpenRouterCatalogEndpoint(ctx.input.fixtures.company.id));
|
|
publicCatalogStatus = catalog.status;
|
|
if (catalog.status !== 200 || !Array.isArray(catalog.data) || !catalog.data.length || !catalog.data.every((row: Model) => typeof row.id === "string" && row.id.startsWith("openrouter/") && typeof row.label === "string")) throw new Error("Official public OpenRouter model metadata unavailable; no model options were invented");
|
|
publicOpenRouterCatalog = catalog.data;
|
|
}
|
|
return { worker, admittedModels: discovered.data, discoveryStatus: discovered.status, agentRuntimeInventoryStatus: restricted.status,
|
|
...(publicOpenRouterCatalog ? { publicOpenRouterCatalog, publicCatalogScope, publicCatalogStatus } : {}) };
|
|
}, gradeModelOptions, {
|
|
oracleVersion: "paperclip.chat-catalog.model-options.scoped-catalog.v5",
|
|
sourceFiles: ["chat-catalog-domains/runtime-support.ts", "chat-catalog-domains/runtime-runs-adapters.ts", "chat-scenarios/runs-adapters.yaml", "chat-catalog-domains/model-option-catalog.ts", "run-observations.ts"],
|
|
async observe(ctx, state) {
|
|
const { observeRuntime } = await import("./runtime-support.js");
|
|
const o = await observeRuntime(ctx, state);
|
|
const events: Record<string, unknown>[] = [];
|
|
for (const run of o.runs) events.push(...await collectRunEvents<Record<string, unknown>>(afterSeq =>
|
|
ctx.input.api.get(`/api/heartbeat-runs/${run.id}/events?afterSeq=${afterSeq}&limit=1000`)));
|
|
state.agentDiscoveryReads = countModelDiscoveryReads(events, o.runs.map(run => run.id));
|
|
// Credentials remain only in the private attempt closure. Never put them in
|
|
// state, messages, diagnostic artifacts or calibration fixtures.
|
|
state.secretScanComplete = Array.isArray(ctx.input.privateSecrets);
|
|
state.secretLeaked = ctx.input.privateSecrets?.some(secret => secret.length > 8 && o.reply.includes(secret)) ?? true;
|
|
return o;
|
|
},
|
|
async verifyResult(ctx, state, value) {
|
|
const o = runtimeObservation(value); if (!o) throw new Error("Model options response is missing");
|
|
await expect(ctx.input.page.getByTestId("task-chat-agent-bubble").last()).toBeVisible();
|
|
},
|
|
})];
|
|
|
|
const MODEL_DISCOVERY_OPERATION = "GET /api/companies/{companyId}/adapters/{type}/models";
|
|
/** Successful model discovery results recorded in the answering runs' own tool events. */
|
|
export function countModelDiscoveryReads(events: Record<string, unknown>[], runIds: string[]) {
|
|
const record = (value: unknown) => value && typeof value === "object" && !Array.isArray(value) ? value as Record<string, unknown> : {};
|
|
return events.filter(event => {
|
|
const prp = record(record(event.payload).prpEvent), item = record(record(prp.payload).item), result = record(item.result);
|
|
return event.eventType === "item.completed" && item.type === "tool_result" && runIds.includes(String(prp.runId))
|
|
&& result.apiOperationId === MODEL_DISCOVERY_OPERATION && result.ok === true && result.status === 200;
|
|
}).length;
|
|
}
|
|
|
|
export function modelDiscoveryEndpoint(companyId: string, worker: RuntimeAgent) {
|
|
if (worker.adapterType !== "paperclip_runner" || !["codex", "opencode"].includes(String(worker.adapterConfig?.provider)) || !worker.defaultEnvironmentId)
|
|
throw new Error("Model discovery requires the actually selected native provider and environment");
|
|
return `/api/companies/${encodeURIComponent(companyId)}/adapters/paperclip_runner/models?provider=${worker.adapterConfig!.provider}&environmentId=${encodeURIComponent(worker.defaultEnvironmentId)}`;
|
|
}
|