mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-13 15:55:46 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
143 lines
12 KiB
TypeScript
143 lines
12 KiB
TypeScript
import { expect } from "@playwright/test";
|
|
import { checks, type Entity } from "./internal-support.js";
|
|
import { createAuthenticatedPerson, enrollPrerequisitePerson } from "./identity-auth.js";
|
|
import { probeAgentPermission, waitForReply, remainingIdentityObservationBudget } from "./identity-support.js";
|
|
import { runtimeDefinition, runtimeWorker, runtimeObservation, observeRuntime, openRuntimeAgentProfile, verifyRuntimeResult, agentLink, type RuntimeAgent } from "./runtime-support.js";
|
|
import type { ChatCatalogContext } from "../chat-catalog-contract.js";
|
|
interface Primary { companyId: string; userId: string; primaryAgentId: string | null }
|
|
type Person = Awaited<ReturnType<typeof createAuthenticatedPerson>>;
|
|
const people = new WeakMap<ChatCatalogContext, Person>();
|
|
const endpoint = (companyId: string) => `/api/companies/${companyId}/primary-agent/me`;
|
|
async function personPrimary(person: Person, companyId: string): Promise<Primary> {
|
|
const response = await person.request(endpoint(companyId));
|
|
if (!response.ok) { await response.body?.cancel(); throw new Error(`Secondary primary read returned ${response.status}`); }
|
|
return response.json() as Promise<Primary>;
|
|
}
|
|
export function gradePrimary(value: unknown) {
|
|
const c = checks(); const o = runtimeObservation(value);
|
|
c.add("complete-human-primary-evidence", !!o, "Real user-scoped saved preferences and human replacement control are required."); if (!o) return c.result();
|
|
const worker = o.state.worker as RuntimeAgent; const before = o.state.primaryBefore as Primary;
|
|
const after = o.state.primaryAfter as Primary | undefined; const otherBefore = o.state.otherPersonBefore as Primary;
|
|
const otherAfter = o.state.otherPersonAfter as Primary | undefined;
|
|
c.add("only-human-replaces-existing-primary", !!before && before.primaryAgentId === o.leadId
|
|
&& o.state.beforeHumanPrimary === o.leadId && o.state.replacementConfirmed === true
|
|
&& after?.primaryAgentId === worker.id && after.companyId === o.companyId && after.userId === before.userId,
|
|
"The original primary survives the chat response and is replaced only after the visible human confirmation.");
|
|
c.add("agent-preference-write-denied", o.state.agentWriteStatus === 403, "The preference endpoint rejects the real CEO agent bearer.");
|
|
c.add("other-person-company-unaffected", !!otherAfter && !!otherBefore && otherAfter.userId !== before.userId
|
|
&& JSON.stringify(otherAfter) === JSON.stringify(otherBefore)
|
|
&& JSON.stringify(o.state.otherCompanyAfter) === JSON.stringify(o.state.otherCompanyBefore),
|
|
"Independent authenticated person and company preference readbacks do not change.");
|
|
c.add("recent-chat-precedence-without-work", o.state.reopenedRecentAgent === o.leadId
|
|
&& o.state.runsAfterNavigation === 1 && o.state.chatCountBeforeNavigation === o.state.chatCountAfterNavigation,
|
|
"Opening Chat may reopen this valid recent source conversation and creates no duplicate chat or execution.");
|
|
// The reply's wording is not graded: the person must reach the control
|
|
// through the exact profile link the reply rendered, and saved state proves
|
|
// the agent wrote nothing before that human confirmation.
|
|
const href = agentLink(o, worker);
|
|
c.add("reply-links-chosen-profile", !!href && o.state.profileLinkFollowed === href,
|
|
"The reply links Morgan's profile, and the person reaches the primary control by clicking that rendered link.");
|
|
return c.result();
|
|
}
|
|
export async function verifyReadyPrimaryChat(ctx: ChatCatalogContext, state: Record<string, unknown>, value: unknown) {
|
|
const o = runtimeObservation(value); const before = state.primaryBefore as Primary; const worker = state.worker as RuntimeAgent;
|
|
const sourceId = state.sourceBeforeNavigation; const nativeIds = state.nativeIdsBeforeNavigation;
|
|
if (!o || o.companyId !== ctx.input.fixtures.company.id || o.leadId !== ctx.input.fixtures.agent.id
|
|
|| typeof sourceId !== "string" || !sourceId || !Array.isArray(nativeIds) || nativeIds.length !== 1 || typeof nativeIds[0] !== "string")
|
|
throw new Error("Primary Chat readiness requires its exact original conversation and native run");
|
|
const budget = () => remainingIdentityObservationBudget(ctx);
|
|
const lead = o.agents.find(row => row.id === o.leadId); if (!lead) throw new Error("Primary Chat lead is missing");
|
|
await expect(ctx.input.page).toHaveURL(url => {
|
|
const parts = url.pathname.split("/").filter(Boolean).map(decodeURIComponent);
|
|
return parts.length === 3 && parts[0] === ctx.input.fixtures.company.issuePrefix && parts[1] === "chats" && [lead.id, lead.urlKey].includes(parts[2]);
|
|
}, { timeout: budget() }); budget();
|
|
const composer = ctx.input.page.getByTestId("task-chat-composer-input");
|
|
await expect(composer).toBeVisible({ timeout: budget() }); budget();
|
|
await expect(composer.locator('[contenteditable="true"], textarea').first()).toBeEditable({ timeout: budget() }); budget();
|
|
const chat = await ctx.input.api.get<Entity & { conversationAgentId?: string; conversationUserId?: string }>(`/api/companies/${o.companyId}/chats/${o.leadId}`, { timeout: budget() }); budget();
|
|
if (chat.id !== sourceId || chat.companyId !== o.companyId || chat.conversationAgentId !== o.leadId || chat.conversationUserId !== before.userId)
|
|
throw new Error("Ready Chat reopened a different conversation or person");
|
|
const comments = await ctx.input.api.get<Entity[]>(`/api/issues/${sourceId}/comments?order=asc`, { timeout: budget() }); budget();
|
|
const humans = comments.filter(row => !row.authorAgentId);
|
|
const reply = comments.find(row => row.authorAgentId === o.leadId && row.createdByRunId === nativeIds[0] && !!row.body?.trim());
|
|
if (humans.length !== 1 || humans[0]!.authorUserId !== before.userId || humans[0]!.body?.trim() !== ctx.scenario.query.trim() || !reply)
|
|
throw new Error("Ready Chat lacks its original human request and native response");
|
|
for (const comment of [humans[0]!, reply]) {
|
|
await expect(ctx.input.page.locator(`[id=${JSON.stringify(`comment-${comment.id}`)}]`)).toBeVisible({ timeout: budget() }); budget();
|
|
}
|
|
await ctx.refreshIssue(); budget();
|
|
const primary = await ctx.input.api.get<Primary>(endpoint(o.companyId), { timeout: budget() }); budget();
|
|
const chats = await ctx.input.api.get<Entity[]>(`/api/companies/${o.companyId}/chats`, { timeout: budget() }); budget();
|
|
const runs = await ctx.allRuns(); budget();
|
|
if (ctx.issue()?.id !== sourceId || primary.companyId !== o.companyId || primary.userId !== before.userId || primary.primaryAgentId !== worker.id
|
|
|| chats.length !== state.chatCountBeforeNavigation || chats.filter(row => row.id === sourceId).length !== 1
|
|
|| runs.length !== 1 || runs[0]?.id !== nativeIds[0] || runs[0].agentId !== o.leadId || runs[0].status !== "succeeded")
|
|
throw new Error("Settled Chat changed the primary preference, conversation or native work");
|
|
state.reopenedRecentAgent = o.leadId; state.runsAfterNavigation = runs.length; state.chatCountAfterNavigation = chats.length;
|
|
await ctx.input.evidence("chat-primary-ready-conversation.json", { companyId: o.companyId, agentId: o.leadId, sourceId, userId: before.userId,
|
|
primaryAgentId: primary.primaryAgentId, originalNativeIds: nativeIds, chatCount: chats.length, composerReady: true, originalConversationVisible: true, noExtraWork: true }); budget();
|
|
}
|
|
export const runtimePrimaryCases = [runtimeDefinition("agents.choose-primary", async ctx => {
|
|
const secrets = ctx.input.privateSecrets; if (!secrets) throw new Error("Primary fixture requires private credential sink");
|
|
const browser = ctx.input.page.context().browser(); if (!browser) throw new Error("Real browser required");
|
|
const primaryBefore = await ctx.input.api.get<Primary>(endpoint(ctx.input.fixtures.company.id));
|
|
if (primaryBefore.primaryAgentId !== ctx.input.fixtures.agent.id) throw new Error("Catalog requires an existing primary agent");
|
|
const worker = await runtimeWorker(ctx);
|
|
const person = await createAuthenticatedPerson({ api: ctx.input.api, browser, secrets, name: "Second primary reader" }); people.set(ctx, person);
|
|
await enrollPrerequisitePerson(ctx, person, "operator");
|
|
const otherCompany = await ctx.input.api.post<Entity>("/api/companies", { name: `Other primary company ${ctx.input.nonce}` });
|
|
return { worker, primaryBefore, otherCompany, otherPersonBefore: await personPrimary(person, ctx.input.fixtures.company.id),
|
|
otherCompanyBefore: await ctx.input.api.get<Primary>(endpoint(otherCompany.id)) };
|
|
}, gradePrimary, {
|
|
authentication: "human-session", oracleVersion: "paperclip.chat-catalog.runtime-primary.v3",
|
|
sourceFiles: ["chat-catalog-domains/runtime-primary.ts", "chat-catalog-domains/runtime-support.ts", "chat-catalog-domains/identity-support.ts", "chat-scenarios/agents.yaml"],
|
|
async act(ctx, state) {
|
|
remainingIdentityObservationBudget(ctx);
|
|
await waitForReply(ctx, ctx.observationDeadlineAt);
|
|
remainingIdentityObservationBudget(ctx);
|
|
const worker = state.worker as RuntimeAgent;
|
|
state.beforeHumanPrimary = (await ctx.input.api.get<Primary>(endpoint(ctx.input.fixtures.company.id))).primaryAgentId;
|
|
state.agentWriteStatus = await probeAgentPermission(ctx, endpoint(ctx.input.fixtures.company.id), "PUT", { primaryAgentId: worker.id });
|
|
const o = await observeRuntime(ctx, state);
|
|
const source = ctx.input.page.url();
|
|
const href = agentLink(o, worker);
|
|
if (!href) throw new Error("The reply rendered no link to Morgan's profile for the person to follow");
|
|
await openRuntimeAgentProfile(ctx, worker, o);
|
|
state.profileLinkFollowed = href;
|
|
await ctx.input.page.getByRole("button", { name: "Set as my primary", exact: true }).click();
|
|
const dialog = ctx.input.page.getByRole("alertdialog");
|
|
await expect(dialog).toContainText("Change your primary agent?"); await expect(dialog).toContainText("Morgan");
|
|
await dialog.getByRole("button", { name: "Set as my primary", exact: true }).click();
|
|
await expect(ctx.input.page.getByRole("img", { name: "My primary agent", exact: true }).first()).toBeVisible();
|
|
state.replacementConfirmed = true;
|
|
// Revisit the valid recent source before opening the normal Chat landing.
|
|
await ctx.input.page.goto(source, { waitUntil: "domcontentloaded" });
|
|
await expect(ctx.input.page.getByTestId("task-chat-composer-input")).toBeVisible();
|
|
const chats = `/api/companies/${ctx.input.fixtures.company.id}/chats`;
|
|
state.chatCountBeforeNavigation = (await ctx.input.api.get<Entity[]>(chats)).length;
|
|
state.sourceBeforeNavigation = ctx.issue()?.id;
|
|
state.nativeIdsBeforeNavigation = (await ctx.allRuns()).map(run => run.id);
|
|
await ctx.input.page.goto(`/${ctx.input.fixtures.company.issuePrefix}/chats`, { waitUntil: "domcontentloaded" });
|
|
const lead = o.agents.find(row => row.id === ctx.input.fixtures.agent.id)!;
|
|
await ctx.input.page.waitForURL(url => [lead.id, lead.urlKey].includes(decodeURIComponent(url.pathname.split("/").at(-1)!)));
|
|
await verifyReadyPrimaryChat(ctx, state, o);
|
|
},
|
|
async observe(ctx, state) {
|
|
const person = people.get(ctx); if (!person) throw new Error("Secondary authenticated person missing");
|
|
state.primaryAfter = await ctx.input.api.get<Primary>(endpoint(ctx.input.fixtures.company.id));
|
|
state.otherPersonAfter = await personPrimary(person, ctx.input.fixtures.company.id);
|
|
state.otherCompanyAfter = await ctx.input.api.get<Primary>(endpoint((state.otherCompany as Entity).id));
|
|
return observeRuntime(ctx, state);
|
|
},
|
|
async verifyResult(ctx, state, value) {
|
|
remainingIdentityObservationBudget(ctx);
|
|
await verifyRuntimeResult(ctx, state, value);
|
|
remainingIdentityObservationBudget(ctx);
|
|
await verifyReadyPrimaryChat(ctx, state, value);
|
|
},
|
|
async cleanup(ctx, state) {
|
|
const person = people.get(ctx); people.delete(ctx); await person?.dispose();
|
|
await ctx.input.api.delete(`/api/companies/${(state.otherCompany as Entity).id}`, { allowNotFound: true });
|
|
},
|
|
})];
|