Files
PaperClipAI/tests/runner-e2e/chat-catalog-domains/runtime-native-fault.test.ts
T
f4337bb5fb test(evals): land the chat catalog eval harness on master (#19614)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - The chat-feature evals measure whether agents complete real chat
requests through the product
> - The chat catalog eval harness and its repairs live on the
`chat-eval/master-candidate` branch, not on master
> - Today's work made 139 of 242 chat evals pass in verified single-case
live runs. Each product fix landed on master as its own pull request
> - The eval-side changes (setups, graders, fault seams, evidence
capture) still exist only on the candidate
> - This pull request lands the harness on master. Master stays the
source of truth for product behavior
> - The benefit is one tree: evals run against master commits, and
product fixes reach the evals as soon as they merge

## Linked Issues or Issue Description

Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs
#20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409

**What existing behavior does this improve?**
The chat catalog eval harness and the product it evaluates live on a
long-running branch outside master. Eval fixes do not reach master, so
master-based eval runs use old setups and graders.

**Subsystem affected**
`tests/runner-e2e` chat catalog harness, plus a small set of product
changes that exist only on the candidate.

**Proposed change**
Land the harness on master. Every product fix from this eval work
already merged to master as its own pull request. Conflicts keep
master's product behavior.

## What Changed

- Most of the diff (808 of 851 files) is under `tests/runner-e2e/`:
chat-catalog domains, scenarios, descriptors, the TestOps manifest,
private evidence tooling, and their tests.
- Graders now check saved state, setup literals and rendered or clicked
links. Many keyword and regex checks on free-form replies are removed.
Each changed grader has a bumped `oracleVersion` and calibration tests
(a valid reply, a reworded valid reply, and broken variants that must
fail).
- The shared link helper `hasLink` no longer treats a list link (for
example `/COM/issues?view=mine`) as a link to every task without a URL
key.
- Setup fixes build real state through supported product routes: routine
history, agent grants through the board grant route, budget holds with a
real cap, and a storage-layer archive fault for
`inbox-search.archive-partial-failure`.
- Browser boundary journeys (sign-in, chat-disabled, onboarding) now
write the standard pass evidence files.
- Retargeted cases, approved by the maintainer:
`agent-chat.chat-disabled` (Conference Room gate),
`agents.restore-instructions` (no saved instruction history),
`access.manage-membership` (member permission edits stay board-only).
- The private evidence trusted files (`manual-private-handoff.ts`,
`manual-private-retention.ts`, `manual-private-report-assets.ts`) are
byte-identical to master.
- Product files outside `tests/` (43 files, +1,328 −49) carry
candidate-only changes that master does not yet have. Most are tests.
The main code changes are in `request-human-input.ts`,
`heartbeat-run-summary.ts`, `native-completion-feedback.ts`,
`native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and
`IssueChatLongThreadPerf.tsx`.

## Verification

- `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts
chat-catalog-consistency.test.ts unit-launcher.test.mjs
--testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests
pass.
- `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass.
- `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`:
no change.
- `tsc` for `server` and `tests/runner-e2e`: clean.
- Live single-case verification: 139 of 242 cases passed on paid runs,
and a person read the saved evidence for each. These are single-case
runs, not one full-cohort run.

## Risks

- Large diff. Most of it is test-only, but the 43 non-test files change
product code paths. Review those files first.
- Some graders are now less strict on reply wording. A person must read
replies for meaning on those cases.
- 42 cases need disposable outside accounts (Notion, Slack, GitHub,
Daytona and others) and stay blocked. `access.invite-teammate` stays
failing until local agent isolation lands, because the runner's durable
state keeps a live invite token.
- The paid workflow compares the trusted private-evidence files with
master. They are unchanged, so this risk is low.

## Model Used

Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code
execution, in Claude Code. Subagents used the same model.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-11-10 08:02:11 -06:00

36 lines
3.7 KiB
TypeScript

import { describe, expect, it } from "vitest";
import { ownedNativeExecutablePath, matchesOwnedNativeIdentity, retainedFaultCode, type NativeFaultBinding } from "./runtime-native-fault.js";
function valid() {
return { identity: { pid: 940123, uid: 501, group: 940123, startedAt: "2026-10-26T12:00:00Z", executable: "/qualified/runnerd", commandRunId: "run", commandRunnerId: "runner", runtimeRoot: "/owned/attempt/state/runner" },
run: { id: "run", companyId: "company", agentId: "morgan", status: "running", runtimeMode: "native", nativeIssueId: "website", runnerInstanceId: "runner", processPid: 940123, processGroupId: 940123, processStartedAt: new Date("2026-10-26T12:00:00.123Z") } as NativeFaultBinding,
expected: { companyId: "company", agentId: "morgan", issueId: "website", uid: 501, executable: "/qualified/runnerd", root: "/owned/attempt" } };
}
it("accepts exact public native binding and separately observed owned process identity", () => expect(matchesOwnedNativeIdentity(valid())).toBe(true));
it.each(["uid", "pid", "group"] as const)("rejects mismatched %s", field => { const x = valid(); x.identity[field]++; expect(matchesOwnedNativeIdentity(x)).toBe(false); });
it.each(["commandRunId", "commandRunnerId", "executable", "runtimeRoot"] as const)("rejects foreign %s", field => { const x = valid(); x.identity[field] = "/other"; expect(matchesOwnedNativeIdentity(x)).toBe(false); });
it("rejects a sibling path sharing the attempt prefix", () => { const x = valid(); x.identity.runtimeRoot = "/owned/attempt-foreign/state"; expect(matchesOwnedNativeIdentity(x)).toBe(false); });
it("rejects PID reuse with changed start identity", () => { const x = valid(); x.identity.startedAt = "2026-10-26T13:00:00Z"; expect(matchesOwnedNativeIdentity(x)).toBe(false); });
it.each(["companyId", "agentId", "nativeIssueId"] as const)("rejects changed public run %s", field => { const x = valid(); x.run[field] = "foreign"; expect(matchesOwnedNativeIdentity(x)).toBe(false); });
it("rejects a missing retained process start", () => { const x = valid(); x.run.processStartedAt = null; expect(matchesOwnedNativeIdentity(x)).toBe(false); });
it("rejects terminal public run state", () => { const x = valid(); x.run.status = "succeeded"; expect(matchesOwnedNativeIdentity(x)).toBe(false); });
it("rejects legacy runtime", () => { const x = valid(); x.run.runtimeMode = "legacy"; expect(matchesOwnedNativeIdentity(x)).toBe(false); });
it("uses Linux kernel executable identity without trusting a ps basename, preserving absolute macOS paths", () => {
expect(ownedNativeExecutablePath(987654, "node", "linux")).toBe("/proc/987654/exe");
expect(ownedNativeExecutablePath(987654, "/owned/bin/runner", "darwin")).toBe("/owned/bin/runner");
for (const platform of ["darwin", "win32"] as const) expect(() => ownedNativeExecutablePath(987654, "node", platform)).toThrow();
for (const pid of [0, 1, process.pid, 12.5]) expect(() => ownedNativeExecutablePath(pid, "/owned/bin/runner", "linux")).toThrow();
});
describe("fault cause retained after same-run recovery", () => {
it("reads the infrastructure code from the attempt's own failure events", () => {
const message = "Notification transport failed closed: native_runner_process_exited: runnerd exited unexpectedly";
expect(retainedFaultCode([{ eventType: "turn.failed", payload: { error: { code: "notification_transport_failed", message } } }])).toBe("native_runner_process_exited");
expect(retainedFaultCode([{ eventType: "error", message }])).toBe("native_runner_process_exited");
expect(retainedFaultCode([{ eventType: "harness.diagnostic", message }])).toBeNull();
expect(retainedFaultCode([{ eventType: "error", message: "model said native_runner_process_exited_maybe" }])).toBeNull();
expect(retainedFaultCode([])).toBeNull();
});
});