mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-14 08:53:19 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
41 lines
5.8 KiB
TypeScript
41 lines
5.8 KiB
TypeScript
import { it, expect } from "vitest";
|
|
import { apiReadDigests, apiReadStatuses } from "./api-read-receipts.js";
|
|
import { savedCall } from "./api-read-receipts.test-fixtures.js";
|
|
import { delegatedWorkReads, gradeTrackDelegatedWork } from "./runtime-handoffs.js";
|
|
function valid() {
|
|
const task = { id: "website", identifier: "ACORN-1", assigneeAgentId: "morgan", status: "done" };
|
|
return { scenarioId: "agent-chat.track-delegated-work", origin: "http://fixture.invalid", companyId: "company", leadId: "ceo",
|
|
state: { task, worker: { id: "morgan" }, createdFromSource: true, workerWasReallyWaiting: true, originalSourceRetained: true,
|
|
workerStatusAtQueryReply: "running", queryToolReads: [{ runId: "query", name: "call_api", mentionsTask: true }] as Array<{ runId: string; name: string; mentionsTask: boolean }>, queryReply: "Morgan is still working on Website and waiting for the brief.", queryLinks: ["/ACORN/issues/ACORN-1"],
|
|
marker: "actual delivery marker", completionDelivered: true, workerRunId: "worker", sourceAssigneePreserved: true,
|
|
delivery: { checks: [{ id: "actual-delivery", passed: true }], response: { body: "Morgan finished Website. The actual result is ready." } } },
|
|
agents: [], tasks: [task], links: [], humanQueries: [], reply: "", activity: [], documents: [{ id: "delivery", body: "actual delivery marker" }],
|
|
runs: [{ id: "handoff", agentId: "ceo", status: "succeeded" }, { id: "worker", agentId: "morgan", status: "succeeded" },
|
|
{ id: "query", agentId: "ceo", status: "succeeded" }, { id: "completion", agentId: "ceo", status: "succeeded" }] };
|
|
}
|
|
it("accepts actual prior native delegation, accurate busy status and automatic result delivery", () => expect(gradeTrackDelegatedWork(valid()).passed).toBe(true));
|
|
it("accepts natural attributed pending and completion reports", () => { const o = valid(); o.state.queryReply = "The Website task remains with Morgan, who is waiting on the brief and has not finished this turn."; o.state.delivery.response.body = "Morgan completed the Website task; its saved result is available."; expect(gradeTrackDelegatedWork(o).passed).toBe(true); });
|
|
it("rejects missing handoff evidence", () => expect(gradeTrackDelegatedWork(undefined).passed).toBe(false));
|
|
it("rejects a task manually seeded instead of created by that conversation", () => { const o = valid(); o.state.createdFromSource = false; expect(gradeTrackDelegatedWork(o).passed).toBe(false); });
|
|
it("does not grade the status answer's wording", () => { const o = valid(); o.state.queryReply = "RUN-2 is with Morgan; the run is live and the brief has not arrived, so there is no result yet."; o.state.delivery.response.body = "Here is the Website result Morgan saved."; expect(gradeTrackDelegatedWork(o).passed).toBe(true); });
|
|
it("rejects a status answer given after the worker run already ended", () => { const o = valid(); o.state.workerStatusAtQueryReply = "succeeded"; expect(gradeTrackDelegatedWork(o).passed).toBe(false); });
|
|
it("rejects a status answer that never read the task or its runs", () => { const o = valid(); o.state.queryToolReads = [{ runId: "query", name: "paperclip_list_agents", mentionsTask: false }]; expect(gradeTrackDelegatedWork(o).passed).toBe(false); });
|
|
it("rejects a read tied to neither the delegated task nor its run, whatever the tool name", () => { for (const name of ["paperclip_call_api", "paperclip_get_task_history", "paperclip_get_task"]) { const o = valid(); o.state.queryToolReads = [{ runId: "query", name, mentionsTask: false }]; expect(gradeTrackDelegatedWork(o).passed).toBe(false); } });
|
|
it("binds call_api reads to the delegated task or Morgan's run by their saved input digest", () => {
|
|
const digests = apiReadDigests(delegatedWorkReads({ id: "website", identifier: "ACORN-1" }, "morgan-run"));
|
|
const ok = (input: Record<string, unknown>) => apiReadStatuses(savedCall(input, 200), digests).length === 1;
|
|
expect(ok({ operationId: "GET /api/issues/{id}", pathParams: { id: "ACORN-1" } })).toBe(true);
|
|
expect(ok({ operationId: "GET /api/issues/{id}/runs", pathParams: { id: "website" } })).toBe(true);
|
|
expect(ok({ operationId: "GET /api/heartbeat-runs/{runId}", pathParams: { runId: "morgan-run" } })).toBe(true);
|
|
expect(ok({ operationId: "GET /api/issues/{id}", pathParams: { id: "ACORN-2" } })).toBe(false);
|
|
expect(ok({ operationId: "GET /api/companies/{companyId}/issues", pathParams: { companyId: "company" } })).toBe(false);
|
|
});
|
|
it("accepts a read whose output names the task even under another tool", () => { const o = valid(); o.state.queryToolReads = [{ runId: "query", name: "bash", mentionsTask: true }]; expect(gradeTrackDelegatedWork(o).passed).toBe(true); });
|
|
it("rejects an empty status answer", () => { const o = valid(); o.state.queryReply = ""; expect(gradeTrackDelegatedWork(o).passed).toBe(false); });
|
|
it("rejects linking a similarly named task", () => { const o = valid(); o.state.queryLinks = ["/ACORN/issues/ACORN-2"]; expect(gradeTrackDelegatedWork(o).passed).toBe(false); });
|
|
it("rejects duplicate delegated work", () => { const o = valid(); o.tasks.push({ ...o.tasks[0]!, id: "duplicate" }); expect(gradeTrackDelegatedWork(o).passed).toBe(false); });
|
|
it("rejects an uncorrelated completion update", () => { const o = valid(); o.state.delivery.checks[0]!.passed = false; expect(gradeTrackDelegatedWork(o).passed).toBe(false); });
|
|
it("rejects a completion update without access to the saved result", () => { const o = valid(); o.state.delivery.checks.push({ id: "completion-result-access", passed: false }); expect(gradeTrackDelegatedWork(o).passed).toBe(false); });
|
|
it("rejects a missing saved deliverable", () => { const o = valid(); o.documents = []; expect(gradeTrackDelegatedWork(o).passed).toBe(false); });
|
|
it("rejects a second Morgan execution", () => { const o = valid(); o.runs.push({ id: "worker-2", agentId: "morgan", status: "succeeded" }); expect(gradeTrackDelegatedWork(o).passed).toBe(false); });
|