Files
PaperClipAI/tests/runner-e2e/chat-catalog-domains/runtime-email-reply.test.ts
T
f4337bb5fb test(evals): land the chat catalog eval harness on master (#19614)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - The chat-feature evals measure whether agents complete real chat
requests through the product
> - The chat catalog eval harness and its repairs live on the
`chat-eval/master-candidate` branch, not on master
> - Today's work made 139 of 242 chat evals pass in verified single-case
live runs. Each product fix landed on master as its own pull request
> - The eval-side changes (setups, graders, fault seams, evidence
capture) still exist only on the candidate
> - This pull request lands the harness on master. Master stays the
source of truth for product behavior
> - The benefit is one tree: evals run against master commits, and
product fixes reach the evals as soon as they merge

## Linked Issues or Issue Description

Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs
#20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409

**What existing behavior does this improve?**
The chat catalog eval harness and the product it evaluates live on a
long-running branch outside master. Eval fixes do not reach master, so
master-based eval runs use old setups and graders.

**Subsystem affected**
`tests/runner-e2e` chat catalog harness, plus a small set of product
changes that exist only on the candidate.

**Proposed change**
Land the harness on master. Every product fix from this eval work
already merged to master as its own pull request. Conflicts keep
master's product behavior.

## What Changed

- Most of the diff (808 of 851 files) is under `tests/runner-e2e/`:
chat-catalog domains, scenarios, descriptors, the TestOps manifest,
private evidence tooling, and their tests.
- Graders now check saved state, setup literals and rendered or clicked
links. Many keyword and regex checks on free-form replies are removed.
Each changed grader has a bumped `oracleVersion` and calibration tests
(a valid reply, a reworded valid reply, and broken variants that must
fail).
- The shared link helper `hasLink` no longer treats a list link (for
example `/COM/issues?view=mine`) as a link to every task without a URL
key.
- Setup fixes build real state through supported product routes: routine
history, agent grants through the board grant route, budget holds with a
real cap, and a storage-layer archive fault for
`inbox-search.archive-partial-failure`.
- Browser boundary journeys (sign-in, chat-disabled, onboarding) now
write the standard pass evidence files.
- Retargeted cases, approved by the maintainer:
`agent-chat.chat-disabled` (Conference Room gate),
`agents.restore-instructions` (no saved instruction history),
`access.manage-membership` (member permission edits stay board-only).
- The private evidence trusted files (`manual-private-handoff.ts`,
`manual-private-retention.ts`, `manual-private-report-assets.ts`) are
byte-identical to master.
- Product files outside `tests/` (43 files, +1,328 −49) carry
candidate-only changes that master does not yet have. Most are tests.
The main code changes are in `request-human-input.ts`,
`heartbeat-run-summary.ts`, `native-completion-feedback.ts`,
`native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and
`IssueChatLongThreadPerf.tsx`.

## Verification

- `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts
chat-catalog-consistency.test.ts unit-launcher.test.mjs
--testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests
pass.
- `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass.
- `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`:
no change.
- `tsc` for `server` and `tests/runner-e2e`: clean.
- Live single-case verification: 139 of 242 cases passed on paid runs,
and a person read the saved evidence for each. These are single-case
runs, not one full-cohort run.

## Risks

- Large diff. Most of it is test-only, but the 43 non-test files change
product code paths. Review those files first.
- Some graders are now less strict on reply wording. A person must read
replies for meaning on those cases.
- 42 cases need disposable outside accounts (Notion, Slack, GitHub,
Daytona and others) and stay blocked. `access.invite-teammate` stays
failing until local agent isolation lands, because the runner's durable
state keeps a live invite token.
- The paid workflow compares the trusted private-evidence files with
master. They are unchanged, so this risk is low.

## Model Used

Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code
execution, in Claude Code. Subagents used the same model.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-11-10 08:02:11 -06:00

18 lines
5.4 KiB
TypeScript

import { expect, it } from "vitest";
import { createHash } from "node:crypto";
import { gradeReplyEmail, selectedReviewReadThenReply, truthfulUnverifiedMobile } from "./runtime-email-reply.js";
const hash = (v: string) => createHash("sha256").update(v).digest("hex");
function valid() { return { companyId: "company", leadId: "ceo", scenarioId: "chat-channels.reply-to-email", origin: "http://127.0.0.1:42123", reply: "", agents: [], tasks: [], activity: [], links: [], humanQueries: [], runs: [1,2,3,4,5,6,7].map(id => ({ id: String(id), agentId: "ceo", status: "succeeded" })), state: { actualTwoInboundBound: true, actualThreadRetained: true, exactLatestReplyBound: true, independentProviderCount: 1, oneSavedPublication: true, brokenLayoutReallyObserved: true, noPrematureReply: true, unverifiedReadBound: true, unverifiedReply: "The current mobile layout has not been verified as fixed. I cannot truthfully send that claim yet.", actualMobileFixBound: true, actualReadBeforeReply: true, normalReplyNativeBound: true, nativeLedgerCausal: true, factualReplyBound: true, factualReply: "The latest reviewer question received the reply and the actual provider accepted it. Recipient delivery is unconfirmed.", actualOutcome: "sent" } }; }
it("accepts both genuinely unverified and actual verified same-thread reply phases", () => expect(gradeReplyEmail(valid()).passed).toBe(true));
it("accepts a natural substantive qualification and provider-outcome paraphrase", () => { const o = valid(); o.state.unverifiedReply = "I checked the current source: mobile still overflows. A fix is pending, so I won't tell the reviewer it is repaired."; o.state.factualReply = "Your response to the newest question was sent. I cannot confirm whether it was delivered."; expect(gradeReplyEmail(o).passed).toBe(true); });
it("rejects plausible false mobile-fix claims even when surrounded by caveats", () => { expect(truthfulUnverifiedMobile("The layout is now fixed, but it remains unverified.")).toBe(false); const o = valid(); o.state.unverifiedReply += " The mobile layout is already fixed."; expect(gradeReplyEmail(o).passed).toBe(false); expect(truthfulUnverifiedMobile("I cannot confirm whether the mobile layout is fixed.")).toBe(true); });
it("rejects earlier/foreign thread selection, a premature email, missing actual repair or guessed native send", () => { for (const key of ["exactLatestReplyBound", "noPrematureReply", "actualMobileFixBound", "normalReplyNativeBound", "actualReadBeforeReply", "actualThreadRetained"]) { const o = valid(); (o.state as Record<string, unknown>)[key] = false; expect(gradeReplyEmail(o).passed).toBe(false); } });
it("rejects duplicate sends, unrelated native phases and false delivery claims", () => { const o = valid(); o.state.independentProviderCount = 2; expect(gradeReplyEmail(o).passed).toBe(false); const p = valid(); p.state.nativeLedgerCausal = false; expect(gradeReplyEmail(p).passed).toBe(false); const q = valid(); q.state.factualReply += " It was delivered."; expect(gradeReplyEmail(q).passed).toBe(false); });
const expected = { issueId: "task", conversationId: "conversation", earlierId: "earlier", latestId: "latest", publicationId: "publication", documentId: "document", documentSha256: hash("real fixed source") };
function tool(id: string, name: string, input: unknown, result: unknown, seq: number) { return [{ seq, eventType: "item.started", payload: { prpEvent: { payload: { item: { id, type: "tool_use", name, input } } } } }, { seq: seq + 1, eventType: "item.completed", payload: { prpEvent: { payload: { item: { id, type: "tool_result", result } } } } }, { seq: seq + 2, eventType: "tool.execution.completed", payload: { prpEvent: { payload: { executionId: id, name, status: "completed" } } } }]; }
function actual() { return [...tool("thread", "agentmail_read_thread", {}, { issueId: "task", conversationId: "conversation", messages: [{ providerMessageId: "earlier", direction: "inbound" }, { providerMessageId: "latest", direction: "inbound" }] }, 1), ...tool("source", "read_document", { key: "mobile-layout" }, { document: { id: "document", issueId: "task", body: "real fixed source" } }, 4), ...tool("send", "agentmail_send", { request: { conversationId: "conversation", replyToMessageId: "latest", idempotencyKey: "publication" } }, { id: "publication" }, 7)]; }
it("binds actual production read_document wrapper and selected thread reads before the completed native reply", () => expect(selectedReviewReadThenReply(actual(), expected)).toEqual({ selectedRead: true, replyBound: true }));
it("rejects missing/wrong evidence, earlier message reply and uncompleted synthetic results", () => { expect(selectedReviewReadThenReply(actual(), { ...expected, latestId: "wrong" }).replyBound).toBe(false); expect(selectedReviewReadThenReply(actual(), { ...expected, documentSha256: hash("wrong source") }).replyBound).toBe(false); expect(selectedReviewReadThenReply(actual().slice(0, -1), expected).replyBound).toBe(false); const late = actual(); late[3]!.seq = 10; expect(selectedReviewReadThenReply(late, expected).replyBound).toBe(false); });
it("allows the unchanged selected message from actual prior read evidence but never substitutes that for current repaired source", () => { const withoutThread = actual().slice(3); expect(selectedReviewReadThenReply(withoutThread, { ...expected, priorSelectedThreadRead: true }).replyBound).toBe(true); expect(selectedReviewReadThenReply(withoutThread.slice(3), { ...expected, priorSelectedThreadRead: true }).replyBound).toBe(false); });