Files
PaperClipAI/tests/runner-e2e/chat-catalog-domains/runtime-email-duplicate.test.ts
T
f4337bb5fb test(evals): land the chat catalog eval harness on master (#19614)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - The chat-feature evals measure whether agents complete real chat
requests through the product
> - The chat catalog eval harness and its repairs live on the
`chat-eval/master-candidate` branch, not on master
> - Today's work made 139 of 242 chat evals pass in verified single-case
live runs. Each product fix landed on master as its own pull request
> - The eval-side changes (setups, graders, fault seams, evidence
capture) still exist only on the candidate
> - This pull request lands the harness on master. Master stays the
source of truth for product behavior
> - The benefit is one tree: evals run against master commits, and
product fixes reach the evals as soon as they merge

## Linked Issues or Issue Description

Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs
#20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409

**What existing behavior does this improve?**
The chat catalog eval harness and the product it evaluates live on a
long-running branch outside master. Eval fixes do not reach master, so
master-based eval runs use old setups and graders.

**Subsystem affected**
`tests/runner-e2e` chat catalog harness, plus a small set of product
changes that exist only on the candidate.

**Proposed change**
Land the harness on master. Every product fix from this eval work
already merged to master as its own pull request. Conflicts keep
master's product behavior.

## What Changed

- Most of the diff (808 of 851 files) is under `tests/runner-e2e/`:
chat-catalog domains, scenarios, descriptors, the TestOps manifest,
private evidence tooling, and their tests.
- Graders now check saved state, setup literals and rendered or clicked
links. Many keyword and regex checks on free-form replies are removed.
Each changed grader has a bumped `oracleVersion` and calibration tests
(a valid reply, a reworded valid reply, and broken variants that must
fail).
- The shared link helper `hasLink` no longer treats a list link (for
example `/COM/issues?view=mine`) as a link to every task without a URL
key.
- Setup fixes build real state through supported product routes: routine
history, agent grants through the board grant route, budget holds with a
real cap, and a storage-layer archive fault for
`inbox-search.archive-partial-failure`.
- Browser boundary journeys (sign-in, chat-disabled, onboarding) now
write the standard pass evidence files.
- Retargeted cases, approved by the maintainer:
`agent-chat.chat-disabled` (Conference Room gate),
`agents.restore-instructions` (no saved instruction history),
`access.manage-membership` (member permission edits stay board-only).
- The private evidence trusted files (`manual-private-handoff.ts`,
`manual-private-retention.ts`, `manual-private-report-assets.ts`) are
byte-identical to master.
- Product files outside `tests/` (43 files, +1,328 −49) carry
candidate-only changes that master does not yet have. Most are tests.
The main code changes are in `request-human-input.ts`,
`heartbeat-run-summary.ts`, `native-completion-feedback.ts`,
`native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and
`IssueChatLongThreadPerf.tsx`.

## Verification

- `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts
chat-catalog-consistency.test.ts unit-launcher.test.mjs
--testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests
pass.
- `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass.
- `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`:
no change.
- `tsc` for `server` and `tests/runner-e2e`: clean.
- Live single-case verification: 139 of 242 cases passed on paid runs,
and a person read the saved evidence for each. These are single-case
runs, not one full-cohort run.

## Risks

- Large diff. Most of it is test-only, but the 43 non-test files change
product code paths. Review those files first.
- Some graders are now less strict on reply wording. A person must read
replies for meaning on those cases.
- 42 cases need disposable outside accounts (Notion, Slack, GitHub,
Daytona and others) and stay blocked. `access.invite-teammate` stays
failing until local agent isolation lands, because the runner's durable
state keeps a live invite token.
- The paid workflow compares the trusted private-evidence files with
master. They are unchanged, so this risk is low.

## Model Used

Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code
execution, in Claude Code. Subagents used the same model.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-11-10 08:02:11 -06:00

26 lines
4.8 KiB
TypeScript

import { expect, it } from "vitest";
import { randomUUID, createHash } from "node:crypto";
import { mkdtemp, realpath, rm } from "node:fs/promises";
import { tmpdir } from "node:os";
import path from "node:path";
import { createRequire } from "node:module";
import { EventEmitter } from "node:events";
import { emailDuplicateRequestMatches, matchesDuplicateSend, installOwnedEmailReceiptDuplicate, armOwnedEmailReceiptDuplicate, readOwnedEmailDuplicate, type EmailDuplicateRequest, type EmailDuplicateReceipt } from "./runtime-email-duplicate.js";
function fixture() { const nonce = randomUUID(), request: EmailDuplicateRequest = { executionId: "chat-features.runner-codex-subscription.local.chat-channels.outbound-email", attemptId: "a".repeat(32), inboxId: "qa@example.test", marker: `Launch draft ${nonce}`, nonce, expiresAt: Date.now() + 60000 }, publication = randomUUID(), url = new URL(`https://api.agentmail.to/v0/inboxes/${encodeURIComponent(request.inboxId)}/messages/send`), init: RequestInit = { method: "POST", headers: { "Idempotency-Key": publication }, body: JSON.stringify({ to: [request.inboxId], text: request.marker, headers: { "X-Paperclip-Publication-Id": publication } }) }; return { request, publication, url, init }; }
it("accepts only exact selected, bounded, attempt-owned receipt duplication", () => { const f = fixture(); expect(emailDuplicateRequestMatches(f.request, f.request)).toBe(true); for (const change of [{ executionId: "goals.list" }, { attemptId: "b".repeat(32) }, { expiresAt: Date.now() - 1 }, { marker: "unrelated draft" }, { extra: true }]) expect(emailDuplicateRequestMatches({ ...f.request, ...change }, f.request)).toBe(false); });
it("observes only the authorized original publication and selected real provider/inbox", () => { const f = fixture(); expect(matchesDuplicateSend(f.request, f.url, f.init)).toBe(f.publication); expect(matchesDuplicateSend(f.request, new URL(f.url.href.replace("api.agentmail.to", "evil.example.test")), f.init)).toBeUndefined(); for (const change of [{ to: ["other@example.test"] }, { text: "wrong draft" }, { headers: { "X-Paperclip-Publication-Id": randomUUID() } }]) expect(matchesDuplicateSend(f.request, f.url, { ...f.init, body: JSON.stringify({ ...JSON.parse(String(f.init.body)), ...change }) })).toBeUndefined(); });
it("installs nothing for unrelated executions", async () => { const original = globalThis.fetch; expect(await installOwnedEmailReceiptDuplicate({ executionIds: ["goals.list"], attemptId: "", temporaryRoot: "/not-read" })).toBeUndefined(); expect(globalThis.fetch).toBe(original); });
it("duplicates one identical authentic receipt only; unrelated and later events remain single, sends remain one", async () => {
const f = fixture(), root = await realpath(await mkdtemp(path.join(tmpdir(), "email-duplicate-control-"))), prior = globalThis.fetch; let sends = 0;
globalThis.fetch = (async () => { sends++; return new Response(JSON.stringify({ message_id: "actual-message", thread_id: "actual-thread" }), { status: 202 }); }) as typeof fetch;
const WS = createRequire(new URL("../../../server/package.json", import.meta.url))("ws") as { prototype: EventEmitter }, originalEmit = WS.prototype.emit;
const owned = await installOwnedEmailReceiptDuplicate({ executionIds: [f.request.executionId], attemptId: f.request.attemptId, temporaryRoot: root });
try { await armOwnedEmailReceiptDuplicate(root, f.request); const response = await fetch(f.url, f.init); expect(response.status).toBe(202); expect((await response.json()).message_id).toBe("actual-message");
const socket = Object.setPrototypeOf(new EventEmitter(), WS.prototype) as EventEmitter & { _url: string }; socket._url = "wss://ws.agentmail.to/v0"; const observed: Buffer[] = []; socket.on("message", bytes => observed.push(bytes));
const other = Buffer.from(JSON.stringify({ event_type: "message.sent", send: { inbox_id: f.request.inboxId, message_id: "other" } })); socket.emit("message", other); expect(observed).toHaveLength(1);
const real = Buffer.from(JSON.stringify({ event_type: "message.sent", send: { inbox_id: f.request.inboxId, message_id: "actual-message" } })); socket.emit("message", real); expect(observed).toHaveLength(3); expect(observed[1]).toBe(real); expect(observed[2]).toBe(real);
socket.emit("message", real); expect(observed).toHaveLength(4); expect(sends).toBe(1); await owned!.close();
const receipt = readOwnedEmailDuplicate<EmailDuplicateReceipt>(root, "receipt.json"); expect(receipt.publicationId).toBe(f.publication); expect(receipt.authenticPayloadSha256).toBe(createHash("sha256").update(real).digest("hex")); expect(receipt.injectedDuplicateCount).toBe(1); expect(receipt.released).toBe(true);
} finally { await owned?.close(); globalThis.fetch = prior; await rm(root, { recursive: true, force: true }); } expect(WS.prototype.emit).toBe(originalEmit);
});