mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-13 15:55:46 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
55 lines
5.7 KiB
TypeScript
55 lines
5.7 KiB
TypeScript
import { agentHarnessType } from "../../../packages/shared/src/agent-runner.js";
|
|
import type { Agent } from "../../../packages/shared/src/types/agent.js";
|
|
import { readFile } from "node:fs/promises";
|
|
import { chromium, test } from "@playwright/test";
|
|
import type { Environment, EnvironmentProbeResult } from "../../../packages/shared/src/types/environment.js";
|
|
import type { SshComputerRequest, SshComputerReceipt } from "./runtime-computers-private.js";
|
|
async function main(): Promise<SshComputerReceipt> {
|
|
let attached = false; try { test.info(); attached = true; } catch { /* standalone child */ }
|
|
if (attached) throw new Error("SSH credential entry must be outside Test");
|
|
const r = JSON.parse(await readFile(process.argv[2]!, "utf8")) as SshComputerRequest & { executablePath: string };
|
|
const base = new URL(r.baseURL);
|
|
if (base.protocol !== "http:" || base.hostname !== "127.0.0.1" || !/^[a-f0-9-]{36}$/i.test(r.companyId) || !["claude_local", "saved-agent"].includes(r.harness) || !["create", "probe"].includes(r.operation)) throw new Error("Invalid selected SSH binding");
|
|
const headers = { Cookie: r.cookies.map(x => `${x.name}=${x.value}`).join("; "), Origin: base.origin, "Content-Type": "application/json" };
|
|
async function api<T>(url: string, body?: unknown, method = body === undefined ? "GET" : "POST"): Promise<T> {
|
|
const response = await fetch(new URL(url, base), { method, headers, body: body === undefined ? undefined : JSON.stringify(body), redirect: "error", signal: AbortSignal.timeout(180000) });
|
|
if (!response.ok) { await response.body?.cancel(); throw new Error("Owned SSH public operation rejected"); } return response.json() as Promise<T>;
|
|
}
|
|
let id = r.environmentId, created = false;
|
|
try {
|
|
if (r.operation === "create") {
|
|
const browser = await chromium.launch({ headless: true, executablePath: r.executablePath });
|
|
try {
|
|
const context = await browser.newContext({ baseURL: base.origin }); await context.addCookies(r.cookies);
|
|
const page = await context.newPage(); await page.goto(`/${r.companyPrefix}/company/settings/instance/environments/new`);
|
|
const field = (label: string) => page.locator("label").filter({ hasText: new RegExp(`^${label}$`) }).locator("../..");
|
|
await field("Driver").locator("select").selectOption("ssh");
|
|
for (const [label, value] of [["Name", r.name], ["Host", r.host], ["Port", String(r.port)], ["Username", r.username], ["Remote workspace path", r.remoteWorkspacePath]]) await field(label).locator("input").fill(value!);
|
|
await field("Private key").locator("textarea").fill(r.privateKey); await field("Known hosts").locator("textarea").fill(r.knownHosts);
|
|
const response = page.waitForResponse(x => x.request().method() === "POST" && new URL(x.url()).pathname === `/api/companies/${r.companyId}/environments`);
|
|
await page.getByRole("button", { name: "Create environment", exact: true }).click();
|
|
const saved = await response; if (!saved.ok()) throw new Error("Actual SSH UI create rejected");
|
|
id = (await saved.json() as Environment).id; created = true;
|
|
} finally { await browser.close(); }
|
|
}
|
|
if (!id || !/^[a-f0-9-]{36}$/i.test(id)) throw new Error("No actual saved target");
|
|
const detail = await api<Environment>(`/api/environments/${id}`), inventory = await api<Environment[]>(`/api/companies/${r.companyId}/environments`), c = detail.config;
|
|
if (!inventory.some(x => x.id === id) || detail.driver !== "ssh" || detail.status !== "active" || detail.name !== r.name || c.host !== r.host || c.port !== r.port || c.username !== r.username || c.remoteWorkspacePath !== r.remoteWorkspacePath || c.knownHosts !== r.knownHosts || c.strictHostKeyChecking !== true) throw new Error("Saved SSH identity differs from selected target");
|
|
let selectedHarness: string | null = null;
|
|
let login: boolean | null = null, runtimeStatus: SshComputerReceipt["runtimeStatus"] = null, runtimeCodes: string[] = [];
|
|
if (r.operation === "probe") {
|
|
const savedAgent = r.harness === "saved-agent" && r.agentId ? await api<Agent>(`/api/agents/${r.agentId}`) : undefined;
|
|
if (r.harness === "saved-agent" && (!savedAgent || savedAgent.companyId !== r.companyId || savedAgent.id !== r.agentId)) throw new Error("Actual Morgan runtime binding is missing");
|
|
selectedHarness = savedAgent ? agentHarnessType(savedAgent.adapterType, savedAgent.adapterConfig) : "claude_local";
|
|
const probe = await api<EnvironmentProbeResult>(`/api/environments/${id}/probe?companyId=${r.companyId}`, {}); login = probe.ok;
|
|
if (login) { const runtime = await api<{ status: "pass" | "warn" | "fail"; checks: Array<{ code: string }> }>(`/api/companies/${r.companyId}/adapters/${savedAgent?.adapterType ?? "claude_local"}/test-environment`, savedAgent ? { agentId: savedAgent.id, adapterConfig: savedAgent.adapterConfig, ...(savedAgent.runtimeConfig.aiConnection ? { aiConnection: savedAgent.runtimeConfig.aiConnection } : {}), environmentId: id } : { environmentId: id, runner: "legacy", adapterConfig: {} });
|
|
runtimeStatus = runtime.status; runtimeCodes = runtime.checks.map(x => x.code); }
|
|
}
|
|
return { processIsolation: true, testRunnerAttached: false, apiStepRecorder: false, operation: r.operation, companyId: r.companyId, environmentId: id, savedIdentityMatched: true, login, runtimeStatus, runtimeCodes, selectedHarness, ...(r.agentId ? { agentId: r.agentId } : {}) };
|
|
} catch {
|
|
if (created && id) await api(`/api/environments/${id}`, undefined, "DELETE");
|
|
throw new Error("SSH actual UI/probe failed; private diagnostics withheld");
|
|
}
|
|
}
|
|
main().then(x => process.stdout.write(JSON.stringify(x))).catch(() => { process.stderr.write("Selected SSH journey failed; private diagnostics withheld"); process.exitCode = 1; });
|