mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-14 08:53:19 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
84 lines
7.1 KiB
TypeScript
84 lines
7.1 KiB
TypeScript
import { createHash } from "node:crypto";
|
|
import { pollUntil } from "../api.js";
|
|
import { checks, sameTask, type Entity } from "./internal-support.js";
|
|
import { agentLink, runtimeDefinition, runtimeObservation, observeRuntime, type RuntimeAgent, type InstructionFile } from "./runtime-support.js";
|
|
interface BuiltInState { definition: { key: string }; agentId: string | null; agent: RuntimeAgent | null; status: string }
|
|
/**
|
|
* Agent instruction files persist without revision history (design change 14420):
|
|
* a read reports a content token stamped with the reader, so the write's
|
|
* attribution is the `agent.files_updated` audit row for the saved bytes.
|
|
*/
|
|
function agentInstructionSave(o: NonNullable<ReturnType<typeof runtimeObservation>>, workerId: string, content: string) {
|
|
const contentHash = createHash("sha256").update(content).digest("hex");
|
|
return o.activity.find(row => row.action === "agent.files_updated" && row.companyId === o.companyId && row.entityId === workerId
|
|
&& row.actorType === "agent" && row.actorId === o.leadId && row.agentId === o.leadId
|
|
&& row.details?.path === "AGENTS.md" && row.details.contentHash === contentHash
|
|
&& o.runs.some(run => run.id === (row as typeof row & { runId?: string }).runId));
|
|
}
|
|
function nonEmptyLines(content: string) { return content.split("\n").map(line => line.trim()).filter(Boolean); }
|
|
export function gradeBuiltInConfiguration(value: unknown) {
|
|
const c = checks(); const o = runtimeObservation(value);
|
|
c.add("actual-built-in-observation", !!o, "The protected built-in registry, saved instruction file and historical task are independently read."); if (!o) return c.result();
|
|
const original = o.state.builtInBefore as BuiltInState | undefined; const after = o.state.builtInAfter as BuiltInState | undefined;
|
|
const beforeInstruction = o.state.originalInstruction as InstructionFile | undefined; const current = o.instruction;
|
|
const worker = o.agents.find(row => row.id === original?.agentId);
|
|
c.add("protected-identity-preserved", !!original && !!after && after.definition.key === "summarizer" && after.agentId === original.agentId
|
|
&& !!worker && worker.companyId === o.companyId && o.agents.length === o.state.agentCountBefore,
|
|
"The required registry still points to the same summarizer, with no replacement ordinary hire.");
|
|
// The wording of the new guidance is the model's own; grade that the run
|
|
// itself saved a targeted edit of the built-in's bundled instructions.
|
|
const originalLines = beforeInstruction ? nonEmptyLines(beforeInstruction.content) : [];
|
|
const currentLines = new Set(current ? nonEmptyLines(current.content) : []);
|
|
c.add("configuration-durably-saved-by-run", !!current && !!beforeInstruction && !!worker && current.content !== beforeInstruction.content
|
|
&& !!agentInstructionSave(o, worker.id, current.content),
|
|
"The chat agent's own run saved changed instructions for the existing summarizer, and those bytes are what the product now serves.");
|
|
c.add("targeted-edit-retains-summarizer-purpose", originalLines.length > 0
|
|
&& originalLines.filter(line => currentLines.has(line)).length * 2 >= originalLines.length,
|
|
"The edit tunes the bundled summarizer instructions rather than replacing them wholesale.");
|
|
c.add("history-retained", o.tasks.length === 1 && sameTask(o.state.historicalTask as Entity, o.tasks[0]),
|
|
"The summarizer's attributed historical work remains intact.");
|
|
c.add("names-configured-agent", !!worker && (!!agentLink(o, worker) || (!!worker.name && o.reply.includes(worker.name))),
|
|
"The response identifies the summarizer whose configuration it changed.");
|
|
return c.result();
|
|
}
|
|
export const runtimeBuiltInCases = [runtimeDefinition("agents.configure-required-agent", async ctx => {
|
|
await ctx.input.api.patch("/api/instance/settings/experimental", { enableBuiltInAgents: true });
|
|
const root = `/api/companies/${ctx.input.fixtures.company.id}`;
|
|
const builtInBefore = await ctx.input.api.post<BuiltInState>(`${root}/built-in-agents/summarizer/reconcile`, {});
|
|
if (!builtInBefore.agentId || !builtInBefore.agent) throw new Error("Public reconcile did not create the protected summarizer identity");
|
|
const worker = builtInBefore.agent;
|
|
const originalInstruction = await ctx.input.api.get<InstructionFile>(`/api/agents/${worker.id}/instructions-bundle/file?path=AGENTS.md`);
|
|
const historicalTask = await ctx.input.api.post<Entity>(`${root}/issues`, { title: "Historical summary work", status: "backlog", assigneeAgentId: worker.id });
|
|
const agentCountBefore = (await ctx.input.api.get<RuntimeAgent[]>(`${root}/agents`)).length;
|
|
return { worker, builtInBefore, instructionAgentId: worker.id, originalInstruction, historicalTask, agentCountBefore };
|
|
}, gradeBuiltInConfiguration, {
|
|
oracleVersion: "paperclip.chat-catalog.runtime.configure-required-agent.v3",
|
|
sourceFiles: ["chat-catalog-domains/runtime-built-in.ts", "chat-catalog-domains/runtime-support.ts", "chat-scenarios/agents.yaml"],
|
|
setupPolicy: { readiness: "preserve-scenario", invariantCheckIds: ["lead-ready", "protected-summarizer-identity", "historical-task-unrun"] },
|
|
async verifySetup(ctx, state) {
|
|
const c = checks();
|
|
// Preserve the protected summarizer's real pause; only the ordinary source
|
|
// agent must complete its asynchronous public readiness verification.
|
|
const lead = await pollUntil({ label: "Required-agent configuration source readiness", deadlineAt: Date.now() + 45_000,
|
|
load: () => ctx.input.api.get<RuntimeAgent & { lifecycleError?: string | null }>(`/api/agents/${ctx.input.fixtures.agent.id}`),
|
|
accept: row => row.lifecycleState === "ready" && ["idle", "active"].includes(row.status ?? ""),
|
|
reject: row => row.lifecycleError ? "Source runtime verification failed" : undefined });
|
|
const builtIn = await ctx.input.api.get<BuiltInState>(`/api/companies/${ctx.input.fixtures.company.id}/built-in-agents/summarizer/status`);
|
|
const history = await ctx.input.api.get<Entity>(`/api/issues/${(state.historicalTask as Entity).id}`);
|
|
c.add("lead-ready", lead.lifecycleState === "ready" && ["idle", "active"].includes(lead.status ?? ""), "The actual chat agent is runnable.");
|
|
c.add("protected-summarizer-identity", builtIn.definition.key === "summarizer" && builtIn.agentId === (state.worker as RuntimeAgent).id,
|
|
"The genuine protected identity is preserved; readiness is never manufactured for this configuration-only request.");
|
|
c.add("historical-task-unrun", history.status === "backlog" && (await ctx.allRuns()).length === 0, "The retained history fixture has not started provider work.");
|
|
return c.result();
|
|
},
|
|
async observe(ctx, state) {
|
|
state.builtInAfter = await ctx.input.api.get<BuiltInState>(`/api/companies/${ctx.input.fixtures.company.id}/built-in-agents/summarizer/status`);
|
|
// The built-in bundle has no arbitrary side-file prerequisite.
|
|
const result = await observeRuntime(ctx, { ...state, instructionAgentId: undefined });
|
|
const root = `/api/agents/${(state.worker as RuntimeAgent).id}/instructions-bundle`;
|
|
result.instruction = await ctx.input.api.get<InstructionFile>(`${root}/file?path=AGENTS.md`);
|
|
result.instructionHistory = await ctx.input.api.get(`${root}/history?path=AGENTS.md`);
|
|
return result;
|
|
},
|
|
})];
|