Files
PaperClipAI/tests/runner-e2e/chat-catalog-domains/internal-task-creation.ts
T
f4337bb5fb test(evals): land the chat catalog eval harness on master (#19614)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - The chat-feature evals measure whether agents complete real chat
requests through the product
> - The chat catalog eval harness and its repairs live on the
`chat-eval/master-candidate` branch, not on master
> - Today's work made 139 of 242 chat evals pass in verified single-case
live runs. Each product fix landed on master as its own pull request
> - The eval-side changes (setups, graders, fault seams, evidence
capture) still exist only on the candidate
> - This pull request lands the harness on master. Master stays the
source of truth for product behavior
> - The benefit is one tree: evals run against master commits, and
product fixes reach the evals as soon as they merge

## Linked Issues or Issue Description

Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs
#20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409

**What existing behavior does this improve?**
The chat catalog eval harness and the product it evaluates live on a
long-running branch outside master. Eval fixes do not reach master, so
master-based eval runs use old setups and graders.

**Subsystem affected**
`tests/runner-e2e` chat catalog harness, plus a small set of product
changes that exist only on the candidate.

**Proposed change**
Land the harness on master. Every product fix from this eval work
already merged to master as its own pull request. Conflicts keep
master's product behavior.

## What Changed

- Most of the diff (808 of 851 files) is under `tests/runner-e2e/`:
chat-catalog domains, scenarios, descriptors, the TestOps manifest,
private evidence tooling, and their tests.
- Graders now check saved state, setup literals and rendered or clicked
links. Many keyword and regex checks on free-form replies are removed.
Each changed grader has a bumped `oracleVersion` and calibration tests
(a valid reply, a reworded valid reply, and broken variants that must
fail).
- The shared link helper `hasLink` no longer treats a list link (for
example `/COM/issues?view=mine`) as a link to every task without a URL
key.
- Setup fixes build real state through supported product routes: routine
history, agent grants through the board grant route, budget holds with a
real cap, and a storage-layer archive fault for
`inbox-search.archive-partial-failure`.
- Browser boundary journeys (sign-in, chat-disabled, onboarding) now
write the standard pass evidence files.
- Retargeted cases, approved by the maintainer:
`agent-chat.chat-disabled` (Conference Room gate),
`agents.restore-instructions` (no saved instruction history),
`access.manage-membership` (member permission edits stay board-only).
- The private evidence trusted files (`manual-private-handoff.ts`,
`manual-private-retention.ts`, `manual-private-report-assets.ts`) are
byte-identical to master.
- Product files outside `tests/` (43 files, +1,328 −49) carry
candidate-only changes that master does not yet have. Most are tests.
The main code changes are in `request-human-input.ts`,
`heartbeat-run-summary.ts`, `native-completion-feedback.ts`,
`native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and
`IssueChatLongThreadPerf.tsx`.

## Verification

- `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts
chat-catalog-consistency.test.ts unit-launcher.test.mjs
--testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests
pass.
- `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass.
- `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`:
no change.
- `tsc` for `server` and `tests/runner-e2e`: clean.
- Live single-case verification: 139 of 242 cases passed on paid runs,
and a person read the saved evidence for each. These are single-case
runs, not one full-cohort run.

## Risks

- Large diff. Most of it is test-only, but the 43 non-test files change
product code paths. Review those files first.
- Some graders are now less strict on reply wording. A person must read
replies for meaning on those cases.
- 42 cases need disposable outside accounts (Notion, Slack, GitHub,
Daytona and others) and stay blocked. `access.invite-teammate` stays
failing until local agent isolation lands, because the runner's durable
state keeps a live invite token.
- The paid workflow compares the trusted private-evidence files with
master. They are unchanged, so this risk is low.

## Model Used

Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code
execution, in Claude Code. Subagents used the same model.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-11-10 08:02:11 -06:00

138 lines
12 KiB
TypeScript

import { createHash } from "node:crypto";
import { chatCatalogNativePhaseDeadline, chatCatalogNativePhaseIsTimely } from "../chat-catalog-contract.js";
import { verifyDistinctTaskFixtures } from "./internal-distinct-fixtures.js";
import type { ChatCatalogCase, ChatCatalogContext } from "../chat-catalog-contract.js";
import type { ChatRun, ChatIssue } from "../chat-flow.js";
import { dropChatSendAcknowledgement } from "../lost-send.js";
import { pollUntil } from "../api.js";
import { makeDefinition, fixtureWorker } from "./internal-definition.js";
import { observeInternal, project, task, entity, observation, checks, hasLink, sameTask,
type Entity, type InternalObservation } from "./internal-support.js";
interface Attachment extends Entity { contentType?: string; originalFilename?: string; filename?: string; byteSize?: number }
interface CreationObservation extends InternalObservation {
source: ChatIssue | null;
replies: Entity[];
sourceComments: Array<Entity & { clientRequestId?: string }>;
websiteFiles: Array<{ issueId: string; attachmentId: string; body: string; sha256: string; createdAt?: string }>;
}
function boundIssue(run: ChatRun) { return (run as ChatRun & { nativeIssueId?: string }).nativeIssueId ?? run.contextSnapshot?.issueId; }
function newTasks(o: InternalObservation) {
const priorIds = Array.isArray(o.state.priorTasks) ? (o.state.priorTasks as Entity[]).map(row => row.id) : [];
return o.tasks.filter(row => !priorIds.includes(row.id));
}
function creationObservation(value: unknown): CreationObservation | undefined {
const o = observation(value) as CreationObservation | undefined;
return o && Array.isArray(o.replies) && Array.isArray(o.sourceComments) && Array.isArray(o.websiteFiles) ? o : undefined;
}
export function gradeDelegatedCreation(value: unknown) {
const c = checks(); const o = creationObservation(value);
c.add("complete-creation-evidence", !!o, "Creation needs actual conversation, task, worker-run and delivered-file observations.");
if (!o) return c.result();
const created = newTasks(o); const saved = created[0]; const worker = entity(o.state, "worker");
const launch = o.projects.filter(row => row.name === "Launch"); const p = launch[0];
const workRuns = saved ? o.runs.filter(run => boundIssue(run) === saved.id) : [];
c.add("one-ordinary-company-task", created.length === 1 && !!saved && saved.companyId === o.companyId
&& saved.assigneeAgentId === worker.id && saved.parentId == null && saved.projectId === p?.id && saved.id !== o.source?.id,
"One ordinary task belongs to the intended Launch project and single eligible Morgan, separately from standing Chat.");
c.add("requested-work-captured", !!saved && (o.scenarioId === "projects.project-work"
? /\bmobile\b/i.test(`${saved.title} ${saved.description ?? ""}`) && /\blayout\b/i.test(`${saved.title} ${saved.description ?? ""}`)
: /\b(?:website|web site|landing.page)\b/i.test(`${saved.title} ${saved.description ?? ""}`)),
"The actual new task captures the requested website or mobile-layout work.");
c.add("one-launch-and-attribution", launch.length === 1 && p?.companyId === o.companyId && !!saved
&& o.activity.filter(row => row.action === "issue.created" && row.entityId === saved.id).length === 1
&& o.activity.some(row => row.action === "issue.created" && row.entityId === saved.id && row.agentId === o.leadId),
"Exactly one intended Launch and one CEO-attributed task creation exist.");
c.add("retained-chat-and-links", o.source?.assigneeAgentId === o.leadId && o.source.status === "in_review"
&& o.source.conversationState === "waiting" && !o.source.scheduledRetry && !o.source.activeRecoveryAction
&& !!saved && hasLink(o, "issues", saved) && !!p && (o.scenarioId !== "tasks.website-without-project" || hasLink(o, "projects", p)),
"The original source remains a settled standing conversation and renders the actual saved result links.");
c.add("separate-admitted-worker", o.scenarioId === "projects.project-work" && workRuns.length === 0 || workRuns.length === 1
&& workRuns[0]?.agentId === worker.id && ["queued", "running", "succeeded"].includes(workRuns[0]?.status ?? ""),
"Requested execution is a separate Morgan run bound to the actual new task; project task creation may remain saved.");
const readinessClaim = /\b(?:website|site|landing.page)\b(?!\s+task\b)[^.!?\n]{0,60}\b(?:is ready|is live|is built|is complete|has been built|has been deployed)\b/i;
c.add("no-premature-website-success", o.replies.every(reply => !readinessClaim.test(reply.body ?? "") || !!saved && saved.status === "done"
&& workRuns.some(run => run.status === "succeeded") && o.websiteFiles.some(file => file.issueId === saved.id
&& /<html\b/i.test(file.body) && /<body\b/i.test(file.body) && /<h[1-6]\b/i.test(file.body)
&& Date.parse(file.createdAt ?? "") <= Date.parse(reply.createdAt ?? ""))),
"A claimed finished website requires independently downloaded HTML from the executed task, rather than task creation alone.");
const priorTasks = Array.isArray(o.state.priorTasks) ? o.state.priorTasks as Entity[] : [];
c.add("existing-work-preserved", priorTasks.every(before => sameTask(before, o.tasks.find(row => row.id === before.id))),
"Existing tasks, including similarly named work in other projects, remain unchanged.");
if (o.scenarioId === "projects.project-work") {
const open = priorTasks.filter(row => row.projectId === p?.id && !["done", "cancelled"].includes(row.status ?? ""));
c.add("launch-leftover-summary", open.length > 0 && open.every(row => hasLink(o, "issues", row))
&& priorTasks.filter(row => row.projectId !== p?.id).every(row => !hasLink(o, "issues", row)),
"The leftover-work summary is grounded in Launch's unfinished work and excludes the other project's distractor.");
}
if (o.scenarioId === "tasks.website-without-project") {
const transport = o.state.transport as { commentId?: string; clientRequestId?: string; replayedCommentId?: string; firstTaskId?: string; firstProjectId?: string } | undefined;
const requestRuns = transport ? o.runs.filter(run => run.contextSnapshot?.wakeCommentId === transport.commentId
|| Array.isArray(run.contextSnapshot?.wakeCommentIds) && run.contextSnapshot.wakeCommentIds.includes(transport.commentId)) : [];
c.add("committed-lost-ack-recovery", !!transport && typeof transport.commentId === "string" && !!transport.commentId
&& typeof transport.clientRequestId === "string" && !!transport.clientRequestId && transport.commentId === transport.replayedCommentId
&& o.sourceComments.filter(row => row.clientRequestId === transport.clientRequestId).map(row => row.id).join() === transport.commentId
&& saved?.id === transport.firstTaskId && p?.id === transport.firstProjectId && requestRuns.length === 1,
"A real lost HTTP acknowledgement and exact client-request replay retain one original comment, project, task and request-bound run.");
c.add("new-project-is-agent-created", !!p && o.activity.some(row => row.action === "project.created" && row.entityId === p.id && row.agentId === o.leadId),
"The harness did not seed the requested new project.");
}
return c.result();
}
async function observeCreation(ctx: ChatCatalogContext, state: Record<string, unknown>): Promise<CreationObservation> {
const o = await observeInternal(ctx, state); const source = ctx.issue();
const sourceComments = source ? await ctx.input.api.get<CreationObservation["sourceComments"]>(`/api/issues/${source.id}/comments?order=asc`) : [];
const replies = sourceComments.filter(row => row.authorAgentId === o.leadId && o.runs.some(run => run.id === row.createdByRunId));
const websiteFiles: CreationObservation["websiteFiles"] = [];
for (const saved of newTasks(o)) {
const attachments = await ctx.input.api.get<Attachment[]>(`/api/issues/${saved.id}/attachments`);
for (const file of attachments.filter(row => /\.html?$/i.test(row.originalFilename ?? row.filename ?? "") || row.contentType === "text/html").slice(0, 3)) {
if (file.byteSize !== undefined && file.byteSize > 1_048_576) continue;
const content = await ctx.input.api.getAttachmentContent(file.id);
const body = content.toString("utf8");
if (Buffer.byteLength(body) <= 1_048_576) websiteFiles.push({ issueId: saved.id, attachmentId: file.id, body,
sha256: createHash("sha256").update(body).digest("hex"), createdAt: file.createdAt });
}
}
return { ...o, source: source ?? null, replies, sourceComments, websiteFiles };
}
function creationDefinition(scenarioId: string): ChatCatalogCase {
let interception: Awaited<ReturnType<typeof dropChatSendAcknowledgement>> | undefined;
const base = makeDefinition(scenarioId, async ctx => {
const worker = await fixtureWorker(ctx); const priorTasks: Entity[] = [];
if (scenarioId !== "tasks.website-without-project") {
const p = await project(ctx, "Launch", { description: "Acorn Notes is a note-taking product for small research teams. The website should explain it and offer signup." });
if (scenarioId === "projects.project-work") {
priorTasks.push(await task(ctx, "Signup copy", p.id));
priorTasks.push(await task(ctx, "Product brief", p.id, { status: "done" }));
const other = await project(ctx, "Experiments"); priorTasks.push(await task(ctx, "Signup copy", other.id, { allowDuplicate: true }));
await verifyDistinctTaskFixtures(ctx, priorTasks);
}
}
if (scenarioId === "tasks.website-without-project") interception = await dropChatSendAcknowledgement(ctx.input.page, ctx.scenario.query);
return { worker, priorTasks };
}, gradeDelegatedCreation);
return { ...base, observe: observeCreation, sourceFiles: [...base.sourceFiles, "chat-catalog-domains/internal-task-creation.ts", "lost-send.ts"],
expectedRunCount: 3, minimumRunCount: scenarioId === "projects.project-work" ? 1 : 2,
runPolicy: { kind: "source-settled-with-active-work", maximumActiveWorkerRuns: 1 },
async act(ctx, state) {
if (scenarioId !== "tasks.website-without-project") return;
if (!interception) throw new Error("Lost acknowledgement fixture was not armed");
const sent = await interception.committed;
const first = await pollUntil({ label: "Committed project and task before lost-ack replay", deadlineAt: chatCatalogNativePhaseDeadline(ctx, Date.now() + 150_000),
load: () => observeCreation(ctx, state), accept: o => chatCatalogNativePhaseIsTimely(ctx) && newTasks(o).length === 1 && o.projects.filter(row => row.name === "Launch").length === 1
&& ctx.issue()?.conversationState === "waiting" });
await interception.dispose();
const replay = await ctx.input.api.post<{ id: string }>(sent.path, sent.data);
state.transport = { commentId: sent.commentId, clientRequestId: String(sent.data.clientRequestId), replayedCommentId: replay.id,
firstTaskId: newTasks(first)[0]!.id, firstProjectId: first.projects.find(row => row.name === "Launch")!.id };
await ctx.input.evidence("chat-catalog-lost-ack-transport.json", { fault: "server committed; browser acknowledgement reset", ...state.transport as object,
originalRequestBody: sent.data.body, retry: "Exact original production clientRequestId and request payload; no new human prompt." });
await ctx.input.page.reload({ waitUntil: "domcontentloaded" });
},
async cleanup() { await interception?.dispose(); interception = undefined; },
};
}
export const delegatedTaskCases: readonly ChatCatalogCase[] = [creationDefinition("tasks.website-task"), creationDefinition("tasks.website-without-project")];
export const projectWorkCases: readonly ChatCatalogCase[] = [creationDefinition("projects.project-work")];