mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-15 18:56:05 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
44 lines
4.1 KiB
TypeScript
44 lines
4.1 KiB
TypeScript
import type { Agent } from "../../../packages/shared/src/types/agent.js";
|
|
import type { BudgetOverview } from "../../../packages/shared/src/types/budget.js";
|
|
import type { HeartbeatRun } from "../../../packages/shared/src/types/heartbeat.js";
|
|
import { updateAgentPermissionsSchema } from "../../../packages/shared/src/validators/agent.js";
|
|
import type { ChatCatalogContext } from "../chat-catalog-contract.js";
|
|
import type { ChatRun } from "../chat-flow.js";
|
|
import { pollUntil } from "../api.js";
|
|
|
|
/** Use the permission-specific public route; ordinary agent updates reject permissions. */
|
|
export async function grantCaseTaskAssignment(ctx: ChatCatalogContext, agentId: string) {
|
|
const before = await ctx.input.api.get<Agent>(`/api/agents/${agentId}`);
|
|
if (before.id !== agentId || before.companyId !== ctx.input.fixtures.company.id) throw new Error("Case assignment prerequisite agent scope mismatch");
|
|
const permissions = updateAgentPermissionsSchema.parse({ ...before.permissions, canAssignTasks: true });
|
|
await ctx.input.api.patch(`/api/agents/${agentId}/permissions`, permissions);
|
|
const after = await ctx.input.api.get<Agent>(`/api/agents/${agentId}`);
|
|
if (after.id !== before.id || after.companyId !== before.companyId || !after.permissions.canAssignTasks
|
|
|| after.permissions.canCreateAgents !== before.permissions.canCreateAgents) throw new Error("Case assignment prerequisite public readback failed");
|
|
await ctx.input.evidence(`chat-case-assignment-${agentId}.json`, { agentId, companyId: before.companyId, beforePermissions: before.permissions, requestedPermissions: permissions, afterPermissions: after.permissions });
|
|
}
|
|
|
|
type CancellationIdentity = { companyId: string; agentId: string; issueId: string; runId: string };
|
|
type CancellationSnapshot = { run: Pick<HeartbeatRun, "id" | "companyId" | "agentId" | "issueId" | "status" | "finishedAt">; nativeRun: ChatRun | undefined; overview: BudgetOverview };
|
|
export function caseCancellationAccountingReady(expected: CancellationIdentity, value: CancellationSnapshot): boolean {
|
|
const { run, nativeRun, overview } = value;
|
|
if (run.id !== expected.runId || run.companyId !== expected.companyId || run.agentId !== expected.agentId || run.issueId !== expected.issueId
|
|
|| run.status !== "cancelled" || !run.finishedAt || nativeRun?.id !== run.id || nativeRun.companyId !== run.companyId
|
|
|| nativeRun.agentId !== run.agentId || nativeRun.runtimeMode !== "native" || nativeRun.status !== "cancelled"
|
|
|| nativeRun.contextSnapshot?.issueId !== expected.issueId || overview.companyId !== expected.companyId) return false;
|
|
const relevant = overview.policies.filter(policy => policy.isActive && (policy.scopeType === "company" && policy.scopeId === expected.companyId || policy.scopeType === "agent" && policy.scopeId === expected.agentId));
|
|
// Public pendingRunCount includes terminal runs awaiting final accounting. Both
|
|
// funded scopes must be observable; absence of policies is not readiness.
|
|
return ["company", "agent"].every(scope => relevant.some(policy => policy.scopeType === scope))
|
|
&& relevant.every(policy => policy.companyId === expected.companyId && policy.hardStopEnabled && policy.amount > 0
|
|
&& policy.unpricedUsagePolicy === "allow" && policy.pendingRunCount === 0 && policy.status !== "hard_stop" && !policy.paused && policy.remainingAmount > 0);
|
|
}
|
|
|
|
export async function waitCaseCancellationAccounting(ctx: ChatCatalogContext, expected: CancellationIdentity) {
|
|
const snapshot = await pollUntil({ label: "owned cancelled case prerequisite final accounting before canonical admission", deadlineAt: Date.now() + 60_000, intervalMs: 1000,
|
|
load: async (): Promise<CancellationSnapshot> => ({ run: await ctx.input.api.get<HeartbeatRun>(`/api/heartbeat-runs/${expected.runId}`),
|
|
nativeRun: (await ctx.allRuns()).find(run => run.id === expected.runId), overview: await ctx.input.api.get<BudgetOverview>(`/api/companies/${expected.companyId}/budgets/overview`) }),
|
|
accept: value => caseCancellationAccountingReady(expected, value) });
|
|
await ctx.input.evidence("chat-case-cancelled-prerequisite-accounting.json", { expected, ...snapshot });
|
|
}
|