mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-15 18:56:05 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
68 lines
6.2 KiB
TypeScript
68 lines
6.2 KiB
TypeScript
import { createHash, randomUUID } from "node:crypto";
|
|
import { lstat, readFile, realpath, rename, rm, writeFile } from "node:fs/promises";
|
|
import path from "node:path";
|
|
import { runnerE2EServerControlPaths } from "../harness-env.js";
|
|
import { readProcessTable, type ProcessObservation } from "../process-tree.js";
|
|
import { runnerE2ETypeScriptProcessArgs } from "../web-server-command.js";
|
|
import { invitationIncident, type InvitationRuntimeProof } from "./identity-invite-prerequisite.js";
|
|
const digest = (value: string | Buffer) => createHash("sha256").update(value).digest("hex");
|
|
export const invitationSourceProofPath = (root: string) => path.join(runnerE2EServerControlPaths(root).controlDirectory, "invitation-source-process.json");
|
|
interface SourceProof {
|
|
schema: "invitation-source-process.v1"; generation: string; attemptId: string; executionIds: string[]; apiOrigin: string;
|
|
sourceRoot: string; serverEntry: string; serverEntrySha256: string; redactorSha256: string;
|
|
argv: string[]; pid: number; parentPid: number; processStarted: string; spawnedAt: string;
|
|
}
|
|
interface Expected { temporaryRoot: string; sourceRoot: string; apiOrigin: string; attemptId: string; executionId: string }
|
|
async function sourceBytes(root: string) {
|
|
const serverEntry = await realpath(path.join(root, "server/src/index.ts"));
|
|
return { serverEntry, serverEntrySha256: digest(await readFile(serverEntry)),
|
|
redactorSha256: digest(await readFile(path.join(root, "server/src/middleware/redact-sensitive.ts"))) };
|
|
}
|
|
export function validateInvitationSourceProof(value: unknown, expected: Expected, bytes: Awaited<ReturnType<typeof sourceBytes>>,
|
|
process: ProcessObservation | undefined, health: { commit?: string | null; serverInfo?: { processStartedAt?: string } }, restartGeneration?: string): asserts value is SourceProof {
|
|
const p = value as SourceProof;
|
|
const boot = Date.parse(health.serverInfo?.processStartedAt ?? ""), spawn = Date.parse(p?.spawnedAt ?? "");
|
|
if (!expected.attemptId || !expected.executionId || !p || p.schema !== "invitation-source-process.v1" || !p.generation || restartGeneration !== undefined && p.generation !== restartGeneration || p.attemptId !== expected.attemptId
|
|
|| p.apiOrigin !== expected.apiOrigin || p.sourceRoot !== expected.sourceRoot || p.serverEntry !== bytes.serverEntry
|
|
|| p.serverEntrySha256 !== bytes.serverEntrySha256 || p.redactorSha256 !== bytes.redactorSha256
|
|
|| !Array.isArray(p.executionIds) || p.executionIds.length !== 1 || p.executionIds[0] !== expected.executionId
|
|
|| JSON.stringify(p.argv) !== JSON.stringify(runnerE2ETypeScriptProcessArgs(expected.sourceRoot, path.join(expected.sourceRoot, "tests/runner-e2e/server-entry.ts"), ["onboard", "--yes", "--run"]))
|
|
|| !process || process.pid !== p.pid || process.parentPid !== p.parentPid || process.started !== p.processStarted
|
|
|| !Number.isSafeInteger(p.pid) || p.pid <= 1 || p.parentPid <= 1 || !Number.isFinite(boot) || !Number.isFinite(spawn)
|
|
|| boot < spawn - 2000 || boot > Date.now() || spawn > Date.now()) throw new Error("Invitation source process proof is unqualified");
|
|
}
|
|
/** The supervisor alone writes this private receipt from its actual spawn. */
|
|
export async function publishInvitationSourceProof(input: Omit<Expected, "executionId"> & { executionIds: string[]; pid: number; argv: string[]; spawnedAt: string }) {
|
|
const filename = invitationSourceProofPath(input.temporaryRoot);
|
|
await rm(filename, { force: true });
|
|
const processes = await readProcessTable(); const process = processes?.find(row => row.pid === input.pid);
|
|
if (!process) return;
|
|
const sourceRoot = await realpath(input.sourceRoot); const bytes = await sourceBytes(sourceRoot);
|
|
const receipt: SourceProof = { schema: "invitation-source-process.v1", generation: randomUUID(), attemptId: input.attemptId,
|
|
executionIds: input.executionIds, apiOrigin: input.apiOrigin, sourceRoot, ...bytes, argv: input.argv, pid: process.pid,
|
|
parentPid: process.parentPid, processStarted: process.started, spawnedAt: input.spawnedAt };
|
|
const temporary = `${filename}.${randomUUID()}.tmp`;
|
|
try { await writeFile(temporary, JSON.stringify(receipt), { mode: 0o600 }); await rename(temporary, filename); }
|
|
finally { await rm(temporary, { force: true }); }
|
|
return receipt.generation;
|
|
}
|
|
/** Every enrollment re-reads the current generation, process and source bytes. */
|
|
export async function verifyInvitationSourceProof(input: Expected & { health(): Promise<{ commit?: string | null; serverInfo?: { processStartedAt?: string } }> }): Promise<InvitationRuntimeProof> {
|
|
const filename = invitationSourceProofPath(input.temporaryRoot); const metadata = await lstat(filename);
|
|
if (!metadata.isFile() || metadata.isSymbolicLink() || metadata.mode & 0o077 || process.getuid && metadata.uid !== process.getuid()) throw new Error("Invitation source proof custody is invalid");
|
|
const encoded = await readFile(filename); const value = JSON.parse(encoded.toString("utf8")) as unknown;
|
|
const sourceRoot = await realpath(input.sourceRoot); const bytes = await sourceBytes(sourceRoot);
|
|
const table = await readProcessTable(); const health = await input.health();
|
|
let restartGeneration: string | undefined;
|
|
try {
|
|
const ack = JSON.parse(await readFile(runnerE2EServerControlPaths(input.temporaryRoot).restartAcknowledgementPath, "utf8")) as { status?: string; invitationSourceGeneration?: string };
|
|
if (ack.status !== "ready" || !ack.invitationSourceGeneration) throw new Error("Invitation restart proof is unqualified");
|
|
restartGeneration = ack.invitationSourceGeneration;
|
|
} catch (error) { if ((error as NodeJS.ErrnoException).code !== "ENOENT") throw error; }
|
|
validateInvitationSourceProof(value, { ...input, sourceRoot }, bytes, table?.find(row => row.pid === (value as SourceProof)?.pid), health, restartGeneration);
|
|
if (digest(await readFile(filename)) !== digest(encoded)) throw new Error("Invitation source proof changed during verification");
|
|
return { apiOrigin: value.apiOrigin, processStartedAt: health.serverInfo!.processStartedAt!, healthCommit: health.commit ?? null,
|
|
redactorSha256: value.redactorSha256, serverEntrySha256: value.serverEntrySha256,
|
|
supervisorReceiptSha256: digest(encoded), priorProofSha256: invitationIncident.priorProofSha256 };
|
|
}
|