mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-14 00:26:28 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat-feature evals measure whether agents complete real chat requests through the product > - The chat catalog eval harness and its repairs live on the `chat-eval/master-candidate` branch, not on master > - Today's work made 139 of 242 chat evals pass in verified single-case live runs. Each product fix landed on master as its own pull request > - The eval-side changes (setups, graders, fault seams, evidence capture) still exist only on the candidate > - This pull request lands the harness on master. Master stays the source of truth for product behavior > - The benefit is one tree: evals run against master commits, and product fixes reach the evals as soon as they merge ## Linked Issues or Issue Description Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs #20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409 **What existing behavior does this improve?** The chat catalog eval harness and the product it evaluates live on a long-running branch outside master. Eval fixes do not reach master, so master-based eval runs use old setups and graders. **Subsystem affected** `tests/runner-e2e` chat catalog harness, plus a small set of product changes that exist only on the candidate. **Proposed change** Land the harness on master. Every product fix from this eval work already merged to master as its own pull request. Conflicts keep master's product behavior. ## What Changed - Most of the diff (808 of 851 files) is under `tests/runner-e2e/`: chat-catalog domains, scenarios, descriptors, the TestOps manifest, private evidence tooling, and their tests. - Graders now check saved state, setup literals and rendered or clicked links. Many keyword and regex checks on free-form replies are removed. Each changed grader has a bumped `oracleVersion` and calibration tests (a valid reply, a reworded valid reply, and broken variants that must fail). - The shared link helper `hasLink` no longer treats a list link (for example `/COM/issues?view=mine`) as a link to every task without a URL key. - Setup fixes build real state through supported product routes: routine history, agent grants through the board grant route, budget holds with a real cap, and a storage-layer archive fault for `inbox-search.archive-partial-failure`. - Browser boundary journeys (sign-in, chat-disabled, onboarding) now write the standard pass evidence files. - Retargeted cases, approved by the maintainer: `agent-chat.chat-disabled` (Conference Room gate), `agents.restore-instructions` (no saved instruction history), `access.manage-membership` (member permission edits stay board-only). - The private evidence trusted files (`manual-private-handoff.ts`, `manual-private-retention.ts`, `manual-private-report-assets.ts`) are byte-identical to master. - Product files outside `tests/` (43 files, +1,328 −49) carry candidate-only changes that master does not yet have. Most are tests. The main code changes are in `request-human-input.ts`, `heartbeat-run-summary.ts`, `native-completion-feedback.ts`, `native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and `IssueChatLongThreadPerf.tsx`. ## Verification - `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts chat-catalog-consistency.test.ts unit-launcher.test.mjs --testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests pass. - `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`: no change. - `tsc` for `server` and `tests/runner-e2e`: clean. - Live single-case verification: 139 of 242 cases passed on paid runs, and a person read the saved evidence for each. These are single-case runs, not one full-cohort run. ## Risks - Large diff. Most of it is test-only, but the 43 non-test files change product code paths. Review those files first. - Some graders are now less strict on reply wording. A person must read replies for meaning on those cases. - 42 cases need disposable outside accounts (Notion, Slack, GitHub, Daytona and others) and stay blocked. `access.invite-teammate` stays failing until local agent isolation lands, because the runner's durable state keeps a live invite token. - The paid workflow compares the trusted private-evidence files with master. They are unchanged, so this risk is low. ## Model Used Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code execution, in Claude Code. Subagents used the same model. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
242 lines
11 KiB
TypeScript
242 lines
11 KiB
TypeScript
import { writeFile, rm } from "node:fs/promises";
|
|
import path from "node:path";
|
|
import { isDeepStrictEqual } from "node:util";
|
|
import { createHash } from "node:crypto";
|
|
import type { ChatCatalogContext } from "../chat-catalog-contract.js";
|
|
import type {
|
|
PaperclipPluginManifestV1,
|
|
PluginRecord,
|
|
} from "../../../packages/shared/src/types/plugin.js";
|
|
import { pollUntil } from "../api.js";
|
|
import { createPreviewFixture } from "./external-plugin-fixture.js";
|
|
import { identityWorker } from "./identity-support.js";
|
|
export interface CustodyReceipt {
|
|
companyId: string;
|
|
agentId: string;
|
|
operationId: string;
|
|
version: number;
|
|
phase: string;
|
|
hadOwnedSecret: boolean;
|
|
returnedOwnedSecret: boolean;
|
|
}
|
|
export interface CustodyState {
|
|
ownerAgentId: string;
|
|
receipts: CustodyReceipt[];
|
|
}
|
|
export function custodyManifest(key: string): PaperclipPluginManifestV1 {
|
|
return {
|
|
id: key,
|
|
apiVersion: 1,
|
|
version: "0.1.0",
|
|
displayName: "Owned instance custody fixture",
|
|
description: "Disposable agent lifecycle custody boundary",
|
|
author: "Paperclip evaluation fixture",
|
|
categories: ["automation"],
|
|
capabilities: ["agents.lifecycle.manage", "api.routes.register"],
|
|
agentLifecycle: true,
|
|
entrypoints: { worker: "./dist/worker.js" },
|
|
apiRoutes: [
|
|
{
|
|
routeKey: "custody",
|
|
method: "GET",
|
|
path: "/custody",
|
|
auth: "board",
|
|
capability: "api.routes.register",
|
|
companyResolution: { from: "query", key: "companyId" },
|
|
},
|
|
{
|
|
routeKey: "release",
|
|
method: "POST",
|
|
path: "/release",
|
|
auth: "board",
|
|
capability: "api.routes.register",
|
|
companyResolution: { from: "query", key: "companyId" },
|
|
},
|
|
],
|
|
};
|
|
}
|
|
export function custodyRoundtrip(
|
|
input: unknown,
|
|
companyId: string,
|
|
agentId: string,
|
|
resumeOperationId: string,
|
|
version: number,
|
|
) {
|
|
const value = input as Partial<CustodyState> | undefined;
|
|
return (
|
|
!!value &&
|
|
value.ownerAgentId === agentId &&
|
|
Array.isArray(value.receipts) &&
|
|
value.receipts.some(
|
|
(row) =>
|
|
row?.companyId === companyId &&
|
|
row.agentId === agentId &&
|
|
row.phase === "preparing" &&
|
|
row.hadOwnedSecret === false &&
|
|
row.returnedOwnedSecret === true,
|
|
) &&
|
|
value.receipts.some(
|
|
(row) =>
|
|
row?.companyId === companyId &&
|
|
row.agentId === agentId &&
|
|
row.phase === "resuming" &&
|
|
row.operationId === resumeOperationId &&
|
|
row.version === version &&
|
|
row.hadOwnedSecret === true &&
|
|
row.returnedOwnedSecret === false,
|
|
)
|
|
);
|
|
}
|
|
export interface PublicCustodyAgent {
|
|
id: string;
|
|
companyId: string;
|
|
lifecycleState: string;
|
|
lifecycleVersion?: number;
|
|
lifecycleError?: string | null;
|
|
}
|
|
export function publicResumeCustodyReceipt(input: {
|
|
companyId: string; agentId: string; paused: PublicCustodyAgent;
|
|
resumed: PublicCustodyAgent; ready: PublicCustodyAgent;
|
|
before: CustodyState; after: CustodyState;
|
|
}): CustodyReceipt | undefined {
|
|
const { companyId, agentId, paused, resumed, ready, before, after } = input;
|
|
const sameAgent = (agent: PublicCustodyAgent) => agent?.id === agentId && agent.companyId === companyId && !agent.lifecycleError;
|
|
if (!sameAgent(paused) || !sameAgent(resumed) || !sameAgent(ready)
|
|
|| paused.lifecycleState !== "paused" || !Number.isSafeInteger(paused.lifecycleVersion) || paused.lifecycleVersion! < 1 || !Number.isSafeInteger(paused.lifecycleVersion! + 2)) return;
|
|
const version = paused.lifecycleVersion! + 1;
|
|
if (!(resumed.lifecycleState === "resuming" && resumed.lifecycleVersion === version
|
|
|| resumed.lifecycleState === "ready" && resumed.lifecycleVersion === version + 1)
|
|
|| ready.lifecycleState !== "ready" || ready.lifecycleVersion !== version + 1
|
|
|| before?.ownerAgentId !== agentId || after?.ownerAgentId !== agentId
|
|
|| !Array.isArray(before.receipts) || !Array.isArray(after.receipts)
|
|
|| !isDeepStrictEqual(after.receipts.slice(0, before.receipts.length), before.receipts)
|
|
|| after.receipts.some(row => !row || row.companyId !== companyId)) return;
|
|
const priorOperations = new Set(before.receipts.map(row => row.operationId));
|
|
const receipts = after.receipts.filter(row => row.agentId === agentId && row.phase === "resuming" && !priorOperations.has(row.operationId));
|
|
if (!receipts.length || receipts.some(row => typeof row.operationId !== "string" || !row.operationId
|
|
|| row.version !== version || row.hadOwnedSecret !== true || row.returnedOwnedSecret !== false)
|
|
|| new Set(receipts.map(row => row.operationId)).size !== 1) return;
|
|
const receipt = receipts[0]!;
|
|
if (!custodyRoundtrip(after, companyId, agentId, receipt.operationId, receipt.version)) return;
|
|
return receipt;
|
|
}
|
|
/** Vetted synthetic plugin uses the supported lifecycle result, not a private
|
|
* secret-service write. Its public receipt exposes identities and booleans only. */
|
|
export async function createInstanceCustody(
|
|
ctx: ChatCatalogContext,
|
|
value: string,
|
|
) {
|
|
const scaffold = await createPreviewFixture(ctx),
|
|
seed = path.join(scaffold.packageRoot, "custody-input.private");
|
|
let installedId: string | undefined, ownerAgentId: string | undefined;
|
|
const apiPath = (route: string) =>
|
|
`/api/plugins/${installedId}/api/${route}?companyId=${ctx.input.fixtures.company.id}`;
|
|
async function read() {
|
|
return ctx.input.api.get<CustodyState>(apiPath("custody"));
|
|
}
|
|
async function lifecycle(agentId: string, expected: string) {
|
|
return pollUntil({
|
|
label: `owned custody lifecycle ${expected}`,
|
|
deadlineAt: Date.now() + 90000,
|
|
intervalMs: 500,
|
|
load: () =>
|
|
ctx.input.api.get<PublicCustodyAgent>(`/api/agents/${agentId}`),
|
|
accept: (row) => row.lifecycleState === expected,
|
|
reject: (row) =>
|
|
row.lifecycleError
|
|
? "Owned custody lifecycle failed; diagnostic withheld"
|
|
: undefined,
|
|
});
|
|
}
|
|
async function close() {
|
|
try {
|
|
if (installedId && ownerAgentId) {
|
|
await ctx.input.api.post(apiPath("release"), {});
|
|
await ctx.input.api.post(`/api/agents/${ownerAgentId}/pause`);
|
|
await lifecycle(ownerAgentId, "paused");
|
|
}
|
|
if (installedId)
|
|
await ctx.input.api.delete(`/api/plugins/${installedId}`, {
|
|
allowNotFound: true,
|
|
});
|
|
} finally {
|
|
await scaffold.close();
|
|
}
|
|
}
|
|
try {
|
|
await writeFile(seed, value, { mode: 0o600 });
|
|
const manifest = custodyManifest(scaffold.key),
|
|
sdk = new URL(
|
|
"../../../packages/plugins/sdk/dist/index.js",
|
|
import.meta.url,
|
|
).href;
|
|
const worker = `import {definePlugin,runWorker} from ${JSON.stringify(sdk)};import {readFile} from 'node:fs/promises';const expected=await readFile(${JSON.stringify(seed)},'utf8');const company=${JSON.stringify(ctx.input.fixtures.company.id)},receipts=[];let ownerAgentId='',release=false;const plugin=definePlugin({async setup(){},async onHealth(){return {status:'ok'}},async onAgentLifecycle(input){if(input.companyId!==company)return {operationId:input.operationId,version:input.version,status:'complete'};if(!ownerAgentId&&input.phase==='preparing')ownerAgentId=input.agentId;const owned=input.agentId===ownerAgentId,hadOwnedSecret=input.instanceSecrets?.custody_probe===expected,returnedOwnedSecret=owned&&input.phase==='preparing';if(receipts.length>=64)throw new Error('Owned lifecycle receipt bound exceeded');receipts.push({companyId:input.companyId,agentId:input.agentId,operationId:input.operationId,version:input.version,phase:input.phase,hadOwnedSecret,returnedOwnedSecret});return {operationId:input.operationId,version:input.version,status:'complete',...(owned&&release?{instanceSecrets:{custody_probe:null}}:returnedOwnedSecret?{instanceSecrets:{custody_probe:expected}}:{})};},async onApiRequest(input){if(input.companyId!==company||input.actor.actorType!=='user')throw new Error('Owned custody board scope required');if(input.routeKey==='release'&&input.method==='POST')release=true;return {body:{ownerAgentId,receipts}}}});export default plugin;runWorker(plugin,import.meta.url);\n`;
|
|
await writeFile(
|
|
path.join(scaffold.packageRoot, "dist/manifest.js"),
|
|
`export default ${JSON.stringify(manifest)};\n`,
|
|
);
|
|
await writeFile(path.join(scaffold.packageRoot, "dist/worker.js"), worker);
|
|
await ctx.input.evidence("chat-catalog-owned-custody-package.json", {
|
|
synthetic: true,
|
|
manifestSha256: createHash("sha256")
|
|
.update(JSON.stringify(manifest))
|
|
.digest("hex"),
|
|
workerSha256: createHash("sha256").update(worker).digest("hex"),
|
|
operatorChannel: "public-board-local-package-install",
|
|
});
|
|
const installed = await ctx.input.api.post<PluginRecord>(
|
|
"/api/plugins/install",
|
|
{ packageName: scaffold.packageRoot, isLocalPath: true },
|
|
);
|
|
installedId = installed.id;
|
|
await pollUntil({
|
|
label: "owned custody real plugin admission",
|
|
deadlineAt: Date.now() + 45000,
|
|
intervalMs: 500,
|
|
load: () =>
|
|
ctx.input.api.get<PluginRecord>(`/api/plugins/${installed.id}`),
|
|
accept: (row) => row.status === "ready",
|
|
reject: (row) =>
|
|
row.status === "error"
|
|
? "Owned custody package admission failed; detail withheld"
|
|
: undefined,
|
|
});
|
|
const riley = await identityWorker(ctx, "Riley");
|
|
ownerAgentId = riley.id;
|
|
await lifecycle(riley.id, "ready");
|
|
await ctx.input.api.post(`/api/agents/${riley.id}/pause`);
|
|
const paused = await lifecycle(riley.id, "paused");
|
|
const before = await read();
|
|
const resumeDeadlineAt = Date.now() + 90000;
|
|
const resumed = await ctx.input.api.post<PublicCustodyAgent>(`/api/agents/${riley.id}/resume`);
|
|
const observed = await pollUntil({
|
|
label: "owned custody public resume and real operation receipt",
|
|
deadlineAt: resumeDeadlineAt,
|
|
intervalMs: 500,
|
|
load: async () => {
|
|
const [ready, after] = await Promise.all([
|
|
ctx.input.api.get<PublicCustodyAgent>(`/api/agents/${riley.id}`), read(),
|
|
]);
|
|
return { ready, after };
|
|
},
|
|
accept: ({ ready, after }) => Date.now() < resumeDeadlineAt && !!publicResumeCustodyReceipt({ companyId: ctx.input.fixtures.company.id, agentId: riley.id, paused, resumed, ready, before, after }),
|
|
reject: ({ ready }) => ready.lifecycleError ? "Owned custody resume failed; diagnostic withheld" : undefined,
|
|
});
|
|
const receipt = publicResumeCustodyReceipt({ companyId: ctx.input.fixtures.company.id, agentId: riley.id, paused, resumed, ...observed, before });
|
|
if (Date.now() >= resumeDeadlineAt || !receipt) throw new Error("Actual public resume custody receipt is missing, late or unqualified");
|
|
await rm(seed, { force: true });
|
|
return {
|
|
pluginId: installed.id,
|
|
rileyId: riley.id,
|
|
resumeOperationId: receipt.operationId,
|
|
resumeVersion: receipt.version,
|
|
seedRemoved: true as const,
|
|
read,
|
|
close,
|
|
};
|
|
} catch (error) {
|
|
await close();
|
|
throw error;
|
|
}
|
|
}
|