mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-21 00:05:49 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The issue detail surface includes an Issue Properties pane that shows live metadata for a selected issue. > - Watchdog configuration can be changed from that pane, but cached issue detail data also feeds the pane key and rerender behavior. > - If the cache does not reflect watchdog changes immediately, the properties pane can keep stale watchdog state until a later refetch completes. > - This pull request updates the watchdog save/delete paths to write the returned watchdog state into cached issue detail data. > - It also includes watchdog fields in the issue properties panel key so watchdog configuration changes invalidate the memoized panel state. > - The benefit is a properties pane that updates consistently after operators set or remove a watchdog. ## Linked Issues or Issue Description Refs #8789 This PR fixes stale watchdog state in the Issue Properties pane after watchdog save/delete mutations. ## What Changed - Write the saved watchdog summary into cached issue detail data after a successful watchdog upsert using the exact `queryKeys.issues.detail(issue.id)` key. - Clear cached issue detail watchdog data after a successful watchdog delete using the exact `queryKeys.issues.detail(issue.id)` key. - Include stable watchdog fields in `buildIssuePropertiesPanelKey` so watchdog configuration changes produce a new panel key. - Add focused tests for watchdog cache updates and panel-key invalidation, including save and delete cache assertions. ## Verification - `pnpm --filter @paperclipai/ui exec vitest run src/components/IssueProperties.test.tsx src/lib/issue-properties-panel-key.test.ts` - Result: 2 files passed, 40 tests passed. ## Risks Low risk. The change is scoped to UI cache handling for issue detail watchdog state and panel-key generation. The main risk is an unexpected query-cache shape, covered by focused tests around the existing issue detail query key. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used OpenAI Codex coding agent running GPT-5-class model with repository tool use and local command execution. The exact backend model identifier and context window are not exposed in this runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
122 lines
3.8 KiB
TypeScript
122 lines
3.8 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import type { Issue } from "@paperclipai/shared";
|
|
import { buildIssuePropertiesPanelKey } from "./issue-properties-panel-key";
|
|
|
|
function createIssue(overrides: Partial<Issue> = {}) {
|
|
return {
|
|
id: "issue-1",
|
|
status: "in_progress" as const,
|
|
priority: "medium" as const,
|
|
assigneeAgentId: "agent-1",
|
|
assigneeUserId: null,
|
|
projectId: "project-1",
|
|
projectWorkspaceId: null,
|
|
parentId: null,
|
|
createdByUserId: "user-1",
|
|
hiddenAt: null,
|
|
labelIds: ["label-1"],
|
|
executionPolicy: null,
|
|
executionState: null,
|
|
executionWorkspaceId: null,
|
|
executionWorkspacePreference: null,
|
|
executionWorkspaceSettings: null,
|
|
currentExecutionWorkspace: null,
|
|
blocks: [],
|
|
blockedBy: [],
|
|
ancestors: [],
|
|
updatedAt: new Date("2026-04-12T12:00:00.000Z"),
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
describe("buildIssuePropertiesPanelKey", () => {
|
|
it("ignores plain updatedAt churn", () => {
|
|
const first = buildIssuePropertiesPanelKey(createIssue(), []);
|
|
const second = buildIssuePropertiesPanelKey(
|
|
createIssue({ updatedAt: new Date("2026-04-12T12:05:00.000Z") }),
|
|
[],
|
|
);
|
|
|
|
expect(second).toBe(first);
|
|
});
|
|
|
|
it("changes when a displayed property changes", () => {
|
|
const first = buildIssuePropertiesPanelKey(createIssue(), []);
|
|
const second = buildIssuePropertiesPanelKey(
|
|
createIssue({ assigneeAgentId: "agent-2" }),
|
|
[],
|
|
);
|
|
|
|
expect(second).not.toBe(first);
|
|
});
|
|
|
|
it("changes when watchdog configuration changes", () => {
|
|
const first = buildIssuePropertiesPanelKey(createIssue({ watchdog: null }), []);
|
|
const second = buildIssuePropertiesPanelKey(
|
|
createIssue({
|
|
watchdog: {
|
|
id: "watchdog-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
watchdogAgentId: "agent-1",
|
|
instructions: "Keep the tree moving.",
|
|
status: "active",
|
|
watchdogIssueId: null,
|
|
lastObservedFingerprint: null,
|
|
lastReviewedFingerprint: null,
|
|
lastTriggeredAt: null,
|
|
lastCompletedAt: null,
|
|
triggerCount: 0,
|
|
createdAt: new Date("2026-04-12T12:01:00.000Z"),
|
|
updatedAt: new Date("2026-04-12T12:01:00.000Z"),
|
|
},
|
|
}),
|
|
[],
|
|
);
|
|
|
|
expect(second).not.toBe(first);
|
|
});
|
|
|
|
it("changes when workspace detail hydrates after opening from a cached issue", () => {
|
|
const first = buildIssuePropertiesPanelKey(createIssue(), []);
|
|
const second = buildIssuePropertiesPanelKey(
|
|
createIssue({
|
|
executionWorkspaceId: "workspace-1",
|
|
executionWorkspacePreference: "reuse_existing",
|
|
executionWorkspaceSettings: { mode: "isolated_workspace" },
|
|
currentExecutionWorkspace: {
|
|
id: "workspace-1",
|
|
companyId: "company-1",
|
|
projectId: "project-1",
|
|
projectWorkspaceId: "project-workspace-1",
|
|
sourceIssueId: "issue-1",
|
|
mode: "isolated_workspace",
|
|
strategyType: "git_worktree",
|
|
name: "PAP-1 workspace",
|
|
status: "active",
|
|
cwd: "/tmp/paperclip/PAP-1",
|
|
repoUrl: null,
|
|
baseRef: "master",
|
|
branchName: "PAP-1-workspace",
|
|
providerType: "git_worktree",
|
|
providerRef: "/tmp/paperclip/PAP-1",
|
|
derivedFromExecutionWorkspaceId: null,
|
|
lastUsedAt: new Date("2026-04-12T12:01:00.000Z"),
|
|
openedAt: new Date("2026-04-12T12:01:00.000Z"),
|
|
closedAt: null,
|
|
cleanupEligibleAt: null,
|
|
cleanupReason: null,
|
|
config: null,
|
|
metadata: null,
|
|
runtimeServices: [],
|
|
createdAt: new Date("2026-04-12T12:01:00.000Z"),
|
|
updatedAt: new Date("2026-04-12T12:01:00.000Z"),
|
|
},
|
|
}),
|
|
[],
|
|
);
|
|
|
|
expect(second).not.toBe(first);
|
|
});
|
|
});
|