mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-17 01:25:26 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Cloud owns human identity and passes a verified identity to each tenant. > - The tenant can report no session while the Cloud session is still valid. > - The access gate and direct `/auth` route then show the instance password form. > - This pull request sends those users through the configured Cloud entry endpoint. > - Cloud can renew the tenant session or show its login page, then return to the original task. ## Linked Issues or Issue Description **What happened?** A Cloud tenant can display the self-hosted email/password form after an instance session check returns no session. This gives Cloud users the wrong login method. **Expected behavior** An active Cloud session renews tenant access automatically. A signed-out user signs in through Cloud. Staging and production use their own configured Cloud origins. Self-hosted instances keep their instance login form. **Steps to reproduce** 1. Open a Cloud tenant task or an `/auth?next=...` link. 2. Keep the Cloud session active but make the instance session check return 401. 3. Observe the instance password form instead of Cloud session recovery. **Deployment mode** Cloud-managed authenticated instances. No database or server API changes. Searched related authentication PRs. Native self-hosted OIDC support in #10411 is a separate feature; this change uses the existing Cloud entry contract. ## What Changed - Wait for deployment metadata before showing an instance login form. - Use the health response's Cloud origin and stack slug for session recovery. - Preserve the tenant path, query, and fragment. Reject external and recursive login return targets. - Limit automatic recovery per tab. Show a manual Cloud retry after failed recovery. Show service failures as errors. - Keep self-hosted login and local trusted access. Add focused tests, browser regressions, deployment documentation, and an unavailable-state design example. ## Verification - `pnpm -r typecheck` and `pnpm build` passed. - UI typecheck and `pnpm check:token-gates` passed after the final UI edits. - All UI tests passed: 639 files, 6,777 tests. - 63 focused Vitest tests passed across Auth, CloudAccessGate, Cloud links, and recovery coordination. - `pnpm exec playwright test --config tests/e2e/playwright.config.ts tests/e2e/cloud-auth.spec.ts`: 5 passed. The tests use the real tenant UI and database with a simulated Cloud HTTP endpoint. They cover both Cloud origins, direct auth/task links, no password-form flash, preserved URLs, reload, and self-hosted login. - Hands-on browser test used the real Cloud gateway and a fresh tenant build with disposable local data. Active Cloud session plus a forced missing instance session returned to the task. An expired tenant cookie also renewed automatically and returned to the task. Removing both sessions reached the real Cloud email/social login UI. Persistent failure stopped at the retry screen; retry succeeded after removing the injected fault. The fixture used a loopback transport adapter and a simulated signed-out OIDC issuer. No production session or deployment was changed. - The default local browser startup hit the host's embedded PostgreSQL resource limit. The passing run used a separate disposable database on the test PostgreSQL process. - The full local `pnpm test:run` sweep was stopped after about 31 minutes once CI completed the full suite. It had reported 33 failures in the unchanged runner API unit/integration files; both files pass in isolation (1,749 + 28 tests). The local sweep did not reach the later workspace/serialized groups. CI completed all of those groups successfully. - Greptile reviewed commit `d603fd4e39455de44da9dae81b72197096c0e1e8` at 5/5 with its only thread resolved. All CI gates are green on this commit, including all general/serialized server groups, workspace tests, Runner checks, typecheck, build, and all eight browser shards ([run](https://github.com/paperclipai/paperclip/actions/runs/36446230697)). ## Risks - Recovery depends on valid Cloud origin and stack metadata. Incomplete metadata shows an unavailable message instead of a password form. - Browsers with session storage disabled use the manual Cloud link, since automatic retries cannot be bounded across documents. - The external identity provider's email/social login was not completed in this local test. Existing Cloud authentication owns that flow. - No migration, credential format, membership rule, or production deployment changes. ## Model Used OpenAI GPT-6 through Codex. The exact served variant and context-window limit are not exposed in this session. Used reasoning, repository tools, code execution, and browser testing. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
230 lines
8.8 KiB
TypeScript
230 lines
8.8 KiB
TypeScript
import { useEffect, useMemo, useState } from "react";
|
|
import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
|
|
import { useNavigate, useSearchParams } from "@/lib/router";
|
|
import { authApi } from "../api/auth";
|
|
import { healthApi } from "../api/health";
|
|
import { CloudSignIn } from "@/components/CloudSignIn";
|
|
import { clearCloudSignInAttempt } from "@/lib/cloud-sign-in";
|
|
import { tenantSignInReturnPath } from "@/lib/cloudLinks";
|
|
import { queryKeys } from "../lib/queryKeys";
|
|
import { getRememberedInvitePath } from "../lib/invite-memory";
|
|
import { Button } from "@/components/ui/button";
|
|
import { AsciiArtAnimation } from "@/components/AsciiArtAnimation";
|
|
import { PaperclipLoading } from "@/components/AnimatedPaperclipIcon";
|
|
import { ThemeToggle } from "@/components/ThemeToggle";
|
|
import { PaperclipLockup } from "../components/PaperclipLockup";
|
|
|
|
type AuthMode = "sign_in" | "sign_up";
|
|
|
|
export function AuthPage() {
|
|
const queryClient = useQueryClient();
|
|
const navigate = useNavigate();
|
|
const [searchParams] = useSearchParams();
|
|
const [mode, setMode] = useState<AuthMode>("sign_in");
|
|
const [name, setName] = useState("");
|
|
const [email, setEmail] = useState("");
|
|
const [password, setPassword] = useState("");
|
|
const [error, setError] = useState<string | null>(null);
|
|
const errorId = "auth-error";
|
|
|
|
const nextPath = useMemo(
|
|
() => tenantSignInReturnPath(searchParams.get("next") || getRememberedInvitePath() || "/"),
|
|
[searchParams],
|
|
);
|
|
const healthQuery = useQuery({
|
|
queryKey: queryKeys.health,
|
|
queryFn: () => healthApi.get(),
|
|
retry: false,
|
|
});
|
|
const { data: session, isLoading: isSessionLoading, error: sessionError } = useQuery({
|
|
queryKey: queryKeys.auth.session,
|
|
queryFn: () => authApi.getSession(),
|
|
retry: false,
|
|
});
|
|
|
|
useEffect(() => {
|
|
if (session) {
|
|
clearCloudSignInAttempt();
|
|
navigate(nextPath, { replace: true });
|
|
}
|
|
}, [session, navigate, nextPath]);
|
|
|
|
const mutation = useMutation({
|
|
mutationFn: async () => {
|
|
if (mode === "sign_in") {
|
|
await authApi.signInEmail({ email: email.trim(), password });
|
|
return;
|
|
}
|
|
await authApi.signUpEmail({
|
|
name: name.trim(),
|
|
email: email.trim(),
|
|
password,
|
|
});
|
|
},
|
|
onSuccess: async () => {
|
|
setError(null);
|
|
await queryClient.invalidateQueries({ queryKey: queryKeys.auth.session });
|
|
await queryClient.invalidateQueries({ queryKey: queryKeys.health });
|
|
// Reset rather than invalidate: the `["companies"]` entry is shared app-wide and
|
|
// is not account-scoped, so invalidating leaves the previous account's list
|
|
// readable (and any fetch for that session in flight) until the refetch lands.
|
|
// Sign-in can change accounts, so drop the list outright.
|
|
await queryClient.resetQueries({ queryKey: queryKeys.companies.all });
|
|
navigate(nextPath, { replace: true });
|
|
},
|
|
onError: (err) => {
|
|
setError(err instanceof Error ? err.message : "Authentication failed");
|
|
},
|
|
});
|
|
|
|
const canSubmit =
|
|
email.trim().length > 0 &&
|
|
password.trim().length > 0 &&
|
|
(mode === "sign_in" || (name.trim().length > 0 && password.trim().length >= 8));
|
|
|
|
if (healthQuery.isLoading || isSessionLoading || session) {
|
|
return (
|
|
<div className="fixed inset-0 flex items-center justify-center">
|
|
<PaperclipLoading className="min-h-0" />
|
|
</div>
|
|
);
|
|
}
|
|
|
|
// A health/session failure must not be mistaken for a self-hosted instance.
|
|
if (healthQuery.error || sessionError) {
|
|
return <p role="alert" className="p-6 text-sm text-destructive">Unable to check sign-in. Refresh and try again.</p>;
|
|
}
|
|
|
|
if (healthQuery.data?.cloud) {
|
|
return <CloudSignIn cloud={healthQuery.data.cloud} returnTo={nextPath} />;
|
|
}
|
|
|
|
return (
|
|
<div className="fixed inset-0 flex bg-background">
|
|
<div className="absolute top-4 right-4 z-10">
|
|
<ThemeToggle />
|
|
</div>
|
|
{/* Left half — form */}
|
|
<div className="w-full md:w-1/2 flex flex-col overflow-y-auto">
|
|
<div className="w-full max-w-md mx-auto my-auto px-8 py-12">
|
|
<div className="mb-8">
|
|
<PaperclipLockup className="h-5 w-auto" />
|
|
</div>
|
|
|
|
<h1 className="text-xl font-semibold">
|
|
{mode === "sign_in" ? "Sign in to Paperclip" : "Create your Paperclip account"}
|
|
</h1>
|
|
<p className="mt-1 text-sm text-muted-foreground">
|
|
{mode === "sign_in"
|
|
? "Use your email and password to access this instance."
|
|
: "Create an account for this instance. Email confirmation is not required in v1."}
|
|
</p>
|
|
|
|
<form
|
|
className="mt-6 space-y-4"
|
|
method="post"
|
|
action={mode === "sign_up" ? "/api/auth/sign-up/email" : "/api/auth/sign-in/email"}
|
|
onSubmit={(event) => {
|
|
event.preventDefault();
|
|
if (mutation.isPending) return;
|
|
if (!canSubmit) {
|
|
setError("Please fill in all required fields.");
|
|
return;
|
|
}
|
|
mutation.mutate();
|
|
}}
|
|
>
|
|
{mode === "sign_up" && (
|
|
<div>
|
|
<label htmlFor="name" className="text-xs text-muted-foreground mb-1 block">Name</label>
|
|
<input
|
|
id="name"
|
|
name="name"
|
|
className="w-full rounded-md border border-border bg-transparent px-3 py-2 text-sm outline-none focus:ring-1 focus:ring-ring placeholder:text-muted-foreground/50"
|
|
value={name}
|
|
onChange={(event) => setName(event.target.value)}
|
|
autoComplete="name"
|
|
required
|
|
aria-required="true"
|
|
aria-invalid={error ? true : undefined}
|
|
aria-describedby={error ? errorId : undefined}
|
|
autoFocus
|
|
/>
|
|
</div>
|
|
)}
|
|
<div>
|
|
<label htmlFor="email" className="text-xs text-muted-foreground mb-1 block">Email</label>
|
|
<input
|
|
id="email"
|
|
name="email"
|
|
className="w-full rounded-md border border-border bg-transparent px-3 py-2 text-sm outline-none focus:ring-1 focus:ring-ring placeholder:text-muted-foreground/50"
|
|
type="email"
|
|
value={email}
|
|
onChange={(event) => setEmail(event.target.value)}
|
|
autoComplete="username"
|
|
required
|
|
aria-required="true"
|
|
aria-invalid={error ? true : undefined}
|
|
aria-describedby={error ? errorId : undefined}
|
|
autoFocus={mode === "sign_in"}
|
|
/>
|
|
</div>
|
|
<div>
|
|
<label htmlFor="password" className="text-xs text-muted-foreground mb-1 block">Password</label>
|
|
<input
|
|
id="password"
|
|
name="password"
|
|
className="w-full rounded-md border border-border bg-transparent px-3 py-2 text-sm outline-none focus:ring-1 focus:ring-ring placeholder:text-muted-foreground/50"
|
|
type="password"
|
|
value={password}
|
|
onChange={(event) => setPassword(event.target.value)}
|
|
autoComplete={mode === "sign_in" ? "current-password" : "new-password"}
|
|
required
|
|
aria-required="true"
|
|
aria-invalid={error ? true : undefined}
|
|
aria-describedby={error ? errorId : undefined}
|
|
/>
|
|
</div>
|
|
{error && (
|
|
<p id={errorId} role="alert" className="text-xs text-destructive">
|
|
{error}
|
|
</p>
|
|
)}
|
|
<Button
|
|
type="submit"
|
|
disabled={mutation.isPending}
|
|
aria-disabled={!canSubmit || mutation.isPending}
|
|
className={`w-full ${!canSubmit && !mutation.isPending ? "opacity-50" : ""}`}
|
|
>
|
|
{mutation.isPending
|
|
? "Working…"
|
|
: mode === "sign_in"
|
|
? "Sign In"
|
|
: "Create Account"}
|
|
</Button>
|
|
</form>
|
|
|
|
<div className="mt-5 text-sm text-muted-foreground">
|
|
{mode === "sign_in" ? "Need an account?" : "Already have an account?"}{" "}
|
|
<button
|
|
type="button"
|
|
className="font-medium text-foreground underline underline-offset-2"
|
|
onClick={() => {
|
|
setError(null);
|
|
setMode(mode === "sign_in" ? "sign_up" : "sign_in");
|
|
}}
|
|
>
|
|
{mode === "sign_in" ? "Create one" : "Sign in"}
|
|
</button>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
{/* Right half — ASCII art animation (hidden on mobile) */}
|
|
<div className="hidden md:block w-1/2 overflow-hidden">
|
|
<AsciiArtAnimation />
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|