mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-29 21:07:40 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The runner package already provides the production protocol and execution spine. > - Contributors still need stable SDK surfaces, deterministic test tools, and local inspection tools. > - Those surfaces share generated contracts and must change as one package boundary. > - This pull request adds the package-local SDK, labs, examples, and drift checks. > - The benefit is a reviewable developer platform that does not change application execution selection. ## Linked Issues or Issue Description **Subsystem affected** `packages/paperclip-runner` — runner SDK, conformance tools, and developer tooling. **Problem or motivation** The production runner spine is present, but package consumers cannot build deterministic integrations, inspect sessions, or verify provider-neutral behavior through supported surfaces. **Proposed solution** Add browser, React, standalone, live-session, scenario, conformance, and evaluation surfaces. Add generated contract inventories and package-local verification scripts. Keep production application routing unchanged. **Alternatives considered** We considered splitting each generated catalog, SDK surface, and demo into separate pull requests. Those changes share exports, fixtures, and drift gates. Splitting them would create intermediate package states that do not build. **Roadmap alignment** No overlapping item appears in `ROADMAP.md`. This work extends the runner package that is already on `master`. ## What Changed - Add browser, React, standalone, live-session, and issue-thread SDK surfaces. - Add deterministic mock control-plane, scenario, conformance, replay, and evaluation tools. - Add bounded Codex, OpenCode, and ACPX development transports and fixtures. - Keep deferred managed-provider execution fail-closed. Persisted compatibility data remains readable. - Add generated capability inventories with their source files and drift checks. - Add examples, package documentation, browser checks, and clean-consumer checks. - Preserve the reviewed protocol bounds, replay compatibility aliases, process environment isolation, and semantic redaction limits. - Update the ACPX package patch that the existing workspace patch registry already tracks. - Do not change `pnpm-lock.yaml`, repository workflows, server runtime selection, or the application UI. ## Verification GitHub Actions is the verification authority for this pull request. The repository CI, package TypeScript and Rust checks, package tests, generated-output drift checks, browser checks, security scans, and Greptile review must pass on the exact head. Local test suites were not run because this series uses parallel GitHub Actions for verification. ## Risks This is a large greenfield package change. The main risks are public export drift, generated-output drift, and optional React consumer compatibility. Package boundary checks, clean-consumer checks, and browser tests cover those risks. Production adapter selection and server execution are outside this pull request. ## Stack 1. **This PR:** runner SDK and developer tooling. 2. [Codex production server integration](https://github.com/paperclipai/paperclip/pull/12616). 3. [Provider-neutral task-thread UI](https://github.com/paperclipai/paperclip/pull/12617). ## Model Used OpenAI Codex, GPT-5, high-reasoning mode, with tool use and code execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have described the issue in-PR following the feature request template - [x] I have not referenced internal/instance-local Paperclip issues or links - [x] My branch name describes the change and contains no internal Paperclip ticket id - [ ] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge
307 lines
12 KiB
TypeScript
307 lines
12 KiB
TypeScript
import {
|
|
PRP_ACTIONABLE_ATTENTION_KINDS,
|
|
PRP_ATTENTION_OWNER_CLASSES,
|
|
PRP_VERIFICATION_REASON_CODES,
|
|
} from "../contracts/completion-result.js";
|
|
|
|
export type PrpVerificationReasonCode = (typeof PRP_VERIFICATION_REASON_CODES)[number];
|
|
export type PrpActionableAttentionKind = (typeof PRP_ACTIONABLE_ATTENTION_KINDS)[number];
|
|
export type PrpAttentionOwnerClass = (typeof PRP_ATTENTION_OWNER_CLASSES)[number];
|
|
|
|
export interface PrpNormalizedVerification {
|
|
commandOrCheck: string;
|
|
status: "passed" | "failed" | "not_run";
|
|
reasonCode: PrpVerificationReasonCode | null;
|
|
detail: string | null;
|
|
artifactRef: string | null;
|
|
sourceIndex: number;
|
|
}
|
|
|
|
export interface PrpNormalizedAttentionRequest {
|
|
kind: PrpActionableAttentionKind;
|
|
summary: string;
|
|
ownerClass: PrpAttentionOwnerClass;
|
|
targetAgentId: string | null;
|
|
sourceIndex: number;
|
|
sourceKind: string;
|
|
legacy: boolean;
|
|
}
|
|
|
|
export interface PrpIgnoredAttentionRequest {
|
|
sourceIndex: number;
|
|
sourceKind: string | null;
|
|
summary: string | null;
|
|
disposition: "verification_caveat" | "ignored" | "rejected";
|
|
reasonCode: string;
|
|
}
|
|
|
|
export interface PrpResultSignals {
|
|
verification: PrpNormalizedVerification[];
|
|
actionableAttentionRequests: PrpNormalizedAttentionRequest[];
|
|
ignoredAttentionRequests: PrpIgnoredAttentionRequest[];
|
|
}
|
|
|
|
const verificationReasonCodes = new Set<string>(PRP_VERIFICATION_REASON_CODES);
|
|
const unavailableVerificationReasonCodes = new Set<string>(
|
|
PRP_VERIFICATION_REASON_CODES.filter((reasonCode) => reasonCode !== "other"),
|
|
);
|
|
const attentionKinds = new Set<string>(PRP_ACTIONABLE_ATTENTION_KINDS);
|
|
const ownerClasses = new Set<string>(PRP_ATTENTION_OWNER_CLASSES);
|
|
|
|
function record(value: unknown): Record<string, unknown> {
|
|
return typeof value === "object" && value !== null && !Array.isArray(value)
|
|
? value as Record<string, unknown>
|
|
: {};
|
|
}
|
|
|
|
function text(value: unknown): string | null {
|
|
return typeof value === "string" && value.trim().length > 0 ? value.trim() : null;
|
|
}
|
|
|
|
function inferVerificationReason(value: string): PrpVerificationReasonCode {
|
|
const lower = value.toLowerCase();
|
|
if (/budget|quota|token limit/.test(lower)) return "budget_exhausted";
|
|
if (/credential|api key|secret|login|auth(?:entication)? required/.test(lower)) return "credential_missing";
|
|
if (/permission|denied|forbidden|not allowed/.test(lower)) return "permission_denied";
|
|
if (/policy|governance|approval policy/.test(lower)) return "policy_restricted";
|
|
if (/external|service|upstream|network|offline|dns/.test(lower)) return "external_service_unavailable";
|
|
if (/dependency|package|module|library/.test(lower)) return "dependency_missing";
|
|
if (/tool|command|binary|node|npm|sandbox/.test(lower)) return "tool_unavailable";
|
|
if (/environment|runtime|platform/.test(lower)) return "environment_unavailable";
|
|
return "other";
|
|
}
|
|
|
|
function normalizeVerification(result: Record<string, unknown>): PrpNormalizedVerification[] {
|
|
const entries = Array.isArray(result.verification) ? result.verification : [];
|
|
return entries.map((value, sourceIndex) => {
|
|
const entry = record(value);
|
|
const rawStatus = String(entry.status);
|
|
const reportedStatus: PrpNormalizedVerification["status"] = ["pass", "success", "succeeded"].includes(rawStatus)
|
|
? "passed"
|
|
: rawStatus === "fail"
|
|
? "failed"
|
|
: ["passed", "failed", "not_run"].includes(rawStatus)
|
|
? rawStatus as PrpNormalizedVerification["status"]
|
|
: "not_run";
|
|
const detail = text(entry.detail) ?? text(entry.result);
|
|
const commandOrCheck = text(entry.commandOrCheck) ?? text(entry.command) ?? `verification-${sourceIndex + 1}`;
|
|
const reportedReason = text(entry.reasonCode);
|
|
const normalizedReportedReason = reportedReason && verificationReasonCodes.has(reportedReason)
|
|
? reportedReason as PrpVerificationReasonCode
|
|
: null;
|
|
// Provider models sometimes report an unavailable command as `failed`
|
|
// because the shell returned non-zero, while also supplying a reason code
|
|
// that explicitly says no meaningful verification verdict was possible.
|
|
// The reason code is the stronger semantic signal: reserve `failed` for a
|
|
// check that actually ran and found the work incorrect.
|
|
const status = reportedStatus === "failed"
|
|
&& normalizedReportedReason
|
|
&& unavailableVerificationReasonCodes.has(normalizedReportedReason)
|
|
? "not_run"
|
|
: reportedStatus;
|
|
const reasonCode = normalizedReportedReason
|
|
?? (status === "not_run"
|
|
? inferVerificationReason(`${commandOrCheck} ${detail ?? ""}`)
|
|
: null);
|
|
return {
|
|
commandOrCheck,
|
|
status,
|
|
reasonCode,
|
|
detail,
|
|
artifactRef: text(entry.artifactRef),
|
|
sourceIndex,
|
|
};
|
|
});
|
|
}
|
|
|
|
/** Normalize accepted PRP v1 aliases before strict canonical validation. */
|
|
export function normalizeLegacyPrpStructuredRunResult(value: unknown): unknown {
|
|
const source = record(value);
|
|
if (Object.keys(source).length === 0) return value;
|
|
const normalized: Record<string, unknown> = { ...source };
|
|
// Provider tool-callers do not consistently echo constant discriminator
|
|
// fields even when they are present in the advertised JSON schema. The
|
|
// transport already selected the semantic-result tool, so adding its
|
|
// canonical discriminator here is deterministic rather than inferential.
|
|
const reportedSchema = text(normalized.schema);
|
|
if (
|
|
reportedSchema === null
|
|
|| ["paperclip_finish", "paperclip_paperclip_finish", "paperclip_finish.v1"].includes(reportedSchema)
|
|
) {
|
|
normalized.schema = "paperclip.run_result.v1";
|
|
}
|
|
const signals = normalizePrpResultSignals(source);
|
|
if (["complete", "completed"].includes(String(normalized.reportedWorkDisposition))) {
|
|
normalized.reportedWorkDisposition = "done";
|
|
}
|
|
const completionClaim = record(normalized.completionClaim);
|
|
if (Array.isArray(completionClaim.criteria)) {
|
|
normalized.completionClaim = {
|
|
...completionClaim,
|
|
criteria: completionClaim.criteria.map((value) => {
|
|
const criterion = record(value);
|
|
const reportedStatus = text(criterion.status);
|
|
const status = reportedStatus && ["pass", "passed", "complete", "completed"].includes(reportedStatus)
|
|
? "satisfied"
|
|
: reportedStatus && ["fail", "failed", "incomplete"].includes(reportedStatus)
|
|
? "not_satisfied"
|
|
: criterion.status;
|
|
return { ...criterion, status };
|
|
}),
|
|
};
|
|
}
|
|
normalized.attentionRequests = signals.actionableAttentionRequests.map((entry) => ({
|
|
kind: entry.kind,
|
|
summary: entry.summary,
|
|
ownerClass: entry.ownerClass,
|
|
...(entry.targetAgentId ? { targetAgentId: entry.targetAgentId } : {}),
|
|
}));
|
|
normalized.artifacts = Array.isArray(source.artifacts) ? source.artifacts : [];
|
|
normalized.verification = signals.verification.map((entry) => ({
|
|
commandOrCheck: entry.commandOrCheck,
|
|
status: entry.status,
|
|
...(entry.reasonCode ? { reasonCode: entry.reasonCode } : {}),
|
|
...(entry.detail ? { detail: entry.detail } : {}),
|
|
...(entry.artifactRef ? { artifactRef: entry.artifactRef } : {}),
|
|
}));
|
|
return normalized;
|
|
}
|
|
|
|
function legacyAttentionRequest(
|
|
entry: Record<string, unknown>,
|
|
sourceIndex: number,
|
|
sourceKind: string,
|
|
summary: string,
|
|
): PrpNormalizedAttentionRequest | null {
|
|
const target = record(entry.target);
|
|
const targetAgentId = text(entry.targetAgentId) ?? text(target.agentId);
|
|
const ownerClass = text(entry.ownerClass) ?? text(target.ownerClass);
|
|
const requiredAuthority = text(entry.requiredAuthority);
|
|
switch (sourceKind) {
|
|
case "credential_grant":
|
|
return { kind: "credential", summary, ownerClass: "human", targetAgentId: null, sourceIndex, sourceKind, legacy: true };
|
|
case "governed_approval":
|
|
return { kind: "approval", summary, ownerClass: "human", targetAgentId: null, sourceIndex, sourceKind, legacy: true };
|
|
case "subjective_decision":
|
|
return { kind: "human_input", summary, ownerClass: "human", targetAgentId: null, sourceIndex, sourceKind, legacy: true };
|
|
case "domain_expertise":
|
|
return targetAgentId
|
|
? { kind: "agent_handoff", summary, ownerClass: "agent", targetAgentId, sourceIndex, sourceKind, legacy: true }
|
|
: null;
|
|
case "external_action":
|
|
return {
|
|
kind: "external_action",
|
|
summary,
|
|
ownerClass: ownerClass === "external_system" || requiredAuthority === "external" ? "external_system" : "human",
|
|
targetAgentId: null,
|
|
sourceIndex,
|
|
sourceKind,
|
|
legacy: true,
|
|
};
|
|
default:
|
|
return null;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Normalize model-authored result signals without rewriting the immutable PRP result.
|
|
* Unknown legacy attention is diagnostic data, never a finalization exception.
|
|
*/
|
|
export function normalizePrpResultSignals(value: unknown): PrpResultSignals {
|
|
const result = record(value);
|
|
const verification = normalizeVerification(result);
|
|
const actionableAttentionRequests: PrpNormalizedAttentionRequest[] = [];
|
|
const ignoredAttentionRequests: PrpIgnoredAttentionRequest[] = [];
|
|
const requests = Array.isArray(result.attentionRequests) ? result.attentionRequests : [];
|
|
|
|
requests.forEach((value, sourceIndex) => {
|
|
const entry = record(value);
|
|
const sourceKind = text(entry.kind) ?? text(entry.requestedCapability);
|
|
const summary = text(entry.summary);
|
|
if (!sourceKind || !summary) {
|
|
ignoredAttentionRequests.push({
|
|
sourceIndex,
|
|
sourceKind,
|
|
summary,
|
|
disposition: "rejected",
|
|
reasonCode: "attention_request_malformed",
|
|
});
|
|
return;
|
|
}
|
|
|
|
if (sourceKind === "environment_constraint") {
|
|
const target = verification.find((candidate) => candidate.status === "not_run");
|
|
if (target) {
|
|
target.detail = target.detail
|
|
? target.detail.includes(summary) ? target.detail : `${target.detail}\n${summary}`
|
|
: summary;
|
|
target.reasonCode = inferVerificationReason(`${target.commandOrCheck} ${target.detail}`);
|
|
}
|
|
ignoredAttentionRequests.push({
|
|
sourceIndex,
|
|
sourceKind,
|
|
summary,
|
|
disposition: "verification_caveat",
|
|
reasonCode: target ? "legacy_environment_constraint_normalized" : "legacy_environment_constraint_unbound",
|
|
});
|
|
return;
|
|
}
|
|
|
|
if (attentionKinds.has(sourceKind) && text(entry.ownerClass)) {
|
|
const ownerClass = text(entry.ownerClass);
|
|
const targetAgentId = text(entry.targetAgentId);
|
|
if (!ownerClass || !ownerClasses.has(ownerClass) || (ownerClass === "agent" && !targetAgentId)) {
|
|
ignoredAttentionRequests.push({
|
|
sourceIndex,
|
|
sourceKind,
|
|
summary,
|
|
disposition: "rejected",
|
|
reasonCode: "attention_request_owner_invalid",
|
|
});
|
|
return;
|
|
}
|
|
actionableAttentionRequests.push({
|
|
kind: sourceKind as PrpActionableAttentionKind,
|
|
summary,
|
|
ownerClass: ownerClass as PrpAttentionOwnerClass,
|
|
targetAgentId,
|
|
sourceIndex,
|
|
sourceKind,
|
|
legacy: false,
|
|
});
|
|
return;
|
|
}
|
|
|
|
if (sourceKind === "review") {
|
|
actionableAttentionRequests.push({
|
|
kind: "review",
|
|
summary,
|
|
ownerClass: "human",
|
|
targetAgentId: null,
|
|
sourceIndex,
|
|
sourceKind,
|
|
legacy: true,
|
|
});
|
|
return;
|
|
}
|
|
|
|
const legacy = legacyAttentionRequest(entry, sourceIndex, sourceKind, summary);
|
|
if (legacy) {
|
|
actionableAttentionRequests.push(legacy);
|
|
return;
|
|
}
|
|
|
|
ignoredAttentionRequests.push({
|
|
sourceIndex,
|
|
sourceKind,
|
|
summary,
|
|
disposition: "ignored",
|
|
reasonCode: ["context_lookup", "retry", "duplicate", "alternate_track"].includes(sourceKind)
|
|
? "attention_request_internal_capability_not_provider_actionable"
|
|
: "attention_request_kind_unsupported",
|
|
});
|
|
});
|
|
|
|
return { verification, actionableAttentionRequests, ignoredAttentionRequests };
|
|
}
|