mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-21 08:22:20 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Optional product features need small, typed model decisions. > - Each company needs to choose which shared API connection pays for those decisions. > - Calls must retain user and task permissions, budget limits, and cost attribution. > - This pull request adds a managed decision service, setup UI, and request history. > - Features can check availability cheaply and keep their existing behavior when decisions are unavailable. ## Linked Issues or Issue Description **Subsystem affected** Server services, shared contracts, database accounting, Company Settings, and Costs. **Problem or motivation** Paperclip has no common decision-model service. Adding provider calls within each feature would duplicate credential access, permission checks, and billing rules. **Proposed solution** Let a connection manager configure one company decision model. Support OpenAI Decisions and Jev through OpenRouter. Provide a fixed setup test and metadata-only history. Default company-sponsored background decisions to on during setup, and preserve a saved off setting. **Alternatives considered** Per-feature credentials would duplicate existing connection management. Personal overrides and provider fallback chains add permission and billing complexity; they remain deferred. **Roadmap alignment** Reviewed ROADMAP.md and searched open PRs. This extends existing connection access and budget accounting. Product features that call the service remain outside this change. No matching decision-model service PR was found. ## What Changed - Add company settings, an internal `decisionModelService`, local availability checks, and trusted human, agent/run, and system contexts. - Pin Vercel AI SDK provider dependencies and adapt boolean, choice, and ordered-score decisions for both providers. Bound requests and time; disable paid retries. - Add durable invocation metadata and agentless decision ledger charges. Preserve fractional cents, pricing evidence, dispatch identity, and unresolved billing holds. - Share the company accounting lock and apply company, agent, and project budgets. Settle charges once, retain unknown holds, and recover interrupted calls without resubmission. - Reuse connection setup and management UI. Add a Decisions view under Costs, production-component Storybook coverage, database migration, and service documentation. ## Verification - Passed 166 current-code tests covering the decision service/provider, setup component, Costs, OpenAPI, and every failure from the earlier broad run. Coverage includes native SDK wire formats, refusals, billed malformed responses, permission and secret-rotation races, identity changes, concurrent budget admission, unresolved holds, agent/task deletion, and stale setup feedback. - Passed 170 existing connection, cost, budget, heartbeat-accounting, and profile regression tests. - Passed repository typecheck, production build, and design token gates after integrating master. Verified the generated migration on a fresh test database and upgraded the populated preview database from the branch's earlier migration without losing settings or usage. - Ran the required full `pnpm test:run`: its general phase completed with 16,354 passed and 10 failures across five files while this branch was still being updated. Every reported failure passes in the current-code rerun; the serialized phase did not run after that failure. The full GitHub CI suite passed on `b1b856a88`: general and serialized tests, browser shards, runner checks, typecheck, production build, packaging/canary, and policy gates. [CI evidence](https://github.com/paperclipai/paperclip/actions/runs/37673106360). - Passed the full-shell Storybook setup-to-history interaction test again after integrating master. Greptile rates the final revision 5/5 with zero unresolved threads. - Walked through the running app: empty setup, add each provider, save, reload, run all three sample questions, inspect fractional charges in history, switch provider while sponsorship is off, disable, and reconnect. Checked mobile settings. These tests used the actual UI, vault, server, SDKs, and database with simulated upstream responses. - Live paid setup tests remain unverified: this environment has no authorized OpenAI/OpenRouter credentials available. No mocked test is presented as live provider evidence. Reviewer journey: Company Settings → General → Decision model. Add/select a shared API connection, save, run the billed sample, open View usage, then disable decisions and verify Run test is disabled after reload. ## Risks - The SDK decision interface is experimental. Pinned versions and wire-format tests limit upgrade drift. - The migration allows agentless service charges and reservations. Existing agent cost-reporting APIs still require an agent, and decision receipts stay separate from run reconciliation. - Timeouts can have unknown provider charges. Holds remain until an audited accounting correction resolves them. - OpenAI prices use a versioned Decisions rate snapshot; OpenRouter costs use provider receipts. Unknown pricing is retained as unknown. - A configured company authorizes background spending by default. Setup explains this, and managers can turn it off. - Live provider account/model availability still needs the two credentialed acceptance checks. ## Model Used OpenAI GPT-6 through Codex, with reasoning, repository inspection, code execution, and browser tools. The exact serving revision and context-window size are not exposed in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
388 lines
16 KiB
TypeScript
388 lines
16 KiB
TypeScript
import { useEffect, useMemo } from "react";
|
|
import { useQuery } from "@tanstack/react-query";
|
|
import { AlertCircle, UserRound, UserRoundPen } from "lucide-react";
|
|
import {
|
|
hidesInstancePage,
|
|
type UserProfileDailyPoint,
|
|
type UserProfileWindowStats,
|
|
} from "@paperclipai/shared";
|
|
import { Link, useParams } from "@/lib/router";
|
|
import { authApi } from "../api/auth";
|
|
import { userProfilesApi } from "../api/userProfiles";
|
|
import { Avatar, AvatarFallback, AvatarImage } from "../components/ui/avatar";
|
|
import { Button } from "../components/ui/button";
|
|
import { EmptyState } from "../components/EmptyState";
|
|
import { PageSkeleton } from "../components/PageSkeleton";
|
|
import { IssueStatusBadge } from "../components/StatusBadge";
|
|
import { useBreadcrumbs } from "../context/BreadcrumbContext";
|
|
import { useCompany } from "../context/CompanyContext";
|
|
import { useHiddenSettings } from "../hooks/useHiddenSettings";
|
|
import { queryKeys } from "../lib/queryKeys";
|
|
import {
|
|
formatCents,
|
|
formatDate,
|
|
formatNumber,
|
|
formatShortDate,
|
|
formatTokens,
|
|
issueUrl,
|
|
providerDisplayName,
|
|
relativeTime,
|
|
} from "../lib/utils";
|
|
|
|
const NO_COMPANY = "__none__";
|
|
const PROFILE_SETTINGS_PATH = "/company/settings/instance/profile";
|
|
|
|
function initials(name: string | null | undefined) {
|
|
const value = name?.trim() || "User";
|
|
const parts = value.split(/\s+/).filter(Boolean);
|
|
if (parts.length > 1) return `${parts[0]?.[0] ?? ""}${parts[parts.length - 1]?.[0] ?? ""}`.toUpperCase();
|
|
return value.slice(0, 2).toUpperCase();
|
|
}
|
|
|
|
function totalTokens(stats: Pick<UserProfileWindowStats, "inputTokens" | "cachedInputTokens" | "outputTokens">) {
|
|
return stats.inputTokens + stats.cachedInputTokens + stats.outputTokens;
|
|
}
|
|
|
|
function completionRate(stats: UserProfileWindowStats) {
|
|
if (stats.touchedIssues === 0) return "0%";
|
|
return `${Math.round((stats.completedIssues / stats.touchedIssues) * 100)}%`;
|
|
}
|
|
|
|
function HeroStat({ label, value, hint }: { label: string; value: string; hint?: string }) {
|
|
return (
|
|
<div className="min-w-0">
|
|
<div className="text-2xl font-semibold tabular-nums sm:text-3xl">{value}</div>
|
|
<div className="mt-1 text-(length:--text-micro) font-medium uppercase tracking-wide text-muted-foreground">{label}</div>
|
|
{hint ? <div className="mt-0.5 text-xs text-muted-foreground/70">{hint}</div> : null}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function WindowColumn({ stats }: { stats: UserProfileWindowStats }) {
|
|
const tokens = totalTokens(stats);
|
|
return (
|
|
<div className="flex min-w-0 flex-col gap-4 border-l border-border pl-5 first:border-l-0 first:pl-0">
|
|
<div className="flex items-baseline justify-between gap-3">
|
|
<h2 className="text-(length:--text-micro) font-medium uppercase tracking-wide text-muted-foreground">{stats.label}</h2>
|
|
<span className="text-(length:--text-micro) text-muted-foreground tabular-nums">{completionRate(stats)} done</span>
|
|
</div>
|
|
|
|
<div className="grid grid-cols-2 gap-x-5 gap-y-3">
|
|
<Metric value={formatNumber(stats.touchedIssues)} label="Touched" />
|
|
<Metric value={formatNumber(stats.completedIssues)} label="Completed" />
|
|
<Metric value={formatNumber(stats.commentCount)} label="Comments" />
|
|
<Metric value={formatNumber(stats.activityCount)} label="Actions" />
|
|
</div>
|
|
|
|
<div className="grid grid-cols-2 gap-x-5 gap-y-1.5 pt-3 text-xs tabular-nums text-muted-foreground">
|
|
<span>Tokens</span>
|
|
<span className="text-right text-foreground">{formatTokens(tokens)}</span>
|
|
<span>Spend</span>
|
|
<span className="text-right text-foreground">{formatCents(stats.costCents)}</span>
|
|
<span>Created</span>
|
|
<span className="text-right text-foreground">{formatNumber(stats.createdIssues)}</span>
|
|
<span>Open</span>
|
|
<span className="text-right text-foreground">{formatNumber(stats.assignedOpenIssues)}</span>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function Metric({ value, label }: { value: string; label: string }) {
|
|
return (
|
|
<div className="min-w-0">
|
|
<div className="truncate text-xl font-semibold tabular-nums">{value}</div>
|
|
<div className="mt-0.5 text-(length:--text-micro) text-muted-foreground">{label}</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function UsageChart({ points }: { points: UserProfileDailyPoint[] }) {
|
|
const totals = points.map((point) => totalTokens(point));
|
|
const maxTokens = Math.max(1, ...totals);
|
|
const maxCompleted = Math.max(1, ...points.map((point) => point.completedIssues));
|
|
const totalTokensSum = totals.reduce((sum, value) => sum + value, 0);
|
|
|
|
return (
|
|
<section>
|
|
<div className="flex flex-wrap items-baseline justify-between gap-3 border-b border-border pb-3">
|
|
<h2 className="text-sm font-semibold">Last 14 days</h2>
|
|
<div className="flex items-baseline gap-4 text-xs text-muted-foreground">
|
|
<span className="tabular-nums text-foreground">{formatTokens(totalTokensSum)}</span>
|
|
<span>tokens total</span>
|
|
</div>
|
|
</div>
|
|
<div className="mt-6 grid grid-cols-(--gtc-57) items-end gap-1.5 sm:gap-2">
|
|
{points.map((point) => {
|
|
const tokens = totalTokens(point);
|
|
const heightPct = tokens === 0 ? 0 : Math.max(2, Math.round((tokens / maxTokens) * 100));
|
|
const completedPct = point.completedIssues === 0
|
|
? 0
|
|
: Math.max(8, Math.round((point.completedIssues / maxCompleted) * 36));
|
|
return (
|
|
<div key={point.date} className="group flex h-36 flex-col justify-end">
|
|
<div
|
|
className="w-full bg-foreground/80 transition-opacity group-hover:bg-foreground"
|
|
style={{ height: `${heightPct}%`, minHeight: tokens === 0 ? 1 : undefined }}
|
|
title={`${formatShortDate(point.date)}: ${formatTokens(tokens)} tokens, ${point.completedIssues} completed`}
|
|
/>
|
|
{completedPct > 0 ? (
|
|
<div
|
|
className="mt-1 w-full rounded-full bg-emerald-500/80"
|
|
style={{ height: 2, opacity: Math.min(1, 0.35 + completedPct / 100) }}
|
|
/>
|
|
) : null}
|
|
</div>
|
|
);
|
|
})}
|
|
</div>
|
|
<div className="mt-2 grid grid-cols-(--gtc-57) gap-1.5 text-(length:--text-nano) tabular-nums text-muted-foreground sm:gap-2">
|
|
{points.map((point, index) => (
|
|
<div key={point.date} className="text-center">
|
|
{index === 0 || index === 6 || index === 13 ? formatShortDate(point.date) : null}
|
|
</div>
|
|
))}
|
|
</div>
|
|
<div className="mt-4 flex flex-wrap items-center gap-4 text-(length:--text-nano) uppercase tracking-wide text-muted-foreground">
|
|
<span className="inline-flex items-center gap-1.5">
|
|
<span className="h-2 w-2 bg-foreground/80" /> tokens / day
|
|
</span>
|
|
<span className="inline-flex items-center gap-1.5">
|
|
<span className="h-(--sz-3px) w-4 rounded-full bg-emerald-500/80" /> completions
|
|
</span>
|
|
</div>
|
|
</section>
|
|
);
|
|
}
|
|
|
|
interface UsageRow {
|
|
key: string;
|
|
label: string;
|
|
sublabel: string;
|
|
costCents: number;
|
|
inputTokens: number;
|
|
cachedInputTokens: number;
|
|
outputTokens: number;
|
|
}
|
|
|
|
function UsageList({
|
|
title,
|
|
empty,
|
|
rows,
|
|
}: {
|
|
title: string;
|
|
empty: string;
|
|
rows: UsageRow[];
|
|
}) {
|
|
return (
|
|
<section>
|
|
<div className="flex items-baseline justify-between gap-3 border-b border-border pb-3">
|
|
<h2 className="text-sm font-semibold">{title}</h2>
|
|
<span className="text-xs text-muted-foreground tabular-nums">{rows.length}</span>
|
|
</div>
|
|
{rows.length === 0 ? (
|
|
<div className="pt-4 text-sm text-muted-foreground">{empty}</div>
|
|
) : (
|
|
<ul className="divide-y divide-border">
|
|
{rows.map((row) => (
|
|
<li key={row.key} className="grid gap-2 py-2.5 sm:grid-cols-(--gtc-17) sm:items-center">
|
|
<div className="min-w-0">
|
|
<div className="truncate text-sm font-medium">{row.label}</div>
|
|
<div className="truncate text-xs text-muted-foreground">{row.sublabel}</div>
|
|
</div>
|
|
<div className="flex items-baseline gap-4 text-xs tabular-nums sm:justify-end">
|
|
<span className="text-muted-foreground">{formatTokens(totalTokens(row))}</span>
|
|
<span className="font-medium">{formatCents(row.costCents)}</span>
|
|
</div>
|
|
</li>
|
|
))}
|
|
</ul>
|
|
)}
|
|
</section>
|
|
);
|
|
}
|
|
|
|
export function UserProfile() {
|
|
const { userSlug = "" } = useParams<{ userSlug: string }>();
|
|
const { selectedCompanyId } = useCompany();
|
|
const { setBreadcrumbs } = useBreadcrumbs();
|
|
const companyId = selectedCompanyId ?? NO_COMPANY;
|
|
|
|
const { data, isLoading, error } = useQuery({
|
|
queryKey: queryKeys.userProfile(companyId, userSlug),
|
|
queryFn: () => userProfilesApi.get(companyId, userSlug),
|
|
enabled: !!selectedCompanyId && !!userSlug,
|
|
});
|
|
// The edit link only belongs on the viewer's own profile, and never when the
|
|
// hosting operator hides the profile settings surface the link points at.
|
|
const { data: session } = useQuery({
|
|
queryKey: queryKeys.auth.session,
|
|
queryFn: () => authApi.getSession(),
|
|
retry: false,
|
|
});
|
|
const { hidden: hiddenSettings } = useHiddenSettings();
|
|
const canEditProfile =
|
|
Boolean(data?.user.id) &&
|
|
data?.user.id === session?.user.id &&
|
|
!hidesInstancePage(hiddenSettings, "instance.profile");
|
|
|
|
useEffect(() => {
|
|
setBreadcrumbs([{ label: "Users" }, { label: data?.user.name ?? userSlug }]);
|
|
}, [data?.user.name, setBreadcrumbs, userSlug]);
|
|
|
|
const allTime = data?.stats.find((entry) => entry.key === "all");
|
|
const last7 = data?.stats.find((entry) => entry.key === "last7");
|
|
const displayName = data?.user.name?.trim() || data?.user.email?.split("@")[0] || "User";
|
|
|
|
const agentUsageRows = useMemo<UsageRow[]>(
|
|
() =>
|
|
(data?.topAgents ?? []).map((row) => ({
|
|
key: row.agentId ?? "unknown",
|
|
label: row.agentName ?? (row.agentId ? row.agentId.slice(0, 8) : "Paperclip services"),
|
|
sublabel: "Task-linked usage",
|
|
costCents: row.costCents,
|
|
inputTokens: row.inputTokens,
|
|
cachedInputTokens: row.cachedInputTokens,
|
|
outputTokens: row.outputTokens,
|
|
})),
|
|
[data?.topAgents],
|
|
);
|
|
|
|
const providerUsageRows = useMemo<UsageRow[]>(
|
|
() =>
|
|
(data?.topProviders ?? []).map((row) => ({
|
|
key: `${row.provider}:${row.biller}:${row.model}`,
|
|
label: `${providerDisplayName(row.provider)} / ${row.model}`,
|
|
sublabel: `Billed through ${providerDisplayName(row.biller)}`,
|
|
costCents: row.costCents,
|
|
inputTokens: row.inputTokens,
|
|
cachedInputTokens: row.cachedInputTokens,
|
|
outputTokens: row.outputTokens,
|
|
})),
|
|
[data?.topProviders],
|
|
);
|
|
|
|
if (!selectedCompanyId) {
|
|
return <EmptyState icon={UserRound} message="Select an organization to view user profiles." />;
|
|
}
|
|
|
|
if (isLoading) {
|
|
return <PageSkeleton variant="dashboard" />;
|
|
}
|
|
|
|
if (error || !data) {
|
|
return <EmptyState icon={AlertCircle} message="User profile not found for this organization." />;
|
|
}
|
|
|
|
const allTimeTokens = allTime ? totalTokens(allTime) : 0;
|
|
const metaParts = [
|
|
data.user.membershipRole ?? "member",
|
|
data.user.membershipStatus,
|
|
`joined ${formatDate(data.user.joinedAt)}`,
|
|
];
|
|
|
|
return (
|
|
<div className="space-y-10 pb-10">
|
|
<section className="flex flex-col gap-7 border-b border-border pb-8">
|
|
<div className="flex flex-wrap items-center gap-5">
|
|
<Avatar className="size-16 border border-border" size="lg">
|
|
{data.user.image ? <AvatarImage src={data.user.image} alt={displayName} /> : null}
|
|
<AvatarFallback className="text-lg font-semibold">{initials(displayName)}</AvatarFallback>
|
|
</Avatar>
|
|
<div className="min-w-0 flex-1">
|
|
<div className="flex flex-wrap items-baseline gap-x-3 gap-y-1">
|
|
<h1 className="truncate text-2xl font-semibold">{displayName}</h1>
|
|
<span className="text-sm text-muted-foreground">@{data.user.slug}</span>
|
|
</div>
|
|
<div className="mt-1.5 flex flex-wrap items-center gap-x-3 gap-y-0.5 text-xs text-muted-foreground">
|
|
{data.user.email ? <span className="truncate">{data.user.email}</span> : null}
|
|
{data.user.email ? <span aria-hidden>·</span> : null}
|
|
<span>{metaParts.join(" · ")}</span>
|
|
</div>
|
|
</div>
|
|
{canEditProfile ? (
|
|
<Button asChild variant="outline" size="sm">
|
|
<Link to={PROFILE_SETTINGS_PATH}>
|
|
<UserRoundPen />
|
|
Edit profile
|
|
</Link>
|
|
</Button>
|
|
) : null}
|
|
</div>
|
|
|
|
<div className="grid gap-6 sm:grid-cols-2 lg:grid-cols-4">
|
|
<HeroStat label="All-time tokens" value={formatTokens(allTimeTokens)} hint={formatCents(allTime?.costCents ?? 0) + " spent"} />
|
|
<HeroStat label="Completed" value={formatNumber(allTime?.completedIssues ?? 0)} hint={allTime ? `${completionRate(allTime)} rate` : undefined} />
|
|
<HeroStat label="Open assigned" value={formatNumber(allTime?.assignedOpenIssues ?? 0)} hint={`${formatNumber(allTime?.createdIssues ?? 0)} created`} />
|
|
<HeroStat label="7-day actions" value={formatNumber(last7?.activityCount ?? 0)} hint={`${formatNumber(last7?.commentCount ?? 0)} comments`} />
|
|
</div>
|
|
</section>
|
|
|
|
<section className="grid gap-8 border-b border-border pb-8 lg:grid-cols-3">
|
|
{data.stats.map((entry) => <WindowColumn key={entry.key} stats={entry} />)}
|
|
</section>
|
|
|
|
<UsageChart points={data.daily} />
|
|
|
|
<div className="grid gap-10 pt-2 xl:grid-cols-2">
|
|
<section>
|
|
<div className="flex items-baseline justify-between gap-3 border-b border-border pb-3">
|
|
<h2 className="text-sm font-semibold">Recent tasks</h2>
|
|
<span className="text-xs text-muted-foreground tabular-nums">{data.recentIssues.length}</span>
|
|
</div>
|
|
{data.recentIssues.length === 0 ? (
|
|
<div className="pt-4 text-sm text-muted-foreground">No touched tasks yet.</div>
|
|
) : (
|
|
<ul className="divide-y divide-border">
|
|
{data.recentIssues.map((issue) => (
|
|
<li key={issue.id}>
|
|
<Link
|
|
to={issueUrl(issue)}
|
|
className="grid gap-2 py-2.5 transition-colors hover:bg-accent/40 sm:grid-cols-(--gtc-58) sm:items-center"
|
|
>
|
|
<span className="font-mono text-xs text-muted-foreground">{issue.identifier ?? issue.id.slice(0, 8)}</span>
|
|
<span className="truncate text-sm">{issue.title}</span>
|
|
<span className="flex items-center gap-3 sm:justify-end">
|
|
<IssueStatusBadge status={issue.status} />
|
|
<span className="text-xs tabular-nums text-muted-foreground">{relativeTime(issue.updatedAt)}</span>
|
|
</span>
|
|
</Link>
|
|
</li>
|
|
))}
|
|
</ul>
|
|
)}
|
|
</section>
|
|
|
|
<section>
|
|
<div className="flex items-baseline justify-between gap-3 border-b border-border pb-3">
|
|
<h2 className="text-sm font-semibold">Recent activity</h2>
|
|
<span className="text-xs text-muted-foreground tabular-nums">{data.recentActivity.length}</span>
|
|
</div>
|
|
{data.recentActivity.length === 0 ? (
|
|
<div className="pt-4 text-sm text-muted-foreground">No direct user actions recorded yet.</div>
|
|
) : (
|
|
<ul className="divide-y divide-border">
|
|
{data.recentActivity.map((event) => (
|
|
<li key={event.id} className="grid gap-2 py-2.5 sm:grid-cols-(--gtc-17) sm:items-center">
|
|
<div className="min-w-0">
|
|
<div className="truncate text-sm">{event.action.replaceAll("_", " ")}</div>
|
|
<div className="truncate text-xs text-muted-foreground">
|
|
{event.entityType} · {event.entityId.slice(0, 12)}
|
|
</div>
|
|
</div>
|
|
<span className="text-xs tabular-nums text-muted-foreground sm:justify-self-end">{relativeTime(event.createdAt)}</span>
|
|
</li>
|
|
))}
|
|
</ul>
|
|
)}
|
|
</section>
|
|
</div>
|
|
|
|
<div className="grid gap-10 xl:grid-cols-2">
|
|
<UsageList title="Agent attribution" empty="No issue-linked token usage yet." rows={agentUsageRows} />
|
|
<UsageList title="Provider mix" empty="No provider usage attributed yet." rows={providerUsageRows} />
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|