mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-24 01:41:42 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The board UI is the operator surface where users create, assign, monitor, and review work items. > - The product language is moving toward "tasks" for user-facing work items while the internal API and database still use "issues". > - PR #7543 bundled this copy migration with broader information-architecture work, which made the branch too large for Greptile review. > - This pull request peels the Issue-to-Task copy migration into a smaller, independently reviewable change. > - The benefit is clearer user-facing terminology, less agent confusion via the Paperclip skill note, and a smaller PR that Greptile can review. ## Linked Issues or Issue Description Refs #7645 Refs #7543 Refs PAP-10430 This PR was split out of #7543 so the Issue-to-Task copy migration can be reviewed separately and the remaining IA PR can fall under Greptile's file limit. ## What Changed - Preserves Scott Tong's original `PAP-57` copy-only commit, with author and co-author credit intact, to rename user-facing "Issues" copy to "Tasks" across the UI while keeping routes/API/internal symbols as `issue`. - Updates onboarding and release-smoke browser selectors from `Create & Open Issue` to `Create & Open Task`. - Adds a terminology note to `skills/paperclip/SKILL.md` clarifying that task and issue refer to the same Paperclip work item. - Resolves the only cherry-pick conflict by keeping current search artifacts support and changing visible search copy to "tasks". ## Verification - `pnpm --filter @paperclipai/ui build` passed. - `NODE_ENV=test pnpm exec vitest run ui/src/components/IssuesList.test.tsx ui/src/components/Sidebar.test.tsx ui/src/components/NewIssueDialog.test.tsx ui/src/pages/IssueDetail.test.tsx` passed: 4 files, 66 tests. - `git diff --check origin/master...HEAD` passed. - Diff is 80 files, below Greptile's 100-file limit. - Before/after UI copy examples: "Issues" -> "Tasks", "New Issue" -> "New Task", "Create & Open Issue" -> "Create & Open Task". ## Risks - Medium copy-risk: this intentionally changes user-facing terminology broadly while keeping internal issue identifiers and routes unchanged. - Some docs and APIs still say `issue`; the skill note clarifies this so agents do not treat task and issue as separate entities. - Browser-level visual validation is expected from CI because this local container is missing usable browser dependencies. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used Scott Tong authored the original `PAP-57` copy migration, assisted by Claude Opus 4.8 and Paperclip agents per the preserved commit metadata. Codex / GPT-5-class coding agent with shell, GitHub CLI, and repository access performed the PR split, conflict resolution, skill note, and verification. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: scotttong <scott.tong@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
91 lines
3.3 KiB
TypeScript
91 lines
3.3 KiB
TypeScript
import { ChevronLeft, ChevronRight } from "lucide-react";
|
|
import type { Issue } from "@paperclipai/shared";
|
|
import type { IssueSiblingNavigation as IssueSiblingNavigationState } from "@/lib/issue-detail-subissues";
|
|
import { createIssueDetailPath, withIssueDetailHeaderSeed } from "@/lib/issueDetailBreadcrumb";
|
|
import { cn } from "@/lib/utils";
|
|
import { Link } from "@/lib/router";
|
|
import { StatusIcon } from "./StatusIcon";
|
|
|
|
type IssueSiblingNavigationProps = {
|
|
navigation: IssueSiblingNavigationState | null;
|
|
linkState?: unknown;
|
|
};
|
|
|
|
export function IssueSiblingNavigation({ navigation, linkState }: IssueSiblingNavigationProps) {
|
|
if (!navigation) return null;
|
|
|
|
return (
|
|
<nav
|
|
aria-label="Sub-task navigation"
|
|
className="mt-4 flex flex-col gap-3 sm:mt-6 sm:grid sm:grid-cols-2"
|
|
>
|
|
{navigation.previous ? (
|
|
<SiblingLink direction="previous" issue={navigation.previous} linkState={linkState} />
|
|
) : null}
|
|
{navigation.next ? (
|
|
<SiblingLink
|
|
direction="next"
|
|
issue={navigation.next}
|
|
linkState={linkState}
|
|
className={!navigation.previous ? "sm:col-start-2" : undefined}
|
|
/>
|
|
) : null}
|
|
</nav>
|
|
);
|
|
}
|
|
|
|
function SiblingLink({
|
|
direction,
|
|
issue,
|
|
linkState,
|
|
className,
|
|
}: {
|
|
direction: "previous" | "next";
|
|
issue: Issue;
|
|
linkState?: unknown;
|
|
className?: string;
|
|
}) {
|
|
const issuePathId = issue.identifier ?? issue.id;
|
|
const label = direction === "previous" ? "Previous" : "Next";
|
|
const ariaDirection = direction === "previous" ? "Previous sub-task" : "Next sub-task";
|
|
const identifier = issue.identifier ?? issue.id.slice(0, 8);
|
|
const Icon = direction === "previous" ? ChevronLeft : ChevronRight;
|
|
|
|
return (
|
|
<Link
|
|
to={createIssueDetailPath(issuePathId)}
|
|
state={withIssueDetailHeaderSeed(linkState, issue)}
|
|
issuePrefetch={issue}
|
|
issueQuicklookSide="top"
|
|
issueQuicklookAlign={direction === "previous" ? "start" : "end"}
|
|
aria-label={`${ariaDirection}: ${identifier} - ${issue.title}`}
|
|
className={cn(
|
|
"group min-w-0 rounded-lg border border-border bg-card px-3 py-2.5 text-left no-underline transition-colors hover:bg-accent/50 focus-visible:outline-none focus-visible:ring-[3px] focus-visible:ring-ring",
|
|
direction === "next" && "sm:text-right",
|
|
className,
|
|
)}
|
|
>
|
|
<div className="min-w-0 space-y-1.5">
|
|
<div className={cn(
|
|
"flex items-center gap-1.5 text-xs text-muted-foreground transition-colors group-hover:text-foreground",
|
|
direction === "next" && "sm:justify-end",
|
|
)}>
|
|
{direction === "previous" ? <Icon className="h-3.5 w-3.5 shrink-0" /> : null}
|
|
<span>{label}</span>
|
|
{direction === "next" ? <Icon className="h-3.5 w-3.5 shrink-0" /> : null}
|
|
</div>
|
|
<div className={cn(
|
|
"flex min-w-0 items-center gap-1.5 text-xs font-mono text-muted-foreground transition-colors group-hover:text-foreground",
|
|
direction === "next" && "sm:justify-end",
|
|
)}>
|
|
<StatusIcon status={issue.status} blockerAttention={issue.blockerAttention} />
|
|
<span className="shrink-0">{identifier}</span>
|
|
</div>
|
|
<div className="truncate text-sm text-foreground">
|
|
{issue.title}
|
|
</div>
|
|
</div>
|
|
</Link>
|
|
);
|
|
}
|