Files
PaperClipAI/tests/storybook-visual
DottaandPaperclip b9308f9828 fix(ui): keep long agent names inside task columns (#21155)
## Thinking Path

> - Paperclip helps people manage AI agents and their work.
> - Task views show the assignee and creator in fixed-width columns.
> - Long names can extend past those columns and cover adjacent values.
> - The identity labels already support text truncation but need a width
limit.
> - This pull request limits each identity to its task column.
> - Names stay on one line, avatars keep their size, and adjacent values
stay readable.

## Linked Issues or Issue Description

**What happened?**

Long agent and human names extend outside the Responsible and Kicked off
by columns in task views.

**Expected behavior**

Names fit inside each column. Long names show an ellipsis. Avatars
remain visible. The title attribute retains the full name.

**Steps to reproduce**

1. Open a task view with Responsible and Kicked off by columns visible.
2. Use a long agent name for the assignee and creator.
3. Observe names covering adjacent columns.

## What Changed

- Limit agent and human identity width to the containing task column.
- Add a production-component Storybook example for long names, names
without spaces, and short names.
- Add browser layout checks for both identity columns, avatar size, full
text, adjacent values, and row height in both themes at 640px and
1200px.

## Verification

- The browser regression failed before the fix: an identity reached
x=424 while its column ended at x=144.
- The focused Chromium suite passes all four cases at 640px and 1200px
in light and dark modes.
- `pnpm --dir ui exec vitest run src/components/IssueColumns.test.tsx
src/components/IssuesList.test.tsx`: 83 tests pass.
- `pnpm --filter @paperclipai/ui typecheck`: passes.
- `node scripts/check-token-gates.mjs` and `git diff --check`: pass.
- `pnpm verify` returned exit 2 because the browser test requires
broader CI coverage. The complete PR CI run supplies that coverage.
- All tests, typecheck, build, and e2e gates pass on final commit
`f73568822add60b4659f2cbdad0196fdfe010d3b`:
https://github.com/paperclipai/paperclip/actions/runs/43271777908.
- The separate commitperclip review passed:
https://github.com/paperclipai/paperclip/actions/runs/43271777344.
- Greptile gives this commit 5/5. There are no open findings or review
threads.
- All 61 checks are complete: 57 success, 1 neutral, and 3 skipped. The
Storybook workflow was skipped; the focused browser suite passed
locally.

## Risks

Low risk. The width limit applies only to identity labels in shared task
columns. The full name remains in the DOM and the existing title
attribute. No API or stored-data changes.

## Model Used

OpenAI Codex, based on GPT-6, with code tools and Chromium browser
checks. The runtime does not expose a more specific model ID.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-11-12 22:15:04 -06:00
..

Storybook Visual Baselines

The visual suite compares built Storybook stories against PNG snapshots stored outside git. The checked-in manifest at baseline-manifest.json pins the immutable archive URL, SHA-256, byte size, snapshot count, and capture environment.

Commands

pnpm storybook-visual:baseline download
pnpm storybook-visual:baseline verify
pnpm test:storybook-visual
pnpm test:storybook-visual:update

download fetches the archive, verifies its SHA-256 and byte size, unpacks it to tests/storybook-visual/.snapshots/, and checks the PNG count. The same snapshot directory can be overridden with STORYBOOK_VISUAL_SNAPSHOT_DIR.

Known Limitation: Linux Baselines

Storybook visual baselines are platform-locked. The checked-in manifest records the capture environment as ubuntu-24.04, and Playwright compares screenshots with maxDiffPixels: 0. Pixel-exact results are only meaningful when local runs use the same Linux/Ubuntu capture platform as the baseline.

macOS, Windows, and other non-matching local environments can produce false-positive diffs from font rasterization and subpixel rendering differences. Use the Storybook Visual GitHub Actions workflow on ubuntu-latest as the source of truth for cross-platform review, or run the suite locally in a matching Linux environment before accepting or updating baselines.

CI and Review Artifacts

Storybook visual tests are opt-in while the suite stabilizes. Add the storybook-visual label to a pull request, or run the Storybook Visual workflow manually, to download the pinned baseline, build Storybook, and run the Playwright visual suite on GitHub Actions.

The workflow uploads tests/storybook-visual/playwright-report/ and tests/storybook-visual/test-results/ as a storybook-visual-report-* artifact on every run. When screenshots differ, Playwright writes the actual, expected, and diff PNGs into test-results, so reviewers can inspect the failure without rerunning the suite locally.

Normal PR visual runs use repository read-only permissions and never upload or modify baseline objects. To review intentional visual changes before updating baseline-manifest.json, run the workflow manually with update_snapshots enabled. That produces a storybook-visual-baseline-review-* artifact containing the packed candidate snapshot archive for review. Publishing that bundle to the baseline bucket still requires the explicit maintainer upload command below.

Updating Baselines

  1. Run pnpm test:storybook-visual:update after reviewing intentional visual diffs.
  2. Run pnpm storybook-visual:baseline pack to create tests/storybook-visual/baseline-review/snapshots.tgz.
  3. Upload the archive from a trusted maintainer environment with STORYBOOK_VISUAL_S3_URI=s3://bucket/baselines/storybook-visual/<sha>/snapshots.tgz pnpm storybook-visual:baseline upload.
  4. Copy the printed snapshotCount and archive fields into baseline-manifest.json.

Generated snapshots, review bundles, Playwright reports, and downloaded caches are ignored by git.