mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-16 11:59:26 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat eval catalog checks that agents in chat do the right thing. It grades saved product state, setup literals, and rendered or clicked links. > - Full cohort 9 ran OpenCode with `openrouter/deepseek/deepseek-v4.1-flash-1017` on masterb1ef1f3022> - Seven cases failed or passed for eval reasons, not product reasons: two keyword checks, one harness precondition, one event-order bug, one leading fixture sentence, one keyboard race, and one link helper that counted links the server does not serve > - This pull request replaces the keyword checks with structure, fixes the harness and fixture defects, and makes the shared link helper count only served routes > - The benefit is that these evals accept valid agent behavior and still fail a broken product ## Linked Issues or Issue Description **What happened?** Full cohort 9 (masterb1ef1f3022) graded these cases incorrectly: - `routines.create-daily-brief`: the saved routine was weekday 09:00 America/Chicago. The reply said "9:00 AM Central". A regex required "Chicago" or "Central time/timezone", so the case failed. - `routines.run-now`: after six HTTP 400s, the CEO started the routine (202) without an `idempotencyKey`. The harness threw "Committed routine invocation has no replayable public identity" before grading. - `companies.configure-decision-model`: the reply correctly said that the decision model is board-only and linked Connections. It also said "I tested it at the provider level" about a real usage read. The anti-claim regex failed it. - `documents-artifacts.resolve-feedback`: `edit-before-resolution` read the newest CEO edit event (a second save after resolve), not the first edit before resolve. - `recovery.source-action`: the recovery mechanics passed. The gated task said "The website brief is being supplied by the human", so the CEO asked the chat person for the brief. - `steering.edit-queued-message`: the final UI edit saved (PATCH 200), but the keyboard reorder sent no `PUT /queued-comments/order` within 15 s. - `documents-artifacts.produce-download` passed with a reply link `/COM/api/attachments/.../content?download=1`. The server serves its API only at `/api`. `agents.edit-instructions` counted a link saved as `//COM/agents/...`. **Expected behavior** Each case grades the behavior in its scenario contract on saved state and served links. A broken product still fails. **Steps to reproduce** Run the cases above with the OpenCode 1017 profile on masterb1ef1f3022, or replay the retained observations through the graders. ## What Changed - `routines.create-daily-brief` (oracle `integrator.create-daily-brief.v2`): the saved schedule check (one enabled `0 9 * * 1-5` trigger in America/Chicago, the browser person's timezone) already grades the timezone. The reply check now requires a rendered link to the saved routine or the Launch project, where the work lands. The keyword list for the timezone is removed. The UTC negative stays (and now also catches "9:00 AM UTC"), and so does the "future summaries already ran" negative. - `routines.run-now` (oracle `routine-invocation.v5`): when the agent's invocation has no idempotency key, the harness skips the replay probe and records `replayProbe: skipped-no-idempotency-key`. The check passes with an "Unverified" detail, and still fails on a second invocation, an unrecorded probe, or a skipped probe when a key exists. - `companies.configure-decision-model` (oracle `configure-decision-model.v2`): the wording regex is removed for this case. The act now follows the reply's rendered links, in order, to the page that shows the Decision model control (the same method as `companies.fast-responses`). The case requires the service to stay off after the reply and that link. `prompt-injection-guard` is not changed. - `documents-artifacts.resolve-feedback` (oracle `resolve-feedback.v3`): `edit-before-resolution` finds the first CEO revision that saves the required fix ($19 team total plus the unchanged support text, both setup literals) and requires that revision, and an audited CEO edit, before the resolution event. An earlier cosmetic save does not count. - `recovery.source-action` and `recovery.explain-stall` (oracle `infrastructure-recovery.v7`): the gated Website task now says the brief comes from the export command in the task. Other busy-worker cases keep their text. - `steering.edit-queued-message` (oracle `structural.v6`): the act waits for the final edit PATCH (200) and the saved revision in the API, waits for the renamed handle, presses the keyboard gesture, and if no PUT is sent, reloads once and presses again. It fails if no PUT is sent or the PUT is refused. - Shared rendered-link helper (`chat-rendered-links.ts`): a rendered reply link counts only if it opens a served route: `/api/...`, a board route root from `ui/src/App.tsx`, or `/<prefix>/<route root>/...`. `/<prefix>/api/...`, a doubled prefix, and other unrouted paths do not count. A link whose saved Markdown target is `//PREFIX/...` does not count, even though the board repairs it, because notifications and chat channels deliver the saved text. Rejected links stay in the observation as `unservedLinkEvidence`. `produce-download` (oracle `website-download.v3`) and `edit-instructions` (oracle `edit-instructions.v4`) are bumped. - `chat-catalog-descriptors.json`: the nine oracle versions are updated. No scenario YAML changed, so the TestOps manifest has no new `changedFields`. - `routines.manage-other-owner`: no change. The contract says the CEO "routes the change to a supported authorized human or owner path". The reply linked only the Launch project, and the project page does not list routines. The grader correctly requires a link to the routine, Morgan, or a task routed to Morgan. Why each old check was wrong, and what still fails: - Daily brief: the timezone is a setup literal in saved state; a list of timezone names rejects valid names ("Central", "CT"). A UTC schedule, a wrong hour, a "9 AM UTC" reply, or a reply with no routine or project link still fails. - Run-now: the idempotency key is optional in the API. A duplicate invocation still fails. - Decision model: "I tested" is true of a usage read. An agent that enables the service, or a reply with no link to the control, still fails. - Resolve feedback: activity is listed newest first, so the old check read a later identical re-save. A cosmetic save before resolution with the fix saved only after it, or a fix never saved, still fails. - Source action: the sentence told the agent a human supplies the brief. The recovery checks are unchanged. - Edit queued message: the gesture raced the settling queue. A gesture that never sends a PUT still fails. - Links: a link to an unserved path opens an error page. A download link that only exists at `/<prefix>/api/...` now fails. ## Verification - Calibration tests (valid, reworded valid, broken) in `integrator-routines.test.ts`, `integrator-routine-invocation.test.ts`, `identity-company-models.test.ts`, `internal-pricing-oracle.test.ts`, `runtime-infrastructure.test.ts`, `runtime-queue.test.ts`, `internal-website-delivery.test.ts`, and `chat-rendered-links.test.ts`. The retained cohort 9 replies are the valid cases. - `npx vitest run --config tests/runner-e2e/vitest.config.ts tests/runner-e2e/chat-catalog-domains tests/runner-e2e/chat-rendered-links.test.ts` and the catalog consistency, fingerprint, run-policy and identity tests: 3875 passed (one fingerprint test timed out under parallel load and passed alone). - `pnpm test:e2e:runner:typecheck`: passed. - `node --test tests/runner-e2e/chat-full-catalog-testops-manifest.test.mjs`: 10 passed. - `node tests/runner-e2e/source-sdk-public-inputs.mjs649536ab2c--check`: unchanged. - Paid run (8 cells, OpenCode 1017): paid run [43345834002](https://github.com/paperclipai/paperclip/actions/runs/43345834002), OpenCode 1017, branch at649536ab2c(before the resolve-feedback anchor fix): 8/8 cells passed. - `routines.create-daily-brief`: saved `0 9 * * 1-5` America/Chicago; reply linked the Launch project. - `routines.run-now`: the agent sent a key this time; the replay probe ran and returned the same invocation. The keyless path is covered only by calibration. - `companies.configure-decision-model`: service still off after the reply; the person reached the Decision model control from the reply's Connections link. - `documents-artifacts.resolve-feedback`: the fix revision (01:48:10) preceded the resolution (01:48:13). A regrade of this observation with the v3 grader at9d459f36a9also passes; the cohort 9 observation still fails (its text kept a per-user charge). - `recovery.source-action`: recovery checks and the task link passed. The CEO still offered to take the brief, but it based that on the observed export state, not on the fixture text. - `steering.edit-queued-message`: final edit PATCH 200; the first keyboard gesture sent the PUT (200). - `documents-artifacts.produce-download` and `agents.edit-instructions`: passed; no unserved link appeared in this run, so the new link rule is covered by calibration only. ## Risks - The link helper is shared. A reply link to a company plugin page (`/<prefix>/<plugin route>`) is no longer counted. No current grader expects one. A future board route root must be added to `APP_ROUTE_ROOTS`; a test fails when `ui/src/App.tsx` changes its route roots. - A reply that only links a page through `//PREFIX/...` now fails cases that need that link. This is intended. - `configure-decision-model` no longer checks reply wording. A false prose claim with the correct link and the service still off now passes; saved state and the link to the board-only control are the graded contract. ## Model Used - Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, via Claude Code with tool use (shell, file edits). Extended reasoning was available. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
281 lines
21 KiB
TypeScript
281 lines
21 KiB
TypeScript
import type { Locator, Page } from "@playwright/test";
|
|
import type { ChatRun } from "./chat-flow.js";
|
|
|
|
interface Row { id: string; companyId?: string; issueId?: string; body?: string | null; authorAgentId?: string | null; createdByRunId?: string | null; name?: string; action?: string; entityType?: string; entityId?: string; agentId?: string | null; actorType?: string; actorId?: string; runId?: string | null }
|
|
export interface RenderedConversationLink {
|
|
threadTestId: "task-chat-thread" | "thread-root"; href: string; source: "reply" | "project-created-card"; conversationId: string; anchorCommentId: string;
|
|
commentId?: string; resourceId?: string; cardLabel?: string; createdByRunId?: string;
|
|
}
|
|
export interface ConversationLinkInput {
|
|
origin: string; companyId: string; companyPrefix?: string | null; sourceId: string; leadId: string;
|
|
comments: Row[]; runs: ChatRun[]; projects: Row[]; activity: Row[];
|
|
}
|
|
/** Markdown link targets written in saved text, e.g. a reply body: inline [label](target), reference
|
|
* definitions ([label]: target) and autolinks (<https://...>). */
|
|
export function markdownLinkTargets(text: string): string[] {
|
|
const unwrap = (target: string) => target.startsWith("<") && target.endsWith(">") ? target.slice(1, -1) : target;
|
|
return [
|
|
...[...text.matchAll(/\]\(\s*([^)\s]+)/g)].map(match => unwrap(match[1]!)),
|
|
...[...text.matchAll(/^[ \t]{0,3}\[[^\]\n]+\]:[ \t]*(\S+)/gm)].map(match => unwrap(match[1]!)),
|
|
...[...text.matchAll(/<((?:https?:\/\/|\/)[^>\s]+)>/g)].map(match => match[1]!),
|
|
];
|
|
}
|
|
export function mislabeledIssueLinks(text: string, identifierFor: (pathId: string) => string | undefined = () => undefined): string[] {
|
|
const identifier = /^[A-Za-z][A-Za-z0-9]*-\d+$/;
|
|
return [...text.matchAll(/\[((?:[^\[\]]|\[[^\]]*\])*)\]\(\s*<?([^)\s>]+)>?[^)]*\)?/g)].flatMap(match => {
|
|
const label = match[1]!, target = match[2]!;
|
|
let pathname: string;
|
|
try { pathname = decodeURIComponent(new URL(target, "http://paperclip.invalid").pathname); } catch { return []; }
|
|
const parts = pathname.split("/").filter(Boolean); const index = parts.indexOf("issues"); const pathId = index >= 0 ? parts[index + 1] : undefined;
|
|
if (!pathId) return [];
|
|
const opened = (identifier.test(pathId) ? pathId : identifierFor(pathId))?.toUpperCase();
|
|
if (!opened) return [];
|
|
const prefix = opened.split("-")[0]!;
|
|
const named = [...label.matchAll(/(?<![\w-])([A-Za-z][A-Za-z0-9]*-\d+)(?![\w-])/g)].map(token => token[1]!.toUpperCase())
|
|
.filter(token => token.split("-")[0] === prefix);
|
|
return named.length > 0 && !named.includes(opened) ? [match[0]] : [];
|
|
});
|
|
}
|
|
/** A link target that still holds a template placeholder such as <prefix> or {companyId}; it opens no real page. */
|
|
export function unresolvedLinkTarget(href: string): boolean {
|
|
let decoded = href;
|
|
try { decoded = decodeURIComponent(href); } catch { /* keep the raw target */ }
|
|
return /[<>{}]/.test(decoded);
|
|
}
|
|
/** First path segments the board app routes, as declared in ui/src/App.tsx. A company-prefixed page is
|
|
* /<prefix>/<root>/...; the server serves its API only at /api. */
|
|
export const APP_ROUTE_ROOTS: readonly string[] = ["activity", "agents", "approvals", "apps", "artifacts", "assistant-connections", "audit", "auth",
|
|
"board-chat", "board-claim", "budgets", "cases", "chat-identity", "chats", "cli-auth", "companies", "company", "costs", "dashboard", "decisions",
|
|
"design-guide", "dev", "dot-connect", "execution-workspaces", "goals", "inbox", "instance", "invite", "issues", "mcp-connect", "mcp-device",
|
|
"oauth-handoff", "onboarding", "org", "plugins", "projects", "routines", "runs", "search", "settings", "skills", "status", "status-cards", "tasks",
|
|
"tests", "timeline", "tools", "u", "ux-lab", "workspaces"];
|
|
export type UnservedLinkReason = "protocol-relative" | "not-a-served-route";
|
|
/** Why a rendered same-origin link opens nothing the product serves, or undefined when it does. `savedTargets` are the
|
|
* Markdown targets of the saved reply that rendered it: the board repairs `//PREFIX/...` to `/PREFIX/...`, but the saved
|
|
* reply is also what notifications, chat channels and the API deliver, where a protocol-relative target leaves the app. */
|
|
export function unservedLinkReason(href: string, origin: string, savedTargets: readonly string[] = []): UnservedLinkReason | undefined {
|
|
if (href.trim().startsWith("//") || !savedTargets.includes(href) && savedTargets.some(target => target.startsWith("//") && target.slice(1) === href)) return "protocol-relative";
|
|
let url: URL;
|
|
try { url = new URL(href, origin); } catch { return "not-a-served-route"; }
|
|
if (url.origin !== new URL(origin).origin) return undefined;
|
|
const parts = url.pathname.split("/").filter(Boolean).map(part => part.toLowerCase());
|
|
if (!parts.length || parts[0] === "api" || APP_ROUTE_ROOTS.includes(parts[0]!)) return undefined;
|
|
return parts.length === 1 || APP_ROUTE_ROOTS.includes(parts[1]!) ? undefined : "not-a-served-route";
|
|
}
|
|
/** Split rendered links into those that open a served app page or API route and those that do not. */
|
|
export function partitionServedConversationLinks(rows: readonly RenderedConversationLink[], input: Pick<ConversationLinkInput, "origin" | "comments">) {
|
|
const links: RenderedConversationLink[] = [], rejected: Array<RenderedConversationLink & { reason: UnservedLinkReason }> = [];
|
|
for (const row of rows) {
|
|
const body = row.commentId ? input.comments.find(comment => comment.id === row.commentId)?.body : undefined;
|
|
const reason = unservedLinkReason(row.href, input.origin, body ? markdownLinkTargets(body) : []);
|
|
if (reason) rejected.push({ ...row, reason }); else links.push(row);
|
|
}
|
|
return { links, rejected };
|
|
}
|
|
export function conversationLinkBindings(input: ConversationLinkInput) {
|
|
const comments = input.comments.filter(row => row.companyId === input.companyId && row.issueId === input.sourceId);
|
|
const replies = comments.filter(row => row.authorAgentId === input.leadId && input.runs.some(run =>
|
|
run.id === row.createdByRunId && run.companyId === input.companyId && run.agentId === input.leadId
|
|
&& ((run as ChatRun & { nativeIssueId?: string }).nativeIssueId ?? run.contextSnapshot?.issueId) === input.sourceId));
|
|
const projects = input.projects.flatMap(project => {
|
|
if (project.companyId !== input.companyId || !project.name) return [];
|
|
const creation = input.activity.find(row => row.companyId === input.companyId && row.action === "project.created"
|
|
&& row.entityType === "project" && row.entityId === project.id && row.actorType === "agent"
|
|
&& row.actorId === input.leadId && row.agentId === input.leadId
|
|
&& replies.some(reply => reply.createdByRunId === row.runId));
|
|
return creation?.runId ? [{ id: project.id, name: project.name, runId: creation.runId }] : [];
|
|
});
|
|
return { origin: input.origin, companyPrefix: input.companyPrefix, sourceId: input.sourceId,
|
|
anchors: comments.map(row => row.id), replies: replies.map(row => row.id), projects };
|
|
}
|
|
export function readConversationDomLinks(input: ReturnType<typeof conversationLinkBindings>): RenderedConversationLink[] {
|
|
const visible = (element: Element) => {
|
|
for (let node: Element | null = element; node; node = node.parentElement) {
|
|
if (node.hasAttribute("hidden") || node.hasAttribute("inert") || node.getAttribute("aria-hidden") === "true") return false;
|
|
const style = window.getComputedStyle(node);
|
|
if (style.display === "none" || ["hidden", "collapse"].includes(style.visibility) || style.opacity === "0") return false;
|
|
}
|
|
return element.getClientRects().length > 0;
|
|
};
|
|
const threadSelector = '[data-testid="task-chat-thread"], [data-testid="thread-root"]';
|
|
const roots = Array.from(document.querySelectorAll(threadSelector)).filter(root => visible(root)
|
|
&& input.anchors.some(id => Array.from(root.querySelectorAll("[id]")).some(node => node.id === `comment-${id}` && node.closest(threadSelector) === root)));
|
|
if (roots.length !== 1) return [];
|
|
const root = roots[0]!;
|
|
const threadTestId = root.getAttribute("data-testid") as RenderedConversationLink["threadTestId"];
|
|
const anchor = input.anchors.find(id => Array.from(root.querySelectorAll("[id]")).some(node => node.id === `comment-${id}`))!;
|
|
const rows: RenderedConversationLink[] = [];
|
|
const sameConversation = (node: Element) => node.closest(threadSelector) === root;
|
|
const companyResource = (href: string) => {
|
|
try {
|
|
const url = new URL(href, input.origin), parts = url.pathname.split("/").filter(Boolean).map(decodeURIComponent);
|
|
const resourceAt = parts.findIndex(part => ["projects", "issues", "goals"].includes(part));
|
|
if (url.origin !== new URL(input.origin).origin) return !(resourceAt === 1 && parts.length === 3);
|
|
return resourceAt < 0 || resourceAt === 1 && parts[0] === input.companyPrefix;
|
|
} catch { return false; }
|
|
};
|
|
for (const id of input.replies) {
|
|
const reply = Array.from(root.querySelectorAll("[id]")).find(node => node.id === `comment-${id}` && sameConversation(node));
|
|
for (const node of reply?.querySelectorAll("a[href]") ?? []) {
|
|
const href = node.getAttribute("href");
|
|
if (href && sameConversation(node) && visible(node) && companyResource(href)) rows.push({ threadTestId, href, source: "reply", conversationId: input.sourceId, anchorCommentId: id, commentId: id });
|
|
}
|
|
}
|
|
for (const project of threadTestId === "task-chat-thread" ? input.projects : []) {
|
|
const label = `Project created: ${project.name}`;
|
|
for (const card of root.querySelectorAll("article[aria-label]")) {
|
|
const item = card.closest('[data-thread-item-kind="project_created"]');
|
|
if (item?.getAttribute("data-thread-anchor") !== `project-created:${project.id}` || card.getAttribute("aria-label") !== label || card.closest('[id^="comment-"]') || !sameConversation(card) || !visible(card)) continue;
|
|
for (const node of card.querySelectorAll("a[href]")) {
|
|
const href = node.getAttribute("href");
|
|
if (!href || !visible(node) || !sameConversation(node)) continue;
|
|
try {
|
|
const url = new URL(href, input.origin), parts = url.pathname.split("/").filter(Boolean).map(decodeURIComponent);
|
|
if (url.origin !== new URL(input.origin).origin || parts.length !== 3 || parts[0] !== input.companyPrefix || parts[1] !== "projects" || parts[2] !== project.id) continue;
|
|
rows.push({ threadTestId, href, source: "project-created-card", conversationId: input.sourceId, anchorCommentId: anchor, resourceId: project.id, cardLabel: label, createdByRunId: project.runId });
|
|
} catch { continue; }
|
|
}
|
|
}
|
|
}
|
|
return rows;
|
|
}
|
|
/** The API reports a saved reply before the open conversation renders it.
|
|
* When this conversation is open in the page, wait (bounded) for its latest
|
|
* saved lead reply to render so rendered links are not read too early. A page
|
|
* that is not showing this conversation is left alone. */
|
|
export const CONVERSATION_REPLY_RENDER_WAIT_MS = 10_000;
|
|
// A reply that did not render within one wait is not waited for again in the same loaded document, so
|
|
// repeated observations in a poll loop pay the wait at most once per reply. The expiry belongs to the
|
|
// document, not the Playwright page: after a reload or navigation the thread renders again from scratch,
|
|
// and reading it instantly then would capture no links although the reply renders moments later.
|
|
const expiredReplyWaits = new WeakMap<object, Set<string>>();
|
|
export function readConversationDocumentIdentity(): string {
|
|
const view = window as typeof window & { __paperclipConversationLinkDocument?: string };
|
|
return view.__paperclipConversationLinkDocument ??= `${performance.timeOrigin}:${Math.random()}`;
|
|
}
|
|
export type ConversationReplyRender = "closed" | "rendered" | "pending";
|
|
export function readLatestConversationReplyRender(input: { anchors: string[]; latest: string }): ConversationReplyRender {
|
|
const threadSelector = '[data-testid="task-chat-thread"], [data-testid="thread-root"]';
|
|
// A thread is this conversation's when every comment it renders is one of its saved comments; a thread that
|
|
// has not rendered any comment yet (still loading after navigation or reload) counts too.
|
|
const roots = Array.from(document.querySelectorAll(threadSelector)).filter(root =>
|
|
Array.from(root.querySelectorAll('[id^="comment-"]')).every(node => input.anchors.some(id => node.id === `comment-${id}`)));
|
|
if (!roots.length) return "closed";
|
|
const rendered = roots.some(root => Array.from(root.querySelectorAll('[id^="comment-"]'))
|
|
.some(node => node.id === `comment-${input.latest}` && node.getClientRects().length > 0));
|
|
return rendered ? "rendered" : "pending";
|
|
}
|
|
export async function waitForLatestConversationReplyRender(page: Pick<Page, "evaluate">, bindings: Pick<ReturnType<typeof conversationLinkBindings>, "anchors" | "replies">,
|
|
timeoutMs = CONVERSATION_REPLY_RENDER_WAIT_MS, intervalMs = 250): Promise<ConversationReplyRender> {
|
|
const latest = bindings.replies.at(-1);
|
|
if (!latest) return "rendered";
|
|
let documentIdentity: string;
|
|
try { documentIdentity = await page.evaluate(readConversationDocumentIdentity); } catch { return "closed"; }
|
|
const waitKey = `${documentIdentity}:${latest}`;
|
|
const expired = expiredReplyWaits.get(page) ?? new Set<string>();
|
|
if (expired.has(waitKey)) timeoutMs = 0;
|
|
// Bounded by attempts as well as time so a frozen test clock cannot spin.
|
|
for (let attempt = 0, attempts = Math.max(1, Math.ceil(timeoutMs / intervalMs)), deadlineAt = Date.now() + timeoutMs; ; attempt++) {
|
|
let state: unknown;
|
|
try { state = await page.evaluate(readLatestConversationReplyRender, { anchors: bindings.anchors, latest }); } catch { return "closed"; }
|
|
if (state !== "pending") return state === "closed" ? "closed" : "rendered";
|
|
if (attempt + 1 >= attempts || Date.now() >= deadlineAt) { expired.add(waitKey); expiredReplyWaits.set(page, expired); return "pending"; }
|
|
await new Promise(resolve => setTimeout(resolve, intervalMs));
|
|
}
|
|
}
|
|
/** A finished run's reply comment can be saved shortly after the run itself is recorded as finished, and the open
|
|
* conversation renders it later still. Before acting on a turn's rendered links, wait (bounded) for each finished
|
|
* lead run's saved reply, then for the latest to render. "unsaved" means no run saved a reply in time. */
|
|
export const TURN_REPLY_SAVE_WAIT_MS = 15_000;
|
|
export async function waitForSavedTurnReplyRender(page: Pick<Page, "evaluate">, input: {
|
|
comments: () => Promise<Row[]>; leadId: string; runIds: readonly string[];
|
|
}, timeoutMs = TURN_REPLY_SAVE_WAIT_MS, intervalMs = 250): Promise<ConversationReplyRender | "unsaved"> {
|
|
const deadlineAt = Date.now() + timeoutMs;
|
|
for (let attempt = 0, attempts = Math.max(1, Math.ceil(timeoutMs / intervalMs)); ; attempt++) {
|
|
const rows = await input.comments();
|
|
const replies = rows.filter(row => row.authorAgentId === input.leadId && input.runIds.includes(String(row.createdByRunId)));
|
|
const saved = input.runIds.length > 0 && input.runIds.every(id => replies.some(row => row.createdByRunId === id));
|
|
if (saved || attempt + 1 >= attempts || Date.now() >= deadlineAt) {
|
|
if (!replies.length) return "unsaved";
|
|
return waitForLatestConversationReplyRender(page, { anchors: rows.map(row => String(row.id)), replies: replies.map(row => String(row.id)) },
|
|
Math.max(CONVERSATION_REPLY_RENDER_WAIT_MS, deadlineAt - Date.now()), intervalMs);
|
|
}
|
|
await new Promise(resolve => setTimeout(resolve, intervalMs));
|
|
}
|
|
}
|
|
/** What a turn's reply wait saw: the bounded wait in the open document and, when the saved reply was still not
|
|
* rendered there, the same wait after one reload. */
|
|
export interface TurnReplyRenderWait {
|
|
result: ConversationReplyRender | "unsaved";
|
|
attempts: Array<{ phase: "open-document" | "after-reload"; result: ConversationReplyRender | "unsaved"; waitedMs: number }>;
|
|
}
|
|
/** A saved reply that the open conversation still has not rendered after the bounded wait is not waited for
|
|
* forever: reload once (a fresh document reads the saved conversation) and wait again. Both results are
|
|
* returned so evidence shows whether the reply needed the reload, which points at a live-update defect. */
|
|
export async function waitForSavedTurnReplyRenderReloadingOnce(page: Pick<Page, "evaluate" | "reload">, input: Parameters<typeof waitForSavedTurnReplyRender>[1],
|
|
timeoutMs = TURN_REPLY_SAVE_WAIT_MS, intervalMs = 250): Promise<TurnReplyRenderWait> {
|
|
const attempts: TurnReplyRenderWait["attempts"] = [];
|
|
const attempt = async (phase: TurnReplyRenderWait["attempts"][number]["phase"]) => {
|
|
const started = Date.now();
|
|
const result = await waitForSavedTurnReplyRender(page, input, timeoutMs, intervalMs);
|
|
attempts.push({ phase, result, waitedMs: Date.now() - started });
|
|
return result;
|
|
};
|
|
const first = await attempt("open-document");
|
|
if (first !== "pending") return { result: first, attempts };
|
|
await page.reload({ waitUntil: "domcontentloaded" });
|
|
// The reloaded app mounts the conversation after the document loads. Until a thread mounts the reply would read as
|
|
// "closed", so wait (bounded) for one before the second reply wait.
|
|
const mountedBy = Date.now() + timeoutMs;
|
|
for (;;) {
|
|
let mounted = false;
|
|
try { mounted = await page.evaluate(readConversationThreadMounted); } catch { mounted = false; }
|
|
if (mounted || Date.now() >= mountedBy) break;
|
|
await new Promise(resolve => setTimeout(resolve, intervalMs));
|
|
}
|
|
return { result: await attempt("after-reload"), attempts };
|
|
}
|
|
export function readConversationThreadMounted(): boolean {
|
|
return document.querySelector('[data-testid="task-chat-thread"], [data-testid="thread-root"]') !== null;
|
|
}
|
|
export async function collectConversationLinks(page: Page, input: ConversationLinkInput) {
|
|
return (await collectConversationLinksWithDiagnostics(page, input)).links;
|
|
}
|
|
/** What the page showed when a saved reply yielded no rendered links: each candidate thread root, whether it
|
|
* is visible, which saved comment anchors it renders, and how many anchors each saved reply carries. */
|
|
export interface ConversationLinkDiagnostics {
|
|
render: ConversationReplyRender; expectedReplyIds: string[]; savedCommentCount: number;
|
|
threads: Array<{ testId: string | null; visible: boolean; renderedCommentIds: string[]; foreignCommentIds: string[]; replyAnchorCounts: Record<string, number> }>;
|
|
}
|
|
export function readConversationLinkDiagnostics(input: Pick<ReturnType<typeof conversationLinkBindings>, "anchors" | "replies">): Omit<ConversationLinkDiagnostics, "render"> {
|
|
const threadSelector = '[data-testid="task-chat-thread"], [data-testid="thread-root"]';
|
|
return { expectedReplyIds: input.replies, savedCommentCount: input.anchors.length,
|
|
threads: Array.from(document.querySelectorAll(threadSelector)).map(root => {
|
|
const ids = Array.from(root.querySelectorAll('[id^="comment-"]')).filter(node => node.closest(threadSelector) === root).map(node => node.id.slice("comment-".length));
|
|
return { testId: root.getAttribute("data-testid"), visible: root.getClientRects().length > 0,
|
|
renderedCommentIds: ids.filter(id => input.anchors.includes(id)), foreignCommentIds: ids.filter(id => !input.anchors.includes(id)),
|
|
replyAnchorCounts: Object.fromEntries(input.replies.map(id => [id, root.querySelector(`[id="comment-${id}"]`)?.querySelectorAll("a[href]").length ?? 0])) };
|
|
}) };
|
|
}
|
|
export async function collectConversationLinksWithDiagnostics(page: Page, input: ConversationLinkInput): Promise<{ links: RenderedConversationLink[];
|
|
rejected?: Array<RenderedConversationLink & { reason: UnservedLinkReason }>; diagnostics?: ConversationLinkDiagnostics }> {
|
|
const bindings = conversationLinkBindings(input);
|
|
const render = await waitForLatestConversationReplyRender(page, bindings);
|
|
const { links, rejected } = partitionServedConversationLinks(await page.evaluate(readConversationDomLinks, bindings), input);
|
|
if (rejected.length) console.info(`[chat-rendered-links] links that open no served route: ${JSON.stringify(rejected.map(row => ({ href: row.href, reason: row.reason })))}`);
|
|
const kept = rejected.length ? { rejected } : {};
|
|
if (links.length || !bindings.replies.length) return { links, ...kept };
|
|
let diagnostics: ConversationLinkDiagnostics;
|
|
try { diagnostics = { render, ...await page.evaluate(readConversationLinkDiagnostics, { anchors: bindings.anchors, replies: bindings.replies }) }; }
|
|
catch { diagnostics = { render, expectedReplyIds: bindings.replies, savedCommentCount: bindings.anchors.length, threads: [] }; }
|
|
// Logged so an empty capture says whether the thread was closed, another conversation, or the reply had no anchors yet.
|
|
console.info(`[chat-rendered-links] no rendered reply links: ${JSON.stringify(diagnostics)}`);
|
|
return { links, ...kept, diagnostics };
|
|
}
|
|
export function conversationLinkLocator(page: Page, link: RenderedConversationLink): Locator {
|
|
const thread = page.getByTestId(link.threadTestId).filter({ has: page.locator(`[id=${JSON.stringify(`comment-${link.anchorCommentId}`)}]`) });
|
|
return link.source === "reply"
|
|
? thread.locator(`[id=${JSON.stringify(`comment-${link.commentId}`)}] a[href=${JSON.stringify(link.href)}]`)
|
|
: thread.getByRole("article", { name: link.cardLabel!, exact: true }).locator(`a[href=${JSON.stringify(link.href)}]`);
|
|
}
|