mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-16 11:59:26 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - The chat eval catalog checks real chat journeys against saved product state > - Full cohort 12 (OpenCode with `openrouter/deepseek/deepseek-v4.1-flash-1017`) failed three cases where the agent did the correct thing > - In each case the harness, not the product, broke the journey: it left a page too early, could not answer a choice card, or pressed keys faster than the drag library listens > - A harness that breaks the journey cannot measure the product > - This pull request makes the harness act like a person in these three journeys, counts a verified card choice as a human action, and keeps each check able to fail a broken product > - The benefit is that these three cases measure the product again ## Linked Issues or Issue Description **What happened?** In full cohort 12, three cases failed for harness reasons: - `agents.choose-primary`: the CEO answered correctly. The harness clicked the crown and confirmed. Then it waited for "My primary agent" with `.first()`. The sidebar already showed the CEO's crown, so this wait passed at once. The harness then navigated away before the browser sent `PUT /primary-agent/me`. The server log has no PUT. The read-back still showed the CEO. - `tasks.ambiguous-task`: the CEO changed nothing and asked a correct question card. The card linked both tasks and offered "COM-1 (Launch project)", "COM-2 (Experiments project)" and "Both tasks". The harness could only answer with a text box or an "Other" option. It threw "The linked question has no supported explicit clarification input". - `steering.edit-queued-message`: the person's edit saved (PATCH 200). The keyboard reorder (Space, ArrowUp, Space) sent no `PUT /queued-comments/order` in 2 gestures. Cohort 9 had the same failure. **Expected behavior** Each journey completes as a person does it, and the oracle grades the saved result. **Steps to reproduce** 1. Use master `f7ddab8e94`. 2. Run the Runner Full-Stack E2E workflow with `all=false` and the three case ids `chat-features.runner-opencode.local.<case>`. 3. Read each case's `playwright.log` and `server.log`. **Additional context** - Primary agent: the crown fills at once (optimistic update) and the save starts on confirm. The mutation lives in the app-level `PrimaryAgentProvider`, so in-app navigation does not cancel it. In the failed run the confirm and the full-page `goto` happened within the same second, and the PUT never reached the server. Only a full page load in the first milliseconds can lose the save. A person cannot do that in practice, so this is not a product bug. No UI change. - Keyboard reorder: dnd-kit's `KeyboardSensor` starts the drag on Space, adds its keydown listener in a `setTimeout`, and `sortableKeyboardCoordinates` ignores arrows until the rows are measured on a later render. Keys pressed back to back can arrive before this. In the production Storybook story (headless Chromium), back-to-back `locator.press` moved the item in 6 of 8 tries. Keys about 150 ms apart moved it 5 of 5 times, also after an Edit and Save. With the drag-start wait and a paint between keys it moved 16 of 16 times, also at 6x CPU throttle. The keyboard reorder works for people, so this is not a product bug. No UI change. ## What Changed - `runtime-primary.ts`: wait for the browser's own `PUT /primary-agent/me` that names Morgan, require 2xx, and poll the read-back until Morgan is primary before leaving the page. Look for the "My primary agent" crown only in the header that holds Morgan's avatar. Add `isPrimarySaveRequest`. Oracle `runtime-primary.v6`. - `chat-linked-question.ts` / `internal-tasks.ts`: add `chosenTaskOption`. It finds the one option of the bound saved question that names the Launch task's identifier (a setup literal) and no other candidate's. It uses the option id for the rendered DOM id and the payload's submit label. It does not read option wording. The harness selects that option, checks `aria-checked`, submits, and waits for the `respond` POST. The old text and "Other" paths stay for other cards. The checks that nothing changes before the answer and that only COM-1 changes after it are unchanged. - `chat-catalog-contract.ts` / `internal-tasks.ts`: a chosen option saves no comment, so the flow counted only one human action and failed `catalog-original-human-query`. `tasks.ambiguous-task` now joins the cases that may count a bound UI answer. The case declares `expectedHumanQuestionAnswer` only after the harness answered through the choice, and names the chosen question and option. The flow then verifies the answered card independently: answered by this person, exactly the Launch option and no typed text, one audit event, and one continuation run after it. Oracle `internal.ambiguous-task.v8`. - `chat-catalog-contract.ts`: `chatCatalogHumanQuestionPolicies` takes the answering person and mirrors the server's user rule in `evaluateIssueThreadInteractionResolverAudience`. `anyone` and `human_only` admit the person. `not_creator` admits a person who did not create the card. With no resolver (a pending card) `not_creator` stays rejected, so other callers keep their behavior. For the ambiguous-task choice, an unaddressed card is accepted, as the server allows. - `runtime-queue.ts`: `keyboardMoveQueuedMessageUp` waits for the handle's `aria-pressed="true"` after Space. It lets the page paint before ArrowUp and before the closing Space. It records whether each gesture started a drag. Oracle `edit-queued-message.structural.v7`. - No scenario YAML changed, so the TestOps manifest needs no entry. ## Verification - `npx vitest run --config tests/runner-e2e/vitest.config.ts` for `chat-linked-question.test.ts`, `chat-catalog-consistency.test.ts`, `runtime-primary.test.ts`, `runtime-queue.test.ts`, `internal.test.ts`, `external-company-secret.test.ts`, `external-personal-secret.test.ts`, `turn-response-card.test.ts`, `runtime-task-coordination.test.ts`: pass. - Red/green: the two new keyboard tests fail on the old `keyboardMoveQueuedMessageUp` and pass on the new one. The resolver-policy test fails on the old `chatCatalogHumanQuestionPolicies` (`not_creator` answered by a person who is not the creator) and passes on the new one; `not_creator` answered by its creator and a pending card stay rejected. The choice-accounting test fails on the old allow list. - `chosenTaskOption` tests use the cohort 12 card shape, a reworded card, and cards with no single choice (both, duplicate, neither, `COM-10`, a different card). - `npx tsc -p tests/runner-e2e/tsconfig.json --noEmit`: pass. `node --test tests/runner-e2e/chat-full-catalog-testops-manifest.test.mjs`: 10 pass. - Paid narrow run 1 (commit `33399f8370`): https://github.com/paperclipai/paperclip/actions/runs/43446445525. `agents.choose-primary` passed (browser `PUT /primary-agent/me` 200). `steering.edit-queued-message` passed (browser `PUT /queued-comments/order` 200). `tasks.ambiguous-task` selected COM-1 (`respond` 200, only COM-1 became high) but failed `catalog-original-human-query`, because the flow did not count the choice. Later commits fix that. - Paid narrow run 2 (`c90c2aa26a`) was cancelled by run 3 before its case finished. - Paid narrow run 3 (`tasks.ambiguous-task` only, final verifier `fee3bbd453`): https://github.com/paperclipai/paperclip/actions/runs/43452010284 ## Risks - Low risk. Test harness only. - The ambiguous-task harness now answers through a structured choice when one exists. If the agent asks a card with no option that names only the Launch task, the old text and "Other" paths still apply. - `chatCatalogHumanQuestionPolicies` accepts `not_creator` only when a resolver is passed. Callers that check pending cards pass none, so their behavior is unchanged. ## Model Used - Claude Opus 5.5 (`claude-opus-5-5`), Anthropic, via Claude Code with tool use and code execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
103 lines
9.7 KiB
TypeScript
103 lines
9.7 KiB
TypeScript
import { chatCatalogTasks } from "./chat-feature-cases.js";
|
|
import { expect, it, vi } from "vitest";
|
|
import { validateChatCatalogConsistency } from "./chat-catalog-consistency.js";
|
|
import { chatCatalogCases } from "./chat-catalog-registry.js";
|
|
import { chatCatalogScenarios } from "./chat-catalog-inventory.js";
|
|
import { validChatCatalogHumanCounts, chatCatalogHumanHistoryMatches } from "./chat-catalog-contract.js";
|
|
|
|
it("loads all 242 actual lazy declarations through the admission loaders without executing fixtures", async () => {
|
|
expect(chatCatalogCases).toHaveLength(242);
|
|
expect([...chatCatalogCases.map(row => row.scenarioId), "tasks.create-backlog", "tasks.delegate-announcement"].sort())
|
|
.toEqual(chatCatalogScenarios.map(row => row.id).sort());
|
|
expect(await validateChatCatalogConsistency()).toEqual({ descriptorCount: 242, fixtureCallbacksInvoked: 0 });
|
|
});
|
|
it("rejects actual declaration drift before any fixture callback executes", async () => {
|
|
const descriptor = chatCatalogCases.find(row => row.scenarioId === "agents.hire-denied")!;
|
|
const callback = vi.fn(() => { throw new Error("Fixture must not execute during preflight"); });
|
|
const runtime = { ...descriptor, setup: callback, observe: callback, grade: callback, verifyResult: callback };
|
|
const importer = async () => ({ [descriptor.exportName]: [runtime] });
|
|
await expect(validateChatCatalogConsistency([descriptor], importer)).resolves.toMatchObject({ descriptorCount: 1 });
|
|
await expect(validateChatCatalogConsistency([{ ...descriptor, sourceFiles: [...descriptor.sourceFiles, "unreviewed.ts"] }], importer)).rejects.toThrow("Runtime descriptor drift");
|
|
await expect(validateChatCatalogConsistency([{ ...descriptor, expectedRunCount: descriptor.expectedRunCount + 1 }], importer)).rejects.toThrow("Runtime descriptor drift");
|
|
expect(callback).not.toHaveBeenCalled();
|
|
});
|
|
it("preserves the effective one-human limit when optional declaration defaults are used", () => {
|
|
const choice = chatCatalogCases.find(row => row.scenarioId === "execution-environments.choose-capable-target")!;
|
|
const explicit = { ...choice, expectedHumanMessageCount: 1 };
|
|
const effective = (row: typeof choice) => row.expectedHumanMessageCount ?? 1;
|
|
expect(effective(choice)).toBe(1); expect(effective(explicit)).toBe(1);
|
|
expect(validChatCatalogHumanCounts(choice)).toBe(true); expect(validChatCatalogHumanCounts(explicit)).toBe(true);
|
|
expect(validChatCatalogHumanCounts({ ...choice, expectedHumanMessageCount: 0 })).toBe(false);
|
|
const history = { human: [{ id: "canonical", body: "Original query" }], runIds: [], boundary: { humanCommentIds: [], runIds: [] }, renderedQuery: "Original query" };
|
|
for (const implementation of [choice, explicit]) {
|
|
expect(chatCatalogHumanHistoryMatches({ ...history, implementation })).toBe(true);
|
|
expect(chatCatalogHumanHistoryMatches({ ...history, implementation, human: [] })).toBe(false);
|
|
expect(chatCatalogHumanHistoryMatches({ ...history, implementation, human: [...history.human, { id: "extra", body: "Hidden nudge" }] })).toBe(false);
|
|
}
|
|
});
|
|
|
|
it("declares company approval as a static optional extra action without invoking callbacks",async()=>{
|
|
const descriptor=chatCatalogCases.find(row=>row.scenarioId==="secrets.configure-company-secret")!;
|
|
expect(descriptor).toMatchObject({expectedRunCount:3,minimumRunCount:2,expectedHumanMessageCount:2,optionalCompanySecretBindingApproval:true});
|
|
expect(chatCatalogTasks.find(t=>t.id===descriptor.scenarioId)).toMatchObject({expectedRunCount:3,minimumExpectedRunCount:2,expectedHumanMessageCount:2,optionalCompanySecretBindingApproval:true});
|
|
expect(chatCatalogTasks.filter(t=>t.optionalCompanySecretBindingApproval).map(t=>t.id)).toEqual([descriptor.scenarioId]);
|
|
const callback=vi.fn(()=>{throw new Error("No fixture or proof callback during declaration validation");});
|
|
const runtime={...descriptor,setup:callback,observe:callback,grade:callback,verifyResult:callback,expectedCompanySecretBindingApproval:callback};
|
|
const importer=async()=>({[descriptor.exportName]:[runtime]});
|
|
await expect(validateChatCatalogConsistency([descriptor],importer)).resolves.toMatchObject({fixtureCallbacksInvoked:0});
|
|
await expect(validateChatCatalogConsistency([{...descriptor,optionalCompanySecretBindingApproval:undefined}],importer)).rejects.toThrow("Runtime descriptor drift");
|
|
expect(validChatCatalogHumanCounts({...descriptor,scenarioId:"secrets.personal-secret"})).toBe(false);
|
|
expect(callback).not.toHaveBeenCalled();
|
|
});
|
|
|
|
// Full cohort 12 fix run (tasks.ambiguous-task): the person chose the Launch option on the CEO's question card.
|
|
// A chosen option saves no comment, so the flow must count the independently verified answer as the second action.
|
|
it("counts a verified clarification choice as the ambiguous-task person's second action", async () => {
|
|
const { verifyChatCatalogHumanQuestionAnswer } = await import("./chat-catalog-contract.js");
|
|
const { answeredClarification } = await import("./chat-catalog-domains/internal-tasks.js");
|
|
const implementation = chatCatalogCases.find(row => row.scenarioId === "tasks.ambiguous-task")!;
|
|
const expected = answeredClarification({ state: { answeredQuestion: { interactionId: "card", sourceRunId: "first", userId: "person", questionId: "landing_page_task", optionId: "com-1" } } })!;
|
|
expect(expected).toEqual({ interactionId: "card", sourceRunId: "first", userId: "person", clarificationChoice: { questionId: "landing_page_task", optionId: "com-1" } });
|
|
expect(answeredClarification({ state: { answeredQuestion: { interactionId: "card", sourceRunId: "first", userId: null } } })).toBeUndefined();
|
|
expect(answeredClarification({ state: {} })).toBeUndefined();
|
|
const card = { id: "card", kind: "ask_user_questions", status: "answered", companyId: "co", issueId: "chat", sourceRunId: "first", createdByAgentId: "ceo",
|
|
createdByUserId: null, addresseeUserId: "person", addresseeAgentId: null, resolverPolicy: "anyone", effectiveResolverPolicy: "anyone",
|
|
resolvedByUserId: "person", resolvedByAgentId: null, resolvedAt: "2026-11-13T15:01:47Z",
|
|
result: { answers: [{ questionId: "landing_page_task", optionIds: ["com-1"] }] } };
|
|
const audit = { companyId: "co", entityId: "chat", action: "issue.thread_interaction_answered", actorType: "user", actorId: "person",
|
|
details: { interactionId: "card", interactionKind: "ask_user_questions", interactionStatus: "answered" } };
|
|
const runs = [
|
|
{ id: "first", companyId: "co", agentId: "ceo", status: "succeeded", runtimeMode: "native", startedAt: "2026-11-13T15:00:30Z", contextSnapshot: { issueId: "chat", commentId: "query" } },
|
|
{ id: "second", companyId: "co", agentId: "ceo", status: "succeeded", runtimeMode: "native", startedAt: "2026-11-13T15:01:48Z", contextSnapshot: { issueId: "chat", interactionId: "card" } },
|
|
];
|
|
const verify = (overrides: Record<string, unknown> = {}, rows = runs) => verifyChatCatalogHumanQuestionAnswer({ expected, companyId: "co", issueId: "chat", agentId: "ceo",
|
|
canonicalComment: { id: "query", authorUserId: "person" }, interactions: [{ ...card, ...overrides } as never], activity: [audit], runs: rows });
|
|
const answer = verify();
|
|
expect(answer).toMatchObject({ continuationRunId: "second" });
|
|
// A typed "Other" answer, an unanswered card, or no continuation run is not a verified choice.
|
|
expect(verify({ result: { answers: [{ questionId: "landing_page_task", optionIds: [], otherText: "COM-1" }] } })).toBeUndefined();
|
|
expect(verify({ status: "pending" })).toBeUndefined();
|
|
// The product lets the person answer an unaddressed card, or one any resolver but its agent creator may answer.
|
|
expect(verify({ addresseeUserId: null, resolverPolicy: "not_creator", effectiveResolverPolicy: "not_creator" })).toMatchObject({ continuationRunId: "second" });
|
|
expect(verify({ resolverPolicy: "agent_only", effectiveResolverPolicy: "agent_only" })).toBeUndefined();
|
|
expect(verify({ addresseeUserId: "someone-else" })).toBeUndefined();
|
|
// The saved choice must be the Launch option alone.
|
|
expect(verify({ result: { answers: [{ questionId: "landing_page_task", optionIds: ["com-2"] }] } })).toBeUndefined();
|
|
expect(verify({ result: { answers: [{ questionId: "landing_page_task", optionIds: ["com-1", "com-2"] }] } })).toBeUndefined();
|
|
expect(verify({}, runs.slice(0, 1))).toBeUndefined();
|
|
const history = { human: [{ id: "query", body: "Mark the landing-page task as high priority." }], runIds: ["first", "second"],
|
|
boundary: { humanCommentIds: [], runIds: [] }, renderedQuery: "Mark the landing-page task as high priority." };
|
|
expect(chatCatalogHumanHistoryMatches({ ...history, implementation, questionAnswer: answer })).toBe(true);
|
|
expect(chatCatalogHumanHistoryMatches({ ...history, implementation })).toBe(false);
|
|
expect(chatCatalogHumanHistoryMatches({ ...history, implementation: { ...implementation, scenarioId: "tasks.edit-properties" }, questionAnswer: answer })).toBe(false);
|
|
});
|
|
it("accepts a not_creator card resolved by a person other than its creator, as the server does", async () => {
|
|
const { chatCatalogHumanQuestionPolicies } = await import("./chat-catalog-contract.js");
|
|
const notCreator = { resolverPolicy: "not_creator", requestedResolverPolicy: "not_creator", effectiveResolverPolicy: "not_creator" };
|
|
expect(chatCatalogHumanQuestionPolicies({ ...notCreator, createdByUserId: null }, { userId: "person" })).toBe(true);
|
|
expect(chatCatalogHumanQuestionPolicies({ ...notCreator, createdByUserId: "person" }, { userId: "person" })).toBe(false);
|
|
expect(chatCatalogHumanQuestionPolicies({ ...notCreator, createdByUserId: null })).toBe(false);
|
|
expect(chatCatalogHumanQuestionPolicies({ resolverPolicy: "anyone", effectiveResolverPolicy: "human_only" })).toBe(true);
|
|
expect(chatCatalogHumanQuestionPolicies({ resolverPolicy: "agent_only" }, { userId: "person" })).toBe(false);
|
|
});
|