mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-14 08:26:46 +02:00
## Thinking Path > - Paperclip is a control plane for AI-agent companies, with the CLI acting as a scriptable operator and agent interface to that control plane. > - The REST API surface has grown across companies, agents, issues, routines, plugins, auth, workspaces, secrets, and operational inspection commands. > - The CLI had drifted from that API surface: some commands were missing, some command shapes differed from docs/reference material, and several edge cases only failed during end-to-end local-source testing. > - The local development runbook requires these tests to be disposable and isolated from a real `~/.paperclip`, `~/.codex`, or `~/.claude` installation. > - This pull request adds broad CLI/API parity coverage, fixes the actionable bugs found during that pass, and records the reproducible test log under `doc/logs`. > - The benefit is a more complete, scriptable CLI surface with regression coverage for the command families exercised by the parity run. ## What Changed - Added or expanded CLI command coverage for access/auth, companies, agents, projects, goals, issues and subresources, routines, plugins, workspaces, activity/run/cost/dashboard inspection, assets, skills, secrets, tokens, prompt/wake flows, and local setup helpers. - Fixed CLI/API parity bugs found during the run, including context profile patching, issue interaction optional payloads, malformed tree-hold errors, environment duplicate handling, configure invalid-section exit codes, worktree pnpm invocation, token agent ID resolution, plugin tool worker lookup, and routine webhook secret cleanup. - Added missing CLI wrappers and route coverage for health/access, invite resolution URL forwarding, join status normalization, secret lifecycle commands, LLM docs routes, available-skill isolation, positive board-claim coverage, and interactive `connect` prompt-flow tests. - Added a schema-backed `/api/openapi.json` route sufficient for CLI parity and `paperclipai openapi --json` smoke coverage. - Added `doc/logs/2026-05-24-cli-api-parity-e2e-log.md` with the detailed living test/bug log and renamed the log directory from `doc/bugs` to `doc/logs`. - Added `doc/plans/2026-05-23-cli-api-parity.md` and the OpenAPI parity reference used during the pass. OpenAPI note: this PR intentionally does not try to subsume `feature/openapi-spec`. The OpenAPI implementation here is schema-backed and better than the earlier route-inventory stub, but `feature/openapi-spec` is the fuller/better OpenAPI branch because it includes exact mounted-route coverage tests and additional current route coverage. That branch should stay as its own PR and can supersede this OpenAPI route implementation. ## Verification Targeted automated checks run: - `pnpm exec vitest run server/src/__tests__/openapi-routes.test.ts` - `pnpm exec vitest run server/src/__tests__/board-claim.test.ts` - `pnpm exec vitest run cli/src/__tests__/connect.test.ts` - `pnpm exec vitest run cli/src/__tests__/agent-lifecycle.test.ts` - `pnpm exec vitest run server/src/__tests__/plugin-database.test.ts` - `pnpm exec vitest run server/src/__tests__/routines-service.test.ts` - `pnpm --dir cli typecheck` - `pnpm --dir server typecheck` Manual/local E2E verification: - Ran the full disposable local-source CLI/API parity pass with isolated `PAPERCLIP_HOME`, `PAPERCLIP_CONFIG`, `PAPERCLIP_CONTEXT`, `PAPERCLIP_AUTH_STORE`, `CODEX_HOME`, and `CLAUDE_HOME` under `tmp/cli-api-parity`. - Verified `DATABASE_URL` and `DATABASE_MIGRATION_URL` stayed unset for the scratch server. - Verified live health and schema-backed OpenAPI responses on non-default port `3197`. - Revoked created board/agent tokens and cleaned up temporary plugins, secrets, non-default environments, and project workspaces. - See `doc/logs/2026-05-24-cli-api-parity-e2e-log.md` for the full command-by-command reproduction log. Not run: - Full `pnpm test`, `pnpm test:run`, or `pnpm build` were not run after the entire branch because the branch is broad and the parity pass used focused test/typecheck verification plus live isolated CLI reruns. ## Risks - This is a broad PR and touches many CLI command modules, so review surface is high. The changes are grouped around one theme, but a split may be easier if maintainers prefer narrower PRs. - The OpenAPI route in this PR is not the final/best OpenAPI implementation. `feature/openapi-spec` has stronger exact-route coverage and should remain the source for the dedicated OpenAPI PR. - The living log is intentionally detailed and large. It is useful for reproducibility but adds documentation weight. - No UI changes are intended; screenshots are not applicable. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-based coding agent in Codex desktop. Exact served model/context-window identifier was not exposed in the local app. Work used shell/Git/GitHub CLI tooling, local source inspection, targeted test execution, and live isolated Paperclip CLI/API smoke testing. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Devin Foley <devin@devinfoley.com>
322 lines
11 KiB
TypeScript
322 lines
11 KiB
TypeScript
import { Command } from "commander";
|
|
import type { HeartbeatRun, HeartbeatRunEvent, Issue, WorkspaceOperation } from "@paperclipai/shared";
|
|
import {
|
|
addCommonClientOptions,
|
|
apiPath,
|
|
formatInlineRecord,
|
|
handleCommandError,
|
|
printOutput,
|
|
resolveCommandContext,
|
|
type BaseClientOptions,
|
|
} from "./common.js";
|
|
|
|
interface RunListOptions extends BaseClientOptions {
|
|
agentId?: string;
|
|
limit?: string;
|
|
}
|
|
|
|
interface RunLiveOptions extends BaseClientOptions {
|
|
limit?: string;
|
|
minCount?: string;
|
|
}
|
|
|
|
interface RunEventsOptions extends BaseClientOptions {
|
|
afterSeq?: string;
|
|
limit?: string;
|
|
}
|
|
|
|
interface RunLogOptions extends BaseClientOptions {
|
|
offset?: string;
|
|
limitBytes?: string;
|
|
text?: boolean;
|
|
}
|
|
|
|
interface RunWatchdogOptions extends BaseClientOptions {
|
|
decision: string;
|
|
reason?: string;
|
|
snoozedUntil?: string;
|
|
evaluationIssueId?: string;
|
|
}
|
|
|
|
interface RunIssueSummary extends Issue {
|
|
runId?: string;
|
|
runStatus?: string;
|
|
}
|
|
|
|
export function registerRunCommands(command: Command): void {
|
|
addCommonClientOptions(
|
|
command
|
|
.command("list")
|
|
.description("List heartbeat runs for a company")
|
|
.option("-C, --company-id <id>", "Company ID")
|
|
.option("--agent-id <id>", "Filter by agent ID")
|
|
.option("--limit <n>", "Maximum runs to return")
|
|
.action(async (opts: RunListOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts, { requireCompany: true });
|
|
const params = new URLSearchParams();
|
|
if (opts.agentId) params.set("agentId", opts.agentId);
|
|
if (opts.limit) params.set("limit", opts.limit);
|
|
const query = params.toString();
|
|
const rows = (await ctx.api.get<HeartbeatRun[]>(
|
|
`${apiPath`/api/companies/${ctx.companyId}/heartbeat-runs`}${query ? `?${query}` : ""}`,
|
|
)) ?? [];
|
|
printRuns(rows, ctx.json);
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
{ includeCompany: false },
|
|
);
|
|
|
|
addCommonClientOptions(
|
|
command
|
|
.command("live")
|
|
.description("List queued and running heartbeat runs for a company")
|
|
.option("-C, --company-id <id>", "Company ID")
|
|
.option("--limit <n>", "Maximum runs to return")
|
|
.option("--min-count <n>", "Pad with recent completed runs up to this count")
|
|
.action(async (opts: RunLiveOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts, { requireCompany: true });
|
|
const params = new URLSearchParams();
|
|
if (opts.limit) params.set("limit", opts.limit);
|
|
if (opts.minCount) params.set("minCount", opts.minCount);
|
|
const query = params.toString();
|
|
const rows = (await ctx.api.get<HeartbeatRun[]>(
|
|
`${apiPath`/api/companies/${ctx.companyId}/live-runs`}${query ? `?${query}` : ""}`,
|
|
)) ?? [];
|
|
printRuns(rows, ctx.json);
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
{ includeCompany: false },
|
|
);
|
|
|
|
addCommonClientOptions(
|
|
command
|
|
.command("get")
|
|
.description("Get a heartbeat run")
|
|
.argument("<runId>", "Heartbeat run ID")
|
|
.action(async (runId: string, opts: BaseClientOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts);
|
|
const run = await ctx.api.get<HeartbeatRun>(apiPath`/api/heartbeat-runs/${runId}`);
|
|
printOutput(run, { json: ctx.json });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
);
|
|
|
|
addCommonClientOptions(
|
|
command
|
|
.command("cancel")
|
|
.description("Cancel a queued or running heartbeat run")
|
|
.argument("<runId>", "Heartbeat run ID")
|
|
.action(async (runId: string, opts: BaseClientOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts);
|
|
const run = await ctx.api.post<HeartbeatRun | null>(apiPath`/api/heartbeat-runs/${runId}/cancel`, {});
|
|
printOutput(run, { json: ctx.json });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
);
|
|
|
|
addCommonClientOptions(
|
|
command
|
|
.command("events")
|
|
.description("List heartbeat run events")
|
|
.argument("<runId>", "Heartbeat run ID")
|
|
.option("--after-seq <n>", "Only return events after this sequence", "0")
|
|
.option("--limit <n>", "Maximum events to return", "200")
|
|
.action(async (runId: string, opts: RunEventsOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts);
|
|
const params = new URLSearchParams();
|
|
if (opts.afterSeq) params.set("afterSeq", opts.afterSeq);
|
|
if (opts.limit) params.set("limit", opts.limit);
|
|
const events = (await ctx.api.get<HeartbeatRunEvent[]>(
|
|
`${apiPath`/api/heartbeat-runs/${runId}/events`}?${params.toString()}`,
|
|
)) ?? [];
|
|
if (ctx.json) {
|
|
printOutput(events, { json: true });
|
|
return;
|
|
}
|
|
for (const event of events) {
|
|
console.log(formatInlineRecord({
|
|
seq: event.seq,
|
|
eventType: event.eventType,
|
|
stream: event.stream,
|
|
level: event.level,
|
|
message: event.message,
|
|
}));
|
|
}
|
|
if (events.length === 0) printOutput([], { json: false });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
);
|
|
|
|
addCommonClientOptions(
|
|
command
|
|
.command("log")
|
|
.description("Read heartbeat run log bytes")
|
|
.argument("<runId>", "Heartbeat run ID")
|
|
.option("--offset <bytes>", "Byte offset", "0")
|
|
.option("--limit-bytes <bytes>", "Maximum bytes to read")
|
|
.option("--text", "Print only the log text when the API returns a text field")
|
|
.action(async (runId: string, opts: RunLogOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts);
|
|
const result = await fetchLog(ctx.api, apiPath`/api/heartbeat-runs/${runId}/log`, opts);
|
|
printLogResult(result, { json: ctx.json, text: opts.text });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
);
|
|
|
|
addCommonClientOptions(
|
|
command
|
|
.command("issues")
|
|
.description("List issues associated with a heartbeat run")
|
|
.argument("<runId>", "Heartbeat run ID")
|
|
.action(async (runId: string, opts: BaseClientOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts);
|
|
const rows = (await ctx.api.get<RunIssueSummary[]>(apiPath`/api/heartbeat-runs/${runId}/issues`)) ?? [];
|
|
printOutput(rows.map((row) => ({
|
|
identifier: row.identifier,
|
|
id: row.id,
|
|
status: row.status,
|
|
priority: row.priority,
|
|
title: row.title,
|
|
runStatus: row.runStatus,
|
|
})), { json: ctx.json });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
);
|
|
|
|
addCommonClientOptions(
|
|
command
|
|
.command("workspace-operations")
|
|
.description("List workspace operations for a heartbeat run")
|
|
.argument("<runId>", "Heartbeat run ID")
|
|
.action(async (runId: string, opts: BaseClientOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts);
|
|
const rows = (await ctx.api.get<WorkspaceOperation[]>(
|
|
apiPath`/api/heartbeat-runs/${runId}/workspace-operations`,
|
|
)) ?? [];
|
|
printOutput(rows.map((row) => ({
|
|
id: row.id,
|
|
status: row.status,
|
|
phase: row.phase,
|
|
command: row.command,
|
|
cwd: row.cwd,
|
|
logBytes: row.logBytes,
|
|
})), { json: ctx.json });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
);
|
|
|
|
addCommonClientOptions(
|
|
command
|
|
.command("workspace-log")
|
|
.description("Read a workspace operation log")
|
|
.argument("<operationId>", "Workspace operation ID")
|
|
.option("--offset <bytes>", "Byte offset", "0")
|
|
.option("--limit-bytes <bytes>", "Maximum bytes to read")
|
|
.option("--text", "Print only the log text when the API returns a text field")
|
|
.action(async (operationId: string, opts: RunLogOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts);
|
|
const result = await fetchLog(ctx.api, apiPath`/api/workspace-operations/${operationId}/log`, opts);
|
|
printLogResult(result, { json: ctx.json, text: opts.text });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
);
|
|
|
|
addCommonClientOptions(
|
|
command
|
|
.command("watchdog-decision")
|
|
.description("Record a watchdog decision for a heartbeat run")
|
|
.argument("<runId>", "Heartbeat run ID")
|
|
.requiredOption("--decision <decision>", "snooze, continue, or dismissed_false_positive")
|
|
.option("--reason <text>", "Decision reason")
|
|
.option("--snoozed-until <iso8601>", "Required for snooze decisions")
|
|
.option("--evaluation-issue-id <id>", "Related watchdog evaluation issue ID")
|
|
.action(async (runId: string, opts: RunWatchdogOptions) => {
|
|
try {
|
|
const ctx = resolveCommandContext(opts);
|
|
const decision = await ctx.api.post(apiPath`/api/heartbeat-runs/${runId}/watchdog-decisions`, {
|
|
decision: opts.decision,
|
|
reason: opts.reason,
|
|
snoozedUntil: opts.snoozedUntil,
|
|
evaluationIssueId: opts.evaluationIssueId,
|
|
});
|
|
printOutput(decision, { json: ctx.json });
|
|
} catch (err) {
|
|
handleCommandError(err);
|
|
}
|
|
}),
|
|
);
|
|
}
|
|
|
|
async function fetchLog(
|
|
api: { get<T>(path: string): Promise<T | null> },
|
|
path: string,
|
|
opts: RunLogOptions,
|
|
): Promise<unknown> {
|
|
const params = new URLSearchParams();
|
|
if (opts.offset) params.set("offset", opts.offset);
|
|
if (opts.limitBytes) params.set("limitBytes", opts.limitBytes);
|
|
return api.get(`${path}?${params.toString()}`);
|
|
}
|
|
|
|
function printRuns(rows: HeartbeatRun[], json: boolean): void {
|
|
if (json) {
|
|
printOutput(rows, { json: true });
|
|
return;
|
|
}
|
|
for (const row of rows) {
|
|
console.log(formatInlineRecord({
|
|
id: row.id,
|
|
status: row.status,
|
|
agentId: row.agentId,
|
|
invocationSource: row.invocationSource,
|
|
triggerDetail: row.triggerDetail,
|
|
startedAt: row.startedAt,
|
|
finishedAt: row.finishedAt,
|
|
logBytes: row.logBytes,
|
|
}));
|
|
}
|
|
if (rows.length === 0) printOutput([], { json: false });
|
|
}
|
|
|
|
function printLogResult(result: unknown, opts: { json: boolean; text?: boolean }): void {
|
|
if (opts.json) {
|
|
printOutput(result, { json: true });
|
|
return;
|
|
}
|
|
|
|
if (opts.text && typeof result === "object" && result !== null && "text" in result) {
|
|
const text = (result as { text?: unknown }).text;
|
|
process.stdout.write(typeof text === "string" ? text : String(text ?? ""));
|
|
return;
|
|
}
|
|
|
|
printOutput(result, { json: false });
|
|
}
|