mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-11 14:10:50 +02:00
## Thinking Path
> - Paperclip is the open source app people use to manage AI agents for
work
> - Agents do that work in isolated git worktrees, and a managed
worktree runs its own Paperclip instance with a cloned database
> - That clone needs a seed source, and the source must come from
server-owned registration, never from state the workspace itself can
rewrite
> - The seed-source resolver requires the registered base project
workspace to hold its own `.paperclip/config.json`
> - A managed project workspace is a plain `git clone`, and no code
writes that file into it
> - Every isolated worktree provision, deferred seed, and workspace
repair therefore fails on a managed checkout
> - This pull request lets a named source supply the config when the
base checkout has none
> - The benefit is that managed worktrees provision again, and the seed
source stays server-owned
## Linked Issues or Issue Description
No public GitHub issue exists for this problem. It is described below.
**What happened?**
Agent runs that need an isolated worktree fail during provisioning. The
provision command exits with this error (paths redacted):
```
Execution workspace provision command "bash ./scripts/provision-worktree.sh" failed:
Registered base project workspace has no canonical Paperclip config:
<instance-home>/instances/default/projects/<company-id>/<project-id>/<repo>/.paperclip/config.json
```
`resolveRegisteredWorktreeSeedSource` sets `registeredConfigPath` to
`<baseCwd>/.paperclip/config.json` whenever the caller names a
registered base workspace. It then requires that file to exist.
`scripts/provision-worktree.sh` applies the same rule.
A managed project workspace never has that file.
`materializeManagedProjectWorkspace` creates it with `git clone` and a
rename, so the checkout holds repository content only. The control plane
keeps its config at `<home>/instances/<id>/config.json` instead.
The failure reaches three paths: worktree provisioning, deferred seeding
through `worktree ensure-seeded`, and workspace repair.
The behavior changed in #11671. That pull request replaced a fallback
chain with a single hard requirement. Fixture code in
`scripts/__tests__/provision-worktree-self-heal.test.mjs` writes a
config into the fake base workspace, so tests kept passing.
**Expected behavior**
A managed worktree provisions and seeds from the registered source. The
seed manifest still never selects that source.
**Steps to reproduce**
1. Register the Paperclip repository as a project with a `repoUrl`, so
the server materializes a managed checkout.
2. Assign an issue to an agent whose workspace strategy is
`git_worktree`.
3. Watch the workspace operation log for the provision command.
4. The command exits non-zero with the error above.
**Paperclip version or commit**
Reproduced on `master` at 01ddc26a3.
**Deployment mode**
`local_trusted`, single instance.
**Database mode**
Embedded PostgreSQL.
**Operating system**
Linux, Node.js 22.
**Related pull requests**
- Refs #11671 — introduced the requirement this pull request relaxes.
- Refs #11733 — open work on seed-source preflight. It reads the same
base-workspace config path and skips when the file is absent. It does
not change source selection.
- Refs #11735 — open work on provisioning reliability. It edits the same
four files and will need a rebase after either lands.
## What Changed
- `resolveRegisteredWorktreeSeedSource` sets the registered config path
only when `<baseCwd>/.paperclip/config.json` exists. This makes the
existing `registeredConfigPath ?? explicitSource` branch reachable for a
plain checkout.
- A base workspace that does hold its own config stays authoritative. A
mismatched explicit source is still rejected.
- The resolver throws a named error when the base workspace has no
config and no source is named.
- `readInstanceId` accepts an instance-root config at
`<home>/instances/<id>/config.json`. That layout names its instance by
directory and has no adjacent `.env`. Validation reuses
`resolvePaperclipInstanceId`.
- `scripts/provision-worktree.sh` and
`scripts/provision-worktree-runtime.sh` name the control plane's
instance config as the source when the base workspace has none. The
canonical-path and symlink checks stay.
- The workspace repair route supplies the same fallback, and only when
the base workspace has no config of its own.
- `doc/DEVELOPING.md` records the two source layouts.
## Verification
- `node --test scripts/__tests__/provision-worktree-self-heal.test.mjs`
— 10 tests pass. The fixture no longer writes a config into the base
workspace, so it models a real managed checkout. One test now creates
that config mid-test, which covers both layouts.
- `npx vitest run src/worktree-seed-source.test.ts` in `packages/shared`
— 4 tests pass. Two are new: one resolves an instance-root source, and
one still fails closed when no source exists.
- `npx vitest run src/__tests__/workspace-runtime.test.ts
src/__tests__/execution-workspaces-routes.test.ts
src/__tests__/execution-workspace-runtime-control-conflict.test.ts
src/__tests__/workspace-operations-reconciliation.test.ts
src/__tests__/worktree-seed-server-spawn.test.ts` in `server` — all
pass. Run them one file at a time. They share one test database, and
concurrent runs fail teardown.
- `npx vitest run src/__tests__/worktree.test.ts` in `cli` — 63 tests
pass.
- `pnpm --filter @paperclipai/shared typecheck` — clean.
- Manual check on a live instance: the resolver now returns the instance
config as the source for a managed checkout, with the source instance
`default` and a distinct target instance.
## Risks
Low to moderate.
- The relaxed rule applies only when the base workspace holds no config.
A base workspace that holds one keeps full authority, so the trust model
from #11671 is unchanged. The seed manifest still never selects the
source.
- The instance-id fallback reads a directory name. It applies only to
the `<home>/instances/<id>/config.json` layout, and
`resolvePaperclipInstanceId` rejects an unsafe segment.
- #11735 edits the same four files. Whichever pull request lands second
needs a rebase.
- `pnpm --filter @paperclipai/server typecheck` currently fails on this
checkout with duplicate `drizzle-orm` type instantiations. The failure
is present with and without this change, and the error count is
identical. It comes from an unrelated lockfile state, not from this pull
request.
## Model Used
Claude Opus 5 (`claude-opus-5`), by Anthropic, running in Claude Code.
Extended thinking was on. The model used file, search, and shell tools
to diagnose the failure on a live instance and to run the test suites.
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
462 lines
19 KiB
JavaScript
462 lines
19 KiB
JavaScript
import assert from "node:assert/strict";
|
|
import { spawnSync } from "node:child_process";
|
|
import test from "node:test";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const script = new URL("../provision-worktree.sh", import.meta.url).pathname;
|
|
const runtimeScript = new URL("../provision-worktree-runtime.sh", import.meta.url).pathname;
|
|
|
|
// Keep the PATH minimal so the fallback ladder is deterministic: node must be
|
|
// reachable, but a globally installed `paperclipai` must not shadow the paths
|
|
// under test.
|
|
const testPath = [path.dirname(process.execPath), "/usr/bin", "/bin"].join(":");
|
|
|
|
const cleanupDirs = [];
|
|
|
|
function makeTempDir(prefix) {
|
|
const dir = fs.mkdtempSync(path.join(os.tmpdir(), prefix));
|
|
cleanupDirs.push(dir);
|
|
return dir;
|
|
}
|
|
|
|
/**
|
|
* A control plane's own instance home. A managed project checkout carries no
|
|
* instance config of its own, so this is the seed source the scripts fall back to.
|
|
*/
|
|
function makeInstanceHome() {
|
|
const home = makeTempDir("paperclip-provision-instance-home-");
|
|
fs.mkdirSync(path.join(home, "instances", "default"), { recursive: true });
|
|
fs.writeFileSync(path.join(home, "instances", "default", "config.json"), "{}\n");
|
|
return home;
|
|
}
|
|
|
|
test.after(() => {
|
|
for (const dir of cleanupDirs) {
|
|
fs.rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
/**
|
|
* Writes a fake base workspace whose "tsx runner" is a plain node script, so
|
|
* the provision script's health check and init call can be steered per test.
|
|
*
|
|
* helpExit: exit code for `... index.ts --help` (the health check boot).
|
|
* initExit: exit code for `... index.ts worktree init ...`; on 0 the fake CLI
|
|
* writes a marker config so tests can tell CLI init from fallback.
|
|
*/
|
|
function makeBaseWorkspace({ helpExit, initExit, ensureExit = 0 }) {
|
|
const baseCwd = makeTempDir("paperclip-provision-base-");
|
|
const runnerPath = path.join(baseCwd, "cli", "node_modules", "tsx", "dist", "cli.mjs");
|
|
const entryPath = path.join(baseCwd, "cli", "src", "index.ts");
|
|
fs.mkdirSync(path.dirname(runnerPath), { recursive: true });
|
|
fs.mkdirSync(path.dirname(entryPath), { recursive: true });
|
|
fs.writeFileSync(entryPath, "// fake CLI entry\n");
|
|
fs.writeFileSync(
|
|
runnerPath,
|
|
`
|
|
import fs from "node:fs";
|
|
const cliArgs = process.argv.slice(3);
|
|
fs.appendFileSync(${JSON.stringify(path.join(baseCwd, "cli-invocations.log"))}, JSON.stringify(cliArgs) + "\\n");
|
|
if (cliArgs.includes("--help")) {
|
|
if (${helpExit} !== 0) console.error("ERR_MODULE_NOT_FOUND: drizzle-orm");
|
|
process.exit(${helpExit});
|
|
}
|
|
if (cliArgs[0] === "worktree" && cliArgs[1] === "init") {
|
|
if (${initExit} !== 0) {
|
|
console.error("fake worktree init failure");
|
|
process.exit(${initExit});
|
|
}
|
|
fs.mkdirSync(".paperclip", { recursive: true });
|
|
fs.writeFileSync(".paperclip/config.json", JSON.stringify({ $meta: { source: "fake-cli" } }));
|
|
fs.writeFileSync(".paperclip/.env", "PAPERCLIP_IN_WORKTREE=true\\n");
|
|
process.exit(0);
|
|
}
|
|
if (cliArgs[0] === "worktree" && cliArgs[1] === "ensure-seeded") {
|
|
if (${ensureExit} !== 0) {
|
|
console.error("fake worktree ensure-seeded failure");
|
|
process.exit(${ensureExit});
|
|
}
|
|
fs.rmSync(".paperclip/seed-pending", { force: true });
|
|
fs.rmSync(".paperclip/seed-complete", { force: true });
|
|
fs.writeFileSync(".paperclip/seed-manifest.json", JSON.stringify({
|
|
version: 2,
|
|
source: { instanceId: "base-source", configPath: ${JSON.stringify(path.join(baseCwd, ".paperclip", "config.json"))} },
|
|
snapshotAt: "2026-08-19T00:00:00.000Z",
|
|
seedMode: "minimal",
|
|
migrationRevision: "0142_test.sql",
|
|
targetInstanceId: "target-test",
|
|
phase: "complete",
|
|
state: "verified",
|
|
attemptId: "attempt-test",
|
|
startedAt: "2026-08-19T00:00:00.000Z",
|
|
finishedAt: "2026-08-19T00:01:00.000Z",
|
|
diagnostics: [{ phase: "complete", status: "succeeded", at: "2026-08-19T00:01:00.000Z" }],
|
|
}) + "\\n");
|
|
process.exit(0);
|
|
}
|
|
process.exit(0);
|
|
`,
|
|
);
|
|
return baseCwd;
|
|
}
|
|
|
|
function runProvision(baseCwd, { pathPrefix } = {}) {
|
|
const worktreeCwd = makeTempDir("paperclip-provision-worktree-");
|
|
const worktreesHome = makeTempDir("paperclip-provision-home-");
|
|
const paperclipHome = makeInstanceHome();
|
|
const result = spawnSync("bash", [script], {
|
|
cwd: worktreeCwd,
|
|
encoding: "utf8",
|
|
env: {
|
|
PATH: pathPrefix ? `${pathPrefix}:${testPath}` : testPath,
|
|
HOME: os.homedir(),
|
|
PAPERCLIP_WORKSPACE_BASE_CWD: baseCwd,
|
|
PAPERCLIP_WORKSPACE_CWD: worktreeCwd,
|
|
PAPERCLIP_WORKSPACE_BRANCH: "feature/provision-test",
|
|
PAPERCLIP_WORKTREES_DIR: worktreesHome,
|
|
PAPERCLIP_HOME: paperclipHome,
|
|
PAPERCLIP_PROJECT_WORKSPACE_ID: "project-workspace-1",
|
|
PAPERCLIP_SEED_EXPECTED_COMPANY_ID: "company-1",
|
|
},
|
|
});
|
|
return { result, worktreeCwd, worktreesHome, paperclipHome };
|
|
}
|
|
|
|
function runRuntimeProvision(baseCwd, worktreeCwd) {
|
|
const worktreesHome = makeTempDir("paperclip-provision-runtime-home-");
|
|
const paperclipHome = makeInstanceHome();
|
|
return spawnSync("bash", [runtimeScript], {
|
|
cwd: worktreeCwd,
|
|
encoding: "utf8",
|
|
env: {
|
|
PATH: testPath,
|
|
HOME: os.homedir(),
|
|
PAPERCLIP_WORKSPACE_BASE_CWD: baseCwd,
|
|
PAPERCLIP_WORKSPACE_CWD: worktreeCwd,
|
|
PAPERCLIP_WORKSPACE_BRANCH: "feature/provision-runtime-test",
|
|
PAPERCLIP_WORKTREES_DIR: worktreesHome,
|
|
PAPERCLIP_HOME: paperclipHome,
|
|
PAPERCLIP_PROJECT_WORKSPACE_ID: "project-workspace-1",
|
|
PAPERCLIP_COMPANY_ID: "company-1",
|
|
},
|
|
});
|
|
}
|
|
|
|
function readCliInvocations(baseCwd) {
|
|
const logPath = path.join(baseCwd, "cli-invocations.log");
|
|
if (!fs.existsSync(logPath)) return [];
|
|
return fs
|
|
.readFileSync(logPath, "utf8")
|
|
.trim()
|
|
.split("\n")
|
|
.filter(Boolean)
|
|
.map((line) => JSON.parse(line));
|
|
}
|
|
|
|
function readWorktreeConfig(worktreeCwd) {
|
|
const configPath = path.join(worktreeCwd, ".paperclip", "config.json");
|
|
assert.ok(fs.existsSync(configPath), `expected ${configPath} to exist`);
|
|
return JSON.parse(fs.readFileSync(configPath, "utf8"));
|
|
}
|
|
|
|
test("uses the base CLI when its import graph boots", () => {
|
|
const baseCwd = makeBaseWorkspace({ helpExit: 0, initExit: 0 });
|
|
const { result, worktreeCwd } = runProvision(baseCwd);
|
|
|
|
assert.equal(result.status, 0, result.stderr);
|
|
const config = readWorktreeConfig(worktreeCwd);
|
|
assert.equal(config.$meta.source, "fake-cli");
|
|
assert.equal(
|
|
JSON.parse(fs.readFileSync(path.join(worktreeCwd, ".paperclip", "seed-manifest.json"), "utf8")).state,
|
|
"pending",
|
|
);
|
|
const initInvocation = readCliInvocations(baseCwd).find(
|
|
(args) => args[0] === "worktree" && args[1] === "init",
|
|
);
|
|
assert.ok(
|
|
initInvocation?.includes("--no-seed"),
|
|
`expected --no-seed in ${JSON.stringify(initInvocation)}`,
|
|
);
|
|
});
|
|
|
|
test("rejects a dangling base workspace config symlink instead of falling back", () => {
|
|
const baseCwd = makeBaseWorkspace({ helpExit: 0, initExit: 0 });
|
|
fs.mkdirSync(path.join(baseCwd, ".paperclip"), { recursive: true });
|
|
fs.symlinkSync(path.join(baseCwd, "absent.json"), path.join(baseCwd, ".paperclip", "config.json"));
|
|
|
|
const { result } = runProvision(baseCwd);
|
|
|
|
assert.notEqual(result.status, 0);
|
|
assert.match(result.stderr, /is missing or is not a canonical file/);
|
|
});
|
|
|
|
test("rejects a dangling base workspace .paperclip symlink instead of falling back", () => {
|
|
const baseCwd = makeBaseWorkspace({ helpExit: 0, initExit: 0 });
|
|
// `-e`/`-L` on the config resolve `.paperclip` first, so the config reads as absent
|
|
// here even though the workspace is malformed rather than a plain checkout.
|
|
fs.symlinkSync(path.join(baseCwd, "absent-dir"), path.join(baseCwd, ".paperclip"));
|
|
|
|
const { result } = runProvision(baseCwd);
|
|
|
|
assert.notEqual(result.status, 0);
|
|
assert.match(result.stderr, /\.paperclip is a broken symlink/);
|
|
});
|
|
|
|
test("falls back to an isolated config when the base CLI cannot boot", () => {
|
|
// Simulates the dangling pnpm symlink incident: the runner and entry files
|
|
// exist, but booting the CLI fails ESM resolution. The base has no
|
|
// package.json/pnpm-lock.yaml, so the repair install is not possible and the
|
|
// script must degrade to the no-CLI fallback config instead of failing.
|
|
const baseCwd = makeBaseWorkspace({ helpExit: 1, initExit: 0 });
|
|
const { result, worktreeCwd, worktreesHome } = runProvision(baseCwd);
|
|
|
|
assert.equal(result.status, 0, result.stderr);
|
|
assert.match(result.stderr, /writing isolated fallback config/);
|
|
const config = readWorktreeConfig(worktreeCwd);
|
|
assert.equal(config.$meta.source, "configure");
|
|
const dataDir = config.database.embeddedPostgresDataDir;
|
|
assert.ok(
|
|
!path.relative(worktreesHome, dataDir).startsWith(".."),
|
|
`expected ${dataDir} to live under ${worktreesHome}`,
|
|
);
|
|
const env = fs.readFileSync(path.join(worktreeCwd, ".paperclip", ".env"), "utf8");
|
|
assert.match(env, /PAPERCLIP_IN_WORKTREE=true/);
|
|
assert.equal(
|
|
JSON.parse(fs.readFileSync(path.join(worktreeCwd, ".paperclip", "seed-manifest.json"), "utf8")).state,
|
|
"pending",
|
|
);
|
|
});
|
|
|
|
test("reconciles deployment mode from the registered source when reusing a guest config", () => {
|
|
const baseCwd = makeBaseWorkspace({ helpExit: 1, initExit: 0 });
|
|
const { result: first, worktreeCwd, worktreesHome, paperclipHome } = runProvision(baseCwd);
|
|
assert.equal(first.status, 0, first.stderr);
|
|
assert.equal(readWorktreeConfig(worktreeCwd).server.deploymentMode, "local_trusted");
|
|
|
|
// A base workspace that does carry its own instance config outranks the fallback.
|
|
fs.mkdirSync(path.join(baseCwd, ".paperclip"), { recursive: true });
|
|
fs.writeFileSync(
|
|
path.join(baseCwd, ".paperclip", "config.json"),
|
|
`${JSON.stringify({
|
|
server: {
|
|
deploymentMode: "authenticated",
|
|
exposure: "private",
|
|
},
|
|
}, null, 2)}\n`,
|
|
);
|
|
|
|
const second = spawnSync("bash", [script], {
|
|
cwd: worktreeCwd,
|
|
encoding: "utf8",
|
|
env: {
|
|
PATH: testPath,
|
|
HOME: os.homedir(),
|
|
PAPERCLIP_WORKSPACE_BASE_CWD: baseCwd,
|
|
PAPERCLIP_WORKSPACE_CWD: worktreeCwd,
|
|
PAPERCLIP_WORKSPACE_BRANCH: "feature/provision-test",
|
|
PAPERCLIP_WORKTREES_DIR: worktreesHome,
|
|
PAPERCLIP_HOME: paperclipHome,
|
|
PAPERCLIP_PROJECT_WORKSPACE_ID: "project-workspace-1",
|
|
PAPERCLIP_SEED_EXPECTED_COMPANY_ID: "company-1",
|
|
},
|
|
});
|
|
|
|
assert.equal(second.status, 0, second.stderr);
|
|
assert.match(second.stderr, /Reusing existing isolated Paperclip worktree config/);
|
|
assert.match(second.stderr, /Reconciled isolated Paperclip worktree deployment mode/);
|
|
assert.equal(readWorktreeConfig(worktreeCwd).server.deploymentMode, "authenticated");
|
|
assert.equal(readWorktreeConfig(worktreeCwd).server.exposure, "private");
|
|
});
|
|
|
|
test("repairs an unhealthy base install under the lock and then uses the CLI", (t) => {
|
|
const hasTools = ["flock", "git"].every(
|
|
(tool) => spawnSync("bash", ["-lc", `command -v ${tool}`], { env: { PATH: testPath } }).status === 0,
|
|
);
|
|
if (!hasTools) {
|
|
t.skip("flock or git not available on this host");
|
|
return;
|
|
}
|
|
|
|
// The CLI's health is controlled by a flag file, and a fake `pnpm install`
|
|
// creates that flag — modeling a forced reinstall that relinks the store.
|
|
const baseCwd = makeTempDir("paperclip-provision-repair-base-");
|
|
const healthFlag = path.join(baseCwd, "cli-healthy.flag");
|
|
const runnerPath = path.join(baseCwd, "cli", "node_modules", "tsx", "dist", "cli.mjs");
|
|
const entryPath = path.join(baseCwd, "cli", "src", "index.ts");
|
|
fs.mkdirSync(path.dirname(runnerPath), { recursive: true });
|
|
fs.mkdirSync(path.dirname(entryPath), { recursive: true });
|
|
fs.writeFileSync(entryPath, "// fake CLI entry\n");
|
|
fs.writeFileSync(
|
|
runnerPath,
|
|
`
|
|
import fs from "node:fs";
|
|
const cliArgs = process.argv.slice(3);
|
|
if (cliArgs.includes("--help")) {
|
|
process.exit(fs.existsSync(${JSON.stringify(healthFlag)}) ? 0 : 1);
|
|
}
|
|
if (cliArgs[0] === "worktree" && cliArgs[1] === "init") {
|
|
fs.mkdirSync(".paperclip", { recursive: true });
|
|
fs.writeFileSync(".paperclip/config.json", JSON.stringify({ $meta: { source: "fake-cli" } }));
|
|
fs.writeFileSync(".paperclip/.env", "PAPERCLIP_IN_WORKTREE=true\\n");
|
|
process.exit(0);
|
|
}
|
|
process.exit(0);
|
|
`,
|
|
);
|
|
fs.writeFileSync(path.join(baseCwd, "package.json"), "{}\n");
|
|
fs.writeFileSync(path.join(baseCwd, "pnpm-lock.yaml"), "lockfileVersion: '9.0'\n");
|
|
spawnSync("git", ["init", "-q", baseCwd], { env: { PATH: testPath } });
|
|
|
|
const fakeBin = makeTempDir("paperclip-provision-fakebin-");
|
|
const installLog = path.join(baseCwd, "pnpm-invocations.log");
|
|
fs.writeFileSync(
|
|
path.join(fakeBin, "pnpm"),
|
|
`#!/usr/bin/env bash
|
|
if [[ "$1" == "install" ]]; then
|
|
echo "$@" >> ${JSON.stringify(installLog)}
|
|
touch ${JSON.stringify(healthFlag)}
|
|
exit 0
|
|
fi
|
|
exit 1
|
|
`,
|
|
{ mode: 0o755 },
|
|
);
|
|
|
|
const { result, worktreeCwd } = runProvision(baseCwd, { pathPrefix: fakeBin });
|
|
|
|
assert.equal(result.status, 0, result.stderr);
|
|
const config = readWorktreeConfig(worktreeCwd);
|
|
assert.equal(config.$meta.source, "fake-cli");
|
|
const installs = fs.readFileSync(installLog, "utf8").trim().split("\n");
|
|
assert.equal(installs.length, 1, `expected exactly one repair install, got: ${installs.join(" | ")}`);
|
|
assert.match(installs[0], /--force/);
|
|
assert.match(installs[0], /--frozen-lockfile/);
|
|
assert.ok(
|
|
fs.existsSync(path.join(baseCwd, ".git", "paperclip-provision-repair.lock")),
|
|
"expected the repair lock file inside the resolved git dir",
|
|
);
|
|
});
|
|
|
|
test("a failed CLI init fails provisioning instead of being masked as success", () => {
|
|
// Regression test for the masked `return 0` after the init subshell: a CLI
|
|
// that passes the health check but fails `worktree init` signals a real
|
|
// problem, so the script must propagate the failure rather than report
|
|
// success or write an unseeded fallback config over it.
|
|
const baseCwd = makeBaseWorkspace({ helpExit: 0, initExit: 3 });
|
|
const { result, worktreeCwd } = runProvision(baseCwd);
|
|
|
|
assert.equal(result.status, 3, result.stderr);
|
|
assert.match(result.stderr, /fake worktree init failure/);
|
|
assert.ok(!fs.existsSync(path.join(worktreeCwd, ".paperclip", "config.json")));
|
|
});
|
|
|
|
test("runtime provisioning invokes ensure-seeded once and fast-exits after success", () => {
|
|
const baseCwd = makeBaseWorkspace({ helpExit: 0, initExit: 0 });
|
|
const worktreeCwd = makeTempDir("paperclip-provision-runtime-worktree-");
|
|
fs.mkdirSync(path.join(worktreeCwd, ".paperclip"), { recursive: true });
|
|
fs.writeFileSync(path.join(worktreeCwd, ".paperclip", "config.json"), "{}\n");
|
|
fs.writeFileSync(path.join(worktreeCwd, ".paperclip", "seed-pending"), "{}\n");
|
|
|
|
const first = runRuntimeProvision(baseCwd, worktreeCwd);
|
|
assert.equal(first.status, 0, first.stderr);
|
|
assert.equal(
|
|
JSON.parse(fs.readFileSync(path.join(worktreeCwd, ".paperclip", "seed-manifest.json"), "utf8")).state,
|
|
"verified",
|
|
);
|
|
assert.ok(!fs.existsSync(path.join(worktreeCwd, ".paperclip", "seed-pending")));
|
|
|
|
const ensureCallsAfterFirst = readCliInvocations(baseCwd)
|
|
.filter((args) => args[0] === "worktree" && args[1] === "ensure-seeded");
|
|
assert.equal(ensureCallsAfterFirst.length, 1);
|
|
assert.ok(ensureCallsAfterFirst[0].includes("--config"));
|
|
assert.ok(ensureCallsAfterFirst[0].includes("--from-config"));
|
|
|
|
const second = runRuntimeProvision(baseCwd, worktreeCwd);
|
|
assert.equal(second.status, 0, second.stderr);
|
|
assert.match(second.stderr, /verified seed manifest.*skipping/);
|
|
const ensureCallsAfterSecond = readCliInvocations(baseCwd)
|
|
.filter((args) => args[0] === "worktree" && args[1] === "ensure-seeded");
|
|
assert.equal(ensureCallsAfterSecond.length, 1);
|
|
});
|
|
|
|
test("runtime provisioning seeds a worktree config that has no seed markers", () => {
|
|
const baseCwd = makeBaseWorkspace({ helpExit: 0, initExit: 0 });
|
|
const worktreeCwd = makeTempDir("paperclip-provision-runtime-unmarked-config-");
|
|
fs.mkdirSync(path.join(worktreeCwd, ".paperclip"), { recursive: true });
|
|
fs.writeFileSync(path.join(worktreeCwd, ".paperclip", "config.json"), "{}\n");
|
|
|
|
const result = runRuntimeProvision(baseCwd, worktreeCwd);
|
|
|
|
assert.equal(result.status, 0, result.stderr);
|
|
assert.equal(
|
|
readCliInvocations(baseCwd)
|
|
.filter((args) => args[0] === "worktree" && args[1] === "ensure-seeded").length,
|
|
1,
|
|
);
|
|
assert.equal(
|
|
JSON.parse(fs.readFileSync(path.join(worktreeCwd, ".paperclip", "seed-manifest.json"), "utf8")).state,
|
|
"verified",
|
|
);
|
|
});
|
|
|
|
test("runtime provisioning bootstraps and seeds an empty .paperclip directory", () => {
|
|
const baseCwd = makeBaseWorkspace({ helpExit: 0, initExit: 0 });
|
|
fs.mkdirSync(path.join(baseCwd, "scripts"), { recursive: true });
|
|
fs.copyFileSync(script, path.join(baseCwd, "scripts", "provision-worktree.sh"));
|
|
const worktreeCwd = makeTempDir("paperclip-provision-runtime-empty-state-");
|
|
fs.mkdirSync(path.join(worktreeCwd, ".paperclip"), { recursive: true });
|
|
|
|
const result = runRuntimeProvision(baseCwd, worktreeCwd);
|
|
|
|
assert.equal(result.status, 0, result.stderr);
|
|
assert.match(result.stderr, /config is missing; running the built-in worktree provisioner/);
|
|
const invocations = readCliInvocations(baseCwd);
|
|
assert.equal(
|
|
invocations.filter((args) => args[0] === "worktree" && args[1] === "init").length,
|
|
1,
|
|
);
|
|
assert.equal(
|
|
invocations.filter((args) => args[0] === "worktree" && args[1] === "ensure-seeded").length,
|
|
1,
|
|
);
|
|
assert.equal(
|
|
JSON.parse(fs.readFileSync(path.join(worktreeCwd, ".paperclip", "seed-manifest.json"), "utf8")).state,
|
|
"verified",
|
|
);
|
|
});
|
|
|
|
test("runtime provisioning leaves seed-pending in place when ensure-seeded fails", () => {
|
|
const baseCwd = makeBaseWorkspace({ helpExit: 0, initExit: 0, ensureExit: 4 });
|
|
const worktreeCwd = makeTempDir("paperclip-provision-runtime-failure-");
|
|
fs.mkdirSync(path.join(worktreeCwd, ".paperclip"), { recursive: true });
|
|
fs.writeFileSync(path.join(worktreeCwd, ".paperclip", "config.json"), "{}\n");
|
|
fs.writeFileSync(path.join(worktreeCwd, ".paperclip", "seed-pending"), "{}\n");
|
|
|
|
const result = runRuntimeProvision(baseCwd, worktreeCwd);
|
|
assert.equal(result.status, 4, result.stderr);
|
|
assert.match(result.stderr, /fake worktree ensure-seeded failure/);
|
|
assert.ok(fs.existsSync(path.join(worktreeCwd, ".paperclip", "seed-pending")));
|
|
assert.ok(!fs.existsSync(path.join(worktreeCwd, ".paperclip", "seed-complete")));
|
|
});
|
|
|
|
test("runtime provisioning does not trust a truncated verified manifest", () => {
|
|
const baseCwd = makeBaseWorkspace({ helpExit: 0, initExit: 0, ensureExit: 4 });
|
|
const worktreeCwd = makeTempDir("paperclip-provision-runtime-truncated-");
|
|
fs.mkdirSync(path.join(worktreeCwd, ".paperclip"), { recursive: true });
|
|
fs.writeFileSync(path.join(worktreeCwd, ".paperclip", "config.json"), "{}\n");
|
|
fs.writeFileSync(
|
|
path.join(worktreeCwd, ".paperclip", "seed-manifest.json"),
|
|
JSON.stringify({ version: 2, state: "verified" }),
|
|
);
|
|
|
|
const result = runRuntimeProvision(baseCwd, worktreeCwd);
|
|
assert.equal(result.status, 4, result.stderr);
|
|
assert.equal(
|
|
readCliInvocations(baseCwd)
|
|
.filter((args) => args[0] === "worktree" && args[1] === "ensure-seeded").length,
|
|
1,
|
|
);
|
|
});
|