Files
PaperClipAI/server/src/__tests__/companies-service.test.ts
T
Nicky LeachandPaperclip 2dd9811e8b Own agent hiring and termination in a lifecycle module (#15631)
## Thinking Path

> - Paperclip manages AI agents and their work.
> - Agent creation, approval, pause, and termination change whether an
agent can work.
> - These changes currently use separate service and database paths.
> - Some agents need setup after their record exists and before their
harness can run.
> - This PR adds one module that owns those state changes and their
transactions.
> - The module records progress and retries incomplete work after a
server restart.

## Linked Issues or Issue Description

**Problem or motivation**

A hire can become active before its execution environment is ready.
Direct agent state writes also bypass one common lifecycle boundary.
Termination does not have a durable step for resource cleanup.

**Proposed solution**

Use agent lifecycle commands for hiring, approval, pause, resume, and
termination. Keep proposed hires pending until approval. Prepare each
approved hire, test its saved harness configuration, and then permit
work. Wait for required plugin work before completing a step.

**Alternatives considered**

A general database commit hook would expose transaction details to
callers. A timer alone would delay each new hire. This module owns each
command transaction and starts its worker after commit. A periodic scan
recovers work after a process stops.

**Roadmap alignment**

This change adds the lifecycle boundary for the existing agent and
plugin systems. It does not add a user interface or a provider
implementation. It replaces the lifecycle delivery approach in #15391.
Related proposals include #11475 and #13099; this change does not add
their external executor protocols.

## What Changed

- Add durable approval, preparation, verification, pause, resume, stop,
and cleanup states.
- Keep agent creation, lifecycle state, configuration writes, and agent
record deletion behind `modules/agent-lifecycle`. Keep validation,
credential rules, reads, onboarding, invitations, general approvals, and
company data deletion in their services.
- Commit a hire before the remaining onboarding or invitation work.
Serialize requests with the existing dedicated database connection
helper. Reuse the hire after a failed attempt.
- Keep accepted work in the run queue during setup. Require execution
and cleanup evidence before completing pause or termination.
- Retain the original credential owner when approving migrated hires.
- Start lifecycle work after each command commits. Use database leases
and revision checks for retries and late results.
- Add a generic required plugin method and capability. Store the
required plugin IDs for each agent. Track host and plugin completion
separately.
- Keep harness verification and credential rules in services. Supply
their results to lifecycle through explicit ports. Reject failed logins
and incomplete probes.
- Remove reverse imports from lifecycle adapters into services. Share
record queries and validation below both layers.
- Use one hire decision path for agent IDs and approval IDs. Resolve the
approval and agent change in one transaction. Expose policy
reconciliation on the command object.
- Save configuration and verification invalidation through one module
operation. Ordinary commands own their transaction. Restrict the shared
transaction integration to its listed callers. Reject identity, company,
accounting, timestamp, and unknown fields.
- Require completed termination before deleting agent records. The
company deletion service calls the module through a separate deletion
interface.
- Save an approved secret before applying its agent binding. A failed
binding leaves the secret approved. A retry reuses it.
- Remove old permission and metadata export files. Move hire
configuration rules out of lifecycle persistence.
- Report failed worker steps and scans with operation context and known
error codes. Omit provider messages, stacks, and configuration values.
Document ordinary application use and extension rules.
- Recover expired native owners only after execution stops. Retry
cleanup of failed retained leases. Wait for setup in the live smoke
script.
- Keep manual, budget, and company pause reasons separate. Guard
execution status writes with the ready state.
- Add a migration, boundary checks, regression tests, and a lifecycle
guide. Keep the current UI.
- Limit periodic policy checks to 100 eligible agents per minute.
Continue from the last agent ID. Exclude pending hires and agents in
termination or a final state. Keep explicit company and budget updates
immediate.

## Verification

- Latest head `ccc3c86b0` aligns the shared status update schema with
the PATCH route. All 15 shared tests, 104 server route/OpenAPI tests, 2
CLI tests, and shared/server/CLI TypeScript checks pass. The Greptile
comment is fixed. CI is running; no new Apex review was requested for
this small fix.

- Rebase `75708ac94` rebases onto master at `2eb5187e4`. The backup test
uses the shared 90-second timeout from master; the older timeout commit
was removed. The affected backup test passes.
- Agent budget edits now pass the target agent ID through enforcement.
All 50 affected tests, server TypeScript, and 11 boundary tests pass.
Both configuration update paths have regression coverage. CI is running
on the latest head. No new Apex review was requested for these small
fixes.

- Rebase `9b568666a` preserves the run-control extraction and
delivery-work startup changes from master. All 559 affected tests,
server TypeScript, and 11 boundary tests pass. CI and Apex review are
running on the final head.
- The policy scan fix passes 56 lifecycle and diagnostic tests, 24
policy and caller tests, and 11 boundary tests. A regression test checks
the page limit, interval, excluded states, and cursor wraparound.

- Rebase `fd4698750` passes all 611 tests in eight affected lifecycle,
route, and heartbeat suites. Server TypeScript and all 11 module
boundary tests pass. The company deletion rollback and concurrent hire
tests are included.

- Follow-up `00aac7646` fixes the failed decision deletion test and the
public update schema. All 126 affected server tests, 8 shared tests, 2
CLI tests, and 11 boundary tests pass. Shared, server, CLI, and UI
TypeScript checks pass.

- Server TypeScript passes: `pnpm --filter @paperclipai/server exec tsc
--noEmit`.
- All 11 boundary tests pass: `node --test
scripts/check-module-boundaries.test.mjs`. The repository boundary scan
also passes.
- All 68 lifecycle, failure diagnostic, and harness verification tests
pass. Tests reject forbidden fields through the root command, combined
transition command, and restricted transaction integration. They also
check invalid fields returned by configuration preparation.
- Failure tests cover host work, plugin work, claims, renewals,
deferrals, and scans. Log tests check known error codes and exclusion of
private error contents.
- All 355 tests in 10 existing caller suites pass. These tests cover
secret approval, pairing, pending hires, credentials, company import,
built-in agents, managed agents, instructions, and skills.
- The branch is rebased onto `origin/master` at `2eb5187e4`. The queue
guards and cancellation lock fix use the extracted heartbeat queue.
Agent cancellation uses the extracted run-control file. The source diff
scan found no secrets or private URLs.
- Earlier checks cover approval retries, rollback, late verification
results, policy holds, deletion rollback, concurrent company deletion,
and queue admission during setup.
- Before the rebase, CI passed on `00aac7646` and Greptile Apex rated it
5/5 with no open comments. CI and a new Apex review are pending for the
rebased commit. The branch has no merge conflicts.
- The full local build and native Dot suite were not run. The host has
no Cargo. No live provider test was run.

## Risks

- Background policy recovery takes more than one minute when more than
100 agents are eligible. Explicit company and budget updates still
reconcile immediately.

- The restricted configuration integration keeps an agent reference and
its dependent records in one transaction. It cannot change a budget or
invoke a lifecycle transition. A periodic scan starts pending setup
after that transaction commits.
- Secret approval and binding use separate transactions. A failed
binding can leave an approved secret with no agent binding.
- New approved hires remain unavailable until setup and verification
complete. Existing clients see `paused` during these steps. This PR does
not change the UI.
- Migration `0320_daily_onslaught.sql` maps existing statuses and pause
reasons. It does not create external resources or claim that an existing
harness passed verification.
- Use a coordinated server update for this migration. Older server
versions can write legacy status without the new lifecycle checks.
- A failed onboarding or invitation request can leave a committed hire.
A retry reuses that hire and completes the remaining records.
- Deletion requires completed termination. Company deletion can require
another request while cleanup is pending.
- Required plugins must make repeated calls safe and reject older
revisions. A disabled or removed required plugin blocks completion until
it is restored.
- A new hire can run a second harness test after the existing UI test.
Some adapters can charge for this test.
- No live provider test was run. Provider implementation and resource
backfill remain separate work.

## Model Used

OpenAI GPT-6 through Codex, with reasoning, code tools, and local test
execution.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have described the issue in this PR with the feature request
field labels
- [x] I have not referenced internal or instance-local issues or links
- [x] My branch name describes the change
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation
- [x] I have considered and documented risks
- [x] Targeted local tests pass
- [x] All Paperclip CI gates are green on the new commit
- [x] Greptile Apex is 5/5 with no open comments on the new commit
- [x] I will address review comments before requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-10-09 09:05:12 -07:00

1166 lines
37 KiB
TypeScript

import { randomUUID } from "node:crypto";
import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
import { and, eq } from "drizzle-orm";
import {
activityLog,
agentConfigRevisions,
agents,
agentWakeupRequests,
builtInManagedResources,
cases,
companies,
companySkillVersions,
companySkills,
companyMemberships,
createDb,
heartbeatRunEvents,
heartbeatRuns,
issues,
principalPermissionGrants,
routines,
routineTriggers,
} from "@paperclipai/db";
import {
getEmbeddedPostgresTestSupport,
startEmbeddedPostgresTestDatabase,
} from "./helpers/embedded-postgres.js";
// Observe the Cloud lifecycle doorbell without any network: the real
// implementation is env-gated (a no-op off Cloud), so these tests assert
// WHEN the service rings it, not what the ring does.
const notifyCloudSpy = vi.hoisted(() => vi.fn(async () => {}));
vi.mock("../services/cloud-lifecycle-sync.js", () => ({
isCloudPinnedPrimaryCompany: () => false,
notifyCloudOfPrimaryCompanyLifecycleChange: notifyCloudSpy,
}));
import { configureAgentLifecycle } from "../services/agent-lifecycle.js";
import { companyService } from "../services/companies.js";
import { deriveIssuePrefixBase } from "../services/issue-prefix.js";
import { readBuiltInAgentMarker } from "../lib/built-in-agent-metadata.js";
import { builtInAgentService, reconcileBuiltInAgentsOnStartup } from "../services/built-in-agents.js";
const embeddedPostgresSupport = await getEmbeddedPostgresTestSupport();
const describeEmbeddedPostgres = embeddedPostgresSupport.supported ? describe : describe.skip;
if (!embeddedPostgresSupport.supported) {
console.warn(
`Skipping embedded Postgres company service tests on this host: ${embeddedPostgresSupport.reason ?? "unsupported environment"}`,
);
}
describeEmbeddedPostgres("companyService", () => {
let db!: ReturnType<typeof createDb>;
let lifecycleWorker: ReturnType<typeof configureAgentLifecycle>;
beforeEach(() => { lifecycleWorker = configureAgentLifecycle(db, { requiredPluginIds: async () => [], runPlugin: async () => "complete", runHost: async () => "complete" }); });
async function insertAgents(input: typeof agents.$inferInsert | Array<typeof agents.$inferInsert>) {
const rows = Array.isArray(input) ? input : [input];
await db.insert(agents).values(rows.map(row => ({ ...row,
lifecycleState: ["paused", "pending_approval", "terminated"].includes(row.status ?? "") ? row.status! : "ready",
lifecycleHolds: row.status === "paused" ? [row.pauseReason ?? "manual"] : [],
})));
}
let tempDb: Awaited<ReturnType<typeof startEmbeddedPostgresTestDatabase>> | null = null;
beforeAll(async () => {
tempDb = await startEmbeddedPostgresTestDatabase("paperclip-company-service-");
db = createDb(tempDb.connectionString);
}, 20_000);
afterEach(async () => {
await lifecycleWorker.stop();
await db.delete(routineTriggers);
await db.delete(routines);
await db.delete(builtInManagedResources);
await db.delete(companySkillVersions);
await db.delete(companySkills);
await db.delete(heartbeatRunEvents);
await db.delete(heartbeatRuns);
await db.delete(agentWakeupRequests);
await db.delete(agentConfigRevisions);
await db.delete(activityLog);
await db.delete(agents);
await db.delete(principalPermissionGrants);
await db.delete(companyMemberships);
await db.delete(cases);
await db.delete(issues);
await db.delete(companies);
});
afterAll(async () => {
await tempDb?.cleanup();
});
it("retries generated issue prefixes when Drizzle wraps the unique constraint error", async () => {
await db.insert(companies).values({
name: "Aron Existing",
issuePrefix: "ARO",
});
const created = await companyService(db).create({
name: "Aron & Sharon",
});
expect(created.issuePrefix).toBe("AROA");
const rows = await db.select({ issuePrefix: companies.issuePrefix }).from(companies);
expect(rows.map((row) => row.issuePrefix).sort()).toEqual(["ARO", "AROA"]);
});
it("does not auto-provision bundled built-in agents for a freshly created company", async () => {
const created = await companyService(db).create({
name: "Fresh Company",
});
// A new company starts clean: the Reflection Coach and Summarizer are
// opt-in, not seeded by default for a new user.
const agentRows = await db.select().from(agents).where(eq(agents.companyId, created.id));
expect(agentRows.filter((row) => readBuiltInAgentMarker(row.metadata))).toHaveLength(0);
// Startup reconcile leaves a fresh company untouched — nothing is created.
await reconcileBuiltInAgentsOnStartup(db);
const afterReconcileRows = await db.select().from(agents).where(eq(agents.companyId, created.id));
expect(afterReconcileRows.filter((row) => readBuiltInAgentMarker(row.metadata))).toHaveLength(0);
// The Reflection Coach remains available to enable on demand, and enabling
// it materializes its bundled skill + paused routine.
const enabled = await builtInAgentService(db).ensure(created.id, "reflection-coach");
expect(enabled.agent).toMatchObject({
name: "Reflection Coach",
status: "paused",
budgetMonthlyCents: 0,
});
const [skill] = await db
.select()
.from(companySkills)
.where(and(
eq(companySkills.companyId, created.id),
eq(companySkills.key, "paperclipai/bundled/paperclip-operations/reflection-coach"),
));
expect(skill).toMatchObject({
slug: "reflection-coach",
});
const [routine] = await db
.select()
.from(routines)
.where(and(eq(routines.companyId, created.id), eq(routines.assigneeAgentId, enabled.agentId!)));
expect(routine).toMatchObject({
status: "paused",
assigneeAgentId: enabled.agentId,
originKind: "built_in_agent_bundle",
originId: "reflection-coach:recent-agent-reflection",
});
const [trigger] = await db.select().from(routineTriggers).where(eq(routineTriggers.routineId, routine!.id));
expect(trigger).toMatchObject({
kind: "schedule",
enabled: false,
});
});
it("archives companies by pausing runnable agents and cancelling active runs", async () => {
const companyId = randomUUID();
const runningAgentId = randomUUID();
const idleAgentId = randomUUID();
const errorAgentId = randomUUID();
const pausedAgentId = randomUUID();
const pendingAgentId = randomUUID();
const terminatedAgentId = randomUUID();
const wakeupRequestId = randomUUID();
const runId = randomUUID();
await db.insert(companies).values({
id: companyId,
name: "Archive Test Co",
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
requireBoardApprovalForNewAgents: false,
});
await insertAgents([
{
id: runningAgentId,
companyId,
name: "Running Agent",
role: "engineer",
status: "running",
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
},
{
id: idleAgentId,
companyId,
name: "Idle Agent",
role: "engineer",
status: "idle",
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
},
{
id: errorAgentId,
companyId,
name: "Error Agent",
role: "engineer",
status: "error",
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
},
{
id: pausedAgentId,
companyId,
name: "Paused Agent",
role: "engineer",
status: "paused",
pauseReason: "manual",
pausedAt: new Date("2026-06-01T00:00:00Z"),
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
},
{
id: pendingAgentId,
companyId,
name: "Pending Agent",
role: "engineer",
status: "pending_approval",
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
},
{
id: terminatedAgentId,
companyId,
name: "Terminated Agent",
role: "engineer",
status: "terminated",
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
},
]);
await db.insert(agentWakeupRequests).values({
id: wakeupRequestId,
companyId,
agentId: runningAgentId,
source: "timer",
status: "queued",
});
await db.insert(heartbeatRuns).values({
id: runId,
companyId,
agentId: runningAgentId,
invocationSource: "timer",
status: "running",
wakeupRequestId,
});
const archived = await companyService(db).archive(companyId, {
actorType: "user",
actorId: "test-user",
agentId: null,
runId: null,
});
expect(archived?.status).toBe("archived");
const archiveActivity = await db
.select({
actorType: activityLog.actorType,
actorId: activityLog.actorId,
details: activityLog.details,
})
.from(activityLog)
.where(and(
eq(activityLog.companyId, companyId),
eq(activityLog.action, "company.archived"),
));
expect(archiveActivity).toHaveLength(1);
expect(archiveActivity[0]).toMatchObject({
actorType: "user",
actorId: "test-user",
details: { agentsPaused: 3, runsCancelled: 1 },
});
const rows = await db
.select({
id: agents.id,
status: agents.status,
pauseReason: agents.pauseReason,
})
.from(agents);
const byId = new Map(rows.map((row) => [row.id, row]));
expect(byId.get(runningAgentId)).toMatchObject({ status: "paused", pauseReason: "company_archived" });
expect(byId.get(idleAgentId)).toMatchObject({ status: "paused", pauseReason: "company_archived" });
expect(byId.get(errorAgentId)).toMatchObject({ status: "paused", pauseReason: "company_archived" });
expect(byId.get(pausedAgentId)).toMatchObject({ status: "paused", pauseReason: "manual" });
expect(byId.get(pendingAgentId)).toMatchObject({ status: "pending_approval", pauseReason: null });
expect(byId.get(terminatedAgentId)).toMatchObject({ status: "terminated", pauseReason: null });
const run = await db
.select({
status: heartbeatRuns.status,
error: heartbeatRuns.error,
})
.from(heartbeatRuns)
.then((result) => result[0] ?? null);
expect(run).toMatchObject({
status: "cancelled",
error: "Cancelled because the company was archived",
});
const wakeup = await db
.select({
status: agentWakeupRequests.status,
error: agentWakeupRequests.error,
})
.from(agentWakeupRequests)
.then((result) => result[0] ?? null);
expect(wakeup).toMatchObject({
status: "cancelled",
error: "Cancelled because the company was archived",
});
});
it("reactivates only agents paused because the company was archived", async () => {
const companyId = randomUUID();
const archivedPausedAgentId = randomUUID();
const manualPausedAgentId = randomUUID();
const pendingAgentId = randomUUID();
await db.insert(companies).values({
id: companyId,
name: "Reactivate Test Co",
status: "archived",
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
requireBoardApprovalForNewAgents: false,
});
await insertAgents([
{
id: archivedPausedAgentId,
companyId,
name: "Archived Paused Agent",
role: "engineer",
status: "paused",
pauseReason: "company_archived",
pausedAt: new Date("2026-06-01T00:00:00Z"),
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
},
{
id: manualPausedAgentId,
companyId,
name: "Manual Paused Agent",
role: "engineer",
status: "paused",
pauseReason: "manual",
pausedAt: new Date("2026-06-01T00:00:00Z"),
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
},
{
id: pendingAgentId,
companyId,
name: "Pending Approval Agent",
role: "engineer",
status: "pending_approval",
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
},
]);
const reactivated = await companyService(db).update(
companyId,
{ status: "active" },
{ actorType: "user", actorId: "test-user", agentId: null, runId: null },
);
expect(reactivated?.status).toBe("active");
await lifecycleWorker.process(archivedPausedAgentId);
const reactivateActivity = await db
.select({
actorType: activityLog.actorType,
actorId: activityLog.actorId,
details: activityLog.details,
})
.from(activityLog)
.where(and(
eq(activityLog.companyId, companyId),
eq(activityLog.action, "company.reactivated"),
));
expect(reactivateActivity).toHaveLength(1);
expect(reactivateActivity[0]).toMatchObject({
actorType: "user",
actorId: "test-user",
details: { agentsRestored: 1 },
});
const rows = await db
.select({
id: agents.id,
status: agents.status,
pauseReason: agents.pauseReason,
pausedAt: agents.pausedAt,
})
.from(agents);
const byId = new Map(rows.map((row) => [row.id, row]));
expect(byId.get(archivedPausedAgentId)).toMatchObject({
status: "idle",
pauseReason: null,
pausedAt: null,
});
expect(byId.get(manualPausedAgentId)).toMatchObject({
status: "paused",
pauseReason: "manual",
});
expect(byId.get(pendingAgentId)).toMatchObject({
status: "pending_approval",
pauseReason: null,
});
});
it("runs the archive cascade when update() transitions a company to archived", async () => {
const companyId = randomUUID();
const runningAgentId = randomUUID();
const idleAgentId = randomUUID();
const pendingAgentId = randomUUID();
const wakeupRequestId = randomUUID();
const runId = randomUUID();
await db.insert(companies).values({
id: companyId,
name: "Update Archive Test Co",
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
requireBoardApprovalForNewAgents: false,
});
await insertAgents([
{
id: runningAgentId,
companyId,
name: "Running Agent",
role: "engineer",
status: "running",
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
},
{
id: idleAgentId,
companyId,
name: "Idle Agent",
role: "engineer",
status: "idle",
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
},
{
id: pendingAgentId,
companyId,
name: "Pending Agent",
role: "engineer",
status: "pending_approval",
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
},
]);
await db.insert(agentWakeupRequests).values({
id: wakeupRequestId,
companyId,
agentId: runningAgentId,
source: "timer",
status: "queued",
});
await db.insert(heartbeatRuns).values({
id: runId,
companyId,
agentId: runningAgentId,
invocationSource: "timer",
status: "running",
wakeupRequestId,
});
const archived = await companyService(db).update(
companyId,
{ status: "archived" },
{ actorType: "user", actorId: "test-user", agentId: null, runId: null },
);
expect(archived?.status).toBe("archived");
const rows = await db
.select({ id: agents.id, status: agents.status, pauseReason: agents.pauseReason })
.from(agents);
const byId = new Map(rows.map((row) => [row.id, row]));
expect(byId.get(runningAgentId)).toMatchObject({ status: "paused", pauseReason: "company_archived" });
expect(byId.get(idleAgentId)).toMatchObject({ status: "paused", pauseReason: "company_archived" });
expect(byId.get(pendingAgentId)).toMatchObject({ status: "pending_approval", pauseReason: null });
const run = await db
.select({ status: heartbeatRuns.status, error: heartbeatRuns.error })
.from(heartbeatRuns)
.then((result) => result[0] ?? null);
expect(run).toMatchObject({
status: "cancelled",
error: "Cancelled because the company was archived",
});
const archiveActivity = await db
.select({
actorType: activityLog.actorType,
actorId: activityLog.actorId,
details: activityLog.details,
})
.from(activityLog)
.where(and(
eq(activityLog.companyId, companyId),
eq(activityLog.action, "company.archived"),
));
expect(archiveActivity).toHaveLength(1);
expect(archiveActivity[0]).toMatchObject({
actorType: "user",
actorId: "test-user",
details: { agentsPaused: 2, runsCancelled: 1 },
});
});
it("reactivates company_archived agents even when going via paused state (archived → paused → active)", async () => {
const companyId = randomUUID();
const archivedPausedAgentId = randomUUID();
const manualPausedAgentId = randomUUID();
await db.insert(companies).values({
id: companyId,
name: "Indirect Reactivate Test Co",
status: "paused",
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
requireBoardApprovalForNewAgents: false,
});
await insertAgents([
{
id: archivedPausedAgentId,
companyId,
name: "Archived Paused Agent",
role: "engineer",
status: "paused",
pauseReason: "company_archived",
pausedAt: new Date("2026-06-01T00:00:00Z"),
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
},
{
id: manualPausedAgentId,
companyId,
name: "Manual Paused Agent",
role: "engineer",
status: "paused",
pauseReason: "manual",
pausedAt: new Date("2026-06-01T00:00:00Z"),
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
},
]);
const reactivated = await companyService(db).update(
companyId,
{ status: "active" },
{ actorType: "user", actorId: "test-user", agentId: null, runId: null },
);
expect(reactivated?.status).toBe("active");
await lifecycleWorker.process(archivedPausedAgentId);
const rows = await db
.select({ id: agents.id, status: agents.status, pauseReason: agents.pauseReason })
.from(agents);
const byId = new Map(rows.map((row) => [row.id, row]));
expect(byId.get(archivedPausedAgentId)).toMatchObject({ status: "idle", pauseReason: null });
expect(byId.get(manualPausedAgentId)).toMatchObject({ status: "paused", pauseReason: "manual" });
const reactivateActivity = await db
.select({ details: activityLog.details })
.from(activityLog)
.where(and(
eq(activityLog.companyId, companyId),
eq(activityLog.action, "company.reactivated"),
));
expect(reactivateActivity).toHaveLength(1);
expect(reactivateActivity[0]).toMatchObject({ details: { agentsRestored: 1 } });
});
it("emits company.reactivated for archived → active even when no agents need restoring", async () => {
const companyId = randomUUID();
const terminatedAgentId = randomUUID();
await db.insert(companies).values({
id: companyId,
name: "Empty Reactivate Co",
status: "archived",
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
requireBoardApprovalForNewAgents: false,
});
await insertAgents({
id: terminatedAgentId,
companyId,
name: "Terminated Agent",
role: "engineer",
status: "terminated",
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
});
const reactivated = await companyService(db).update(
companyId,
{ status: "active" },
{ actorType: "user", actorId: "test-user", agentId: null, runId: null },
);
expect(reactivated?.status).toBe("active");
const reactivateActivity = await db
.select({ details: activityLog.details })
.from(activityLog)
.where(and(
eq(activityLog.companyId, companyId),
eq(activityLog.action, "company.reactivated"),
));
expect(reactivateActivity).toHaveLength(1);
expect(reactivateActivity[0]).toMatchObject({ details: { agentsRestored: 0 } });
});
it("does not emit company.reactivated when paused → active restores no archive-paused agents", async () => {
const companyId = randomUUID();
const manualPausedAgentId = randomUUID();
await db.insert(companies).values({
id: companyId,
name: "Plain Unpause Co",
status: "paused",
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
requireBoardApprovalForNewAgents: false,
});
await insertAgents({
id: manualPausedAgentId,
companyId,
name: "Manual Paused Agent",
role: "engineer",
status: "paused",
pauseReason: "manual",
pausedAt: new Date("2026-06-01T00:00:00Z"),
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
});
const reactivated = await companyService(db).update(
companyId,
{ status: "active" },
{ actorType: "user", actorId: "test-user", agentId: null, runId: null },
);
expect(reactivated?.status).toBe("active");
const reactivateActivity = await db
.select({ id: activityLog.id })
.from(activityLog)
.where(and(
eq(activityLog.companyId, companyId),
eq(activityLog.action, "company.reactivated"),
));
expect(reactivateActivity).toHaveLength(0);
const agent = await db
.select({ status: agents.status, pauseReason: agents.pauseReason })
.from(agents)
.then((rows) => rows[0] ?? null);
expect(agent).toMatchObject({ status: "paused", pauseReason: "manual" });
});
it("cancels orphan queued wakeup requests with no runId during archive", async () => {
const companyId = randomUUID();
const agentId = randomUUID();
const orphanWakeupId = randomUUID();
const runWakeupId = randomUUID();
const runId = randomUUID();
await db.insert(companies).values({
id: companyId,
name: "Orphan Wakeup Co",
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
requireBoardApprovalForNewAgents: false,
});
await insertAgents({
id: agentId,
companyId,
name: "Idle Agent",
role: "engineer",
status: "idle",
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
});
await db.insert(agentWakeupRequests).values([
{
id: orphanWakeupId,
companyId,
agentId,
source: "automation",
status: "queued",
},
{
id: runWakeupId,
companyId,
agentId,
source: "timer",
status: "queued",
},
]);
await db.insert(heartbeatRuns).values({
id: runId,
companyId,
agentId,
invocationSource: "timer",
status: "running",
wakeupRequestId: runWakeupId,
});
const archived = await companyService(db).archive(companyId, {
actorType: "user",
actorId: "test-user",
agentId: null,
runId: null,
});
expect(archived?.status).toBe("archived");
const wakeups = await db
.select({
id: agentWakeupRequests.id,
status: agentWakeupRequests.status,
error: agentWakeupRequests.error,
})
.from(agentWakeupRequests);
const byId = new Map(wakeups.map((row) => [row.id, row]));
expect(byId.get(orphanWakeupId)).toMatchObject({
status: "cancelled",
error: "Cancelled because the company was archived",
});
expect(byId.get(runWakeupId)).toMatchObject({
status: "cancelled",
error: "Cancelled because the company was archived",
});
});
it("archive() is idempotent — re-archiving emits no second cascade or activity entry", async () => {
const companyId = randomUUID();
const agentId = randomUUID();
await db.insert(companies).values({
id: companyId,
name: "Idempotent Archive Test Co",
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
requireBoardApprovalForNewAgents: false,
});
await insertAgents({
id: agentId,
companyId,
name: "Idle Agent",
role: "engineer",
status: "idle",
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
});
const actor = { actorType: "user" as const, actorId: "test-user", agentId: null, runId: null };
const first = await companyService(db).archive(companyId, actor);
expect(first?.status).toBe("archived");
const second = await companyService(db).archive(companyId, actor);
expect(second?.status).toBe("archived");
const archiveActivity = await db
.select({ details: activityLog.details })
.from(activityLog)
.where(and(
eq(activityLog.companyId, companyId),
eq(activityLog.action, "company.archived"),
));
expect(archiveActivity).toHaveLength(1);
expect(archiveActivity[0]).toMatchObject({ details: { agentsPaused: 1, runsCancelled: 0 } });
});
it("rings the Cloud lifecycle doorbell exactly on archived-boundary transitions", async () => {
notifyCloudSpy.mockClear();
const companyId = randomUUID();
await db.insert(companies).values({
id: companyId,
name: "Doorbell Test Co",
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
requireBoardApprovalForNewAgents: false,
});
const svc = companyService(db);
const actor = { actorType: "user" as const, actorId: "test-user", agentId: null, runId: null };
// A plain edit never rings.
await svc.update(companyId, { name: "Doorbell Test Co (renamed)" }, actor);
expect(notifyCloudSpy).not.toHaveBeenCalled();
// archive() rings once; re-archiving (no transition) does not.
await svc.archive(companyId, actor);
expect(notifyCloudSpy).toHaveBeenCalledTimes(1);
expect(notifyCloudSpy).toHaveBeenLastCalledWith(companyId);
await svc.archive(companyId, actor);
expect(notifyCloudSpy).toHaveBeenCalledTimes(1);
// Unarchiving through update() rings again.
await svc.update(companyId, { status: "active" }, actor);
expect(notifyCloudSpy).toHaveBeenCalledTimes(2);
// update() into archived rings too (the status-patch archive path).
await svc.update(companyId, { status: "archived" }, actor);
expect(notifyCloudSpy).toHaveBeenCalledTimes(3);
});
it("runs the archive cascade when update() transitions a paused company to archived", async () => {
const companyId = randomUUID();
const idleAgentId = randomUUID();
const runId = randomUUID();
await db.insert(companies).values({
id: companyId,
name: "Paused To Archived Test Co",
status: "paused",
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
requireBoardApprovalForNewAgents: false,
});
await insertAgents({
id: idleAgentId,
companyId,
name: "Idle Agent",
role: "engineer",
status: "idle",
adapterType: "codex_local",
adapterConfig: {},
runtimeConfig: {},
permissions: {},
});
await db.insert(heartbeatRuns).values({
id: runId,
companyId,
agentId: idleAgentId,
invocationSource: "timer",
status: "queued",
});
const archived = await companyService(db).update(
companyId,
{ status: "archived" },
{ actorType: "user", actorId: "test-user", agentId: null, runId: null },
);
expect(archived?.status).toBe("archived");
const agent = await db
.select({ status: agents.status, pauseReason: agents.pauseReason })
.from(agents)
.then((rows) => rows[0] ?? null);
expect(agent).toMatchObject({ status: "paused", pauseReason: "company_archived" });
const run = await db
.select({ status: heartbeatRuns.status })
.from(heartbeatRuns)
.then((rows) => rows[0] ?? null);
expect(run?.status).toBe("cancelled");
const archiveActivity = await db
.select({ details: activityLog.details })
.from(activityLog)
.where(and(
eq(activityLog.companyId, companyId),
eq(activityLog.action, "company.archived"),
));
expect(archiveActivity).toHaveLength(1);
expect(archiveActivity[0]).toMatchObject({
details: { agentsPaused: 1, runsCancelled: 1 },
});
});
it("getById returns null (not a query error) for non-UUID refs", async () => {
const svc = companyService(db);
await expect(svc.getById("tumbly-haus-creative")).resolves.toBeNull();
await expect(svc.getById("not-a-uuid")).resolves.toBeNull();
await expect(svc.getById("")).resolves.toBeNull();
});
describe("issue prefix re-derivation on rename", () => {
const TEST_ACTOR = {
actorType: "user" as const,
actorId: "test-user",
agentId: null,
runId: null,
};
beforeEach(() => {
// The tenant server token is the managed-instance signal the prefix
// re-derivation gates on.
process.env.PAPERCLIP_CLOUD_TENANT_SERVER_TOKEN = "test-server-token";
});
afterEach(() => {
delete process.env.PAPERCLIP_CLOUD_TENANT_SERVER_TOKEN;
});
async function seedCompanyWithWork(name: string, issuePrefix: string) {
const [company] = await db
.insert(companies)
.values({ name, issuePrefix })
.returning({ id: companies.id });
const companyId = company!.id;
await db.insert(issues).values([
{ companyId, title: "First", issueNumber: 1, identifier: `${issuePrefix}-1` },
{ companyId, title: "Second", issueNumber: 12, identifier: `${issuePrefix}-12` },
// A pre-identifier issue must survive the re-key untouched.
{ companyId, title: "Unnumbered", issueNumber: null, identifier: null },
]);
await db.insert(cases).values({
companyId,
caseNumber: 3,
identifier: `${issuePrefix}-C3`,
caseType: "decision",
title: "A case",
});
return companyId;
}
// Nulls last, so an issue that never got an identifier stays visible in
// the assertion instead of sorting unpredictably.
function sortIdentifiers(values: (string | null)[]) {
return [...values].sort((a, b) => {
if (a === null) return b === null ? 0 : 1;
if (b === null) return -1;
return a.localeCompare(b);
});
}
async function readIdentifiers(companyId: string) {
const issueRows = await db
.select({ identifier: issues.identifier })
.from(issues)
.where(eq(issues.companyId, companyId));
const caseRows = await db
.select({ identifier: cases.identifier })
.from(cases)
.where(eq(cases.companyId, companyId));
return {
issues: sortIdentifiers(issueRows.map((row) => row.identifier)),
cases: sortIdentifiers(caseRows.map((row) => row.identifier)),
};
}
it("re-derives the prefix and re-keys both identifier tables on a managed instance", async () => {
const companyId = await seedCompanyWithWork("Acme Robotics", "ACM");
const updated = await companyService(db).update(
companyId,
{ name: "Northwind Traders" },
TEST_ACTOR,
);
expect(updated).toMatchObject({ name: "Northwind Traders", issuePrefix: "NOR" });
await expect(readIdentifiers(companyId)).resolves.toEqual({
issues: ["NOR-1", "NOR-12", null],
cases: ["NOR-C3"],
});
const logged = await db
.select({ details: activityLog.details })
.from(activityLog)
.where(and(
eq(activityLog.companyId, companyId),
eq(activityLog.action, "company.updated"),
));
expect(logged).toHaveLength(1);
expect(logged[0]).toMatchObject({
details: {
source: "company_rename",
reason: "issue_prefix_rederived",
previousIssuePrefix: "ACM",
issuePrefix: "NOR",
issuesRekeyed: 2,
casesRekeyed: 1,
},
});
});
it("suffixes the candidate when another company already holds the derived base", async () => {
await db.insert(companies).values({ name: "Northwind Holdings", issuePrefix: "NOR" });
const companyId = await seedCompanyWithWork("Acme Robotics", "ACM");
const updated = await companyService(db).update(
companyId,
{ name: "Northwind Traders" },
TEST_ACTOR,
);
expect(updated?.issuePrefix).toBe("NORA");
await expect(readIdentifiers(companyId)).resolves.toEqual({
issues: ["NORA-1", "NORA-12", null],
cases: ["NORA-C3"],
});
});
it("keeps the prefix when the rename derives the same base", async () => {
const companyId = await seedCompanyWithWork("Acme Robotics", "ACMA");
const updated = await companyService(db).update(
companyId,
{ name: "Acme Robotics International" },
TEST_ACTOR,
);
// The suffixed prefix is kept: the base did not move, so nothing needs
// to be re-keyed and no disambiguating suffix is lost.
expect(updated?.issuePrefix).toBe("ACMA");
await expect(readIdentifiers(companyId)).resolves.toEqual({
issues: ["ACMA-1", "ACMA-12", null],
cases: ["ACMA-C3"],
});
const logged = await db
.select({ id: activityLog.id })
.from(activityLog)
.where(eq(activityLog.companyId, companyId));
expect(logged).toHaveLength(0);
});
it("keeps identifiers and the company prefix together under concurrent renames", async () => {
const companyId = await seedCompanyWithWork("Acme Robotics", "ACM");
const svc = companyService(db);
// Both renames read the company before either commits. Without a row
// lock the loser re-keys from the prefix it read, finds nothing left to
// move, and strands the identifiers on the winner's prefix while the
// company row carries its own.
await Promise.all([
svc.update(companyId, { name: "Northwind Traders" }, TEST_ACTOR),
svc.update(companyId, { name: "Zenith Freight" }, TEST_ACTOR),
]);
const [company] = await db
.select({ issuePrefix: companies.issuePrefix })
.from(companies)
.where(eq(companies.id, companyId));
const prefix = company!.issuePrefix;
expect(["NOR", "ZEN"]).toContain(prefix);
await expect(readIdentifiers(companyId)).resolves.toEqual({
issues: [`${prefix}-1`, `${prefix}-12`, null],
cases: [`${prefix}-C3`],
});
});
it("keeps the prefix consistent when a stale form resubmits the old name during a rename", async () => {
const companyId = await seedCompanyWithWork("Acme Robotics", "ACM");
const svc = companyService(db);
// The second caller submits the name it loaded before the rename. Judged
// against its own stale read that name looks unchanged, so a pre-lock
// comparison would skip re-derivation and restore "Acme Robotics" on top
// of the rename's prefix.
await Promise.all([
svc.update(companyId, { name: "Northwind Traders" }, TEST_ACTOR),
svc.update(companyId, { name: "Acme Robotics" }, TEST_ACTOR),
]);
const [company] = await db
.select({ name: companies.name, issuePrefix: companies.issuePrefix })
.from(companies)
.where(eq(companies.id, companyId));
// Whichever update commits last, the prefix derives from the name that
// survived, and the identifiers sit on that prefix.
expect(company!.issuePrefix.startsWith(deriveIssuePrefixBase(company!.name))).toBe(true);
await expect(readIdentifiers(companyId)).resolves.toEqual({
issues: [`${company!.issuePrefix}-1`, `${company!.issuePrefix}-12`, null],
cases: [`${company!.issuePrefix}-C3`],
});
});
it("leaves the prefix alone when only non-name fields change", async () => {
const companyId = await seedCompanyWithWork("Acme Robotics", "ACM");
const updated = await companyService(db).update(
companyId,
{ description: "Now with rockets" },
TEST_ACTOR,
);
expect(updated?.issuePrefix).toBe("ACM");
await expect(readIdentifiers(companyId)).resolves.toEqual({
issues: ["ACM-1", "ACM-12", null],
cases: ["ACM-C3"],
});
});
it("never touches the prefix on a self-hosted instance", async () => {
delete process.env.PAPERCLIP_CLOUD_TENANT_SERVER_TOKEN;
const companyId = await seedCompanyWithWork("Acme Robotics", "ACM");
const updated = await companyService(db).update(
companyId,
{ name: "Northwind Traders" },
TEST_ACTOR,
);
expect(updated).toMatchObject({ name: "Northwind Traders", issuePrefix: "ACM" });
await expect(readIdentifiers(companyId)).resolves.toEqual({
issues: ["ACM-1", "ACM-12", null],
cases: ["ACM-C3"],
});
});
});
});