mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-02 16:58:52 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The web server owns request handling and remote execution coordination. > - Deployment must start a ready replacement while the old server still serves. > - An outage test does not prove that two live servers can overlap safely. > - This pull request adds a separate Product E2E cell for that boundary. > - The existing run, file, recovery, and retained-session checks still apply. ## Linked Issues or Issue Description Refs #18518. The runtime prerequisite is merged; this PR qualifies its ephemeral server and deployment contracts. ## What Changed - Add the explicit `rolling-web-deployment` Codex Daytona workflow. - Start independent A/B/C homes and compiled builds behind a test ingress. - Wait for readiness before routing, then drain and delete the old home. - Observe active authority before handoff and use the existing read-only recovery oracle. - Require ordinary reads and saves to succeed throughout replacement. Read back every accepted save exactly once. - Preserve the five-minute outage suites and their existing validators. - Add a model-free supervisor smoke and an unready replacement control. - Require graceful exit before deleting an old home; forced cleanup cannot satisfy the oracle. - Preserve a durable Stop through lease release/expiry until the recovered execution owner acknowledges it. Permit only fenced reattachment of the original execution for Stop cleanup; submit no new turn. - Exclude events saved by A during shutdown from evidence of B making progress. ## Verification - E2E TypeScript check passed. - Affected harness checks: 143 passed. Catalog, fixture and report checks: 120 passed. - Actual supervisor smoke passed two replacements: 436 reads, 45 saves, zero request failures, and confirmed owned resource cleanup. - B became ready in 18.7 seconds; C became ready in 109.2 seconds. A prior C timeout remains failed evidence. - Fresh browser proof: 11 checks passed, 246 reads, 50 acknowledged saves, zero failures, 1,058ms reconnect, both old homes deleted and cleanup confirmed. - Stop lease-gap regression: three PostgreSQL delivery tests passed with a simulated provider edge. Current server TypeScript build/vendoring passed. - Full harness: 5,814 passed, 17 failed, four skipped. Two shutdown races passed the focused file; two report timeouts passed an isolated 42-test rerun. Onboarding/workflow-security/Pi/date-expired fixtures are unchanged on inspected master; the host embedded PostgreSQL fixture remains a setup limitation. This is not a green full local suite. - CI at `172509b8be` passed all gates. Greptile is 5/5 with every review thread resolved. The earlier access-service race failure passed its isolated regression and the subsequent full CI. - Final review corrections: six focused executor cases, three PostgreSQL command-delivery cases, 19 harness cases and server/E2E typechecks passed. - Three live attempts failed before agent creation: two harness setup gaps were fixed, then provider authentication failed. The saved OpenAI key returns 401; a refresh is pending. The Daytona probe reported cleanup uncertain, and no sandbox with that attempt label was found through the authenticated staging manager. No live model execution is claimed. - Live Runner overlap, released-container qualification and hosted deployment proof remain pending. Merging this opt-in qualification lane does not claim those results. ## Risks - The source lane shares workspace dependencies and does not establish container packaging correctness. - The live workflow needs an explicitly owned S3 bucket, PostgreSQL, pinned remote image and provider credentials. - Qualification cleanup stops all owned processes after failure. A failed replacement must not be reported as a pass. ## Model Used OpenAI Codex, GPT-6. Tool use, code execution and repository review. The runtime does not expose a more specific model ID or context-window size. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
161 lines
8.5 KiB
TypeScript
161 lines
8.5 KiB
TypeScript
import { lstat, rename } from "node:fs/promises";
|
|
import type { ServingArtifact } from "./upgrade-artifacts.js";
|
|
import type { ControllerRecoveryReceipt } from "./controller-recovery-observer.js";
|
|
import { setTimeout as delay } from "node:timers/promises";
|
|
import type { MatrixExecution } from "./types.js";
|
|
|
|
export interface ControllerOutage {
|
|
signal: "SIGTERM" | "SIGKILL";
|
|
holdMs: number;
|
|
}
|
|
|
|
export interface ControllerOutageReceipt extends ControllerOutage {
|
|
schema: "paperclip.e2e.controller-outage/v1";
|
|
requestId: string;
|
|
previousPid: number;
|
|
replacementPid?: number;
|
|
startedAt: string;
|
|
stoppedAfterMs?: number;
|
|
cacheDiscarded?: boolean;
|
|
replacementStartedAfterMs?: number;
|
|
readyAfterMs?: number;
|
|
previousArtifact?: ServingArtifact;
|
|
replacementArtifact?: ServingArtifact;
|
|
recovery?: ControllerRecoveryReceipt;
|
|
recoveryProgress?: Partial<ControllerRecoveryReceipt>;
|
|
}
|
|
|
|
export function parseControllerOutage(value: unknown): ControllerOutage {
|
|
if (!value || typeof value !== "object" || Array.isArray(value)) throw new Error("Invalid controller outage");
|
|
const { signal, holdMs } = value as Record<string, unknown>;
|
|
if ((signal !== "SIGTERM" && signal !== "SIGKILL") || !Number.isSafeInteger(holdMs)
|
|
|| Number(holdMs) < 0 || Number(holdMs) > 300_000) throw new Error("Controller outage requires SIGTERM/SIGKILL and 0..300000 integer milliseconds");
|
|
return { signal, holdMs: Number(holdMs) };
|
|
}
|
|
|
|
export function configuredControllerOutage(env: NodeJS.ProcessEnv, defaultHoldMs = 1_000): ControllerOutage {
|
|
const raw = env.PAPERCLIP_RUNNER_E2E_CONTROLLER_OUTAGE_MS ?? String(defaultHoldMs);
|
|
if (!/^\d+$/.test(raw)) throw new Error("Invalid PAPERCLIP_RUNNER_E2E_CONTROLLER_OUTAGE_MS");
|
|
return parseControllerOutage({ signal: env.PAPERCLIP_RUNNER_E2E_CONTROLLER_STOP_SIGNAL ?? "SIGKILL", holdMs: Number(raw) });
|
|
}
|
|
|
|
export function controllerOutageForExecution(execution: MatrixExecution, env: NodeJS.ProcessEnv): ControllerOutage | undefined {
|
|
if (execution.suite.id === "rolling-web-deployment") return undefined;
|
|
if (execution.task.flow !== "everyday_workflow" || execution.task.id !== "recover-controller"
|
|
|| execution.environment.id !== "daytona" || execution.profile.generation !== "native"
|
|
|| (execution.profile.provider !== "codex" && execution.profile.provider !== "acpx")) return undefined;
|
|
const declaredHoldMs = execution.suite.definitionMetadata?.controllerDowntimeMs;
|
|
if (typeof declaredHoldMs !== "number") throw new Error("Controller recovery suite must declare its outage duration");
|
|
const outage = configuredControllerOutage(env, declaredHoldMs);
|
|
if (["daytona-restart-continuity", "remote-workspace-storage"].includes(execution.suite.id) && outage.holdMs < declaredHoldMs) {
|
|
throw new Error("Controller outage is shorter than the dedicated continuity contract");
|
|
}
|
|
return outage;
|
|
}
|
|
|
|
/** A fault receipt is required in addition to the runner's continuity receipts. */
|
|
export function validControllerOutageReceipt(value: unknown, expected?: ControllerOutage, requestId?: string,
|
|
expectedArtifacts?: { previous: Pick<ServingArtifact, "revision" | "treeSha256">;
|
|
replacement: Pick<ServingArtifact, "revision" | "treeSha256"> }): value is ControllerOutageReceipt {
|
|
if (!value || typeof value !== "object" || Array.isArray(value)) return false;
|
|
const r = value as ControllerOutageReceipt;
|
|
try { parseControllerOutage(r); } catch { return false; }
|
|
const durations = [r.stoppedAfterMs, r.replacementStartedAfterMs, r.readyAfterMs];
|
|
return r.schema === "paperclip.e2e.controller-outage/v1"
|
|
&& typeof r.requestId === "string" && /^[A-Za-z0-9._:-]{1,200}$/.test(r.requestId)
|
|
&& typeof r.startedAt === "string" && Number.isFinite(Date.parse(r.startedAt))
|
|
&& Number.isSafeInteger(r.previousPid) && r.previousPid > 0
|
|
&& Number.isSafeInteger(r.replacementPid) && Number(r.replacementPid) > 0 && r.previousPid !== r.replacementPid
|
|
&& r.cacheDiscarded === true
|
|
&& durations.every(ms => typeof ms === "number" && Number.isFinite(ms) && ms >= 0)
|
|
&& r.replacementStartedAfterMs! - r.stoppedAfterMs! >= r.holdMs
|
|
&& r.readyAfterMs! >= r.replacementStartedAfterMs!
|
|
&& r.readyAfterMs! < 420_000
|
|
&& ((!r.previousArtifact && !r.replacementArtifact) || Boolean(r.previousArtifact && r.replacementArtifact
|
|
&& [r.previousArtifact, r.replacementArtifact].every(a => /^[a-f0-9]{40}$/.test(a.revision)
|
|
&& /^[a-f0-9]{64}$/.test(a.treeSha256) && typeof a.version === "string"
|
|
&& ["released", "development-build"].includes(a.evidence))
|
|
&& r.previousArtifact.revision !== r.replacementArtifact.revision
|
|
&& r.previousArtifact.treeSha256 !== r.replacementArtifact.treeSha256))
|
|
&& (!expectedArtifacts || Boolean(r.previousArtifact && r.replacementArtifact
|
|
&& r.previousArtifact.revision === expectedArtifacts.previous.revision
|
|
&& r.previousArtifact.treeSha256 === expectedArtifacts.previous.treeSha256
|
|
&& r.replacementArtifact.revision === expectedArtifacts.replacement.revision
|
|
&& r.replacementArtifact.treeSha256 === expectedArtifacts.replacement.treeSha256))
|
|
&& (requestId === undefined || r.requestId === requestId)
|
|
&& (!expected || (r.signal === expected.signal && r.holdMs === expected.holdMs));
|
|
}
|
|
|
|
/** Test harness only. Owners supply process cleanup, HTTP probing and cache paths.
|
|
* No database mutation, runner command or production recovery hook is involved.
|
|
*/
|
|
export async function replaceController<T extends { pid?: number }>(input: {
|
|
requestId: string; previousPid: number; outage: ControllerOutage;
|
|
stop: (signal: ControllerOutage["signal"]) => Promise<void>;
|
|
waitForUnhealthy: () => Promise<void>;
|
|
discardCache: () => Promise<void>;
|
|
start: () => Promise<T>;
|
|
waitForReady: (replacement: T) => Promise<void>;
|
|
cancelled: () => boolean;
|
|
record: (receipt: ControllerOutageReceipt) => Promise<void>;
|
|
previousArtifact?: ServingArtifact;
|
|
replacementArtifact?: () => ServingArtifact | undefined;
|
|
afterStopped?: (receipt: ControllerOutageReceipt) => Promise<void>;
|
|
afterReady?: (receipt: ControllerOutageReceipt, record: () => Promise<void>) => Promise<void>;
|
|
}): Promise<ControllerOutageReceipt> {
|
|
const outage = parseControllerOutage(input.outage);
|
|
const started = performance.now();
|
|
const receipt: ControllerOutageReceipt = { schema: "paperclip.e2e.controller-outage/v1",
|
|
requestId: input.requestId, previousPid: input.previousPid, startedAt: new Date().toISOString(), ...outage,
|
|
...(input.previousArtifact ? { previousArtifact: input.previousArtifact } : {}) };
|
|
const check = () => { if (input.cancelled()) throw new Error("Wrapper shutdown interrupted the controller outage"); };
|
|
const record = () => input.record({ ...receipt });
|
|
check();
|
|
await record(); // Failed attempts retain the boundary they actually reached.
|
|
await input.stop(outage.signal);
|
|
await input.waitForUnhealthy();
|
|
receipt.stoppedAfterMs = performance.now() - started;
|
|
await input.afterStopped?.(receipt);
|
|
await record();
|
|
await input.discardCache();
|
|
receipt.cacheDiscarded = true;
|
|
await record();
|
|
while (performance.now() - started - receipt.stoppedAfterMs < outage.holdMs) {
|
|
check();
|
|
await delay(Math.min(100, outage.holdMs - (performance.now() - started - receipt.stoppedAfterMs)));
|
|
}
|
|
check();
|
|
receipt.replacementStartedAfterMs = performance.now() - started;
|
|
await record();
|
|
const replacement = await input.start();
|
|
receipt.replacementPid = replacement.pid;
|
|
await record();
|
|
await input.waitForReady(replacement);
|
|
check();
|
|
receipt.readyAfterMs = performance.now() - started;
|
|
if (input.previousArtifact) {
|
|
receipt.replacementArtifact = input.replacementArtifact?.();
|
|
if (!receipt.replacementArtifact) throw new Error("Replacement has no verified serving artifact");
|
|
}
|
|
await record();
|
|
if (!validControllerOutageReceipt(receipt, outage, input.requestId)) throw new Error("Controller outage did not produce a qualifying replacement receipt");
|
|
await input.afterReady?.(receipt, record);
|
|
return receipt;
|
|
}
|
|
|
|
/** Retire only the controller-owned cache; this is not Runner state. */
|
|
export async function retireControllerCache(cache: string, retired: string): Promise<void> {
|
|
try { await rename(cache, retired); }
|
|
catch (error) {
|
|
if ((error as NodeJS.ErrnoException).code !== "ENOENT") throw error;
|
|
// ENOENT can also mean the destination parent is missing. Only absence of
|
|
// the old cache satisfies retirement; preserve every other failure.
|
|
try { await lstat(cache); }
|
|
catch (missing) {
|
|
if ((missing as NodeJS.ErrnoException).code === "ENOENT") return;
|
|
throw missing;
|
|
}
|
|
throw error;
|
|
}
|
|
}
|