mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-23 00:53:38 +02:00
## Thinking Path > - Paperclip is the control plane for autonomous AI companies, where operators need a reliable way to find and act on work awaiting their input. > - The attention and issue-thread interaction subsystems expose those decision points across server APIs and the board UI. > - The previous navigation and interaction presentation left these actions fragmented and did not offer a controlled rollout for the Decisions surface. > - This branch adds the attention feed, richer interaction cards, grouping, dismiss/snooze behavior, and a gated Decisions sidebar entry. > - It also keeps experimental settings and API contracts synchronized, with an idempotent migration for the new dismissal state. > - This pull request delivers the complete, tested attention/Decisions experience as one reviewable unit. ## Linked Issues or Issue Description - Adds an operator-focused attention queue and Decisions experience: grouped decision cards, semantic interaction actions, dismiss/snooze handling, resilient interaction states, and an experimental flag to control the Decisions navigation entry. ## Feature Context ### Problem or Motivation Operators currently have to hunt across approvals, interactions, failed runs, and budget alerts to find decisions that need their action. ### Proposed Solution Provide a gated Decisions attention queue that groups actionable items, supports direct resolution, and preserves operator control through dismiss and snooze actions. ### Alternatives Considered Keep separate, source-specific views only; this leaves cross-cutting operator decisions fragmented and harder to prioritize. ### Roadmap Alignment This improves the V1 control-plane operator workflow by making pending governed actions discoverable in one company-scoped surface. ## What Changed - Added server attention-feed services, routes, interaction handling, dismiss/snooze support, and an idempotent `0145` inbox-dismissal migration. - Added shared attention, inbox-dismissal, and experimental-settings contracts. - Added Decisions/attention UI, interaction-card states, sidebar badge/navigation integration, grouping, keyboard support, and Storybook coverage. - Added tests for attention behavior, thread interactions, settings normalization, dismissals, and API behavior. - Removed generated screenshots from the final PR diff and rebased the branch onto current `master`. ## Verification - `pnpm check:token-gates` — passed. - `pnpm exec vitest run packages/shared/src/issue-thread-interactions.test.ts server/src/__tests__/attention-service.test.ts server/src/__tests__/inbox-dismissals.test.ts server/src/__tests__/issue-thread-interactions-service.test.ts server/src/__tests__/issue-thread-interaction-routes.test.ts ui/src/lib/attention.test.ts ui/src/components/AttentionQueueRow.test.tsx ui/src/components/IssueThreadInteractionCard.test.tsx ui/src/pages/InstanceExperimentalSettings.test.tsx` — passed: 158 tests across 9 focused files. - GitHub Actions for `ad636f560`: build and typecheck/release-registry have passed; remaining general-server and Greptile checks are in progress. ## Risks - Moderate: this is a cross-layer attention/interaction feature with a new migration and navigation behavior. - The `enableDecisions` experimental setting defaults to off, limiting rollout impact. - Existing dismissal data is backfilled to `dismiss`; the migration is idempotent and uses guarded constraint creation. > ROADMAP.md was checked; no duplicate planned core feature was identified. Related open pull requests were searched before opening this PR. ## Model Used - OpenAI GPT-5.5 via Codex CLI, with tool use and local code execution. Context-window size unavailable in this environment. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My public PR branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally; focused tests pass and the remaining unrelated AWS test failure is documented above - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
144 lines
5.2 KiB
TypeScript
144 lines
5.2 KiB
TypeScript
import { useMemo } from "react";
|
|
import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
|
|
import { Loader2 } from "lucide-react";
|
|
import type { Agent } from "@paperclipai/shared";
|
|
import { issuesApi } from "../api/issues";
|
|
import { queryKeys } from "../lib/queryKeys";
|
|
import {
|
|
isIssueThreadInteraction,
|
|
type AskUserQuestionsAnswer,
|
|
type AskUserQuestionsInteraction,
|
|
type IssueThreadInteraction,
|
|
type RequestCheckboxConfirmationInteraction,
|
|
type RequestConfirmationInteraction,
|
|
type RequestItemVerdictsInteraction,
|
|
type RequestItemVerdictValue,
|
|
type SuggestTasksInteraction,
|
|
} from "../lib/issue-thread-interactions";
|
|
import { IssueThreadInteractionCard } from "./IssueThreadInteractionCard";
|
|
|
|
interface AttentionInteractionResolverProps {
|
|
companyId: string;
|
|
issueId: string;
|
|
interactionId: string;
|
|
agentMap?: Map<string, Agent>;
|
|
currentUserId?: string | null;
|
|
userLabelMap?: ReadonlyMap<string, string> | null;
|
|
/** Called after a resolution so the parent can refresh the feed. */
|
|
onResolved?: () => void;
|
|
}
|
|
|
|
/**
|
|
* Lazily fetches the full issue-thread interaction referenced by an attention
|
|
* row and renders the existing {@link IssueThreadInteractionCard} inline, so
|
|
* confirmations and questions are answerable in-row without leaving the queue
|
|
* (converged PAP-12628). Reviews never reach here — they deep-link.
|
|
*/
|
|
export function AttentionInteractionResolver({
|
|
companyId,
|
|
issueId,
|
|
interactionId,
|
|
agentMap,
|
|
currentUserId,
|
|
userLabelMap,
|
|
onResolved,
|
|
}: AttentionInteractionResolverProps) {
|
|
const queryClient = useQueryClient();
|
|
|
|
const { data: interactions, isLoading, error } = useQuery({
|
|
queryKey: queryKeys.issues.interactions(issueId),
|
|
queryFn: () => issuesApi.listInteractions(issueId),
|
|
enabled: !!issueId,
|
|
});
|
|
|
|
const interaction = useMemo<IssueThreadInteraction | null>(() => {
|
|
const match = (interactions ?? []).find((entry) => entry.id === interactionId);
|
|
return match && isIssueThreadInteraction(match) ? match : null;
|
|
}, [interactions, interactionId]);
|
|
|
|
const invalidate = () => {
|
|
queryClient.invalidateQueries({ queryKey: queryKeys.issues.interactions(issueId) });
|
|
queryClient.invalidateQueries({ queryKey: queryKeys.attention(companyId) });
|
|
onResolved?.();
|
|
};
|
|
|
|
const acceptMutation = useMutation({
|
|
mutationFn: (input: {
|
|
interaction: SuggestTasksInteraction | RequestConfirmationInteraction | RequestCheckboxConfirmationInteraction;
|
|
selectedClientKeys?: string[];
|
|
selectedOptionIds?: string[];
|
|
}) =>
|
|
issuesApi.acceptInteraction(issueId, input.interaction.id, {
|
|
selectedClientKeys: input.selectedClientKeys,
|
|
selectedOptionIds: input.selectedOptionIds,
|
|
}),
|
|
onSuccess: invalidate,
|
|
});
|
|
|
|
const rejectMutation = useMutation({
|
|
mutationFn: (input: { interactionId: string; reason?: string }) =>
|
|
issuesApi.rejectInteraction(issueId, input.interactionId, input.reason),
|
|
onSuccess: invalidate,
|
|
});
|
|
|
|
const respondMutation = useMutation({
|
|
mutationFn: (input: { interactionId: string; answers: AskUserQuestionsAnswer[] }) =>
|
|
issuesApi.respondToInteraction(issueId, input.interactionId, { answers: input.answers }),
|
|
onSuccess: invalidate,
|
|
});
|
|
|
|
const cancelMutation = useMutation({
|
|
mutationFn: (input: { interactionId: string }) =>
|
|
issuesApi.cancelInteraction(issueId, input.interactionId),
|
|
onSuccess: invalidate,
|
|
});
|
|
|
|
const verdictsMutation = useMutation({
|
|
mutationFn: (input: {
|
|
interactionId: string;
|
|
verdicts: { id: string; verdict: RequestItemVerdictValue; reason?: string }[];
|
|
}) => issuesApi.submitInteractionVerdicts(issueId, input.interactionId, input.verdicts),
|
|
onSuccess: invalidate,
|
|
});
|
|
|
|
if (isLoading) {
|
|
return (
|
|
<div className="flex items-center gap-2 py-3 text-xs text-muted-foreground">
|
|
<Loader2 className="h-3.5 w-3.5 animate-spin" /> Loading decision…
|
|
</div>
|
|
);
|
|
}
|
|
|
|
if (error || !interaction) {
|
|
return (
|
|
<p className="py-3 text-xs text-muted-foreground">
|
|
This decision is no longer available — it may have been resolved elsewhere.
|
|
</p>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<IssueThreadInteractionCard
|
|
interaction={interaction}
|
|
agentMap={agentMap}
|
|
currentUserId={currentUserId}
|
|
userLabelMap={userLabelMap}
|
|
onAcceptInteraction={(target, selectedClientKeys, selectedOptionIds) =>
|
|
acceptMutation.mutateAsync({ interaction: target, selectedClientKeys, selectedOptionIds }).then(() => undefined)
|
|
}
|
|
onRejectInteraction={(target, reason) =>
|
|
rejectMutation.mutateAsync({ interactionId: target.id, reason }).then(() => undefined)
|
|
}
|
|
onSubmitInteractionAnswers={(target: AskUserQuestionsInteraction, answers) =>
|
|
respondMutation.mutateAsync({ interactionId: target.id, answers }).then(() => undefined)
|
|
}
|
|
onCancelInteraction={(target: AskUserQuestionsInteraction) =>
|
|
cancelMutation.mutateAsync({ interactionId: target.id }).then(() => undefined)
|
|
}
|
|
onSubmitInteractionVerdicts={(target: RequestItemVerdictsInteraction, verdicts) =>
|
|
verdictsMutation.mutateAsync({ interactionId: target.id, verdicts }).then(() => undefined)
|
|
}
|
|
/>
|
|
);
|
|
}
|