mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-21 08:22:20 +02:00
## Thinking Path - Paperclip Runner needs its runtime preinstalled for fast sandbox startup. - Native and local adapters should launch one current CLI installation per provider. - An older global copy can shadow that installation, and exact native compatibility pins must match it. - Update the qualified releases and binary digests, expose shared CLI entrypoints from the provider pack, and prefer the image-owned bin directory. - Keep dependency installation in the image build; task startup only discovers, links, and verifies artifacts. ## Linked Issues or Issue Description **What happened?** Remote native startup rejected a stale global Codex, while CLI-only images lacked runnerd entirely. **Expected behavior** An image-baked runtime starts without uploading binaries or installing packages. All adapters share the same current provider CLI. **Steps to reproduce** Start a native remote task with the old global Codex and the updated runtime available only under `/opt/paperclip-runner/bin`. **Paperclip version or commit** Discovery behavior at `54a99d884`. **Deployment mode** Docker with a remote sandbox. ## What Changed - Prefer `/opt/paperclip-runner/bin`, then the user's local bin directory, then PATH. Existing metadata and version validation remains in force. - Qualify Codex 0.153.4, OpenCode 1.18.29, and Claude SDK 0.3.263 / CLI 2.1.263. Update binary digests, TypeScript/Rust checks, registry defaults, and the displayed OpenCode version together. - Share Codex and Claude's native executable with the ACP bridges through exact dependency overrides. Preserve the separately qualified ACP bridge implementations and their security patches. - Expose shared provider-pack CLI launchers; fail the pack build if Codex ACP resolves a separate Codex installation. Update the eval image's other agent CLIs to current stable releases and remove duplicate global provider installs. - Document the single-current-CLI policy in source comments and development guidance. Latest stable releases are resolved at review/build preparation and pinned; task startup never auto-updates. ## Verification - Native-session and adapter-registry suites: 158 tests passed. - Provider suites: 88 tests passed, 7 Linux-only checks skipped on macOS. One existing macOS temporary-path alias assertion passed when rerun with canonical `TMPDIR=/private/tmp`. - Package-contract and OpenCode materialization tests: 11 passed. - Full typecheck, build, and token gates passed. Rust native-provider/recovery tests: 19 passed. - Broad local suite: 5,974 passed, 23 failed, 41 skipped. Failures are in unchanged macOS workspace/path/port and connection suites; focused runtime tests pass. All latest-head Linux PR checks passed, including the full test shards, typecheck, build, runner verification, browser suites, and canary dry run. - The standalone fleet image built with one current provider CLI each and passed native Codex/Claude binary-integrity checks. A disposable Daytona sandbox reported ready in 798 ms; its baked runner completed an API-key `gpt-5.6-luna` turn in 2,430 ms and returned the expected marker with a usage receipt. No runtime artifacts were uploaded or installed. - The normal shared `codex exec` entrypoint also completed an API-key `gpt-5.6-luna` turn in 2,321 ms. - Both image builds verify the complete generated lockfile against a reviewed SHA-256 before package installation or lifecycle execution. Root lockfile changes remain CI-owned. Merge and rollout remain on hold for operator review. ## Risks - Updating provider CLIs changes their behavior for all adapters; version probes and live native smoke testing are required before image promotion. - The image-owned directory takes precedence. Its entries must launch the same shared CLI as the global PATH, not a private older/newer copy. - Application qualification pins and the deployed image must move together. No startup fallback installation is added. - No schema or authentication-policy changes. ## Model Used OpenAI GPT-6 (Codex). The session does not expose a more specific model ID or context-window size. Used reasoning, repository inspection, code execution, and browser verification. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
476 lines
15 KiB
JavaScript
476 lines
15 KiB
JavaScript
import assert from "node:assert/strict";
|
|
import { mkdtemp, mkdir, readFile, rm, writeFile } from "node:fs/promises";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import test from "node:test";
|
|
|
|
import {
|
|
aggregateProtocolEvalCampaign,
|
|
buildProtocolEvalCatalog,
|
|
credentialForConfig,
|
|
sanitizeProtocolEvalRuns,
|
|
} from "./runner-protocol-eval-campaign.mjs";
|
|
|
|
const roots = [];
|
|
test.afterEach(async () => {
|
|
await Promise.all(
|
|
roots.splice(0).map((root) => rm(root, { recursive: true, force: true })),
|
|
);
|
|
});
|
|
|
|
async function fixture() {
|
|
const root = await mkdtemp(join(tmpdir(), "runner-protocol-campaign-"));
|
|
roots.push(root);
|
|
const program = join(root, "evals/paperclip-runner");
|
|
await Promise.all([
|
|
mkdir(join(program, "rosters"), { recursive: true }),
|
|
mkdir(join(program, "configs"), { recursive: true }),
|
|
mkdir(join(program, "cases"), { recursive: true }),
|
|
mkdir(join(program, "campaigns"), { recursive: true }),
|
|
]);
|
|
const config = {
|
|
schema: "paperclip-runner/eval-config/v1",
|
|
id: "live-opencode-model",
|
|
provider: "opencode",
|
|
driver: "opencode_server",
|
|
model: "openrouter/example/model",
|
|
opencodeVersion: "1.18.29",
|
|
};
|
|
const evalCase = {
|
|
schema: "paperclip-runner/eval-case/v1",
|
|
id: "get-task-context",
|
|
title: "Get context",
|
|
description: "Synthetic public fixture",
|
|
prompt: "Inspect the synthetic task.",
|
|
fixture: "../fixtures/company.json",
|
|
authority: { actorId: "agent-1", taskId: "task-1" },
|
|
checks: [{ id: "context", kind: "semantic_operation" }],
|
|
};
|
|
const roster = {
|
|
schema: "paperclip-runner/live-roster/v1",
|
|
id: "protocol-live-opencode-model",
|
|
model: config.model,
|
|
config: "../configs/live-opencode-model.json",
|
|
cases: [evalCase.id],
|
|
};
|
|
await Promise.all([
|
|
writeFile(
|
|
join(program, "configs/live-opencode-model.json"),
|
|
JSON.stringify(config),
|
|
),
|
|
writeFile(
|
|
join(program, "cases/get-task-context.json"),
|
|
JSON.stringify(evalCase),
|
|
),
|
|
writeFile(
|
|
join(program, "rosters/live-opencode-model.json"),
|
|
JSON.stringify(roster),
|
|
),
|
|
writeFile(
|
|
join(program, "campaigns/live-direct-full.json"),
|
|
JSON.stringify({
|
|
schema: "paperclip-runner/live-campaign/v1",
|
|
lanes: [
|
|
{
|
|
id: "opencode-model",
|
|
executionClass: "default",
|
|
roster: "../rosters/live-opencode-model.json",
|
|
},
|
|
],
|
|
}),
|
|
),
|
|
]);
|
|
return { root, program, config, evalCase, roster };
|
|
}
|
|
|
|
test("maps every qualified driver to one explicit credential boundary", () => {
|
|
assert.equal(credentialForConfig({ provider: "codex" }), "OPENAI_API_KEY");
|
|
assert.equal(
|
|
credentialForConfig({ provider: "opencode" }),
|
|
"OPENROUTER_API_KEY",
|
|
);
|
|
assert.equal(
|
|
credentialForConfig({ provider: "acpx", acpxAgent: "claude" }),
|
|
"ANTHROPIC_API_KEY",
|
|
);
|
|
assert.equal(
|
|
credentialForConfig({ provider: "aws_agentcore" }),
|
|
"AWS_AGENTCORE_OIDC",
|
|
);
|
|
assert.throws(
|
|
() => credentialForConfig({ provider: "unknown" }),
|
|
/credential policy/,
|
|
);
|
|
});
|
|
|
|
test("catalogs roster plus case cells and emits bounded balanced shards", async () => {
|
|
const { root } = await fixture();
|
|
const catalog = await buildProtocolEvalCatalog({
|
|
evalsRoot: root,
|
|
campaignId: "gha-42-1",
|
|
maxParallel: 80,
|
|
});
|
|
assert.equal(catalog.cells.length, 1);
|
|
assert.equal(catalog.selection.kind, "maintained_full");
|
|
assert.equal(catalog.cells[0].credentialName, "OPENROUTER_API_KEY");
|
|
assert.equal(catalog.maxParallelPerShard, 40);
|
|
assert.equal(catalog.matrices[0].include.length, 1);
|
|
assert.equal(catalog.matrices[1].include.length, 0);
|
|
await assert.rejects(
|
|
buildProtocolEvalCatalog({
|
|
evalsRoot: root,
|
|
campaignId: "gha-42-1",
|
|
rosterSelection: "missing-roster",
|
|
}),
|
|
/Unknown live roster/,
|
|
);
|
|
await assert.rejects(
|
|
buildProtocolEvalCatalog({
|
|
evalsRoot: root,
|
|
campaignId: "gha-42-1",
|
|
maxParallel: 1,
|
|
}),
|
|
/from 2 through 100/,
|
|
);
|
|
});
|
|
|
|
test("all selects the maintained enabled campaign and explicit diagnostics can select disabled rosters", async () => {
|
|
const { root, program, config, evalCase } = await fixture();
|
|
const disabledRoster = {
|
|
schema: "paperclip-runner/live-roster/v1",
|
|
id: "protocol-live-disabled-model",
|
|
model: config.model,
|
|
config: "../configs/live-opencode-model.json",
|
|
cases: [evalCase.id],
|
|
};
|
|
await Promise.all([
|
|
writeFile(
|
|
join(program, "rosters/live-disabled-model.json"),
|
|
JSON.stringify(disabledRoster),
|
|
),
|
|
writeFile(
|
|
join(program, "campaigns/live-direct-full.json"),
|
|
JSON.stringify({
|
|
schema: "paperclip-runner/live-campaign/v1",
|
|
lanes: [
|
|
{
|
|
id: "opencode-model",
|
|
executionClass: "default",
|
|
roster: "../rosters/live-opencode-model.json",
|
|
},
|
|
{
|
|
id: "disabled-model",
|
|
executionClass: "disabled",
|
|
roster: "../rosters/live-disabled-model.json",
|
|
},
|
|
],
|
|
}),
|
|
),
|
|
]);
|
|
|
|
const maintained = await buildProtocolEvalCatalog({
|
|
evalsRoot: root,
|
|
campaignId: "gha-42-1",
|
|
});
|
|
assert.deepEqual(
|
|
maintained.rosters.map((roster) => roster.rosterId),
|
|
["protocol-live-opencode-model"],
|
|
);
|
|
|
|
const diagnostic = await buildProtocolEvalCatalog({
|
|
evalsRoot: root,
|
|
campaignId: "gha-42-2",
|
|
rosterSelection: "protocol-live-disabled-model",
|
|
});
|
|
assert.deepEqual(
|
|
diagnostic.rosters.map((roster) => roster.rosterId),
|
|
["protocol-live-disabled-model"],
|
|
);
|
|
assert.equal(diagnostic.selection.kind, "subset");
|
|
});
|
|
|
|
test("all fails closed when the maintained campaign is missing", async () => {
|
|
const { root, program } = await fixture();
|
|
await rm(join(program, "campaigns/live-direct-full.json"));
|
|
|
|
await assert.rejects(
|
|
buildProtocolEvalCatalog({
|
|
evalsRoot: root,
|
|
campaignId: "gha-42-1",
|
|
}),
|
|
/ENOENT/,
|
|
);
|
|
|
|
const diagnostic = await buildProtocolEvalCatalog({
|
|
evalsRoot: root,
|
|
campaignId: "gha-42-2",
|
|
rosterSelection: "protocol-live-opencode-model",
|
|
});
|
|
assert.deepEqual(
|
|
diagnostic.rosters.map((roster) => roster.rosterId),
|
|
["protocol-live-opencode-model"],
|
|
);
|
|
});
|
|
|
|
test("aggregates retained attempts and synthesizes missing cells as infrastructure", async () => {
|
|
const { root, config, evalCase } = await fixture();
|
|
const catalog = await buildProtocolEvalCatalog({
|
|
evalsRoot: root,
|
|
campaignId: "gha-42-1",
|
|
});
|
|
const catalogPath = join(root, "catalog.json");
|
|
await writeFile(catalogPath, JSON.stringify(catalog));
|
|
const campaign = await aggregateProtocolEvalCampaign({
|
|
catalogPath,
|
|
downloadsRoot: join(root, "missing-downloads"),
|
|
evalsRoot: root,
|
|
runsOut: join(root, "merged-runs"),
|
|
campaignOut: join(root, "campaign.json"),
|
|
source: {
|
|
paperclip: { sha: "a".repeat(40), ref: "refs/heads/master" },
|
|
evals: { repository: "paperclipai/paperclip-evals", sha: "b".repeat(40) },
|
|
workflowRunUrl: "https://example.test/actions/runs/42",
|
|
},
|
|
});
|
|
assert.deepEqual(campaign.totals, {
|
|
selected: 1,
|
|
passed: 0,
|
|
behaviorFailures: 0,
|
|
infrastructureFailures: 1,
|
|
});
|
|
assert.equal(campaign.results[0].disposition, "infrastructure_failure");
|
|
assert.equal(campaign.complete, true);
|
|
assert.equal(campaign.allPassed, false);
|
|
const attempt = campaign.results[0].finalAttemptId;
|
|
assert.deepEqual(
|
|
JSON.parse(await readFile(join(root, "merged-runs", attempt, "case.json"))),
|
|
evalCase,
|
|
);
|
|
assert.deepEqual(
|
|
JSON.parse(
|
|
await readFile(join(root, "merged-runs", attempt, "config.json")),
|
|
),
|
|
config,
|
|
);
|
|
});
|
|
|
|
test("campaign cost includes failed attempts before a successful retry", async () => {
|
|
const { root, config, evalCase } = await fixture();
|
|
const catalog = await buildProtocolEvalCatalog({ evalsRoot: root, campaignId: "gha-42-1" });
|
|
const catalogPath = join(root, "catalog.json");
|
|
const download = join(root, "downloads/cell");
|
|
await mkdir(download, { recursive: true });
|
|
await writeFile(catalogPath, JSON.stringify(catalog));
|
|
await writeFile(join(download, "cell.json"), JSON.stringify({
|
|
cellId: catalog.cells[0].cellId, caseId: evalCase.id,
|
|
rosterFile: catalog.cells[0].rosterFile, exitCode: 0,
|
|
}));
|
|
for (const [attemptId, amount, passed] of [["attempt-01", 2, false], ["attempt-02", 3, true]]) {
|
|
const directory = join(download, "runs", attemptId);
|
|
await mkdir(directory, { recursive: true });
|
|
for (const [file, value] of Object.entries({
|
|
"artifact.json": { attemptId, usage: { estimatedCostNanodollars: amount } },
|
|
"score.json": { attemptId, caseId: evalCase.id, passed, disposition: passed ? "passed" : "infrastructure_failure" },
|
|
"case.json": evalCase, "config.json": config,
|
|
})) await writeFile(join(directory, file), JSON.stringify(value));
|
|
}
|
|
const result = await aggregateProtocolEvalCampaign({
|
|
catalogPath, downloadsRoot: join(root, "downloads"), evalsRoot: root,
|
|
runsOut: join(root, "merged"), campaignOut: join(root, "campaign.json"), source: {},
|
|
});
|
|
assert.equal(result.totals.passed, 1);
|
|
assert.equal(result.results[0].usage.estimatedCostNanodollars, 3);
|
|
assert.equal(result.costs.estimated.nanodollars, 5);
|
|
assert.equal(result.costs.attempts, 2);
|
|
assert.equal(result.selection.kind, "maintained_full");
|
|
});
|
|
|
|
test("rejects downloaded cells that were not declared by the immutable catalog", async () => {
|
|
const { root } = await fixture();
|
|
const catalog = await buildProtocolEvalCatalog({
|
|
evalsRoot: root,
|
|
campaignId: "gha-42-1",
|
|
});
|
|
const catalogPath = join(root, "catalog.json");
|
|
const downloads = join(root, "downloads/unexpected");
|
|
await mkdir(downloads, { recursive: true });
|
|
await Promise.all([
|
|
writeFile(catalogPath, JSON.stringify(catalog)),
|
|
writeFile(
|
|
join(downloads, "cell.json"),
|
|
JSON.stringify({
|
|
cellId: "protocol-live-opencode-model--undeclared",
|
|
rosterFile: "live-opencode-model.json",
|
|
caseId: "undeclared",
|
|
exitCode: 1,
|
|
}),
|
|
),
|
|
]);
|
|
await assert.rejects(
|
|
aggregateProtocolEvalCampaign({
|
|
catalogPath,
|
|
downloadsRoot: join(root, "downloads"),
|
|
evalsRoot: root,
|
|
runsOut: join(root, "merged-runs"),
|
|
campaignOut: join(root, "campaign.json"),
|
|
source: {},
|
|
}),
|
|
/unexpected cell/,
|
|
);
|
|
});
|
|
|
|
test("public run projection removes raw evidence and gives unverified recordings an empty chat view", async () => {
|
|
const { root, config, evalCase } = await fixture();
|
|
const attemptId = "get-task-context-opencode-gha-42-1-attempt-01";
|
|
const source = join(root, "raw-runs", attemptId);
|
|
await mkdir(source, { recursive: true });
|
|
await Promise.all([
|
|
writeFile(
|
|
join(source, "artifact.json"),
|
|
JSON.stringify({
|
|
schema: "paperclip-runner/eval-session-artifact/v1",
|
|
attemptId,
|
|
createdAt: "2026-09-05T00:00:00.000Z",
|
|
requestedModel: config.model,
|
|
provider: config.provider,
|
|
driver: config.driver,
|
|
providerVersion: config.opencodeVersion,
|
|
providerSessionId: "private-session-id",
|
|
trace: { secret: "private" },
|
|
usage: {
|
|
agentTurns: 1,
|
|
inputTokens: 100,
|
|
estimatedCostNanodollars: 5000,
|
|
},
|
|
turn: { status: "completed", turnId: "private-turn" },
|
|
snapshot: {
|
|
createdAt: "2026-09-05T00:00:00.000Z",
|
|
providerModel: { id: config.model, provider: "openrouter" },
|
|
transcript: [{ role: "assistant", text: "private transcript" }],
|
|
evidence: [{ kind: "tool_call", data: { token: "private" } }],
|
|
},
|
|
issueThread: { messages: ["private"] },
|
|
devtools: { revisions: [{ state: { private: true } }] },
|
|
}),
|
|
),
|
|
writeFile(
|
|
join(source, "score.json"),
|
|
JSON.stringify({
|
|
schema: "paperclip-runner/eval-score/v1",
|
|
attemptId,
|
|
caseId: evalCase.id,
|
|
disposition: "passed",
|
|
passed: true,
|
|
infrastructureErrors: [],
|
|
checks: [
|
|
{
|
|
id: "context",
|
|
kind: "semantic_operation",
|
|
passed: true,
|
|
detail: "private result",
|
|
evidenceRefs: ["event-1"],
|
|
},
|
|
],
|
|
digest: "sha256:test",
|
|
}),
|
|
),
|
|
writeFile(join(source, "case.json"), JSON.stringify(evalCase)),
|
|
writeFile(
|
|
join(source, "config.json"),
|
|
JSON.stringify({ ...config, managedProfile: { profileId: "private" } }),
|
|
),
|
|
]);
|
|
await sanitizeProtocolEvalRuns({
|
|
runsRoot: join(root, "raw-runs"),
|
|
publicRunsRoot: join(root, "public-runs"),
|
|
});
|
|
const serialized = await readFile(
|
|
join(root, "public-runs", attemptId, "artifact.json"),
|
|
"utf8",
|
|
);
|
|
assert.doesNotMatch(
|
|
serialized,
|
|
/private-session|private transcript|private-turn|"trace":/,
|
|
);
|
|
const artifact = JSON.parse(serialized);
|
|
assert.deepEqual(artifact.snapshot.transcript, []);
|
|
assert.deepEqual(artifact.snapshot.evidence, []);
|
|
assert.deepEqual(artifact.devtools.revisions, []);
|
|
assert.equal(artifact.issueThread.composer.state, "disabled");
|
|
assert.equal(artifact.issueThread.turns[0].items[0].kind, "system_notice");
|
|
const score = JSON.parse(
|
|
await readFile(join(root, "public-runs", attemptId, "score.json"), "utf8"),
|
|
);
|
|
assert.deepEqual(score.checks[0], {
|
|
id: "context",
|
|
kind: "semantic_operation",
|
|
passed: true,
|
|
detail: "passed",
|
|
evidenceRefs: [],
|
|
});
|
|
const publicConfig = await readFile(
|
|
join(root, "public-runs", attemptId, "config.json"),
|
|
"utf8",
|
|
);
|
|
assert.doesNotMatch(publicConfig, /managedProfile|private/);
|
|
});
|
|
|
|
test("public run projection redacts remote profile version identities", async () => {
|
|
const { root, config, evalCase } = await fixture();
|
|
const attemptId = "get-task-context-claude-managed-gha-42-1-attempt-01";
|
|
const source = join(root, "raw-runs", attemptId);
|
|
await mkdir(source, { recursive: true });
|
|
await Promise.all([
|
|
writeFile(
|
|
join(source, "artifact.json"),
|
|
JSON.stringify({
|
|
schema: "paperclip-runner/eval-session-artifact/v1",
|
|
attemptId,
|
|
createdAt: "2026-09-05T00:00:00.000Z",
|
|
requestedModel: "claude-sonnet-5",
|
|
provider: "claude_managed",
|
|
driver: "claude_managed_agents_api",
|
|
providerVersion: "private-agent-version-id",
|
|
usage: {},
|
|
turn: { status: "completed" },
|
|
snapshot: {
|
|
createdAt: "2026-09-05T00:00:00.000Z",
|
|
providerModel: { id: "claude-sonnet-5", provider: "anthropic" },
|
|
},
|
|
}),
|
|
),
|
|
writeFile(
|
|
join(source, "score.json"),
|
|
JSON.stringify({
|
|
schema: "paperclip-runner/eval-score/v1",
|
|
attemptId,
|
|
caseId: evalCase.id,
|
|
disposition: "passed",
|
|
passed: true,
|
|
checks: [],
|
|
}),
|
|
),
|
|
writeFile(join(source, "case.json"), JSON.stringify(evalCase)),
|
|
writeFile(
|
|
join(source, "config.json"),
|
|
JSON.stringify({
|
|
...config,
|
|
id: "live-claude-managed",
|
|
model: "claude-sonnet-5",
|
|
provider: "claude_managed",
|
|
driver: "claude_managed_agents_api",
|
|
}),
|
|
),
|
|
]);
|
|
await sanitizeProtocolEvalRuns({
|
|
runsRoot: join(root, "raw-runs"),
|
|
publicRunsRoot: join(root, "public-runs"),
|
|
});
|
|
const publicArtifact = await readFile(
|
|
join(root, "public-runs", attemptId, "artifact.json"),
|
|
"utf8",
|
|
);
|
|
assert.match(publicArtifact, /remote profile redacted/);
|
|
assert.doesNotMatch(publicArtifact, /private-agent-version-id/);
|
|
});
|