Files
PaperClipAI/tests/runner-e2e/chat-vault-private-server.test.ts
T
f4337bb5fb test(evals): land the chat catalog eval harness on master (#19614)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - The chat-feature evals measure whether agents complete real chat
requests through the product
> - The chat catalog eval harness and its repairs live on the
`chat-eval/master-candidate` branch, not on master
> - Today's work made 139 of 242 chat evals pass in verified single-case
live runs. Each product fix landed on master as its own pull request
> - The eval-side changes (setups, graders, fault seams, evidence
capture) still exist only on the candidate
> - This pull request lands the harness on master. Master stays the
source of truth for product behavior
> - The benefit is one tree: evals run against master commits, and
product fixes reach the evals as soon as they merge

## Linked Issues or Issue Description

Refs #19441, Refs #19599, Refs #20270, Refs #20334, Refs #20342, Refs
#20344, Refs #20354, Refs #20360, Refs #20373, Refs #20382, Refs #20409

**What existing behavior does this improve?**
The chat catalog eval harness and the product it evaluates live on a
long-running branch outside master. Eval fixes do not reach master, so
master-based eval runs use old setups and graders.

**Subsystem affected**
`tests/runner-e2e` chat catalog harness, plus a small set of product
changes that exist only on the candidate.

**Proposed change**
Land the harness on master. Every product fix from this eval work
already merged to master as its own pull request. Conflicts keep
master's product behavior.

## What Changed

- Most of the diff (808 of 851 files) is under `tests/runner-e2e/`:
chat-catalog domains, scenarios, descriptors, the TestOps manifest,
private evidence tooling, and their tests.
- Graders now check saved state, setup literals and rendered or clicked
links. Many keyword and regex checks on free-form replies are removed.
Each changed grader has a bumped `oracleVersion` and calibration tests
(a valid reply, a reworded valid reply, and broken variants that must
fail).
- The shared link helper `hasLink` no longer treats a list link (for
example `/COM/issues?view=mine`) as a link to every task without a URL
key.
- Setup fixes build real state through supported product routes: routine
history, agent grants through the board grant route, budget holds with a
real cap, and a storage-layer archive fault for
`inbox-search.archive-partial-failure`.
- Browser boundary journeys (sign-in, chat-disabled, onboarding) now
write the standard pass evidence files.
- Retargeted cases, approved by the maintainer:
`agent-chat.chat-disabled` (Conference Room gate),
`agents.restore-instructions` (no saved instruction history),
`access.manage-membership` (member permission edits stay board-only).
- The private evidence trusted files (`manual-private-handoff.ts`,
`manual-private-retention.ts`, `manual-private-report-assets.ts`) are
byte-identical to master.
- Product files outside `tests/` (43 files, +1,328 −49) carry
candidate-only changes that master does not yet have. Most are tests.
The main code changes are in `request-human-input.ts`,
`heartbeat-run-summary.ts`, `native-completion-feedback.ts`,
`native-run-finalizer.ts`, `openapi.ts`, `secrets.ts` and
`IssueChatLongThreadPerf.tsx`.

## Verification

- `pnpm vitest run chat-catalog-domains chat-catalog-contract.test.ts
chat-catalog-consistency.test.ts unit-launcher.test.mjs
--testTimeout=180000` in `tests/runner-e2e`: 269 files pass, 3,550 tests
pass.
- `node --test chat-full-catalog-testops-manifest.test.mjs`: 10 pass.
- `node tests/runner-e2e/source-sdk-public-inputs.mjs <HEAD> --check`:
no change.
- `tsc` for `server` and `tests/runner-e2e`: clean.
- Live single-case verification: 139 of 242 cases passed on paid runs,
and a person read the saved evidence for each. These are single-case
runs, not one full-cohort run.

## Risks

- Large diff. Most of it is test-only, but the 43 non-test files change
product code paths. Review those files first.
- Some graders are now less strict on reply wording. A person must read
replies for meaning on those cases.
- 42 cases need disposable outside accounts (Notion, Slack, GitHub,
Daytona and others) and stay blocked. `access.invite-teammate` stays
failing until local agent isolation lands, because the runner's durable
state keeps a live invite token.
- The paid workflow compares the trusted private-evidence files with
master. They are unchanged, so this risk is low.

## Model Used

Anthropic Claude Opus 5.5 (`claude-opus-5-5`), with tool use and code
execution, in Claude Code. Subagents used the same model.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-11-10 08:02:11 -06:00

228 lines
8.1 KiB
TypeScript

import { afterEach, expect, it } from "vitest";
import { mkdtemp, mkdir, writeFile, rm, chmod } from "node:fs/promises";
import { tmpdir } from "node:os";
import path from "node:path";
import { CHAT_PRIVATE_INPUTS_ENV } from "./chat-private-inputs.js";
import {
buildPaperclipServerEnvironment,
buildRunnerE2EProcessEnvironment,
} from "./harness-env.js";
import {
readSelectedVaultServerEnvironment,
privateVaultMetadataMatches,
validVaultBinding,
vaultPrivateFields,
vaultExecutionId,
vaultExecutionIds,
} from "./chat-vault-private-server.js";
import type { MatrixExecution } from "./types.js";
const roots: string[] = [];
afterEach(async () => {
for (const directory of roots.splice(0))
await rm(directory, { recursive: true, force: true });
});
function binding() {
return {
disposable: true,
resourceIds: [
"arn:aws:secretsmanager:us-east-1:123456789012:secret:disposable/deployment-AbCdEf",
"arn:aws:kms:us-east-1:123456789012:key/12345678-1234-1234-1234-123456789012",
],
credentialEnv: [
"PAPERCLIP_CHAT_EVAL_AWS_ACCESS",
"PAPERCLIP_CHAT_EVAL_AWS_SECRET",
"PAPERCLIP_CHAT_EVAL_AWS_SESSION",
"PAPERCLIP_CHAT_EVAL_VAULT_EXPECTED",
],
prerequisites: {
provider: "aws_secrets_manager",
region: "us-east-1",
deploymentId: "disposable-catalog",
kmsKeyId:
"arn:aws:kms:us-east-1:123456789012:key/12345678-1234-1234-1234-123456789012",
secretReference:
"arn:aws:secretsmanager:us-east-1:123456789012:secret:disposable/deployment-AbCdEf",
accessKeyIdEnv: "PAPERCLIP_CHAT_EVAL_AWS_ACCESS",
secretAccessKeyEnv: "PAPERCLIP_CHAT_EVAL_AWS_SECRET",
sessionTokenEnv: "PAPERCLIP_CHAT_EVAL_AWS_SESSION",
expectedValueEnv: "PAPERCLIP_CHAT_EVAL_VAULT_EXPECTED",
},
};
}
async function fixture() {
const root = await mkdtemp(
path.join(tmpdir(), "paperclip-runner-e2e-vault-control-"),
);
roots.push(root);
const directory = path.join(root, "selected-private-inputs");
await mkdir(directory, { mode: 0o700 });
const filename = path.join(directory, "chat-selected-inputs.json"),
b = binding();
const envelope = {
version: 1,
executionId: vaultExecutionId,
references: {
PAPERCLIP_CHAT_EVAL_AWS_ACCESS: "ASIA1234567890123456",
PAPERCLIP_CHAT_EVAL_AWS_SECRET: "synthetic-selected-secret-key",
PAPERCLIP_CHAT_EVAL_AWS_SESSION: "synthetic-selected-session-token",
PAPERCLIP_CHAT_EVAL_VAULT_EXPECTED: "synthetic-vault-oracle-only",
},
external: { schemaVersion: 1, providers: { vault: b } },
declaredReferenceNames: b.credentialEnv,
declaredExternalRequirements: [
{ provider: "vault", fields: [...vaultPrivateFields] },
],
setupBlockers: [] as string[],
};
const save = () =>
writeFile(filename, JSON.stringify(envelope), { mode: 0o600 });
await save();
return {
envelope,
save,
filename,
input: {
executionIds: [vaultExecutionId],
temporaryRoot: root,
backendOrigin: "http://127.0.0.1:3399",
env: {
[CHAT_PRIVATE_INPUTS_ENV]: filename,
AWS_ACCESS_KEY_ID: "AMBIENT-DO-NOT-USE",
AWS_PROFILE: "unrelated-personal-profile",
PAPERCLIP_SECRETS_AWS_ENDPOINT: "http://unrelated.test",
},
},
};
}
it("supplies only explicitly selected server credentials/config and excludes oracle values/default profiles", async () => {
const f = await fixture(),
env = await readSelectedVaultServerEnvironment(f.input);
expect(env.AWS_ACCESS_KEY_ID).toBe(
f.envelope.references.PAPERCLIP_CHAT_EVAL_AWS_ACCESS,
);
expect(env.AWS_SECRET_ACCESS_KEY).toBe(
f.envelope.references.PAPERCLIP_CHAT_EVAL_AWS_SECRET,
);
expect(env.AWS_SESSION_TOKEN).toBe(
f.envelope.references.PAPERCLIP_CHAT_EVAL_AWS_SESSION,
);
expect(env.AWS_EC2_METADATA_DISABLED).toBe("true");
expect(env.AWS_PROFILE).toBeUndefined();
expect(env.PAPERCLIP_SECRETS_AWS_ENDPOINT).toBeUndefined();
expect(JSON.stringify(env)).not.toContain(
f.envelope.references.PAPERCLIP_CHAT_EVAL_VAULT_EXPECTED,
);
expect(
Object.keys(env).some((name) => name.startsWith("PAPERCLIP_CHAT_EVAL_")),
).toBe(false);
expect(env.AWS_CONFIG_FILE).toBe(env.AWS_SHARED_CREDENTIALS_FILE);
});
it("keeps missing selected inputs as reserved setup prerequisites without using ambient AWS", async () => {
const f = await fixture();
expect(
await readSelectedVaultServerEnvironment({
...f.input,
env: { AWS_ACCESS_KEY_ID: "ambient" },
}),
).toEqual({});
f.envelope.setupBlockers = [
"missing-external-reference:PAPERCLIP_CHAT_EVAL_AWS_ACCESS",
];
await f.save();
expect(await readSelectedVaultServerEnvironment(f.input)).toEqual({});
expect(
await readSelectedVaultServerEnvironment({
...f.input,
executionIds: ["unrelated"],
}),
).toEqual({});
});
it("rejects another execution, unsafe private files, undeclared references and cross-account resources", async () => {
const f = await fixture();
await expect(
readSelectedVaultServerEnvironment({
...f.input,
executionIds: [vaultExecutionId, "unrelated"],
}),
).rejects.toThrow(/single selected/);
f.envelope.executionId = "another-execution";
await f.save();
await expect(readSelectedVaultServerEnvironment(f.input)).rejects.toThrow(
/another execution/,
);
f.envelope.executionId = vaultExecutionId;
f.envelope.declaredReferenceNames = [];
await f.save();
await expect(readSelectedVaultServerEnvironment(f.input)).rejects.toThrow(
/selected reference/,
);
f.envelope.declaredReferenceNames = binding().credentialEnv;
await f.save();
await chmod(f.filename, 0o644);
await expect(readSelectedVaultServerEnvironment(f.input)).rejects.toThrow(
/private and owned/,
);
expect(privateVaultMetadataMatches({ uid: 101, mode: 0o600 }, 101)).toBe(
true,
);
expect(privateVaultMetadataMatches({ uid: 102, mode: 0o600 }, 101)).toBe(
false,
);
const b = binding();
expect(validVaultBinding(b)).toBe(true);
b.prerequisites.kmsKeyId = b.prerequisites.kmsKeyId.replace(
"123456789012",
"987654321012",
);
expect(validVaultBinding(b)).toBe(false);
const other = binding();
other.resourceIds = [];
expect(validVaultBinding(other)).toBe(false);
});
it("scrubs ambient AWS and vault SDK config while preserving explicit unrelated suite mechanisms", () => {
const ambient = {
AWS_ACCESS_KEY_ID: "ambient",
AWS_SECRET_ACCESS_KEY: "ambient-secret",
AWS_PROFILE: "personal",
AWS_CONTAINER_CREDENTIALS_FULL_URI: "https://unrelated.test",
AWS_WEB_IDENTITY_TOKEN_FILE: "/private/personal-token",
PAPERCLIP_SECRETS_AWS_ENDPOINT: "https://unrelated.test",
KEEP: "yes",
};
expect(buildPaperclipServerEnvironment(ambient)).toEqual({ KEEP: "yes" });
expect(
buildPaperclipServerEnvironment(ambient, {
AWS_ACCESS_KEY_ID: "explicit-selected",
}).AWS_ACCESS_KEY_ID,
).toBe("explicit-selected");
const execution = {
suite: { id: "chat-features" },
task: { id: "secrets.vault-reference" },
profile: { generation: "native", provider: "codex" },
environment: { id: "local" },
} as MatrixExecution;
const chat = buildRunnerE2EProcessEnvironment(ambient, [execution]);
expect(
Object.keys(chat).some(
(name) =>
name.startsWith("AWS_") || name.startsWith("PAPERCLIP_SECRETS_AWS_"),
),
).toBe(false);
const other = buildRunnerE2EProcessEnvironment(ambient, [
{
...execution,
suite: { ...execution.suite, id: "explicit-unrelated-suite" },
},
]);
expect(other.AWS_ACCESS_KEY_ID).toBe("ambient");
});
it("binds the OpenCode vault envelope to the exact selected new execution, never the prior campaign", async () => {
const f = await fixture();
f.input.executionIds = [vaultExecutionIds[1]!]; f.envelope.executionId = vaultExecutionIds[1]!; await f.save();
expect(await readSelectedVaultServerEnvironment(f.input)).toHaveProperty("AWS_ACCESS_KEY_ID", f.envelope.references.PAPERCLIP_CHAT_EVAL_AWS_ACCESS);
f.envelope.executionId = vaultExecutionId; await f.save();
await expect(readSelectedVaultServerEnvironment(f.input)).rejects.toThrow();
});