mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-11 05:31:46 +02:00
## Thinking Path > - Paperclip is the control plane for autonomous AI companies, so agent work needs visible ownership, recovery, and operator controls. > - This local branch had accumulated several related control-plane reliability and operator-experience fixes across recovery actions, watchdog folding, model-profile defaults, mentions, markdown editing, plugin launchers, and small UI polish. > - The branch needed to be converted into a PR against the current `origin/master` without losing dirty work or including lockfile/workflow churn. > - The safest standalone shape is a single rollup PR because the recovery/server/UI files overlap heavily across the local commits and splitting would create avoidable conflicts. > - This pull request replays the local branch onto latest `origin/master`, preserves the uncommitted work as logical commits, and adds a Zod 4 validator compatibility fix found during verification. > - The benefit is that the May 17 local branch can be reviewed and merged as one coherent, conflict-free branch under the 100-file Greptile limit. ## What Changed - Rebased the local May 17 branch work onto current `origin/master` in a dedicated worktree. - Preserved and committed previously dirty changes for recovery retry handling, plugin/sidebar launcher polish, and `.herenow` ignores. - Added recovery-action behavior for returning source issues to `todo` when retrying source-scoped recovery. - Included the existing local recovery/liveness/watchdog fold, Codex cheap-profile, markdown/mention, duplicate-agent, and UI polish commits from the branch. - Normalized shared validator `z.record(...)` schemas to explicit string-key records for Zod 4 compatibility. - Confirmed the PR has no `pnpm-lock.yaml` or `.github/workflows/*` changes and stays below the 100-file Greptile limit. ## Verification - `pnpm install --frozen-lockfile --ignore-scripts` - `npm run install` in `node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3` to build the local native sqlite3 binding after installing with scripts disabled - `pnpm exec vitest run packages/shared/src/validators/issue.test.ts packages/shared/src/project-mentions.test.ts packages/adapter-utils/src/server-utils.test.ts server/src/__tests__/heartbeat-model-profile.test.ts server/src/__tests__/issue-recovery-actions.test.ts server/src/__tests__/issue-agent-mutation-ownership-routes.test.ts server/src/__tests__/heartbeat-active-run-output-watchdog.test.ts server/src/__tests__/plugin-local-folders.test.ts ui/src/components/IssueRecoveryActionCard.test.tsx ui/src/components/Sidebar.test.tsx ui/src/components/SidebarAccountMenu.test.tsx ui/src/components/IssueProperties.test.tsx ui/src/components/MarkdownEditor.test.tsx ui/src/components/MarkdownBody.test.tsx ui/src/lib/duplicate-agent-payload.test.ts ui/src/pages/Routines.test.tsx` - First pass: 13 files passed with 201 passing tests; 3 server files failed before sqlite3 native binding was built. - After rebuilding sqlite3: `server/src/__tests__/heartbeat-model-profile.test.ts`, `server/src/__tests__/issue-recovery-actions.test.ts`, and `server/src/__tests__/heartbeat-active-run-output-watchdog.test.ts` passed/loaded; embedded Postgres tests were skipped by the local host guard. - `pnpm --filter @paperclipai/shared typecheck` - `pnpm --filter @paperclipai/adapter-utils typecheck` - `pnpm --filter @paperclipai/server typecheck` - `pnpm --filter @paperclipai/ui typecheck` ## Risks - Medium risk: this is a broad rollup PR across recovery semantics, server tests, shared validators, and UI surfaces. - Some embedded Postgres tests skipped locally due the host guard, so CI should provide the stronger database-backed signal. - UI changes were covered by component tests, but no browser screenshot was captured in this PR creation pass. - This branch may overlap with existing recovery/liveness PR work; merge this PR independently or restack/close overlapping branches rather than merging duplicate implementations together. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-based coding agent, tool-enabled local repository and GitHub workflow, medium reasoning effort. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
132 lines
4.8 KiB
TypeScript
132 lines
4.8 KiB
TypeScript
import { z } from "zod";
|
|
|
|
export const executionWorkspaceStatusSchema = z.enum([
|
|
"active",
|
|
"idle",
|
|
"in_review",
|
|
"archived",
|
|
"cleanup_failed",
|
|
]);
|
|
|
|
export const executionWorkspaceConfigSchema = z.object({
|
|
environmentId: z.string().uuid().optional().nullable(),
|
|
provisionCommand: z.string().optional().nullable(),
|
|
teardownCommand: z.string().optional().nullable(),
|
|
cleanupCommand: z.string().optional().nullable(),
|
|
workspaceRuntime: z.record(z.string(), z.unknown()).optional().nullable(),
|
|
desiredState: z.enum(["running", "stopped", "manual"]).optional().nullable(),
|
|
serviceStates: z.record(z.enum(["running", "stopped", "manual"])).optional().nullable(),
|
|
}).strict();
|
|
|
|
export const workspaceRuntimeControlTargetSchema = z.object({
|
|
workspaceCommandId: z.string().min(1).optional().nullable(),
|
|
runtimeServiceId: z.string().uuid().optional().nullable(),
|
|
serviceIndex: z.number().int().nonnegative().optional().nullable(),
|
|
}).strict();
|
|
|
|
export const executionWorkspaceCloseReadinessStateSchema = z.enum([
|
|
"ready",
|
|
"ready_with_warnings",
|
|
"blocked",
|
|
]);
|
|
|
|
export const executionWorkspaceCloseActionKindSchema = z.enum([
|
|
"archive_record",
|
|
"stop_runtime_services",
|
|
"cleanup_command",
|
|
"teardown_command",
|
|
"git_worktree_remove",
|
|
"git_branch_delete",
|
|
"remove_local_directory",
|
|
]);
|
|
|
|
export const executionWorkspaceCloseActionSchema = z.object({
|
|
kind: executionWorkspaceCloseActionKindSchema,
|
|
label: z.string(),
|
|
description: z.string(),
|
|
command: z.string().nullable(),
|
|
}).strict();
|
|
|
|
export const executionWorkspaceCloseLinkedIssueSchema = z.object({
|
|
id: z.string().uuid(),
|
|
identifier: z.string().nullable(),
|
|
title: z.string(),
|
|
status: z.string(),
|
|
isTerminal: z.boolean(),
|
|
}).strict();
|
|
|
|
export const executionWorkspaceCloseGitReadinessSchema = z.object({
|
|
repoRoot: z.string().nullable(),
|
|
workspacePath: z.string().nullable(),
|
|
branchName: z.string().nullable(),
|
|
baseRef: z.string().nullable(),
|
|
hasDirtyTrackedFiles: z.boolean(),
|
|
hasUntrackedFiles: z.boolean(),
|
|
dirtyEntryCount: z.number().int().nonnegative(),
|
|
untrackedEntryCount: z.number().int().nonnegative(),
|
|
aheadCount: z.number().int().nonnegative().nullable(),
|
|
behindCount: z.number().int().nonnegative().nullable(),
|
|
isMergedIntoBase: z.boolean().nullable(),
|
|
createdByRuntime: z.boolean(),
|
|
}).strict();
|
|
|
|
export const workspaceRuntimeServiceSchema = z.object({
|
|
id: z.string(),
|
|
companyId: z.string().uuid(),
|
|
projectId: z.string().uuid().nullable(),
|
|
projectWorkspaceId: z.string().uuid().nullable(),
|
|
executionWorkspaceId: z.string().uuid().nullable(),
|
|
issueId: z.string().uuid().nullable(),
|
|
scopeType: z.enum(["project_workspace", "execution_workspace", "run", "agent"]),
|
|
scopeId: z.string().nullable(),
|
|
serviceName: z.string(),
|
|
status: z.enum(["starting", "running", "stopped", "failed"]),
|
|
lifecycle: z.enum(["shared", "ephemeral"]),
|
|
reuseKey: z.string().nullable(),
|
|
command: z.string().nullable(),
|
|
cwd: z.string().nullable(),
|
|
port: z.number().int().nullable(),
|
|
url: z.string().nullable(),
|
|
provider: z.enum(["local_process", "adapter_managed"]),
|
|
providerRef: z.string().nullable(),
|
|
ownerAgentId: z.string().uuid().nullable(),
|
|
startedByRunId: z.string().uuid().nullable(),
|
|
lastUsedAt: z.coerce.date(),
|
|
startedAt: z.coerce.date(),
|
|
stoppedAt: z.coerce.date().nullable(),
|
|
stopPolicy: z.record(z.string(), z.unknown()).nullable(),
|
|
healthStatus: z.enum(["unknown", "healthy", "unhealthy"]),
|
|
configIndex: z.number().int().nonnegative().nullable().optional(),
|
|
createdAt: z.coerce.date(),
|
|
updatedAt: z.coerce.date(),
|
|
}).strict();
|
|
export const executionWorkspaceCloseReadinessSchema = z.object({
|
|
workspaceId: z.string().uuid(),
|
|
state: executionWorkspaceCloseReadinessStateSchema,
|
|
blockingReasons: z.array(z.string()),
|
|
warnings: z.array(z.string()),
|
|
linkedIssues: z.array(executionWorkspaceCloseLinkedIssueSchema),
|
|
plannedActions: z.array(executionWorkspaceCloseActionSchema),
|
|
isDestructiveCloseAllowed: z.boolean(),
|
|
isSharedWorkspace: z.boolean(),
|
|
isProjectPrimaryWorkspace: z.boolean(),
|
|
git: executionWorkspaceCloseGitReadinessSchema.nullable(),
|
|
runtimeServices: z.array(workspaceRuntimeServiceSchema),
|
|
}).strict();
|
|
|
|
export const updateExecutionWorkspaceSchema = z.object({
|
|
name: z.string().min(1).optional(),
|
|
cwd: z.string().optional().nullable(),
|
|
repoUrl: z.string().optional().nullable(),
|
|
baseRef: z.string().optional().nullable(),
|
|
branchName: z.string().optional().nullable(),
|
|
providerRef: z.string().optional().nullable(),
|
|
status: executionWorkspaceStatusSchema.optional(),
|
|
cleanupEligibleAt: z.string().datetime().optional().nullable(),
|
|
cleanupReason: z.string().optional().nullable(),
|
|
config: executionWorkspaceConfigSchema.optional().nullable(),
|
|
metadata: z.record(z.string(), z.unknown()).optional().nullable(),
|
|
}).strict();
|
|
|
|
export type UpdateExecutionWorkspace = z.infer<typeof updateExecutionWorkspaceSchema>;
|