mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-28 20:21:50 +01:00
## Thinking Path > - Paperclip evals need complete model-spend evidence. > - The bounded Product E2E controller already owns request admission and token receipts. > - Its loopback endpoints cannot serve a Daytona agent. > - Explicit remote cases therefore need a scoped transport to the same controller. > - This PR exposes only authenticated model and OTLP endpoints through one owned quick tunnel. > - Remote requests keep the same budget, request identity, usage journal and cancellation drain. ## Linked Issues or Issue Description Refs #17928, #17929, #17523. **What happened?** The operations manifest and fixture reject Daytona. The parent gateway and native trace relay bind loopback, so normal remote agent traffic cannot use their cost accounting. **Expected behavior** An explicit native marker or feedback case on Daytona can route requests through the bounded parent. Upstream provider and Braintrust keys stay on that controller. Every paid request keeps its usage receipt and the attempt retains ordinary feedback and cleanup evidence. **Steps to reproduce** Use the explicit `remoteGateway: "cloudflare"` manifest option for a native Codex or Claude Daytona marker/feedback case. Without that option, the remote selection remains rejected. The parent verifies its public health nonce before fixture setup. ## What Changed - Add a deadline-limited bridge with exact model/OTLP paths, separate scoped tokens, streamed responses and owned tunnel cleanup. - Start one HTTPS quick tunnel with a private home and no provider credentials or ambient Cloudflare configuration. Do not retry creation or paid work. - Admit only explicit native Daytona marker/feedback cells and require the provisioning credential before opening the journal. - Bind fixture model/OTLP endpoints to the assigned remote origin. Keep provisioning access in the fixture/server controller. - Preserve final token usage when a remote client disconnects during shutdown. - Document the manual route. Daily and weekly selections remain local. ## Verification - Full Product E2E unit suite: 4,370 passed and 2 skipped across 206 files, plus 137 Node checks. - Focused remote/usage/operations/trace checks: 71 tests passed; final bridge/drain checks: 15 passed. - Product E2E typecheck passed. - Tests cover missing tunnel executable, expiry, authentication, blocked paths, token separation, missing provisioning credentials, endpoint assignment and listener cleanup. - The cancellation regression uses the real gateway and ledger with a synthetic upstream. It retains the final receipt once after remote disconnect. - Latest source and architecture/cleanup checks: 167 passed; eval typecheck passed. Both reviews are 5/5 and exact-head CI is green. Live qualification follows merge. ## Risks The explicit route sends synthetic eval requests and scoped attempt tokens through Cloudflare. Those tokens expire with the existing campaign deadline and budget. Upstream keys stay on the controller. Public readiness has a finite wait; failure stops before fixture setup. The operator still needs the existing immutable Daytona image and verified native artifacts. Source and deterministic tests do not establish live remote acceptance. ## Model Used OpenAI Codex, GPT-6 family, with reasoning, repository inspection and code execution. The exact serving model ID and context window are not exposed to this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
102 lines
7.0 KiB
TypeScript
102 lines
7.0 KiB
TypeScript
import { mkdtemp, readFile, writeFile, rm, readdir } from "node:fs/promises";
|
|
import { tmpdir } from "node:os";
|
|
import path from "node:path";
|
|
import { createServer } from "node:http";
|
|
import { once } from "node:events";
|
|
import { expect, it, vi } from "vitest";
|
|
import { isEvalRemoteOrigin, startEvalRemoteBridge, startEvalRemoteGateway } from "./eval-remote-gateway.js";
|
|
|
|
it("forwards only authenticated model/OTLP routes and closes owned exposure", async () => {
|
|
const calls: Array<{ url: string; auth?: string; body: string }> = [];
|
|
const upstream = createServer(async (request, response) => {
|
|
let body = ""; for await (const chunk of request) body += chunk;
|
|
calls.push({ url: request.url!, auth: request.headers.authorization, body });
|
|
response.writeHead(200, { "content-type": "text/event-stream" }); response.end("data: synthetic\n\n");
|
|
});
|
|
upstream.listen(0, "127.0.0.1"); await once(upstream, "listening");
|
|
const address = upstream.address(); if (!address || typeof address === "string") throw new Error("Fixture did not bind");
|
|
const url = `http://127.0.0.1:${address.port}`, modelToken = "a".repeat(64), otlpToken = "b".repeat(64);
|
|
const bridge = await startEvalRemoteBridge({ gateway: { baseUrl: url, token: modelToken },
|
|
observability: { baseUrl: url + "/otel", token: otlpToken }, deadlineAt: Date.now() + 60_000 });
|
|
try {
|
|
expect(await (await fetch(bridge.baseUrl + "/health")).json()).toEqual({ nonce: bridge.nonce });
|
|
for (const path of ["/v1/responses", "/v1/messages?beta=true", "/otel/v1/traces", "/otel/v1/logs"]) {
|
|
expect((await fetch(bridge.baseUrl + path, { method: "POST" })).status).toBe(401);
|
|
const token = path.startsWith("/otel") ? otlpToken : modelToken;
|
|
const response = await fetch(bridge.baseUrl + path, { method: "POST", headers: { authorization: `Bearer ${token}`, "content-type": "application/json" }, body: "{}" });
|
|
expect(response.status).toBe(200); expect(await response.text()).toBe("data: synthetic\n\n");
|
|
}
|
|
expect(calls).toHaveLength(4);
|
|
expect(calls.map(call => call.url)).toEqual(["/v1/responses", "/v1/messages?beta=true", "/otel/v1/traces", "/otel/v1/logs"]);
|
|
expect(calls.map(call => call.auth)).toEqual([`Bearer ${modelToken}`, `Bearer ${modelToken}`, `Bearer ${otlpToken}`, `Bearer ${otlpToken}`]);
|
|
expect((await fetch(bridge.baseUrl + "/admin", { method: "POST", headers: { authorization: `Bearer ${modelToken}` } })).status).toBe(404);
|
|
expect((await fetch(bridge.baseUrl + "/otel/v1/traces", { method: "POST", headers: { authorization: `Bearer ${modelToken}` } })).status).toBe(401);
|
|
await bridge.close(); await expect(fetch(bridge.baseUrl + "/health")).rejects.toThrow();
|
|
} finally { await bridge.close(); upstream.closeAllConnections(); await new Promise<void>(resolve => upstream.close(() => resolve())); }
|
|
});
|
|
|
|
it("admits only HTTPS quick-tunnel origins and bounded loopback destinations", async () => {
|
|
expect(isEvalRemoteOrigin("https://synthetic-fixture.trycloudflare.com")).toBe(true);
|
|
for (const value of ["https://foreign.invalid", "http://synthetic.trycloudflare.com", "https://synthetic.trycloudflare.com/path", "https://synthetic.trycloudflare.com?token=private"]) expect(isEvalRemoteOrigin(value)).toBe(false);
|
|
await expect(startEvalRemoteBridge({ gateway: { baseUrl: "https://foreign.invalid", token: "a".repeat(64) }, deadlineAt: Date.now() + 60_000 })).rejects.toThrow("policy");
|
|
});
|
|
|
|
|
|
it("fails before remote admission when the tunnel executable is unavailable", async () => {
|
|
await expect(startEvalRemoteGateway({ gateway: { baseUrl: "http://127.0.0.1:1", token: "a".repeat(64) },
|
|
deadlineAt: Date.now() + 5000 }, { PAPERCLIP_EVAL_CLOUDFLARED: "/missing/synthetic-cloudflared", PATH: "" }))
|
|
.rejects.toThrow("Remote eval tunnel executable unavailable");
|
|
});
|
|
|
|
it("closes remote exposure at its original campaign deadline", async () => {
|
|
const bridge = await startEvalRemoteBridge({ gateway: { baseUrl: "http://127.0.0.1:1", token: "a".repeat(64) }, deadlineAt: Date.now() + 50 });
|
|
try {
|
|
await new Promise(resolve => setTimeout(resolve, 100));
|
|
await expect(fetch(bridge.baseUrl + "/health")).rejects.toThrow();
|
|
} finally { await bridge.close(); }
|
|
});
|
|
|
|
|
|
it.each(["explicit", "empty-override"])("waits for registration and the correct public nonce, then terminates the owned tunnel: %s", async mode => {
|
|
const root = await mkdtemp(path.join(tmpdir(), "eval-fake-tunnel-"));
|
|
const executable = path.join(root, "cloudflared"), state = path.join(root, "state.json"), stopped = path.join(root, "stopped");
|
|
const origin = "https://synthetic-owned.trycloudflare.com";
|
|
const script = `#!${process.execPath}
|
|
const fs = require("node:fs");
|
|
fs.writeFileSync(${JSON.stringify(state)}, JSON.stringify({baseUrl:process.argv.at(-1),pid:process.pid,env:process.env}));
|
|
process.stderr.write("${origin}\\n");
|
|
setTimeout(() => process.stderr.write("Registered tunnel connection\\n"), 20);
|
|
process.on("SIGTERM", () => { fs.writeFileSync(${JSON.stringify(stopped)}, "stopped"); process.exit(0); });
|
|
setInterval(() => {}, 1000);
|
|
`;
|
|
await writeFile(executable, script, { mode: 0o700 });
|
|
const realFetch = globalThis.fetch; let healthChecks = 0;
|
|
const fetchSpy = vi.spyOn(globalThis, "fetch").mockImplementation(async url => {
|
|
expect(String(url)).toBe(origin + "/health");
|
|
if (++healthChecks === 1) return new Response(JSON.stringify({ nonce: "foreign" }), { status: 200 });
|
|
const { baseUrl } = JSON.parse(await readFile(state, "utf8"));
|
|
return realFetch(baseUrl + "/health");
|
|
});
|
|
let remote: Awaited<ReturnType<typeof startEvalRemoteGateway>> | undefined;
|
|
try {
|
|
remote = await startEvalRemoteGateway({ gateway: { baseUrl: "http://127.0.0.1:1", token: "a".repeat(64) },
|
|
deadlineAt: Date.now() + 10_000 }, { PAPERCLIP_EVAL_CLOUDFLARED: mode === "explicit" ? executable : "", PATH: root, OPENAI_API_KEY: "must-not-leave" });
|
|
expect(remote.baseUrl).toBe(origin); expect(healthChecks).toBe(2);
|
|
const { baseUrl, pid, env } = JSON.parse(await readFile(state, "utf8"));
|
|
expect(env.OPENAI_API_KEY).toBeUndefined(); expect(env.HOME).not.toBe(process.env.HOME);
|
|
await remote.close();
|
|
expect(await readFile(stopped, "utf8")).toBe("stopped");
|
|
expect(() => process.kill(pid, 0)).toThrow();
|
|
await expect(realFetch(baseUrl + "/health")).rejects.toThrow();
|
|
await expect(readFile(path.join(env.HOME, "anything"))).rejects.toThrow();
|
|
} finally { fetchSpy.mockRestore(); await remote?.close(); await rm(root, { recursive: true, force: true }); }
|
|
}, 15_000);
|
|
|
|
|
|
it("cleans the private tunnel home after synchronous spawn rejection", async () => {
|
|
const before = new Set((await readdir(tmpdir())).filter(name => name.startsWith("eval-cloudflare-")));
|
|
await expect(startEvalRemoteGateway({ gateway: { baseUrl: "http://127.0.0.1:1", token: "a".repeat(64) },
|
|
deadlineAt: Date.now() + 60_000 }, { PAPERCLIP_EVAL_CLOUDFLARED: "invalid\0executable", PATH: "" })).rejects.toThrow();
|
|
expect((await readdir(tmpdir())).filter(name => name.startsWith("eval-cloudflare-") && !before.has(name))).toEqual([]);
|
|
});
|