mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-19 01:46:15 +02:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Agents and boards coordinate through issue-thread interactions (request_confirmation, ask_user_questions, suggest_tasks, …) that wait as `pending` cards until someone resolves them > - Two lifecycle gaps existed: an interaction's creator could not take back a card it no longer stands behind, and interactions left `pending` on issues that reached a terminal status lingered forever as live-looking approval requests > - Stale pending cards mislead humans (they look actionable), distort attention/liveness signals, and in the worst case invite acting on a proposal whose issue is already closed or cancelled > - This pull request adds an explicit withdraw route for pending interactions and automatically expires pending interactions when their issue reaches a terminal status (including a catch-up sweep for issues closed before this change) > - The benefit is that interaction cards now faithfully reflect reality: only genuinely actionable requests stay pending, and creators can retract requests that events have overtaken ## Linked Issues or Issue Description Fixes #5787 Refs #7403 Related prior PRs found while searching for duplicates (all overlap partially; none combine both lifecycle paths or the route-level authorization used here): #6709 and #7312 (creator-withdraw attempts), #8169 (terminal expiry), #8081 and #5137 (generalized cancel/expire endpoints), #6094 (stale confirmation auto-resolve). Related merged context: #9568 (agent cancel for ask_user_questions), #10119 (tolerating legacy `withdrawn_by_creator` result outcomes — the reader side of the outcome this PR writes). ## What Changed - New route `POST /issues/:id/interactions/:interactionId/withdraw` that resolves a `pending` interaction to status `withdrawn` with a structured result (`outcome: "withdrawn"`, optional trimmed `reason`), stamps `resolvedBy*`/`resolvedAt`, touches the issue, logs activity, and emits resolved-interaction telemetry - Withdrawal authorization: board users, the interaction's creator agent, or the issue's current assignee agent (assignees additionally pass the standard issue-mutation gate); task-watchdog runs are explicitly rejected, and authorization-boundary plus low-trust control-plane checks apply - Withdrawing an already-resolved interaction returns `409`; unknown/cross-issue/cross-company interaction ids return `404` - New service method `expirePendingInteractionsForTerminalIssue`: when an issue transitions to a terminal status, all of its `pending` interactions are resolved to `expired` with `outcome: "issue_closed"`, guarded by a `status = 'pending'` predicate so concurrent resolutions are not overwritten - The same expiry runs as a catch-up when interactions are listed on an already-terminal issue, so cards stranded by issues closed before this change also get cleaned up; expired request_confirmations are logged with a distinguishing source - Shared package: new `withdrawIssueThreadInteractionSchema` validator, `WithdrawIssueThreadInteraction` type, and `withdrawn` / `issue_closed` result-outcome support for all interaction kinds (kind-aware result shapes for `ask_user_questions` and `request_item_verdicts`) - UI helper `ui/src/lib/issue-thread-interactions.ts` recognizes the new outcomes for card rendering - Docs: bundled skill API reference updated with the withdraw endpoint - Review follow-up: terminal expiry moved from the HTTP route hooks into `issueService.update`'s status-transition block, so direct service callers (tree control, recovery, pipelines, status cards) expire pending cards too; the list-endpoint catch-up remains for issues closed before this change - Review follow-up: withdrawing or issue-close-expiring a `request_confirmation` also settles its linked `tool_action_requests` row (withdraw -> `cancelled`, issue closed -> `expired`), so a parked tool call cannot stay approvable after its card is gone - Review follow-up: interaction cards render dedicated copy for the new outcomes ("Withdrawn" with the reason, "Expired when issue closed") instead of falling through to superseded-by-comment / stale-target variants; withdrawn plan reviews badge as "Withdrawn" rather than "Changes requested" ## Screenshots Card states rendered from a local ux-lab harness with mocked data ([full gallery](https://pages.paperclip.ing/pr-10251-interaction-withdrawal-cards/)): | Light | Dark | | --- | --- | |  |  | ## Verification - `pnpm --filter @paperclipai/shared build` — clean tsc - `cd server && npx vitest run src/__tests__/issue-thread-interaction-routes.test.ts` — 22 tests pass, including new coverage for: creator-agent withdraw success, non-creator/non-assignee agent 403, watchdog-run 403, double-withdraw 409, and board-user withdraw - `cd server && npx vitest run src/services/issue-thread-interactions.test.ts` — 4 tests pass, including terminal-issue expiry writing `issue_closed` results and leaving already-resolved interactions untouched - `cd ui && pnpm typecheck` — clean - `cd server && npx vitest run src/__tests__/issues-service.test.ts` — includes a new embedded-Postgres test proving a direct `issueService.update` terminal transition expires pending interactions and writes the activity-log entry - `cd ui && npx vitest run src/components/IssueThreadInteractionCard.test.tsx` — 32 tests, including new coverage for withdrawn / issue-closed confirmation and question cards - `cd server && npx tsc --noEmit` — matches the pre-existing repo error baseline exactly (no new errors) - Manual: `POST /issues/:id/interactions/:interactionId/withdraw` with `{"reason":"superseded"}` as the creator agent resolves the card to `withdrawn`; closing an issue with a pending confirmation flips it to `expired` with `outcome: "issue_closed"` ## Risks - Interactions on terminal issues now auto-expire (including retroactively via the list-time catch-up), so consumers that expected to resolve a pending interaction on a closed issue will get `409`; this is the intended semantics and matches how the attention feed already wants to treat dead cards - New result outcomes (`withdrawn`, `issue_closed`) are written to stored results; readers were already made tolerant of these outcome strings in #10119, so mixed-version reads are safe - No schema/migration changes; per-row conditional updates (`status = 'pending'`) avoid clobbering concurrent resolutions - Withdrawal is a new mutation surface, but it is strictly narrower than existing resolve paths (board, creator, or assignee only; watchdog runs blocked) ## Model Used Claude Fable 5 (`claude-fable-5`, Anthropic Mythos-class tier) with extended thinking and agentic tool use (Claude Code harness); commit authored in a Paperclip-managed engineering session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
789 lines
29 KiB
TypeScript
789 lines
29 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { act as reactAct, type ComponentProps, type ReactNode } from "react";
|
|
import { flushSync } from "react-dom";
|
|
import { createRoot, type Root } from "react-dom/client";
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import { IssueThreadInteractionCard } from "./IssueThreadInteractionCard";
|
|
import { ThemeProvider } from "../context/ThemeContext";
|
|
import { TooltipProvider } from "./ui/tooltip";
|
|
import {
|
|
pendingAskUserQuestionsInteraction,
|
|
commentExpiredAskUserQuestionsInteraction,
|
|
commentExpiredRequestConfirmationInteraction,
|
|
declinedToolActionInteraction,
|
|
disabledDeclineReasonRequestConfirmationInteraction,
|
|
executedToolActionInteraction,
|
|
expiredToolActionInteraction,
|
|
failedRequestConfirmationInteraction,
|
|
failedToolActionInteraction,
|
|
pendingRequestConfirmationInteraction,
|
|
pendingToolActionDestructiveInteraction,
|
|
pendingToolActionWriteInteraction,
|
|
planApprovalResumeFailedRequestConfirmationInteraction,
|
|
pendingRequestItemVerdictsInteraction,
|
|
pendingSuggestedTasksInteraction,
|
|
runningToolActionInteraction,
|
|
completeRequestItemVerdictsInteraction,
|
|
supersededRequestItemVerdictsInteraction,
|
|
staleTargetRequestConfirmationInteraction,
|
|
rejectedSuggestedTasksInteraction,
|
|
} from "../fixtures/issueThreadInteractionFixtures";
|
|
|
|
let root: Root | null = null;
|
|
let container: HTMLDivElement | null = null;
|
|
|
|
(globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
async function act(callback: () => void | Promise<void>) {
|
|
if (typeof reactAct === "function") {
|
|
await reactAct(callback);
|
|
return;
|
|
}
|
|
|
|
let result: void | Promise<void> = undefined;
|
|
flushSync(() => {
|
|
result = callback();
|
|
});
|
|
await result;
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
}
|
|
|
|
vi.mock("@/lib/router", () => ({
|
|
Link: ({ to, children, className }: { to: string; children: ReactNode; className?: string }) => (
|
|
<a href={to} className={className}>{children}</a>
|
|
),
|
|
}));
|
|
|
|
function renderCard(
|
|
props: Partial<ComponentProps<typeof IssueThreadInteractionCard>> = {},
|
|
) {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
root = createRoot(container);
|
|
|
|
act(() => {
|
|
root?.render(
|
|
<TooltipProvider>
|
|
<ThemeProvider>
|
|
<IssueThreadInteractionCard
|
|
interaction={pendingAskUserQuestionsInteraction}
|
|
{...props}
|
|
/>
|
|
</ThemeProvider>
|
|
</TooltipProvider>,
|
|
);
|
|
});
|
|
|
|
return container;
|
|
}
|
|
|
|
afterEach(() => {
|
|
if (root) {
|
|
act(() => root?.unmount());
|
|
}
|
|
container?.remove();
|
|
root = null;
|
|
container = null;
|
|
});
|
|
|
|
describe("IssueThreadInteractionCard", () => {
|
|
it("exposes pending question options as selectable radio and checkbox controls", () => {
|
|
const host = renderCard({
|
|
interaction: pendingAskUserQuestionsInteraction,
|
|
onSubmitInteractionAnswers: vi.fn(),
|
|
});
|
|
|
|
const singleGroup = host.querySelector('[role="radiogroup"]');
|
|
expect(singleGroup?.getAttribute("aria-labelledby")).toBe(
|
|
"interaction-questions-default-collapse-depth-prompt",
|
|
);
|
|
|
|
const radios = [...host.querySelectorAll('[role="radio"]')];
|
|
expect(radios).toHaveLength(2);
|
|
expect(radios[0]?.getAttribute("aria-checked")).toBe("false");
|
|
|
|
act(() => {
|
|
(radios[0] as HTMLButtonElement).click();
|
|
});
|
|
|
|
expect(radios[0]?.getAttribute("aria-checked")).toBe("true");
|
|
expect(radios[1]?.getAttribute("aria-checked")).toBe("false");
|
|
|
|
const multiGroup = host.querySelector('[role="group"]');
|
|
expect(multiGroup?.getAttribute("aria-labelledby")).toBe(
|
|
"interaction-questions-default-post-submit-summary-prompt",
|
|
);
|
|
expect(host.querySelectorAll('[role="checkbox"]')).toHaveLength(3);
|
|
|
|
const otherLink = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent === "Other",
|
|
);
|
|
expect(otherLink?.getAttribute("role")).toBeNull();
|
|
expect(otherLink?.className).toContain("underline");
|
|
});
|
|
|
|
it("submits written Other answers for pending questions", async () => {
|
|
const onSubmitInteractionAnswers = vi.fn(async () => undefined);
|
|
const host = renderCard({
|
|
interaction: pendingAskUserQuestionsInteraction,
|
|
onSubmitInteractionAnswers,
|
|
});
|
|
|
|
const otherButtons = Array.from(host.querySelectorAll("button")).filter((button) =>
|
|
button.textContent?.includes("Other"),
|
|
);
|
|
expect(otherButtons.length).toBeGreaterThan(0);
|
|
|
|
await act(async () => {
|
|
otherButtons[0]?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
const textarea = host.querySelector("textarea") as HTMLTextAreaElement | null;
|
|
expect(textarea).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
const valueSetter = Object.getOwnPropertyDescriptor(
|
|
HTMLTextAreaElement.prototype,
|
|
"value",
|
|
)?.set;
|
|
valueSetter?.call(textarea, "Keep only the root item open");
|
|
textarea!.dispatchEvent(new Event("input", { bubbles: true }));
|
|
});
|
|
|
|
const summaryCheckbox = Array.from(host.querySelectorAll('[role="checkbox"]')).find((button) =>
|
|
button.textContent?.includes("Inline answer pills"),
|
|
);
|
|
await act(async () => {
|
|
summaryCheckbox?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
const submitButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Send answers"),
|
|
);
|
|
await act(async () => {
|
|
submitButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(onSubmitInteractionAnswers).toHaveBeenCalledWith(
|
|
expect.objectContaining({ kind: "ask_user_questions" }),
|
|
[
|
|
{
|
|
questionId: "collapse-depth",
|
|
optionIds: [],
|
|
otherText: "Keep only the root item open",
|
|
},
|
|
{
|
|
questionId: "post-submit-summary",
|
|
optionIds: ["answers-inline"],
|
|
},
|
|
],
|
|
);
|
|
});
|
|
|
|
it("only shows question cancellation when a cancel handler is wired", () => {
|
|
const withoutHandler = renderCard({
|
|
interaction: pendingAskUserQuestionsInteraction,
|
|
onSubmitInteractionAnswers: vi.fn(),
|
|
});
|
|
expect(withoutHandler.textContent).not.toContain("Cancel question");
|
|
|
|
act(() => root?.unmount());
|
|
withoutHandler.remove();
|
|
root = null;
|
|
|
|
const withHandler = renderCard({
|
|
interaction: pendingAskUserQuestionsInteraction,
|
|
onCancelInteraction: vi.fn(),
|
|
onSubmitInteractionAnswers: vi.fn(),
|
|
});
|
|
expect(withHandler.textContent).toContain("Cancel question");
|
|
});
|
|
|
|
it("renders expired question interactions as resolved and non-actionable", () => {
|
|
const host = renderCard({
|
|
interaction: commentExpiredAskUserQuestionsInteraction,
|
|
onSubmitInteractionAnswers: vi.fn(),
|
|
onCancelInteraction: vi.fn(),
|
|
});
|
|
|
|
expect(host.textContent).toContain("Questions expired by comment");
|
|
expect(host.textContent).toContain("A later board/user comment superseded this question request.");
|
|
expect(host.textContent).not.toContain("Send answers");
|
|
expect(host.textContent).not.toContain("Cancel question");
|
|
|
|
const jumpLink = Array.from(host.querySelectorAll("a")).find((link) =>
|
|
link.textContent?.includes("Jump to comment"),
|
|
);
|
|
expect(jumpLink?.getAttribute("href")).toBe(
|
|
"#comment-22222222-2222-4222-8222-222222222222",
|
|
);
|
|
});
|
|
|
|
it("uses singular copy for expired single-question interactions", () => {
|
|
const [question] = commentExpiredAskUserQuestionsInteraction.payload.questions;
|
|
const host = renderCard({
|
|
interaction: {
|
|
...commentExpiredAskUserQuestionsInteraction,
|
|
payload: {
|
|
...commentExpiredAskUserQuestionsInteraction.payload,
|
|
questions: [question],
|
|
},
|
|
},
|
|
});
|
|
|
|
expect(host.textContent).toContain("Question expired by comment");
|
|
expect(host.textContent).not.toContain("Questions expired by comment");
|
|
});
|
|
|
|
it("renders withdrawn confirmations with the withdraw reason", () => {
|
|
const host = renderCard({
|
|
interaction: {
|
|
...pendingRequestConfirmationInteraction,
|
|
status: "cancelled",
|
|
result: { version: 1, outcome: "withdrawn", reason: "Superseded by the hotfix plan." },
|
|
},
|
|
onAcceptInteraction: vi.fn(),
|
|
onRejectInteraction: vi.fn(),
|
|
});
|
|
|
|
expect(host.textContent).toContain("Withdrawn");
|
|
expect(host.textContent).toContain("Superseded by the hotfix plan.");
|
|
expect(host.textContent).not.toContain("Decline");
|
|
});
|
|
|
|
it("renders confirmations expired by issue closure with dedicated copy", () => {
|
|
const host = renderCard({
|
|
interaction: {
|
|
...pendingRequestConfirmationInteraction,
|
|
status: "expired",
|
|
result: { version: 1, outcome: "issue_closed", reason: null },
|
|
},
|
|
});
|
|
|
|
expect(host.textContent).toContain("Expired when issue closed");
|
|
expect(host.textContent).toContain("The issue was closed before this confirmation was resolved.");
|
|
expect(host.textContent).not.toContain("Expired by target change");
|
|
});
|
|
|
|
it("renders withdrawn question interactions with the withdraw reason", () => {
|
|
const host = renderCard({
|
|
interaction: {
|
|
...pendingAskUserQuestionsInteraction,
|
|
status: "cancelled",
|
|
result: {
|
|
version: 1,
|
|
outcome: "withdrawn",
|
|
reason: "Scope was decided on the parent issue.",
|
|
answers: [],
|
|
summaryMarkdown: null,
|
|
},
|
|
},
|
|
});
|
|
|
|
expect(host.textContent).toContain("Questions withdrawn");
|
|
expect(host.textContent).toContain("Scope was decided on the parent issue.");
|
|
expect(host.textContent).not.toContain("Question cancelled");
|
|
});
|
|
|
|
it("renders question interactions expired by issue closure with dedicated copy", () => {
|
|
const host = renderCard({
|
|
interaction: {
|
|
...pendingAskUserQuestionsInteraction,
|
|
status: "expired",
|
|
result: {
|
|
version: 1,
|
|
outcome: "issue_closed",
|
|
reason: null,
|
|
answers: [],
|
|
summaryMarkdown: null,
|
|
},
|
|
},
|
|
});
|
|
|
|
expect(host.textContent).toContain("Questions expired when issue closed");
|
|
expect(host.textContent).toContain("The issue was closed before these questions were answered.");
|
|
expect(host.textContent).not.toContain("expired by comment");
|
|
});
|
|
|
|
it("makes child tasks explicit in suggested task trees", () => {
|
|
const host = renderCard({
|
|
interaction: pendingSuggestedTasksInteraction,
|
|
});
|
|
|
|
expect(host.textContent).toContain("Child task");
|
|
});
|
|
|
|
it("shows an explicit placeholder when a rejected interaction has no reason", () => {
|
|
const host = renderCard({
|
|
interaction: {
|
|
...rejectedSuggestedTasksInteraction,
|
|
result: { version: 1 },
|
|
},
|
|
});
|
|
|
|
expect(host.textContent).toContain("No reason provided.");
|
|
});
|
|
|
|
it("requires a decline reason when the request confirmation payload asks for one", async () => {
|
|
const onRejectInteraction = vi.fn(async () => undefined);
|
|
const host = renderCard({
|
|
interaction: pendingRequestConfirmationInteraction,
|
|
onRejectInteraction,
|
|
});
|
|
|
|
const declineButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Request revisions"),
|
|
);
|
|
expect(declineButton).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
declineButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
const saveButton = Array.from(host.querySelectorAll("button")).filter((button) =>
|
|
button.textContent?.includes("Request revisions"),
|
|
).at(-1);
|
|
expect(saveButton?.hasAttribute("disabled")).toBe(false);
|
|
|
|
await act(async () => {
|
|
saveButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(host.textContent).toContain("A decline reason is required.");
|
|
|
|
const textarea = host.querySelector("textarea") as HTMLTextAreaElement | null;
|
|
expect(textarea).toBeTruthy();
|
|
expect(textarea?.getAttribute("aria-invalid")).toBe("true");
|
|
|
|
await act(async () => {
|
|
const valueSetter = Object.getOwnPropertyDescriptor(
|
|
HTMLTextAreaElement.prototype,
|
|
"value",
|
|
)?.set;
|
|
valueSetter?.call(textarea, "Needs a smaller phase split");
|
|
textarea!.dispatchEvent(new Event("input", { bubbles: true }));
|
|
});
|
|
const enabledSaveButton = Array.from(host.querySelectorAll("button")).filter((button) =>
|
|
button.textContent?.includes("Request revisions"),
|
|
).at(-1);
|
|
expect(enabledSaveButton?.hasAttribute("disabled")).toBe(false);
|
|
await act(async () => {
|
|
enabledSaveButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(onRejectInteraction).toHaveBeenCalledWith(
|
|
expect.objectContaining({ kind: "request_confirmation" }),
|
|
"Needs a smaller phase split",
|
|
);
|
|
});
|
|
|
|
it("invokes the confirm callback with pending request confirmations", async () => {
|
|
const onAcceptInteraction = vi.fn(async () => undefined);
|
|
const host = renderCard({
|
|
interaction: pendingRequestConfirmationInteraction,
|
|
onAcceptInteraction,
|
|
});
|
|
|
|
const confirmButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Approve plan"),
|
|
);
|
|
expect(confirmButton).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
confirmButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(onAcceptInteraction).toHaveBeenCalledWith(
|
|
expect.objectContaining({ kind: "request_confirmation" }),
|
|
);
|
|
});
|
|
|
|
it("does not expose continuation wake policy labels in the card header", () => {
|
|
const host = renderCard({
|
|
interaction: {
|
|
...pendingRequestConfirmationInteraction,
|
|
continuationPolicy: "wake_assignee_on_accept",
|
|
},
|
|
});
|
|
|
|
expect(host.textContent).not.toContain("Wakes on confirm");
|
|
expect(host.textContent).not.toContain("Wakes assignee");
|
|
});
|
|
|
|
it("renders request confirmation target links and stale-target expiry", () => {
|
|
const host = renderCard({
|
|
interaction: staleTargetRequestConfirmationInteraction,
|
|
});
|
|
|
|
const targetLinks = host.querySelectorAll("a");
|
|
expect(host.textContent).toContain("Expired by target change");
|
|
expect(host.textContent).toContain("Plan v3");
|
|
expect(host.textContent).toContain("Plan v4");
|
|
expect(targetLinks[0]?.getAttribute("href")).toContain("#document-plan");
|
|
expect(targetLinks[1]?.getAttribute("href")).toContain("#document-plan");
|
|
expect(host.textContent).not.toContain("Approve plan");
|
|
});
|
|
|
|
it("renders a jump link for confirmations expired by comment", () => {
|
|
const host = renderCard({
|
|
interaction: commentExpiredRequestConfirmationInteraction,
|
|
});
|
|
|
|
const jumpLink = Array.from(host.querySelectorAll("a")).find((link) =>
|
|
link.textContent?.includes("Jump to comment"),
|
|
);
|
|
|
|
expect(jumpLink?.getAttribute("href")).toBe(
|
|
"#comment-22222222-2222-4222-8222-222222222222",
|
|
);
|
|
});
|
|
|
|
it("declines immediately when decline reasons are disabled", async () => {
|
|
const onRejectInteraction = vi.fn(async () => undefined);
|
|
const host = renderCard({
|
|
interaction: disabledDeclineReasonRequestConfirmationInteraction,
|
|
onRejectInteraction,
|
|
});
|
|
|
|
const declineButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Keep it"),
|
|
);
|
|
expect(declineButton).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
declineButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(host.querySelector("textarea")).toBeNull();
|
|
expect(onRejectInteraction).toHaveBeenCalledWith(
|
|
expect.objectContaining({ kind: "request_confirmation" }),
|
|
undefined,
|
|
);
|
|
});
|
|
|
|
it("renders explicit copy for failed request confirmations", () => {
|
|
const host = renderCard({
|
|
interaction: failedRequestConfirmationInteraction,
|
|
});
|
|
|
|
expect(host.textContent).toContain(
|
|
"This request could not be resolved. Try again or create a new request.",
|
|
);
|
|
});
|
|
|
|
it("renders a plan confirmation as a distinct state-coloured plan card", () => {
|
|
const pending = renderCard({ interaction: pendingRequestConfirmationInteraction });
|
|
const pendingShell = pending.firstElementChild as HTMLElement;
|
|
expect(pendingShell.className).toContain("border-violet-500/80");
|
|
expect(pendingShell.className).not.toContain("border-l-");
|
|
expect(pending.textContent).toContain("Plan");
|
|
expect(pending.textContent).toContain("In review");
|
|
// Approve is a neutral CTA (foreground/background), not the blue primary.
|
|
const approve = Array.from(pending.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Approve plan"),
|
|
);
|
|
expect(approve?.className).toContain("bg-foreground");
|
|
expect(approve?.className).not.toContain("bg-primary");
|
|
|
|
act(() => root?.unmount());
|
|
pending.remove();
|
|
root = null;
|
|
|
|
const accepted = renderCard({
|
|
interaction: { ...pendingRequestConfirmationInteraction, status: "accepted" },
|
|
});
|
|
expect((accepted.firstElementChild as HTMLElement).className).toContain("border-green-500/80");
|
|
expect(accepted.textContent).toContain("Approved");
|
|
|
|
act(() => root?.unmount());
|
|
accepted.remove();
|
|
root = null;
|
|
|
|
const resumeFailed = renderCard({
|
|
interaction: planApprovalResumeFailedRequestConfirmationInteraction,
|
|
});
|
|
expect((resumeFailed.firstElementChild as HTMLElement).className).toContain("border-amber-500/70");
|
|
expect(resumeFailed.textContent).toContain("Approved — agent resume failed");
|
|
expect(resumeFailed.textContent).toContain("Agent resume failed");
|
|
expect(resumeFailed.textContent).toContain("Paperclip needs attention before the agent can resume this approved work.");
|
|
expect(resumeFailed.textContent).toContain("adapter_failed");
|
|
|
|
act(() => root?.unmount());
|
|
resumeFailed.remove();
|
|
root = null;
|
|
|
|
const rejected = renderCard({
|
|
interaction: {
|
|
...pendingRequestConfirmationInteraction,
|
|
status: "rejected",
|
|
result: { version: 1, outcome: "rejected", reason: "Tighten the spacing" },
|
|
},
|
|
});
|
|
expect((rejected.firstElementChild as HTMLElement).className).toContain("border-red-500/80");
|
|
expect(rejected.textContent).toContain("Changes requested");
|
|
});
|
|
|
|
it("attaches screenshots to a plan request-changes reason as markdown images", async () => {
|
|
const onRejectInteraction = vi.fn(async () => undefined);
|
|
const onUploadImage = vi.fn(async () => "https://cdn.example/shot.png");
|
|
const host = renderCard({
|
|
interaction: {
|
|
...pendingRequestConfirmationInteraction,
|
|
payload: {
|
|
...pendingRequestConfirmationInteraction.payload,
|
|
rejectRequiresReason: false,
|
|
},
|
|
},
|
|
onRejectInteraction,
|
|
onUploadImage,
|
|
});
|
|
|
|
const declineButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Request revisions"),
|
|
);
|
|
await act(async () => {
|
|
declineButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
const attachButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Attach screenshots"),
|
|
);
|
|
expect(attachButton).toBeTruthy();
|
|
|
|
const fileInput = host.querySelector('input[type="file"]') as HTMLInputElement | null;
|
|
expect(fileInput).toBeTruthy();
|
|
const file = new File(["x"], "bug.png", { type: "image/png" });
|
|
Object.defineProperty(fileInput!, "files", { value: [file], configurable: true });
|
|
Object.defineProperty(fileInput!, "value", {
|
|
value: "C:/fake/bug.png",
|
|
writable: true,
|
|
configurable: true,
|
|
});
|
|
|
|
await act(async () => {
|
|
fileInput!.dispatchEvent(new Event("change", { bubbles: true }));
|
|
});
|
|
expect(onUploadImage).toHaveBeenCalledTimes(1);
|
|
|
|
const saveButton = Array.from(host.querySelectorAll("button")).filter((button) =>
|
|
button.textContent?.includes("Request revisions"),
|
|
).at(-1);
|
|
await act(async () => {
|
|
saveButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(onRejectInteraction).toHaveBeenCalledWith(
|
|
expect.objectContaining({ kind: "request_confirmation" }),
|
|
"",
|
|
);
|
|
});
|
|
|
|
it("submits an approve verdict once a draft is marked and applied", async () => {
|
|
const onSubmitInteractionVerdicts = vi.fn(async () => undefined);
|
|
const host = renderCard({
|
|
interaction: pendingRequestItemVerdictsInteraction,
|
|
onSubmitInteractionVerdicts,
|
|
});
|
|
|
|
const firstItemId = pendingRequestItemVerdictsInteraction.payload.items[0]!.id;
|
|
const approveButton = Array.from(
|
|
host.querySelectorAll<HTMLButtonElement>(`[data-item-id="${firstItemId}"] button[data-verdict="approve"]`),
|
|
)[0];
|
|
expect(approveButton).toBeTruthy();
|
|
// 44px minimum target (a11y).
|
|
expect(approveButton?.className).toContain("min-h-11");
|
|
|
|
await act(async () => {
|
|
approveButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
const applyButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Apply 1 decision"),
|
|
);
|
|
expect(applyButton).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
applyButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(onSubmitInteractionVerdicts).toHaveBeenCalledWith(
|
|
expect.objectContaining({ kind: "request_item_verdicts" }),
|
|
[{ id: firstItemId, verdict: "approve", reason: undefined }],
|
|
);
|
|
});
|
|
|
|
it("blocks apply for a rejected item until a reason is entered", async () => {
|
|
const onSubmitInteractionVerdicts = vi.fn(async () => undefined);
|
|
const host = renderCard({
|
|
interaction: pendingRequestItemVerdictsInteraction,
|
|
onSubmitInteractionVerdicts,
|
|
});
|
|
|
|
const firstItemId = pendingRequestItemVerdictsInteraction.payload.items[0]!.id;
|
|
const rejectButton = Array.from(
|
|
host.querySelectorAll<HTMLButtonElement>(`[data-item-id="${firstItemId}"] button[data-verdict="reject"]`),
|
|
)[0];
|
|
await act(async () => {
|
|
rejectButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
// Reject reveals a required reason field.
|
|
const reasonField = host.querySelector<HTMLTextAreaElement>(
|
|
`textarea[id="${pendingRequestItemVerdictsInteraction.id}-${firstItemId}-reason"]`,
|
|
);
|
|
expect(reasonField).toBeTruthy();
|
|
|
|
const applyButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Apply 1 decision"),
|
|
);
|
|
// Attempting to apply without a reason does not submit.
|
|
await act(async () => {
|
|
applyButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
expect(onSubmitInteractionVerdicts).not.toHaveBeenCalled();
|
|
expect(host.textContent).toContain("A reason is required to reject this item.");
|
|
});
|
|
|
|
it("renders resolved verdicts as terminal chips with reason echo", () => {
|
|
const host = renderCard({ interaction: completeRequestItemVerdictsInteraction });
|
|
expect(host.textContent).toContain("Approved");
|
|
expect(host.textContent).toContain("Rejected");
|
|
expect(host.textContent).toContain("Tone is off-brand");
|
|
// S5 summary chip.
|
|
expect(host.textContent).toContain("3 approved");
|
|
// No actionable verdict buttons once terminal.
|
|
expect(host.querySelector("button[data-verdict]")).toBeNull();
|
|
});
|
|
|
|
it("shows an already-applied, cannot-revert notice when superseded", () => {
|
|
const host = renderCard({ interaction: supersededRequestItemVerdictsInteraction });
|
|
expect(host.textContent).toContain("expired after a later comment");
|
|
expect(host.textContent).toContain("cannot be");
|
|
expect(host.textContent?.toLowerCase()).toContain("revert");
|
|
});
|
|
});
|
|
|
|
describe("IssueThreadInteractionCard tool-action card", () => {
|
|
it("selects the pending state with the Approve & run affordance and identity header", () => {
|
|
const host = renderCard({
|
|
interaction: pendingToolActionWriteInteraction,
|
|
onAcceptInteraction: vi.fn(),
|
|
onRejectInteraction: vi.fn(),
|
|
});
|
|
|
|
// Pending eyebrow, never a bare "Accepted".
|
|
expect(host.textContent).toContain("Awaiting approval");
|
|
// Identity header: tool display name + WRITE risk badge + app/tool sub-line.
|
|
expect(host.textContent).toContain("Append row to spreadsheet");
|
|
expect(host.textContent).toContain("WRITE");
|
|
expect(host.textContent).toContain("Google Sheets");
|
|
// Primary CTA is "Approve & run" (approve = run), plus the hint + countdown.
|
|
const approve = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Approve & run"),
|
|
);
|
|
expect(approve).toBeTruthy();
|
|
expect(host.textContent).toContain("Approving runs this action now.");
|
|
expect(host.textContent).toContain("Approval expires in");
|
|
// Technical details drawer is present but collapsed by default (hash hidden).
|
|
expect(host.textContent).toContain("Technical details");
|
|
expect(host.textContent).not.toContain("args hash");
|
|
});
|
|
|
|
it("uses the destructive risk badge and a destructive primary button", () => {
|
|
const host = renderCard({
|
|
interaction: pendingToolActionDestructiveInteraction,
|
|
onAcceptInteraction: vi.fn(),
|
|
onRejectInteraction: vi.fn(),
|
|
});
|
|
|
|
expect(host.textContent).toContain("DESTRUCTIVE");
|
|
const approve = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Approve & run"),
|
|
);
|
|
expect(approve?.getAttribute("data-variant")).toBe("destructive");
|
|
});
|
|
|
|
it("reveals redacted args and the hash when the technical drawer is opened", () => {
|
|
const host = renderCard({
|
|
interaction: pendingToolActionWriteInteraction,
|
|
onAcceptInteraction: vi.fn(),
|
|
onRejectInteraction: vi.fn(),
|
|
});
|
|
|
|
const trigger = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Technical details"),
|
|
);
|
|
act(() => {
|
|
(trigger as HTMLButtonElement).click();
|
|
});
|
|
|
|
expect(host.textContent).toContain("args hash");
|
|
expect(host.textContent).toContain("sha256:9f2c1a7be4d0c8a3");
|
|
// Redacted arguments render verbatim, never raw secrets.
|
|
expect(host.textContent).toContain("[redacted]");
|
|
});
|
|
|
|
it("renders the approved-running state with a spinner and no action buttons", () => {
|
|
const host = renderCard({ interaction: runningToolActionInteraction });
|
|
|
|
expect(host.textContent).toContain("Running…");
|
|
expect(host.textContent).toContain("running the action now");
|
|
expect(host.textContent).not.toContain("Approve & run");
|
|
expect(host.querySelector(".animate-spin")).toBeTruthy();
|
|
});
|
|
|
|
it("renders the executed state with a result summary and never reads Accepted", () => {
|
|
const host = renderCard({ interaction: executedToolActionInteraction });
|
|
|
|
expect(host.textContent).toContain("Executed");
|
|
expect(host.textContent).toContain("Row 42 added");
|
|
expect(host.textContent).not.toContain("Accepted");
|
|
const link = Array.from(host.querySelectorAll("a")).find((a) =>
|
|
a.textContent?.includes("View result"),
|
|
);
|
|
expect(link?.getAttribute("href")).toContain("docs.google.com");
|
|
});
|
|
|
|
it("distinguishes failed (ran + connector error) from declined (did not run)", () => {
|
|
const failed = renderCard({ interaction: failedToolActionInteraction });
|
|
expect(failed.textContent).toContain("Failed");
|
|
expect(failed.textContent).toContain("insufficient_permission");
|
|
expect(failed.textContent).toContain("but the connector returned an error");
|
|
|
|
act(() => root?.unmount());
|
|
failed.remove();
|
|
root = null;
|
|
|
|
const declined = renderCard({ interaction: declinedToolActionInteraction });
|
|
expect(declined.textContent).toContain("Declined");
|
|
expect(declined.textContent).toContain("did");
|
|
expect(declined.textContent).toContain("not");
|
|
expect(declined.textContent).toContain("run");
|
|
expect(declined.textContent).toContain("use the CRM sync instead");
|
|
expect(declined.textContent).not.toContain("Approve & run");
|
|
});
|
|
|
|
it("renders the expired state with the 60-minute rule and a recovery path", () => {
|
|
const host = renderCard({ interaction: expiredToolActionInteraction });
|
|
|
|
expect(host.textContent).toContain("Expired");
|
|
expect(host.textContent).toContain("no one responded within 60 minutes");
|
|
expect(host.textContent).toContain("the agent can request approval again");
|
|
expect(host.textContent).not.toContain("Approve & run");
|
|
});
|
|
|
|
it("keeps the generic confirmation rendering for cards without a toolAction", () => {
|
|
const host = renderCard({
|
|
interaction: pendingRequestConfirmationInteraction,
|
|
onAcceptInteraction: vi.fn(),
|
|
onRejectInteraction: vi.fn(),
|
|
});
|
|
|
|
// Legacy confirmation keeps its own prompt + labels, no tool-action surface.
|
|
expect(host.textContent).toContain("Approve the plan and let the responsible start implementation?");
|
|
expect(host.textContent).not.toContain("Approve & run");
|
|
expect(host.textContent).not.toContain("Technical details");
|
|
});
|
|
});
|