mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-02 16:58:52 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Agents use installed skills and exact version pins during execution. > - Managed skills still depended on mutable directories on the web server. > - A replacement server could lose acknowledged edits or remove an unassigned skill whose directory was absent. > - This pull request makes immutable versions the authority for managed content and installed repository reads. > - The server can rebuild delivery files from durable content after replacement. > - This establishes skills readiness for ephemeral web servers. General server draining and workspace recovery remain separate work. ## Linked Issues or Issue Description **Subsystem affected** Skills services, shared contracts, database receipts, Skill Studio, and runtime delivery. **Problem or motivation** A fresh web server must discover, read, edit, and deliver protected installed skills using the same database, object storage, secrets, and supported application artifacts. It must not need its predecessor's files or process memory. **Proposed solution** Use `managed` ownership with a null source locator. Read installed content by immutable version. Prepare packages before a short publication transaction. Persist execution selections before materialization. Recover exact pinned runtime assets and reject deletion while active or recovering pins exist. **Alternatives considered** Reconstructing a mutable installed directory preserves the old source-of-truth ambiguity. Permanent dual writes create two competing authorities. This change uses one managed model after a bounded legacy conversion. **Roadmap alignment** This improves the existing Skills Manager, Studio, version history, and Cloud execution capabilities. The maintainer supplied the implementation contract. This does not add a separate skills product or deploy fleet changes. Related work: #18082 supplies immutable package storage. #17273 addresses edits outside the API for linked local skills; this PR keeps that source category separate. #2648 is a closed earlier ephemeral-filesystem proposal. ## What Changed - Add managed ownership and focused content publication and execution materialization modules. Keep the archive format and package storage tables. - Publish managed create, save, delete, fork, rename, restore, and catalog content with version checks. Add durable create receipts. Preserve file-save receipt responses. - Return file version identities. Keep Studio drafts after a conflict and provide an explicit reload action. A delayed reload cannot overwrite newer typing or navigation. - Persist exact runtime selections, including empty selections. Rebuild pinned assets and verify their admitted digests on a replacement server. - Preserve source access on forks and disconnected copies. Keep the existing workspace policy category for managed skills. - Add bounded conversion, eligibility, and independent verification phases. Load persisted Cloud configuration in the standalone CLI without seeding or changing it. Reject partial current versions against installed inventories; recover only complete saved content or the exact source. Document storage migration blockers and the compatible rollback floor. - Add separate-process PostgreSQL/S3 qualification and update domain, retention, policy, and UI regressions. - Pass the plugin worker manager into Studio execution, admit restricted `skill_test` mode through native Runner contracts, and preserve admitted scope across native and REST tools. Native tests cannot create ordinary tasks, browse company data, or use external tools. - Select the exact durable Studio revision even when unassigned or Beta skills is off. Persist Studio output and audit atomically with native task completion, preserving the result on replay. ## Verification - Final revision `13e8af480b88ba6fea5737bac4bd81104d604792` passed full CI: all 49 workflow jobs completed successfully ([run 41127396098](https://github.com/paperclipai/paperclip/actions/runs/41127396098)). This includes typecheck, test suites, Runner checks, browser checks and build. Greptile review 15 is 5/5 on that same revision, with zero unresolved threads. The PR is ready for review. - Local workspace typecheck and build passed after integrating master. Focused checks passed: 33 execution/completion cases, 52 Runner HTTP cases, 16 managed-content cases, 17 Studio cases, the new real-process CLI regression, map checks and UI token gates. The CLI regression proves inspection does not seed missing Cloud configuration. Server typecheck passed after that fix. - The independent-process PostgreSQL/S3 matrix passed through normal HTTP skill routes. It covers A → B → C replacement, lost commit responses, upload crashes, concurrent saves, binary contents and executable delivery. Metadata listing and warm selected delivery retain zero object downloads. Local timing measurements are recorded; they do not establish hosted latency. - Hosted A → B → C passed on the owned disposable test tenant with external Postgres, S3 and a real remote Paperclip Computer. Predecessor temporary homes were absent. C read and executed B's acknowledged managed save. New runs used repository v1 while v2 was installed. Hashes matched an independently checked exact upstream commit. - Compatible image rollback to `6518b323` passed. Studio retained the unassigned fork's C save. A fresh remote run executed the newer managed content and historical repository pin. The actual shell event confirmed expected hashes, stdout, exit 0 and mode 0555. - Runtime candidate `9200e3fcb4` deployed successfully ([Cloud run 41124147876](https://github.com/paperclipai/paperclip-cloud/actions/runs/41124147876)). The final Studio test delivered only the unassigned fork's exact v3, executed its script and persisted a successful output snapshot. Independent command-event inspection confirmed all three hashes, stdout, exit 0 and mode 0555. All 14 installations were version-backed. Independent verification checked all 25 versions: 23 remote objects, two bundled database snapshots, zero blockers. - The deployed image is `9200e3fcb4`. Later master integration, the client-only delayed-reload draft guard and the CLI bootstrap have separate automated proof. The CLI bootstrap was also exercised against the tenant's stored configuration and storage through the same read-only services. This PR does not claim that the deployed image is the final PR revision. - Live Studio checks exposed worker wiring, admission, access scope, exact selection and completion-publication gaps. They are fixed. Failed attempts remain in the evidence. The full local suite exceeded 80 minutes under host contention and was stopped. Later combined/isolated local attempts also timed out; they are not counted as passes. Full CI covers the integrated suites. Earlier CI found an obsolete restart-scope fixture, which was corrected and passed all 52 HTTP cases. - Reproduction and migration: [`doc/skill-ephemeral-web-servers.md`](doc/skill-ephemeral-web-servers.md). Source revisions, deployments, versions, run IDs, hashes and failure history: [`doc/plans/2026-10-30-ephemeral-web-skills.md`](doc/plans/2026-10-30-ephemeral-web-skills.md). ## Risks - Legacy conversion requires stopped admission and retired filesystem-authoritative writers. Pre-conversion binaries are not supported rollback targets afterward. - Cloud readiness requires remote object storage. Local provider receipts and provider mismatches remain blockers until objects are copied and verified. - Linked local sources retain filesystem semantics and are outside the cloud guarantee. - Cold reads still fetch the existing archive format. Warm runtime preparation retains the verified-cache path. - Bundled reconciliation preserves an installed head. Existing release snapshots remain selectable. An older server must not replace a newer head with its shipped files. - No production volumes, fleet defaults, or general deployment coordination change in this PR. ## Model Used OpenAI Codex, GPT-6 family, with reasoning, repository tools, code execution, and browser use. The exact backend model ID and context-window size are not exposed in this session. No subagents were used. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
397 lines
26 KiB
TypeScript
397 lines
26 KiB
TypeScript
import { agentHarnessType } from "@paperclipai/shared";
|
||
import { observabilitySecretValues } from "@paperclipai/adapter-utils/agent-observability";
|
||
import { agentObservabilityService, unavailableAgentObservability, type ResolvedAgentObservability } from "../agent-observability.js";
|
||
import { agentObservabilityLaunch } from "../agent-observability-launch.js";
|
||
import { withSkillActor } from "../skill-access.js";
|
||
import type { AuthorizationActor } from "../authorization.js";
|
||
import { eq, sql } from "drizzle-orm";
|
||
import { heartbeatRuns, type Db, type agents, type projects } from "@paperclipai/db";
|
||
import type { AiConnectionBinding } from "@paperclipai/shared";
|
||
import { readPaperclipSkillSyncPreference, resolvePaperclipDesiredSkillNames, resolveLegacyPaperclipDesiredSkillNames,
|
||
writePaperclipSkillSyncPreference } from "@paperclipai/adapter-utils/server-utils";
|
||
import { parseObject } from "../../adapters/utils.js";
|
||
import { logger } from "../../middleware/logger.js";
|
||
import { AI_CONNECTION_BUSY_RETRY_REASON, extractWakeCommentIds, isNonAssigneeWorkspaceBusyRetry } from "../../modules/run-dispatch/index.js";
|
||
import { createAgentIdentityRedactor } from "../agent-identity-redaction.js";
|
||
import { agentIdentityService, supportsManagedAgentIdentity } from "../agent-identity.js";
|
||
import { readAiConnectionConfigurationFailure, readAiCredentialAccessFailure } from "../ai-connection-configuration-failure.js";
|
||
import { AI_AUTH_ENV_KEYS, isAiConnectionBusy, prepareManagedAiRuntime, stripAiAuthBindings } from "../ai-connection-runtime.js";
|
||
import { managedAiSessionIdentityCompatible } from "../ai-connection-session.js";
|
||
import type { companySkillService } from "../company-skills.js";
|
||
import { connectionIntentService } from "../connection-intents.js";
|
||
import { prepareConnectionInstructionDelivery } from "../connection-instructions.js";
|
||
import { applyConnectorSkills, prepareConnectorSkillDelivery, resolveConnectorAssignments } from "../connector-runtime.js";
|
||
import { resolveManagedGitHubIdentitySelection } from "../git-credentials.js";
|
||
import { resolveAssignedConnectionInstructionsForRun } from "../native-runtime/assigned-mcp-tools.js";
|
||
import { recordFailedSkillPreparation, type NativeRunHistoricalSpan } from "../native-runtime/native-run-trace.js";
|
||
import { collectRunFailureSecretValues } from "../run-failure-diagnostics.js";
|
||
import { skillVersionSelectionMap } from "../runtime-skill-selections.js";
|
||
import { environmentSkillConfig } from "../environment-skills.js";
|
||
import type { selectHeartbeatEnvironment } from "./environment-selection.js";
|
||
import type { createHeartbeatRetries } from "./retries.js";
|
||
import type { createHeartbeatLifecycle } from "./run-lifecycle.js";
|
||
import { createHeartbeatPreparationTiming } from "./preparation-timing.js";
|
||
import {
|
||
ConfigurationIncompleteFailure, applyRunScopedMentionedSkillKeys, resolveExecutionRunAdapterConfig,
|
||
resolveRunScopedMentionedSkillKeys, type createHeartbeatRunPreparation, type resolveAcceptedPlanWakeRoutingDecision,
|
||
} from "./run-preparation.js";
|
||
import { buildExecutionWorkspaceConfigSnapshot, stripWorkspaceRuntimeFromExecutionRunConfig } from "./workspaces.js";
|
||
import type { HeartbeatWorkspacePreparationInput } from "./workspace-preparation.js";
|
||
|
||
const ACCEPTED_PLAN_CONVERSION_SKILL_KEY =
|
||
"paperclipai/paperclip/paperclip-converting-plans-to-tasks";
|
||
|
||
type ManagedAiRuntime = Awaited<ReturnType<typeof prepareManagedAiRuntime>>;
|
||
type EnvironmentSelection = Awaited<ReturnType<typeof selectHeartbeatEnvironment>>;
|
||
|
||
/** Preparation and routing must use the same immutable mode as native recovery. */
|
||
export function bindHeartbeatRunnerHomeMode(config: Record<string, unknown>, persistedExecution: unknown): Record<string, unknown> {
|
||
const saved = parseObject(persistedExecution);
|
||
if (Object.keys(saved).length === 0) return config;
|
||
// Execution schemas before v7 always used isolated homes.
|
||
return { ...config, homeMode: saved.homeMode ?? "isolated" };
|
||
}
|
||
|
||
export interface HeartbeatExecutionConfigurationInput {
|
||
run: typeof heartbeatRuns.$inferSelect;
|
||
agent: typeof agents.$inferSelect;
|
||
task: {
|
||
issueId: string | null;
|
||
context: Record<string, unknown>;
|
||
responsibleUserId: string | null;
|
||
acceptedPlanContinuationWake: boolean;
|
||
acceptedPlanWakeRoutingDecision: Awaited<ReturnType<typeof resolveAcceptedPlanWakeRoutingDecision>> | null;
|
||
taskProjectContext: Pick<typeof projects.$inferSelect, "id" | "env"> | null;
|
||
routineEnvContext: Awaited<ReturnType<ReturnType<typeof createHeartbeatRunPreparation>["getRoutineEnvForExecutionIssue"]>>;
|
||
/** Resolved from the durable Studio test row by task-context, never wake input. */
|
||
pinnedSkillTest?: { key: string; versionId: string } | null;
|
||
};
|
||
config: {
|
||
sourceWorkspaceConfig: Record<string, unknown>;
|
||
aiBinding: AiConnectionBinding | undefined;
|
||
};
|
||
policy: Pick<HeartbeatWorkspacePreparationInput["policy"],
|
||
"trustPreset" | "useIsolatedTaskDirectory" | "requestedExecutionWorkspaceMode"> & { explicitTaskDirectory: boolean };
|
||
environment: Pick<EnvironmentSelection,
|
||
"selectedEnvironmentId" | "selectedEnvironmentForConfig" | "resolvedInstanceSettings" | "persistedNativeExecutionInput">;
|
||
services: {
|
||
secretsSvc: Parameters<typeof resolveExecutionRunAdapterConfig>[0]["secretsSvc"];
|
||
companySkills: Pick<ReturnType<typeof companySkillService>, "withRuntimeSkillEntries">;
|
||
appendRunEvent: ReturnType<typeof createHeartbeatLifecycle>["appendRunEvent"];
|
||
finalizeAiConnectionBusyDeferral: ReturnType<typeof createHeartbeatRetries>["finalizeAiConnectionBusyDeferral"];
|
||
};
|
||
// The executor must observe these before a later preparation step can throw.
|
||
onFailureSecretsResolved: (readSecrets: () => string[]) => void;
|
||
onManagedAiRuntimeAcquired: (runtime: ManagedAiRuntime) => void;
|
||
onIdentityRedactorPrepared: (redactor: ReturnType<typeof createAgentIdentityRedactor>) => void;
|
||
}
|
||
|
||
/** Assembles effective run configuration; the executor retains cleanup ownership. */
|
||
export async function prepareHeartbeatExecutionConfiguration(db: Db, input: HeartbeatExecutionConfigurationInput) {
|
||
const { run, agent, onFailureSecretsResolved, onManagedAiRuntimeAcquired, onIdentityRedactorPrepared } = input;
|
||
const time = createHeartbeatPreparationTiming(run.id);
|
||
const { issueId, context, responsibleUserId, acceptedPlanContinuationWake, acceptedPlanWakeRoutingDecision, taskProjectContext, routineEnvContext, pinnedSkillTest } = input.task;
|
||
const { selectedEnvironmentId, selectedEnvironmentForConfig, resolvedInstanceSettings, persistedNativeExecutionInput } = input.environment;
|
||
const sourceWorkspaceConfig = agent.adapterType === "paperclip_runner"
|
||
? { ...input.config.sourceWorkspaceConfig,
|
||
homeMode: bindHeartbeatRunnerHomeMode(parseObject(agent.adapterConfig), persistedNativeExecutionInput).homeMode }
|
||
: input.config.sourceWorkspaceConfig;
|
||
const preconfiguredHome = agent.adapterType === "paperclip_runner" && sourceWorkspaceConfig.homeMode === "preconfigured";
|
||
if (preconfiguredHome && pinnedSkillTest) {
|
||
throw new ConfigurationIncompleteFailure("Skill tests require an isolated Runner home to deliver the saved version.", {
|
||
configurationIncomplete: { reason: "skill_unavailable", actionUrl: `/agents/${agent.id}/runtime` },
|
||
});
|
||
}
|
||
const initialHarness = agentHarnessType(agent.adapterType, sourceWorkspaceConfig);
|
||
const observabilityKind = (harness: string) => harness === "codex_local" ? "codex" as const
|
||
: harness === "claude_local" ? "claude" as const
|
||
: harness === "opencode_local" && agent.adapterType === "paperclip_runner" ? "opencode" as const : undefined;
|
||
const unsupportedObservability = !observabilityKind(initialHarness)
|
||
? "unsupported_harness" as const : preconfiguredHome && initialHarness === "codex_local" ? "unsupported_home_mode" as const : undefined;
|
||
const observabilitySnapshot: ResolvedAgentObservability = await agentObservabilityService(db).resolve(agent.companyId, { runId: run.id, agentId: agent.id, responsibleUserId, issueId, unavailableReason: unsupportedObservability })
|
||
.catch(() => unavailableAgentObservability(agent.companyId, "configuration_invalid"));
|
||
const identityRedactor = createAgentIdentityRedactor();
|
||
const earlyObservability = unsupportedObservability === undefined && observabilityKind(initialHarness)
|
||
? agentObservabilityLaunch(observabilitySnapshot, { kind: observabilityKind(initialHarness)!, companyId: agent.companyId, agentId: agent.id }) : undefined;
|
||
identityRedactor.values.push(...observabilitySecretValues(earlyObservability));
|
||
onIdentityRedactorPrepared(identityRedactor);
|
||
// The executor keeps these values in its failure redactor before any later
|
||
// preparation step can fail. Subsequent provider/identity values extend it.
|
||
onFailureSecretsResolved(() => []);
|
||
const aiBinding = preconfiguredHome ? undefined : input.config.aiBinding;
|
||
const { trustPreset, useIsolatedTaskDirectory, explicitTaskDirectory, requestedExecutionWorkspaceMode } = input.policy;
|
||
const { secretsSvc, companySkills, appendRunEvent, finalizeAiConnectionBusyDeferral } = input.services;
|
||
let managedAiRuntime: ManagedAiRuntime | undefined;
|
||
const forceDirectoryStrategy = useIsolatedTaskDirectory || (explicitTaskDirectory && (
|
||
requestedExecutionWorkspaceMode === "agent_default" || Object.keys(parseObject(sourceWorkspaceConfig.workspaceStrategy)).length > 0
|
||
));
|
||
const mergedConfig = {
|
||
...sourceWorkspaceConfig,
|
||
// The base below is already task-owned. Keep directory transport while
|
||
// preserving isolated mode and the mandatory sandbox preflight.
|
||
...(forceDirectoryStrategy ? { workspaceStrategy: { type: "project_primary" } } : {}),
|
||
};
|
||
const configSnapshot = buildExecutionWorkspaceConfigSnapshot(
|
||
mergedConfig,
|
||
selectedEnvironmentId,
|
||
);
|
||
const executionRunConfig =
|
||
stripWorkspaceRuntimeFromExecutionRunConfig(mergedConfig);
|
||
const skillActor: AuthorizationActor = { type: "agent", agentId: agent.id, companyId: agent.companyId,
|
||
runId: run.id, source: "agent_jwt", onBehalfOfUserId: responsibleUserId === "local-board" ? null : responsibleUserId };
|
||
const runScopedMentionedSkillKeys =
|
||
preconfiguredHome || pinnedSkillTest ? [] : await time("configuration_mentions", () => resolveRunScopedMentionedSkillKeys({
|
||
db,
|
||
companyId: agent.companyId,
|
||
issueId,
|
||
commentIds: extractWakeCommentIds(context),
|
||
actor: skillActor,
|
||
}));
|
||
const runScopedSkillKeys =
|
||
!pinnedSkillTest && acceptedPlanContinuationWake &&
|
||
!acceptedPlanWakeRoutingDecision?.suppressAcceptedContinuation
|
||
? [...runScopedMentionedSkillKeys, ACCEPTED_PLAN_CONVERSION_SKILL_KEY]
|
||
: runScopedMentionedSkillKeys;
|
||
const githubSelection = await time("configuration_github_identity", () => resolveManagedGitHubIdentitySelection(
|
||
db,
|
||
agent.companyId,
|
||
{
|
||
agentId: agent.id,
|
||
responsibleUserId,
|
||
allowStandingDelegation: false,
|
||
},
|
||
));
|
||
const useHostGitHub =
|
||
!githubSelection.configured &&
|
||
trustPreset.kind === "standard" &&
|
||
["local", "ssh"].includes(
|
||
selectedEnvironmentForConfig?.driver ?? "local",
|
||
);
|
||
|
||
const { resolvedConfig, configuredTaskEnvironment, secretKeys, secretManifest } =
|
||
await time("configuration_secrets", () => resolveExecutionRunAdapterConfig({
|
||
managedAiCredentials: Boolean(aiBinding),
|
||
managedGitHubCredentials: !useHostGitHub,
|
||
companyId: agent.companyId,
|
||
agentId: agent.id,
|
||
adapterType: agent.adapterType,
|
||
issueId,
|
||
heartbeatRunId: run.id,
|
||
environmentId: selectedEnvironmentForConfig?.id ?? null,
|
||
environmentEnv: aiBinding ? stripAiAuthBindings(selectedEnvironmentForConfig?.envVars) : selectedEnvironmentForConfig?.envVars ?? null,
|
||
environmentDriver: selectedEnvironmentForConfig?.driver ?? null,
|
||
projectId: taskProjectContext?.id ?? null,
|
||
routineId: routineEnvContext.routineId,
|
||
responsibleUserId,
|
||
executionRunConfig: aiBinding ? { ...executionRunConfig, env: stripAiAuthBindings(executionRunConfig.env) } : executionRunConfig,
|
||
projectEnv: aiBinding ? stripAiAuthBindings(taskProjectContext?.env) : taskProjectContext?.env ?? null,
|
||
routineEnv: aiBinding ? stripAiAuthBindings(routineEnvContext.env) : routineEnvContext.env,
|
||
secretsSvc,
|
||
trustPreset,
|
||
}));
|
||
onFailureSecretsResolved(() => collectRunFailureSecretValues(resolvedConfig.env, secretKeys));
|
||
if (aiBinding) {
|
||
try {
|
||
managedAiRuntime = await time("configuration_ai_runtime", () => prepareManagedAiRuntime(db, { companyId: agent.companyId, agentId: agent.id, responsibleUserId, adapterType: agent.adapterType, binding: aiBinding, config: resolvedConfig }));
|
||
onManagedAiRuntimeAcquired(managedAiRuntime);
|
||
} catch (error) {
|
||
// Only fresh executions can receive a pre-provider wait receipt. A
|
||
// persisted native input may already have provider effects to recover.
|
||
if (isAiConnectionBusy(error) && !persistedNativeExecutionInput) {
|
||
// Use the authority recorded by the locked admission gate, never
|
||
// the issue's mutable assignee observed during runtime preparation.
|
||
const authorizedNonAssigneeWake =
|
||
parseObject(run.runnerProfileJson).aiConnectionNonAssigneeCommentWake === true ||
|
||
(run.scheduledRetryReason === AI_CONNECTION_BUSY_RETRY_REASON &&
|
||
isNonAssigneeWorkspaceBusyRetry(run.scheduledRetryReason, parseObject(run.contextSnapshot)));
|
||
await finalizeAiConnectionBusyDeferral(run, error, !authorizedNonAssigneeWake);
|
||
return { prepared: false as const };
|
||
}
|
||
if (responsibleUserId && issueId) {
|
||
await connectionIntentService(db).request({ sub: agent.id, company_id: agent.companyId, run_id: run.id, responsible_user_id: responsibleUserId }, aiBinding.provider, { purpose: "ai" }).catch(() => {
|
||
logger.warn({ runId: run.id, agentId: agent.id }, "Could not attach AI connection request; runtime configuration action remains available");
|
||
});
|
||
}
|
||
throw new ConfigurationIncompleteFailure(error instanceof Error ? error.message : "Configure this agent’s AI connection", {
|
||
configurationIncomplete: { reason: "ai_connection_unavailable", companyId: agent.companyId, agentId: agent.id, responsibleUserId,
|
||
...(!persistedNativeExecutionInput && readAiConnectionConfigurationFailure(error)
|
||
? { selectionFailure: readAiConnectionConfigurationFailure(error) } : {}),
|
||
...(readAiCredentialAccessFailure(error)
|
||
? { credentialAccess: readAiCredentialAccessFailure(error) } : {}),
|
||
provider: aiBinding.provider, method: aiBinding.method, actionUrl: `/agents/${agent.id}/runtime`,
|
||
fingerprint: `ai:${agent.id}:${responsibleUserId}:${JSON.stringify(aiBinding)}` },
|
||
});
|
||
}
|
||
const savedAiAccount = parseObject(run.contextSnapshot?.aiConnection);
|
||
if (persistedNativeExecutionInput && !managedAiSessionIdentityCompatible(
|
||
savedAiAccount.sessionIdentity ?? savedAiAccount.identity,
|
||
managedAiRuntime.sessionIdentity,
|
||
managedAiRuntime.identity,
|
||
)) {
|
||
throw new ConfigurationIncompleteFailure("The AI account changed while this native run was suspended. Start a new execution.", { configurationIncomplete: { reason: "ai_connection_changed", actionUrl: `/agents/${agent.id}/runtime` } });
|
||
}
|
||
Object.assign(resolvedConfig, managedAiRuntime.config);
|
||
for (const key of AI_AUTH_ENV_KEYS) secretKeys.add(key);
|
||
context.aiConnection = { ...managedAiRuntime.attribution, accountName: managedAiRuntime.accountName, identity: managedAiRuntime.identity, sessionIdentity: managedAiRuntime.sessionIdentity };
|
||
await db.update(heartbeatRuns).set({ contextSnapshot: sql`coalesce(${heartbeatRuns.contextSnapshot}, '{}'::jsonb) || ${JSON.stringify({ aiConnection: context.aiConnection, ...(context.aiRouterTaskKey ? { aiRouterTaskKey: context.aiRouterTaskKey } : {}), ...(context.aiRouterSelection ? { aiRouterSelection: context.aiRouterSelection } : {}) })}::jsonb` }).where(eq(heartbeatRuns.id, run.id));
|
||
}
|
||
if (secretManifest.length > 0) {
|
||
context.paperclipSecrets = {
|
||
manifest: secretManifest,
|
||
};
|
||
} else {
|
||
delete context.paperclipSecrets;
|
||
}
|
||
const storedVersions = parseObject(run.contextSnapshot?.skillVersions);
|
||
const hasStoredVersions = Object.prototype.hasOwnProperty.call(run.contextSnapshot ?? {}, "skillVersions");
|
||
if (hasStoredVersions && (!run.contextSnapshot?.skillVersions || typeof run.contextSnapshot.skillVersions !== "object"
|
||
|| Array.isArray(run.contextSnapshot.skillVersions) || Object.values(storedVersions).some(value =>
|
||
typeof value !== "string" || !/^[a-f0-9]{8}(?:-[a-f0-9]{4}){3}-[a-f0-9]{12}$/i.test(value)))) {
|
||
throw new ConfigurationIncompleteFailure("The saved skill selection is incomplete. Recover its exact versions before retrying.", {
|
||
configurationIncomplete: { reason: "skill_unavailable", actionUrl: "/skills" },
|
||
});
|
||
}
|
||
const savedShadowedSkills = Array.isArray(run.contextSnapshot?.shadowedSkills)
|
||
? run.contextSnapshot.shadowedSkills.flatMap(value => {
|
||
const saved = parseObject(value);
|
||
return typeof saved.key === "string" && typeof saved.shadowedBy === "string" && Object.hasOwn(storedVersions, saved.shadowedBy)
|
||
? [{ key: saved.key, shadowedBy: saved.shadowedBy }] : [];
|
||
}) : [];
|
||
const selectedConfig = pinnedSkillTest
|
||
? writePaperclipSkillSyncPreference(resolvedConfig, [pinnedSkillTest])
|
||
: applyRunScopedMentionedSkillKeys(resolvedConfig, runScopedSkillKeys);
|
||
const { config: effectiveResolvedConfig, skillKeys: environmentSkills, shadowedSkills } = hasStoredVersions
|
||
? { config: selectedConfig, skillKeys: [], shadowedSkills: savedShadowedSkills }
|
||
: await environmentSkillConfig(db, agent.companyId, selectedEnvironmentForConfig, selectedConfig);
|
||
if (shadowedSkills?.length) {
|
||
context.shadowedSkills = shadowedSkills;
|
||
if (!hasStoredVersions) await appendRunEvent(run, { eventType: "skills.shadowed", stream: "system", level: "warn",
|
||
message: shadowedSkills.map(({ key, shadowedBy }) => `Skill "${key}" was skipped because required plugin skill "${shadowedBy}" uses the same name.`).join("\n"),
|
||
payload: { shadowedSkills } });
|
||
}
|
||
const runtimeSkillPreference = readPaperclipSkillSyncPreference(
|
||
effectiveResolvedConfig,
|
||
);
|
||
const nativeRunnerPreparationSpans: NativeRunHistoricalSpan[] = [];
|
||
const skillsPrepareStartedAtMs = Date.now();
|
||
let skillDeliveryConfig = effectiveResolvedConfig;
|
||
const prepareSkills = async () => {
|
||
|
||
try {
|
||
const versionSelections = hasStoredVersions
|
||
? new Map(Object.entries(storedVersions).filter((entry): entry is [string, string | null] => entry[1] === null || typeof entry[1] === "string"))
|
||
: skillVersionSelectionMap(runtimeSkillPreference.desiredSkillEntries, {
|
||
versionPinsEnabled: resolvedInstanceSettings.experimental.enableBetaSkills === true,
|
||
});
|
||
// Studio always executes its saved revision, independently of assignment
|
||
// pins and the Beta skills preference. Recovery keeps the admitted map.
|
||
if (!hasStoredVersions && pinnedSkillTest) versionSelections.set(pinnedSkillTest.key, pinnedSkillTest.versionId);
|
||
return await withSkillActor(skillActor, () => companySkills.withRuntimeSkillEntries(agent.companyId, {
|
||
versionSelections, snapshotLatest: true,
|
||
...(hasStoredVersions
|
||
? { onlyKeys: new Set(Object.keys(storedVersions)) }
|
||
: { selectionConfig: effectiveResolvedConfig, includeLegacy: agent.adapterType !== "paperclip_runner" }),
|
||
selectVersions: async entries => {
|
||
const available = hasStoredVersions ? entries.filter(entry => Object.prototype.hasOwnProperty.call(storedVersions, entry.key)) : entries;
|
||
const availableKeys = new Set(available.map(entry => entry.key));
|
||
if (!hasStoredVersions && pinnedSkillTest && (!availableKeys.has(pinnedSkillTest.key)
|
||
|| shadowedSkills?.some(skill => skill.key === pinnedSkillTest.key))) {
|
||
throw new ConfigurationIncompleteFailure("The skill test's pinned skill is unavailable or no longer permitted.", {
|
||
configurationIncomplete: { reason: "skill_unavailable", actionUrl: "/skills" },
|
||
});
|
||
}
|
||
if (hasStoredVersions && Object.keys(storedVersions).some(key => !availableKeys.has(key))) {
|
||
throw new ConfigurationIncompleteFailure("A pinned skill is unavailable or no longer permitted.", {
|
||
configurationIncomplete: { reason: "skill_unavailable", actionUrl: "/skills" },
|
||
});
|
||
}
|
||
const desiredKeys = hasStoredVersions
|
||
? Object.keys(storedVersions)
|
||
: agent.adapterType === "paperclip_runner"
|
||
? resolvePaperclipDesiredSkillNames(effectiveResolvedConfig, available)
|
||
: resolveLegacyPaperclipDesiredSkillNames(effectiveResolvedConfig, available);
|
||
const selectedKeys = new Set(desiredKeys.filter(key => availableKeys.has(key)));
|
||
const resolved = available.filter(entry => selectedKeys.has(entry.key));
|
||
skillDeliveryConfig = writePaperclipSkillSyncPreference(effectiveResolvedConfig,
|
||
resolved.map(entry => ({ key: entry.key, versionId: entry.versionId ?? null })));
|
||
if (!hasStoredVersions) {
|
||
const skillVersions = Object.fromEntries(resolved.map(entry => [entry.key, entry.versionId ?? entry.currentVersionId ?? null]));
|
||
context.skillVersions = skillVersions;
|
||
context.skillSelectionSnapshot = true;
|
||
await db.update(heartbeatRuns).set({ contextSnapshot: sql`coalesce(${heartbeatRuns.contextSnapshot}, '{}'::jsonb) || ${JSON.stringify({ skillVersions, skillSelectionSnapshot: true, ...(shadowedSkills?.length ? { shadowedSkills } : {}) })}::jsonb` }).where(eq(heartbeatRuns.id, run.id));
|
||
}
|
||
return selectedKeys;
|
||
},
|
||
}, async entries => {
|
||
for (const key of [...runScopedMentionedSkillKeys.filter(key => !shadowedSkills?.some(skill => skill.key === key)), ...(hasStoredVersions ? [] : environmentSkills)]) {
|
||
const entry = entries.find(candidate => candidate.key === key);
|
||
if (!entry || entry.sourceStatus === "missing") {
|
||
throw new ConfigurationIncompleteFailure("A referenced skill is unavailable. Restore its installed version or update the task's skill reference.", {
|
||
configurationIncomplete: { reason: "skill_unavailable", skillKey: key, actionUrl: "/skills" },
|
||
});
|
||
}
|
||
}
|
||
return entries;
|
||
}));
|
||
} catch (error) {
|
||
if (agent.adapterType === "paperclip_runner") {
|
||
await recordFailedSkillPreparation({
|
||
runId: run.id,
|
||
startedAtMs: skillsPrepareStartedAtMs,
|
||
onEvent: async (event) => {
|
||
await appendRunEvent(run, event);
|
||
},
|
||
});
|
||
}
|
||
throw error;
|
||
}
|
||
};
|
||
const runtimeSkillEntries = preconfiguredHome ? [] : await time("configuration_skills", prepareSkills);
|
||
nativeRunnerPreparationSpans.push({
|
||
name: "skills.prepare",
|
||
parentName: "task.prepare",
|
||
startedAtMs: skillsPrepareStartedAtMs,
|
||
endedAtMs: Date.now(),
|
||
});
|
||
const connectorAssignments = preconfiguredHome ? [] : await time("configuration_connector_assignments", () => resolveConnectorAssignments(db, { companyId: agent.companyId, agentId: agent.id, runId: run.id, issueId: typeof context.issueId === "string" ? context.issueId : undefined }));
|
||
const connectorSkillConfig = await time("configuration_connector_skills", () => applyConnectorSkills(skillDeliveryConfig, runtimeSkillEntries, connectorAssignments));
|
||
// Both CLI adapters and native context materialization use the same resolved set.
|
||
runtimeSkillEntries.splice(0, runtimeSkillEntries.length, ...connectorSkillConfig.paperclipRuntimeSkills);
|
||
const connectorDelivery = await time("configuration_connector_delivery", () => prepareConnectorSkillDelivery(connectorSkillConfig, agent.adapterType));
|
||
// Always replace this runtime-only field; caller wake data cannot supply skills.
|
||
context.paperclipWake = { ...parseObject(context.paperclipWake), connectorSkillInstructions: connectorDelivery.instructions };
|
||
let runtimeConfig = await time("configuration_connection_instructions", () => prepareConnectionInstructionDelivery({
|
||
resolve: () => resolveAssignedConnectionInstructionsForRun(db, { companyId: agent.companyId, agentId: agent.id, runId: run.id }),
|
||
context, config: connectorDelivery.config, native: agent.adapterType === "paperclip_runner",
|
||
}));
|
||
const agentIdentity = supportsManagedAgentIdentity(agent.adapterType, agent.adapterConfig, run.runtimeMode === "native" ? run.driverKind : undefined)
|
||
? await time("configuration_agent_identity", () => agentIdentityService(db).ensureAgentIdentity(agent.companyId, agent.id))
|
||
: undefined;
|
||
identityRedactor.values.push(...createAgentIdentityRedactor(agentIdentity?.privateKeyPem).values);
|
||
const harness = agentHarnessType(agent.adapterType, runtimeConfig);
|
||
const observability = unsupportedObservability !== "unsupported_home_mode" && observabilityKind(harness)
|
||
? agentObservabilityLaunch(observabilitySnapshot, { kind: observabilityKind(harness)!, companyId: agent.companyId, agentId: agent.id }) : undefined;
|
||
identityRedactor.values.push(...observabilitySecretValues(observability));
|
||
identityRedactor.values.sort((a, b) => b.length - a.length);
|
||
if (observabilitySnapshot.state === "unavailable") {
|
||
logger.warn({ runId: run.id, reason: observabilitySnapshot.reason }, "Agent observability unavailable; execution continues without export");
|
||
const reason = observabilitySnapshot.reason;
|
||
await appendRunEvent(run, { eventType: "agent_observability.unavailable", stream: "system", level: "warn",
|
||
message: reason === "unsupported_home_mode"
|
||
? "Company observability was not applied: automatic configuration of caller-owned Codex homes is unsupported."
|
||
: reason === "unsupported_harness" ? "Company observability was not applied: this harness is not supported."
|
||
: "Company observability is unavailable. Execution continues without company export.",
|
||
payload: { reason, revision: observabilitySnapshot.revision } }).catch(() => {
|
||
logger.warn({ runId: run.id }, "Could not record the agent observability availability diagnostic");
|
||
});
|
||
}
|
||
onIdentityRedactorPrepared(identityRedactor);
|
||
if (agentIdentity) secretKeys.add("PAPERCLIP_AGENT_PRIVATE_KEY");
|
||
return {
|
||
prepared: true as const,
|
||
mergedConfig, configSnapshot, runScopedMentionedSkillKeys, githubSelection, useHostGitHub,
|
||
resolvedConfig, configuredTaskEnvironment, secretKeys, secretManifest,
|
||
runtimeSkillEntries, nativeRunnerPreparationSpans, runtimeConfig, agentIdentity, observability,
|
||
};
|
||
}
|