mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-03 01:14:48 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Company search is the primary way operators find issues, comments, documents, artifacts, agents, and projects across a busy company > - Search previously supported only a bare text query: no way to narrow by status/assignee/project/label/date, no sort control, no typed operators, and weak relevance/snippets meant hunting through noise > - As companies accumulate tens of thousands of items, unfiltered single-sort search stops scaling for day-to-day operator workflows > - This pull request adds a full filtering model (filter bar, chips, mobile sheet, URL state), sort modes, typed query operators (`status:`, `assignee:`, `type:`, …) with command-palette parity, relevance/snippet/deep-link improvements, zero-results recovery, and the supporting shared validators, backend service work, and DB indexes > - The benefit is that operators can go from a vague query to the exact item in a couple of keystrokes, on desktop and mobile, with shareable filtered-search URLs ## Linked Issues or Issue Description No existing public GitHub issue; describing the underlying feature request inline (per feature_request template): - **Problem:** Company search accepted only a plain text query. Users could not filter results by status, assignee, project, label, or recency; could not change result ordering; and got no guidance when filters emptied the result set. - **Desired solution:** Structured search filters (UI controls + typed query operators + URL parameters), selectable sort modes, better relevance and snippets with exact deep links, and parity between the search page and the command palette. - **Alternatives considered:** Client-side filtering of unfiltered results (does not scale past the fetch limit); a separate "advanced search" page (splits the surface and duplicates state handling). Related (not duplicate) PRs found while searching: #4848 (issue search query planning), #8235 (search rate limiting). ## What Changed - **Shared contract:** new search filter/sort/count/zero-results types and validators in `packages/shared` (`validators/search.ts`, types index). - **Backend:** `server/src/services/company-search.ts` supports issue filters, sort modes, per-filter option counts, snippets, artifact visibility, and zero-results loosen suggestions; single-statement match replaces per-scope scans and predicates are trigram-index compatible (~3.7s → ~350ms on a live 14.8k-hit corpus). - **DB:** migration `0142_company_search_sort_indexes.sql` adds the supporting indexes. - **Search page (`ui/src/pages/Search.tsx`):** filter bar, removable chips, mobile filter sheet with result-count preview, sort menu, URL round-tripping, zero-results recovery UI. - **Query operators (`ui/src/lib/search-query-parser.ts`):** typed operators parsed into filters, operator autocomplete, filter pills. - **Command palette:** operator-aware parsing and full-search handoff. - **Stale-operator fix (latest commit):** typed operator filters are no longer folded into persistent URL-filter state, so deleting a token (e.g. removing `status:blocked` from the input) actually removes the filter from subsequent requests; filter-control edits materialize control state and strip typed tokens so a removed chip cannot resurrect from the input. ## Verification - `cd ui && npx vitest run src/pages/Search.test.tsx` — 19 tests including two new red→green regressions for the stale-operator paths (both fail on the previous commit, pass now). - `cd ui && npx vitest run src/components/CommandPalette.test.tsx` and `cd server && npx vitest run src/services/company-search-service.test.ts` — operator parity and backend filter/sort/count coverage. - `cd ui && npx tsc --noEmit` — clean. - Manual: open `/search`, type `auth status:blocked`, confirm the status filter applies; delete `status:blocked`, confirm results are unfiltered again; drive the same filters from the filter bar/chips/mobile sheet and confirm the URL round-trips (reload/back/forward preserves state). - Full end-to-end QA pass (9/9 acceptance checks) against the wireframes on desktop (1280px) and mobile (390px) with a live API and browser automation. ## Risks - Additive migration (indexes only, no data rewrites) — safe to roll forward; index creation cost is paid once at migrate time. - Search request shape gains optional parameters only; old clients keep working. - Behavioral shift: filter-control edits now strip typed operator tokens from the query text (their values persist as filter state) — deliberate, so removed filters stay removed. - Ranking changes alter result ordering for existing queries; covered by service tests and the QA pass. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - Claude Fable 5 (`claude-fable-5`, Anthropic, extended thinking + tool use) — stale-operator-filter fix, regression tests, PR preparation. - GPT-5 Codex (`codex_local` adapter) and Claude Opus 4.6 (`claude-opus-4-6`) — earlier implementation phases (backend contract, filter UI, operators, ranking) under agent orchestration. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [ ] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details — pre-existing branch name retained to avoid closing/reopening the PR - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes (no user-facing docs affected) - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green (pending re-run on latest commit) - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups (pending re-review of the stale-filter fix) - [x] I will address all Greptile and reviewer comments before requesting merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
272 lines
9.6 KiB
TypeScript
272 lines
9.6 KiB
TypeScript
import { memo, type ComponentType, type SVGProps } from "react";
|
|
import { Bot, FileText, Hexagon, MessageSquare, Paperclip, Quote } from "lucide-react";
|
|
import type { Agent, CompanySearchResult } from "@paperclipai/shared";
|
|
import { Link } from "@/lib/router";
|
|
import { cn } from "@/lib/utils";
|
|
import { StatusIcon } from "../StatusIcon";
|
|
import { Identity } from "../Identity";
|
|
import { HighlightedText, type HighlightedTextProps } from "./HighlightedText";
|
|
|
|
type SnippetStyle = {
|
|
Icon: ComponentType<SVGProps<SVGSVGElement>>;
|
|
label: string;
|
|
};
|
|
|
|
const SNIPPET_STYLES: Record<string, SnippetStyle> = {
|
|
comment: { Icon: MessageSquare, label: "Comment" },
|
|
document: { Icon: FileText, label: "Doc" },
|
|
artifact: { Icon: Paperclip, label: "Artifact" },
|
|
description: { Icon: Quote, label: "Description" },
|
|
};
|
|
|
|
function snippetStyle(field: string, fallbackLabel: string): SnippetStyle {
|
|
return SNIPPET_STYLES[field] ?? { Icon: Quote, label: fallbackLabel };
|
|
}
|
|
|
|
function formatRelativeTime(input: string | null): string {
|
|
if (!input) return "";
|
|
const value = new Date(input);
|
|
if (Number.isNaN(value.getTime())) return "";
|
|
const diffMs = Date.now() - value.getTime();
|
|
const seconds = Math.round(diffMs / 1000);
|
|
if (seconds < 60) return "just now";
|
|
const minutes = Math.round(seconds / 60);
|
|
if (minutes < 60) return `${minutes}m`;
|
|
const hours = Math.round(minutes / 60);
|
|
if (hours < 24) return `${hours}h`;
|
|
const days = Math.round(hours / 24);
|
|
if (days < 7) return `${days}d`;
|
|
const weeks = Math.round(days / 7);
|
|
if (weeks < 5) return `${weeks}w`;
|
|
const months = Math.round(days / 30);
|
|
if (months < 12) return `${months}mo`;
|
|
const years = Math.round(days / 365);
|
|
return `${years}y`;
|
|
}
|
|
|
|
export interface SearchResultRowProps {
|
|
result: CompanySearchResult;
|
|
agentsById?: ReadonlyMap<string, Pick<Agent, "id" | "name">>;
|
|
isActive?: boolean;
|
|
className?: string;
|
|
}
|
|
|
|
const ROW_BASE =
|
|
"group flex items-start gap-3 rounded-md px-3 transition-colors no-underline text-inherit hover:bg-muted/40";
|
|
|
|
function SearchResultRowImpl({
|
|
result,
|
|
agentsById,
|
|
isActive,
|
|
className,
|
|
}: SearchResultRowProps) {
|
|
if (result.type === "agent") {
|
|
return (
|
|
<Link
|
|
to={result.href}
|
|
className={cn(ROW_BASE, "py-3", isActive && "bg-muted/40", className)}
|
|
data-result-type="agent"
|
|
>
|
|
<span className="mt-0.5 flex h-5 w-5 shrink-0 items-center justify-center rounded-full bg-muted text-muted-foreground">
|
|
<Bot className="h-3 w-3" />
|
|
</span>
|
|
<div className="min-w-0 flex-1">
|
|
<div className="flex min-w-0 items-center gap-2">
|
|
<span className="truncate text-sm font-medium">{result.title}</span>
|
|
</div>
|
|
{result.snippet ? (
|
|
<SnippetLine
|
|
text={result.snippets[0]?.text ?? result.snippet}
|
|
highlights={result.snippets[0]?.highlights}
|
|
field="agent"
|
|
fallbackLabel={result.sourceLabel ?? "Agent"}
|
|
/>
|
|
) : null}
|
|
</div>
|
|
</Link>
|
|
);
|
|
}
|
|
|
|
if (result.type === "project") {
|
|
return (
|
|
<Link
|
|
to={result.href}
|
|
className={cn(ROW_BASE, "py-3", isActive && "bg-muted/40", className)}
|
|
data-result-type="project"
|
|
>
|
|
<Hexagon className="mt-0.5 h-4 w-4 shrink-0 text-muted-foreground" />
|
|
<div className="min-w-0 flex-1">
|
|
<span className="truncate text-sm font-medium">{result.title}</span>
|
|
{result.snippet ? (
|
|
<SnippetLine
|
|
text={result.snippets[0]?.text ?? result.snippet}
|
|
highlights={result.snippets[0]?.highlights}
|
|
field="project"
|
|
fallbackLabel={result.sourceLabel ?? "Project"}
|
|
/>
|
|
) : null}
|
|
</div>
|
|
</Link>
|
|
);
|
|
}
|
|
|
|
if (result.type === "artifact") {
|
|
const artifact = result.artifact;
|
|
if (!artifact) return null;
|
|
const updated = formatRelativeTime(result.updatedAt ?? artifact.updatedAt);
|
|
return (
|
|
<Link
|
|
to={result.href}
|
|
disableIssueQuicklook
|
|
className={cn(ROW_BASE, "py-4", isActive && "bg-muted/40", className)}
|
|
data-result-type="artifact"
|
|
>
|
|
<Paperclip className="mt-1 h-4 w-4 shrink-0 text-muted-foreground" />
|
|
<div className="min-w-0 flex-1">
|
|
<div className="flex min-w-0 flex-wrap items-baseline gap-x-2.5 gap-y-1">
|
|
<span className="truncate text-sm font-medium text-foreground">{result.title}</span>
|
|
<span className="shrink-0 text-xs text-muted-foreground">
|
|
{artifact.issueIdentifier}
|
|
</span>
|
|
</div>
|
|
{result.snippet ? (
|
|
<SnippetLine
|
|
text={result.snippets[0]?.text ?? result.snippet}
|
|
highlights={result.snippets[0]?.highlights}
|
|
field="artifact"
|
|
fallbackLabel={result.sourceLabel ?? "Artifact"}
|
|
multiline
|
|
/>
|
|
) : null}
|
|
<div className="mt-1.5 flex min-w-0 items-center gap-1.5 text-xs text-muted-foreground sm:hidden">
|
|
<span className="truncate">{artifact.issueTitle}</span>
|
|
{updated ? <span className="ml-auto shrink-0 tabular-nums">{updated}</span> : null}
|
|
</div>
|
|
</div>
|
|
<div className="ml-2 hidden shrink-0 flex-col items-end gap-2 sm:flex">
|
|
{updated ? <span className="text-xs tabular-nums text-muted-foreground">{updated}</span> : null}
|
|
{result.previewImageUrl ? (
|
|
<img
|
|
src={result.previewImageUrl}
|
|
alt=""
|
|
loading="lazy"
|
|
decoding="async"
|
|
className="h-(--sz-88px) w-(--sz-88px) shrink-0 rounded-md border border-border bg-muted object-cover"
|
|
/>
|
|
) : null}
|
|
</div>
|
|
</Link>
|
|
);
|
|
}
|
|
|
|
const issue = result.issue;
|
|
if (!issue) return null;
|
|
const assigneeName = issue.assigneeAgentId
|
|
? agentsById?.get(issue.assigneeAgentId)?.name ?? null
|
|
: null;
|
|
const updated = formatRelativeTime(result.updatedAt ?? issue.updatedAt);
|
|
const titleHighlights = result.snippets.find((snippet) => snippet.field === "title")?.highlights;
|
|
const bodySnippets = result.snippets.filter((snippet) => snippet.field !== "title").slice(0, 2);
|
|
const previewImageUrl = result.previewImageUrl;
|
|
const hasRightRail = previewImageUrl || assigneeName || updated;
|
|
|
|
return (
|
|
<Link
|
|
to={result.href}
|
|
disableIssueQuicklook
|
|
className={cn(ROW_BASE, "py-4", isActive && "bg-muted/40", className)}
|
|
data-result-type="issue"
|
|
>
|
|
<div className="mt-1 shrink-0">
|
|
<StatusIcon status={issue.status} />
|
|
</div>
|
|
<div className="min-w-0 flex-1">
|
|
<div className="flex min-w-0 flex-wrap items-baseline gap-x-2.5 gap-y-1">
|
|
{issue.identifier ? (
|
|
<span className="shrink-0 font-mono text-xs text-muted-foreground tabular-nums">
|
|
{issue.identifier}
|
|
</span>
|
|
) : null}
|
|
<HighlightedText
|
|
text={issue.title}
|
|
highlights={titleHighlights}
|
|
className="min-w-0 flex-1 text-sm font-medium leading-snug text-foreground"
|
|
/>
|
|
</div>
|
|
{bodySnippets.map((snippet, index) => (
|
|
<SnippetLine
|
|
key={`${snippet.field}-${index}`}
|
|
text={snippet.text}
|
|
highlights={snippet.highlights}
|
|
field={snippet.field}
|
|
fallbackLabel={snippet.label}
|
|
multiline
|
|
/>
|
|
))}
|
|
{hasRightRail ? (
|
|
<div className="mt-1.5 flex items-center gap-2 text-xs text-muted-foreground sm:hidden">
|
|
{assigneeName ? <span className="truncate">{assigneeName}</span> : null}
|
|
{updated ? <span className="ml-auto tabular-nums">{updated}</span> : null}
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
{hasRightRail ? (
|
|
<div className="ml-2 hidden shrink-0 flex-col items-end gap-2 sm:flex">
|
|
{assigneeName || updated ? (
|
|
<div className="flex items-center gap-2 text-xs text-muted-foreground">
|
|
{assigneeName ? <Identity name={assigneeName} size="sm" /> : null}
|
|
{updated ? <span className="tabular-nums">{updated}</span> : null}
|
|
</div>
|
|
) : null}
|
|
{previewImageUrl ? (
|
|
<img
|
|
src={previewImageUrl}
|
|
alt=""
|
|
loading="lazy"
|
|
decoding="async"
|
|
className="h-(--sz-88px) w-(--sz-88px) shrink-0 rounded-md border border-border bg-muted object-cover"
|
|
/>
|
|
) : null}
|
|
</div>
|
|
) : null}
|
|
</Link>
|
|
);
|
|
}
|
|
|
|
export const SearchResultRow = memo(SearchResultRowImpl);
|
|
|
|
interface SnippetLineProps {
|
|
text: string;
|
|
highlights?: HighlightedTextProps["highlights"];
|
|
field: string;
|
|
fallbackLabel: string;
|
|
multiline?: boolean;
|
|
}
|
|
|
|
function SnippetLine({ text, highlights, field, fallbackLabel, multiline = false }: SnippetLineProps) {
|
|
const { Icon, label } = snippetStyle(field, fallbackLabel);
|
|
return (
|
|
<div
|
|
className={cn(
|
|
"mt-2.5 flex min-w-0 gap-1.5 text-xs text-muted-foreground",
|
|
multiline ? "items-start" : "items-center",
|
|
)}
|
|
>
|
|
<Icon
|
|
className={cn("h-3.5 w-3.5 shrink-0 text-muted-foreground/60", multiline && "mt-0.5")}
|
|
aria-hidden
|
|
/>
|
|
<span
|
|
className="shrink-0 rounded border border-border bg-muted px-1.5 py-0.5 text-(length:--text-nano) font-medium uppercase tracking-wide text-muted-foreground"
|
|
>
|
|
{label}
|
|
</span>
|
|
<HighlightedText
|
|
text={text}
|
|
highlights={highlights}
|
|
className={multiline ? "line-clamp-2 leading-relaxed" : "line-clamp-1 truncate"}
|
|
/>
|
|
</div>
|
|
);
|
|
}
|