mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-29 12:59:13 +01:00
- Resolve dynamic_command secrets through the runtime injection path with static binding argv only - Add memory-only TTL caching, fail-closed command handling, and metadata-only task activity for fresh mints - Cover cache hit/miss/expiry and generator failure paths in secret service tests - Sync CLI/UI fixtures with dynamic secret fields from the shared contract Co-Authored-By: Paperclip <noreply@paperclip.ing>
334 lines
11 KiB
TypeScript
334 lines
11 KiB
TypeScript
import { Command } from "commander";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import type { Agent, CompanySecret } from "@paperclipai/shared";
|
|
import type { PaperclipConfig } from "../config/schema.js";
|
|
import { secretsCheck } from "../checks/secrets-check.js";
|
|
import {
|
|
buildInlineMigrationSecretName,
|
|
buildMigratedAgentEnv,
|
|
collectInlineSecretMigrationCandidates,
|
|
parseSecretsInclude,
|
|
registerSecretCommands,
|
|
toPlainEnvValue,
|
|
} from "../commands/client/secrets.js";
|
|
|
|
function agent(partial: Partial<Agent>): Agent {
|
|
return {
|
|
id: "agent-12345678",
|
|
companyId: "company-1",
|
|
name: "Coder",
|
|
urlKey: "coder",
|
|
role: "engineer",
|
|
title: null,
|
|
icon: null,
|
|
status: "idle",
|
|
reportsTo: null,
|
|
capabilities: null,
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
budgetMonthlyCents: 0,
|
|
spentMonthlyCents: 0,
|
|
pauseReason: null,
|
|
pausedAt: null,
|
|
permissions: {
|
|
canCreateAgents: false,
|
|
},
|
|
lastHeartbeatAt: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-04-26T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-04-26T00:00:00.000Z"),
|
|
...partial,
|
|
};
|
|
}
|
|
|
|
function secret(partial: Partial<CompanySecret>): CompanySecret {
|
|
return {
|
|
id: "secret-1",
|
|
companyId: "company-1",
|
|
key: "agent_agent-12_anthropic_api_key",
|
|
name: "agent_agent-12_anthropic_api_key",
|
|
provider: "local_encrypted",
|
|
status: "active",
|
|
managedMode: "paperclip_managed",
|
|
externalRef: null,
|
|
dynamicCommand: null,
|
|
providerConfigId: null,
|
|
providerMetadata: null,
|
|
latestVersion: 1,
|
|
description: null,
|
|
lastResolvedAt: null,
|
|
lastRotatedAt: null,
|
|
deletedAt: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: null,
|
|
createdAt: new Date("2026-04-26T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-04-26T00:00:00.000Z"),
|
|
...partial,
|
|
};
|
|
}
|
|
|
|
function configWithSecretsProvider(provider: PaperclipConfig["secrets"]["provider"]): PaperclipConfig {
|
|
return {
|
|
$meta: {
|
|
version: 1,
|
|
updatedAt: "2026-05-02T00:00:00.000Z",
|
|
source: "configure",
|
|
},
|
|
database: {
|
|
mode: "embedded-postgres",
|
|
embeddedPostgresDataDir: "/tmp/paperclip/db",
|
|
embeddedPostgresPort: 55432,
|
|
backup: {
|
|
enabled: true,
|
|
intervalMinutes: 60,
|
|
retentionDays: 30,
|
|
dir: "/tmp/paperclip/backups",
|
|
},
|
|
},
|
|
logging: {
|
|
mode: "file",
|
|
logDir: "/tmp/paperclip/logs",
|
|
},
|
|
server: {
|
|
deploymentMode: "local_trusted",
|
|
exposure: "private",
|
|
host: "127.0.0.1",
|
|
port: 3100,
|
|
allowedHostnames: [],
|
|
serveUi: true,
|
|
},
|
|
auth: {
|
|
baseUrlMode: "auto",
|
|
disableSignUp: false,
|
|
},
|
|
telemetry: {
|
|
enabled: true,
|
|
},
|
|
storage: {
|
|
provider: "local_disk",
|
|
localDisk: {
|
|
baseDir: "/tmp/paperclip/storage",
|
|
},
|
|
s3: {
|
|
bucket: "paperclip",
|
|
region: "us-east-1",
|
|
prefix: "",
|
|
forcePathStyle: false,
|
|
},
|
|
},
|
|
secrets: {
|
|
provider,
|
|
strictMode: true,
|
|
localEncrypted: {
|
|
keyFilePath: "/tmp/paperclip/secrets/master.key",
|
|
},
|
|
},
|
|
};
|
|
}
|
|
|
|
describe("secrets CLI helpers", () => {
|
|
const originalEnv = { ...process.env };
|
|
|
|
beforeEach(() => {
|
|
process.env = { ...originalEnv };
|
|
delete process.env.PAPERCLIP_SECRETS_AWS_REGION;
|
|
delete process.env.AWS_REGION;
|
|
delete process.env.AWS_DEFAULT_REGION;
|
|
delete process.env.PAPERCLIP_SECRETS_AWS_DEPLOYMENT_ID;
|
|
delete process.env.PAPERCLIP_SECRETS_AWS_KMS_KEY_ID;
|
|
});
|
|
|
|
afterEach(() => {
|
|
process.env = { ...originalEnv };
|
|
});
|
|
|
|
it("parses declaration include filters", () => {
|
|
expect(parseSecretsInclude("agents,projects,tasks")).toEqual({
|
|
company: false,
|
|
agents: true,
|
|
projects: true,
|
|
issues: true,
|
|
skills: false,
|
|
});
|
|
});
|
|
|
|
it("detects inline sensitive env values that need migration", () => {
|
|
const rows = collectInlineSecretMigrationCandidates(
|
|
[
|
|
agent({
|
|
id: "agent-12345678",
|
|
adapterConfig: {
|
|
env: {
|
|
ANTHROPIC_API_KEY: "sk-ant-test",
|
|
GH_TOKEN: {
|
|
type: "plain",
|
|
value: "ghp-test",
|
|
},
|
|
PATH: {
|
|
type: "plain",
|
|
value: "/usr/bin",
|
|
},
|
|
OPENAI_API_KEY: {
|
|
type: "secret_ref",
|
|
secretId: "secret-existing",
|
|
},
|
|
},
|
|
},
|
|
}),
|
|
],
|
|
[
|
|
secret({
|
|
id: "secret-gh-token",
|
|
name: buildInlineMigrationSecretName("agent-12345678", "GH_TOKEN"),
|
|
}),
|
|
],
|
|
);
|
|
|
|
expect(rows).toEqual([
|
|
{
|
|
agentId: "agent-12345678",
|
|
agentName: "Coder",
|
|
envKey: "ANTHROPIC_API_KEY",
|
|
secretName: "agent_agent-12_anthropic_api_key",
|
|
existingSecretId: null,
|
|
},
|
|
{
|
|
agentId: "agent-12345678",
|
|
agentName: "Coder",
|
|
envKey: "GH_TOKEN",
|
|
secretName: "agent_agent-12_gh_token",
|
|
existingSecretId: "secret-gh-token",
|
|
},
|
|
]);
|
|
});
|
|
|
|
it("builds migrated env bindings without preserving secret values", () => {
|
|
const next = buildMigratedAgentEnv(
|
|
{
|
|
ANTHROPIC_API_KEY: "sk-ant-test",
|
|
NODE_ENV: {
|
|
type: "plain",
|
|
value: "development",
|
|
},
|
|
},
|
|
new Map([["ANTHROPIC_API_KEY", "secret-1"]]),
|
|
);
|
|
|
|
expect(next).toEqual({
|
|
ANTHROPIC_API_KEY: {
|
|
type: "secret_ref",
|
|
secretId: "secret-1",
|
|
version: "latest",
|
|
},
|
|
NODE_ENV: {
|
|
type: "plain",
|
|
value: "development",
|
|
},
|
|
});
|
|
expect(JSON.stringify(next)).not.toContain("sk-ant-test");
|
|
});
|
|
|
|
it("reads only explicit plain env values", () => {
|
|
expect(toPlainEnvValue("plain-value")).toBe("plain-value");
|
|
expect(toPlainEnvValue({ type: "plain", value: "wrapped" })).toBe("wrapped");
|
|
expect(toPlainEnvValue({ type: "secret_ref", secretId: "secret-1" })).toBeNull();
|
|
});
|
|
|
|
it("reports the AWS bootstrap config required by doctor", () => {
|
|
const result = secretsCheck(configWithSecretsProvider("aws_secrets_manager"));
|
|
|
|
expect(result.status).toBe("fail");
|
|
expect(result.message).toContain("PAPERCLIP_SECRETS_AWS_DEPLOYMENT_ID");
|
|
expect(result.repairHint).toContain("AWS SDK default credential chain");
|
|
expect(result.repairHint).toContain("Do not store AWS root credentials");
|
|
});
|
|
|
|
it("passes AWS doctor checks when non-secret provider config is present", () => {
|
|
process.env.PAPERCLIP_SECRETS_AWS_REGION = "us-east-1";
|
|
process.env.PAPERCLIP_SECRETS_AWS_DEPLOYMENT_ID = "prod-us-1";
|
|
process.env.PAPERCLIP_SECRETS_AWS_KMS_KEY_ID =
|
|
"arn:aws:kms:us-east-1:123456789012:key/test";
|
|
process.env.AWS_PROFILE = "paperclip-prod";
|
|
|
|
const result = secretsCheck(configWithSecretsProvider("aws_secrets_manager"));
|
|
|
|
expect(result.status).toBe("pass");
|
|
expect(result.message).toContain("prod-us-1");
|
|
expect(result.message).toContain("AWS_PROFILE/shared config");
|
|
});
|
|
});
|
|
|
|
describe("secrets API parity commands", () => {
|
|
beforeEach(() => {
|
|
vi.restoreAllMocks();
|
|
delete process.env.PAPERCLIP_API_KEY;
|
|
delete process.env.PAPERCLIP_API_URL;
|
|
vi.spyOn(console, "log").mockImplementation(() => {});
|
|
});
|
|
|
|
afterEach(() => {
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
it("wraps provider config and remote import endpoints", async () => {
|
|
const fetchMock = vi.fn().mockImplementation(() => Promise.resolve(jsonResponse()));
|
|
vi.stubGlobal("fetch", fetchMock);
|
|
|
|
await runSecretCommand(["secrets", "provider-configs", "--company-id", "company-1"]);
|
|
await runSecretCommand(["secrets", "provider-config:create", "--company-id", "company-1", "--payload-json", "{}"]);
|
|
await runSecretCommand(["secrets", "provider-config:discovery-preview", "--company-id", "company-1", "--payload-json", "{}"]);
|
|
await runSecretCommand(["secrets", "provider-config:get", "config-1"]);
|
|
await runSecretCommand(["secrets", "provider-config:update", "config-1", "--payload-json", "{}"]);
|
|
await runSecretCommand(["secrets", "provider-config:default", "config-1"]);
|
|
await runSecretCommand(["secrets", "provider-config:health", "config-1"]);
|
|
await runSecretCommand(["secrets", "provider-config:delete", "config-1"]);
|
|
await runSecretCommand(["secrets", "remote-import:preview", "--company-id", "company-1", "--payload-json", "{}"]);
|
|
await runSecretCommand(["secrets", "remote-import", "--company-id", "company-1", "--payload-json", "{}"]);
|
|
|
|
expect(fetchMock.mock.calls.map((call) => [call[1]?.method ?? "GET", call[0]])).toEqual([
|
|
["GET", "http://localhost:3100/api/companies/company-1/secret-provider-configs"],
|
|
["POST", "http://localhost:3100/api/companies/company-1/secret-provider-configs"],
|
|
["POST", "http://localhost:3100/api/companies/company-1/secret-provider-configs/discovery/preview"],
|
|
["GET", "http://localhost:3100/api/secret-provider-configs/config-1"],
|
|
["PATCH", "http://localhost:3100/api/secret-provider-configs/config-1"],
|
|
["POST", "http://localhost:3100/api/secret-provider-configs/config-1/default"],
|
|
["POST", "http://localhost:3100/api/secret-provider-configs/config-1/health"],
|
|
["DELETE", "http://localhost:3100/api/secret-provider-configs/config-1"],
|
|
["POST", "http://localhost:3100/api/companies/company-1/secrets/remote-import/preview"],
|
|
["POST", "http://localhost:3100/api/companies/company-1/secrets/remote-import"],
|
|
]);
|
|
});
|
|
|
|
it("wraps secret metadata, rotation, usage, access event, and delete endpoints", async () => {
|
|
const fetchMock = vi.fn().mockImplementation(() => Promise.resolve(jsonResponse()));
|
|
vi.stubGlobal("fetch", fetchMock);
|
|
|
|
await runSecretCommand(["secrets", "update", "secret-1", "--payload-json", "{\"description\":\"updated\"}"]);
|
|
await runSecretCommand(["secrets", "rotate", "secret-1", "--value", "new-value"]);
|
|
await runSecretCommand(["secrets", "usage", "secret-1"]);
|
|
await runSecretCommand(["secrets", "access-events", "secret-1"]);
|
|
await runSecretCommand(["secrets", "delete", "secret-1", "--yes", "--confirm", "secret-1"]);
|
|
|
|
expect(fetchMock.mock.calls.map((call) => [call[1]?.method ?? "GET", call[0]])).toEqual([
|
|
["PATCH", "http://localhost:3100/api/secrets/secret-1"],
|
|
["POST", "http://localhost:3100/api/secrets/secret-1/rotate"],
|
|
["GET", "http://localhost:3100/api/secrets/secret-1/usage"],
|
|
["GET", "http://localhost:3100/api/secrets/secret-1/access-events"],
|
|
["DELETE", "http://localhost:3100/api/secrets/secret-1"],
|
|
]);
|
|
});
|
|
});
|
|
|
|
async function runSecretCommand(args: string[]): Promise<void> {
|
|
const program = new Command();
|
|
program.exitOverride();
|
|
program.configureOutput({ writeOut: () => {}, writeErr: () => {} });
|
|
registerSecretCommands(program);
|
|
await program.parseAsync([...args, "--api-base", "http://localhost:3100", "--api-key", "board-token"], { from: "user" });
|
|
}
|
|
|
|
function jsonResponse(body: unknown = { ok: true }, init: ResponseInit = { status: 200 }): Response {
|
|
return new Response(JSON.stringify(body), init);
|
|
}
|