mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-11-10 20:46:28 +01:00
## Thinking Path > - Paperclip manages AI agents and their paid work. > - Budgets must prevent new work and stop reported overruns. > - Cost settlement also ran serial lifecycle reconciliation for every eligible company agent. > - That made request latency grow with unrelated idle agents and delayed results on stop delivery. > - This change separates atomic admission and accounting from durable asynchronous enforcement. > - Scoped live usage detects overruns without writing provisional ledger charges. > - The result is constant query scope for ordinary settlement and recoverable stop delivery. ## Linked Issues or Issue Description **What happened?** Settlement and budget checks entered company-wide lifecycle reconciliation. A company with 1,000 unrelated idle agents performed 1,001 accounting transactions for one ordinary cost evaluation. User requests could also wait for provider termination. Running usage checkpoints did not enforce reported monetary exposure. **Expected behavior** Keep the final reservation gate authoritative. Commit charges, scope blocks, and enforcement intent before returning. Deliver stop requests after commit. Read only applicable policies and execution scopes for ordinary charges. Stop long-running work when supported reported or priced usage establishes an overrun. **Steps to reproduce** 1. Create a disposable company with one company budget and idle agents. 2. Evaluate a charge below the budget with 0, 17, and 1,000 unrelated idle agents. 3. Compare query counts, company accounting transactions, and duration. 4. Use the controlled partial-usage and delayed-stop fixtures to check enforcement and request responsiveness. **Paperclip version or commit** The measured baseline is `6c9b87d0922f1ebfc43e8b0c36889ac5ba7b9837` from `master`. Related public work: Refs #16976, #2006, #3539, #13763, #14296, #16853, #13075. These cover the affected service charge, cancellation, and accounting paths. This change removes their shared reconciliation overhead. ## What Changed - Batch applicable policy exposure under the existing company accounting lock. Preserve exact fractional money and zero-reservation dispatch fences. - Commit a durable final budget dispatch claim before provider I/O. Retain a separate final issue/run ownership transaction through synchronous handoff, without holding the company accounting lock or awaiting provider work. Preserve native recovery lease checks and duplicate handoff fencing. Browser handoff rechecks current policy; it reuses a consumed rate slot only for the identical policy generation. - Separate ledger spend, live observed spend, and effective held capacity. Use the maximum of reservation and live observation for each unfinished operation. - Deliver budget cancellation through the existing coordinator. Revalidate generations and persist queued/running stop fences before external termination. Bound stop concurrency to four. - Apply agent holds only to the affected agent. Project budgets leave other projects running. Project real company transitions in bounded lifecycle batches. - Replace periodic broad reconciliation with durable pending work, startup repair, receipt replay, and concrete retry/window deadlines. Retain drain and idle-safety checks. - Enforce accepted cumulative usage checkpoints without provisional charges. Final accounting atomically replaces live exposure and settles reservations. - Add operator-gated budget spans, regression coverage, map updates, and a real-PostgreSQL comparison harness. No schema or first-party telemetry change. ## Verification - Full workspace `pnpm -r typecheck` passes on the final ownership fix, rebased onto `bbcf5dfe98`. Production `pnpm build` passes on final head `4c5f4de8b1`. Map, module-boundary, token, and Storybook catalog checks pass. - Focused real-PostgreSQL coverage includes the 292-case rebased accounting/dispatch run, 63 browser cases, 52 run-control/cancellation cases, 42 policy-generation cases, 77 lifecycle/commentary cases, and the exact Muse confirmation regression. Native executor unit coverage passes all 768 cases. Final ownership coverage passes: 74 adapter/use-case cases, nine public regression cases, and the additional deleted-project race. These exercise competing ownership, budget changes and charges between phases, zero/nonzero duplicate claims, rollback, recovery contention, read-only capacity rechecks, and controlled HTTP startup after commit. Another 74 pure/startup/tracing cases pass. The complete CI matrix and both 5/5 reviews passed on `1ac9b58`; its external security scan identified a stale-owner handoff race. The final fix restores synchronous issue/run ownership fencing after the accounting transaction commits. Final head `8e84f55ce8` has fresh Greptile 5/5 with zero new comments, Paperclip review 5/5, and a passing security scan. The complete latest-head [CI matrix](https://github.com/paperclipai/paperclip/actions/runs/39535189808) passes, including budget, browser, Runner, build, and canary jobs. The unchanged Runner close fixture passed on its sole same-head job retry. - Broad local `pnpm test:run` invocations were stopped before required source updates (rebase and review fixes). They are not claimed as full passes. Final full-suite coverage comes from the complete latest-head CI matrix; local focused coverage and the incomplete broad invocations are reported separately. - Reproduce performance with `pnpm --filter @paperclipai/server exec tsx ../scripts/benchmark-budget-enforcement.ts --baseline-ref=6c9b87d0922f1ebfc43e8b0c36889ac5ba7b9837`; repeat with `--reverse`. The harness uses disposable real PostgreSQL, 20 warm samples per variant/count, and records raw timings, SQL/lock counts, agent reads, unchanged agent state, and query plans. Final production-source measurement revision: `eff713a4f72c7f4b7a4002a701cb481d4bfccd95`; the extended harness is committed in `4c5f4de8b1`. | Unrelated idle agents | Baseline median / p95 | New median / p95 | Baseline SQL / locks | New SQL / locks | New agent reads | | --- | ---: | ---: | ---: | ---: | ---: | | 0 | 1.80 / 2.33 ms | 2.99 / 3.88 ms | 5 / 1 | 7 / 1 | 0 | | 17 | 15.53 / 19.55 ms | 2.24 / 2.60 ms | 90 / 18 | 7 / 1 | 0 | | 1,000 | 978.35 / 1,790.43 ms | 2.16 / 2.52 ms | 5,005 / 1,001 | 7 / 1 | 0 | - These measurements use local PostgreSQL 18.1 and Node 26.4.0 arm64. They isolate the cost-evaluation core and complete admission path, without hosted-region or provider latency. Prior-revision reversed-order controls also preserved the constant query counts; the final measurements above use the final production source. - Complete reserve → final ownership gate → immediate offline provider result is measured separately, with one responsible agent and one active operation at each unrelated-agent count. Admission p95 baseline/new: 0 agents **11.54 / 29.77 ms**; 17 agents **9.31 / 27.62 ms**; 1,000 agents **24.51 / 74.05 ms**. Baseline admission was already scoped; the stronger final fence adds bounded overhead. New counts stay constant at 53 Drizzle statements, three transactions, two company-accounting locks, and five agent-reading statements bound to the responsible agent. Zero unrelated-agent reads, exactly one provider callback per sample, and no leftover runs or holds. All admission scenarios stay below 250 ms. No external provider calls are included. - The partial-usage/delayed-termination fixture passed 20/20: receipt persistence p95 13 ms, receipt return to observed durable Stop fence p95 28 ms, complete receipt-start-to-fence p95 50 ms, unrelated database request p95 1 ms while termination was blocked. After releasing the controlled termination fixture, acknowledgement p95 was 14 ms. These are separately measured phases; fixture acknowledgement is not live-provider termination latency. - Models and provider deadlines are unchanged. No deployment, live inference, or staging acceptance is claimed. A quiet 30-minute follow-up waits for the merged revision on staging, then repeats classifier and controlled budget-stop acceptance in staging, recording hosted bookkeeping, queue delay, and actual provider acknowledgement separately. - Development failures retained: finalizer notification regressions (fixed; 27/27 affected cases passed), invalid browser admission fixture assumptions (fixed; browser coverage now passes 63/63), and first-head lifecycle/dispatch CI regressions (reproduced and repaired). A prior-head Cases E2E test hit its unchanged announcement-dismiss handler race while opening a filter; the same journey passed on `1ac9b58`. The external security review then found a stale-owner race between accounting commit and provider entry; final verification covers a competing run in that gap while retaining provider I/O outside the accounting lock. Early PostgreSQL startup attempts hit local semaphore pressure; serial reruns succeeded. The final-head Runner lane had one failure among 1,823 tests: the unchanged `timeout-attachment` fixture failed at its first process close after 6.28 seconds. The sole same-head job retry passed all 1,819 active tests (four skipped), including that fixture in 1.85 seconds. Three isolated local probes could not run correctly because the Rust fake-provider fixture binary was absent; cleanup masked the original startup failure. CI builds that fixture through its normal lane. These probes are inconclusive and are not counted as passes. ## Risks - This changes accounting, lifecycle, and cancellation ordering. Durable generations, source/sequence checks, ownership leases, and company locking remain required for correctness. - Provider stop acknowledgement can be slow or fail. Stop intent remains pending until existing termination proof succeeds; cancelled row status alone does not acknowledge delivery. - Mid-run limits depend on provider usage reports or supported price calculations. Providers that report only at completion cannot provide exact mid-call detection. - Signals are process-local wake hints for the supported single-active-writer model. Durable state and startup recovery remain authoritative. - There are no migrations, new queue tables, or cached balances. Repeat the classifier and controlled budget-stop acceptance after normal rollout. ## Model Used OpenAI Codex, based on GPT-6, with reasoning, tool use, code execution, and parallel coding agents. The host does not expose the exact backend model revision or context-window size, so those values are not asserted. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
239 lines
16 KiB
TypeScript
239 lines
16 KiB
TypeScript
import { usdToUnits, unitsToCents } from "@paperclipai/shared";
|
|
import { and, asc, eq, inArray, or, sql } from "drizzle-orm";
|
|
import { accountingRuntimeBaselines, budgetReservations, agentRuntimeState, agents, costEvents, heartbeatRuns, nativeRunFinalizations, issues, projects, decisionInvocations, promptInjectionInvocations, type Db } from "@paperclipai/db";
|
|
import { withAccountingTransaction } from "./accounting-transaction.js";
|
|
import { withBudgetSpan } from "./budget-tracing.js";
|
|
import { conflict } from "../errors.js";
|
|
import { createCostEventInTransaction } from "./costs.js";
|
|
import { budgetServiceInTransaction, type BudgetServiceHooks } from "./budgets.js";
|
|
import { logger } from "../middleware/logger.js";
|
|
import { promises as fs } from "node:fs";
|
|
import { replayUsageReceipts, indexPendingUsageReceipts, recoverPendingRunUsageReceipts, type UsageReceiptIndex } from "./usage-receipts.js";
|
|
|
|
const terminalStatuses = ["succeeded", "failed", "timed_out", "cancelled", "interrupted"];
|
|
const object = (value: unknown): Record<string, unknown> => value && typeof value === "object" && !Array.isArray(value) ? value as Record<string, unknown> : {};
|
|
const text = (value: unknown) => typeof value === "string" && value.length > 0 ? value : null;
|
|
const amount = (value: unknown) => typeof value === "number" && Number.isFinite(value) && value >= 0 ? value : null;
|
|
|
|
/** The run's persisted usage is a durable receipt. Ledger, runtime totals, and
|
|
* acknowledgement commit together, including after a restart or failed run. */
|
|
export async function accountRunCost(db: Db, runId: string, hooks: BudgetServiceHooks = {}, receiptIndex?: UsageReceiptIndex) {
|
|
const [identity] = await db.select({ companyId: heartbeatRuns.companyId, status: heartbeatRuns.status,
|
|
pending: heartbeatRuns.costAccountingPending, accountedAt: heartbeatRuns.costAccountedAt,
|
|
issueId: sql<string | null>`${heartbeatRuns.usageJson}->'ledgerScope'->>'issueId'`,
|
|
}).from(heartbeatRuns).where(eq(heartbeatRuns.id, runId));
|
|
if (!identity || !identity.pending || !terminalStatuses.includes(identity.status)) return false;
|
|
// Finalization can call twice. Settled or active runs owe no accounting work.
|
|
// Pending acknowledgements still receive the locked stale-marker cleanup.
|
|
const index = identity.pending && !identity.accountedAt && terminalStatuses.includes(identity.status)
|
|
? receiptIndex ?? await indexPendingUsageReceipts() : undefined;
|
|
let recoveredFiles: string[] = [];
|
|
const accounted = await withBudgetSpan("budget.accounting.settlement", () => withAccountingTransaction(db, identity.companyId, async (tx, publications) => {
|
|
// Native recovery owns the issue before updating its run. Acquire the
|
|
// charge's issue FK lock first so inserting it cannot reverse that order.
|
|
const issueId = text(identity.issueId);
|
|
if (issueId) await tx.select({ id: issues.id }).from(issues).where(and(
|
|
eq(issues.companyId, identity.companyId), eq(issues.id, issueId),
|
|
)).for("key share");
|
|
let [run] = await tx.select().from(heartbeatRuns).where(eq(heartbeatRuns.id, runId)).for("update");
|
|
if (!run?.costAccountingPending || !terminalStatuses.includes(run.status)) return false;
|
|
if (run.costAccountedAt) {
|
|
await tx.update(heartbeatRuns).set({ costAccountingPending: false }).where(eq(heartbeatRuns.id, run.id));
|
|
await budgetServiceInTransaction(tx, publications).evaluateAffectedScopes(run.companyId, run.agentId,
|
|
text(object(object(run.usageJson).ledgerScope).projectId));
|
|
return false;
|
|
}
|
|
// The bounded global replay can leave a newer receipt behind an older
|
|
// complete snapshot. Drain this run under the accounting lock before
|
|
// deciding completeness, and retain disk evidence until the outer commit.
|
|
recoveredFiles = await recoverPendingRunUsageReceipts(tx, { companyId: identity.companyId, runId }, undefined, { retainFiles: true, index });
|
|
[run] = await tx.select().from(heartbeatRuns).where(eq(heartbeatRuns.id, runId));
|
|
if (text(object(object(run.usageJson).ledgerScope).issueId) !== issueId) {
|
|
throw conflict("Run cost attribution changed. Retry accounting.");
|
|
}
|
|
// A failed capture may follow an older complete attempt. Neither replay
|
|
// nor terminal status can certify that the missing work was free.
|
|
if (object(run.usageJson).accountingCaptureFailed === true) return false;
|
|
const preProviderFailure = object(object(run.resultJson).executionRecovery).providerWorkStarted === false
|
|
|| object(run.usageJson).accountingProviderWorkStarted === false;
|
|
// A failed native turn is not necessarily the end of this heartbeat: the
|
|
// coordinator can resume the same run. Only its closed provider boundary
|
|
// authorizes acknowledgement; finalization may still run after a result.
|
|
if (run.runtimeMode === "native" && !preProviderFailure) {
|
|
const [coordinator] = await tx.select().from(nativeRunFinalizations).where(eq(nativeRunFinalizations.runId, run.id));
|
|
if (coordinator && !coordinator.resultId && coordinator.phase !== "terminal_failure") return false;
|
|
}
|
|
// A stop can mark the run terminal before the provider's shutdown receipt
|
|
// arrives. Keep the debt pending instead of acknowledging an invented zero
|
|
// and permanently discarding that late receipt.
|
|
if (!preProviderFailure && object(run.usageJson).accountingReceiptReady === false) return false;
|
|
// Acknowledgement is part of the same transaction. Budget checks inside
|
|
// this transaction must not mistake this receipt for missing accounting.
|
|
await tx.update(heartbeatRuns).set({ costAccountingPending: false, costAccountedAt: new Date() }).where(eq(heartbeatRuns.id, run.id));
|
|
await tx.update(budgetReservations).set({ state: preProviderFailure ? "released" : "settled", settledAt: new Date() })
|
|
.where(and(eq(budgetReservations.companyId, run.companyId), eq(budgetReservations.runId, run.id), eq(budgetReservations.state, "held")));
|
|
if (preProviderFailure) {
|
|
await budgetServiceInTransaction(tx, publications).evaluateAffectedScopes(run.companyId, run.agentId,
|
|
text(object(object(run.usageJson).ledgerScope).projectId));
|
|
return true;
|
|
}
|
|
const usage = object(run.usageJson);
|
|
const scope = object(usage.ledgerScope);
|
|
// Deleted attribution targets become unallocated; a deletion must never
|
|
// prevent recording provider spend. Foreign-company references still fail.
|
|
for (const [table, key] of [[issues, "issueId"], [projects, "projectId"]] as const) {
|
|
const id = text(scope[key]);
|
|
if (id) {
|
|
const [linked] = await tx.select({ id: table.id }).from(table).where(eq(table.id, id));
|
|
if (!linked) scope[key] = null;
|
|
}
|
|
}
|
|
const costUsd = amount(usage.cacheAdjustedCostUsd) ?? text(usage.costUsdExact) ?? amount(usage.costUsd);
|
|
const billingType = text(usage.billingType) ?? "unknown";
|
|
const costUnits = billingType === "subscription_included" ? 0n : usdToUnits(costUsd ?? 0);
|
|
const costCents = unitsToCents(costUnits);
|
|
const [agent] = await tx.select({ adapterType: agents.adapterType }).from(agents).where(eq(agents.id, run.agentId));
|
|
const hasBillableEvidence = agent?.adapterType !== "process" || costUsd !== null || usage.costStatus === "unpriced"
|
|
|| ["inputTokens", "cachedInputTokens", "outputTokens"].some(key => (amount(usage[key]) ?? 0) > 0)
|
|
|| (text(usage.provider) !== null && usage.provider !== "unknown");
|
|
const receipt = {
|
|
idempotencyKey: `heartbeat:${run.id}:final`,
|
|
agentId: run.agentId, heartbeatRunId: run.id,
|
|
issueId: text(scope.issueId), projectId: text(scope.projectId), billingCode: text(scope.billingCode),
|
|
provider: text(usage.provider) ?? "unknown", biller: text(usage.biller) ?? text(usage.provider) ?? "unknown",
|
|
providerRequestId: text(usage.providerRequestId),
|
|
pricingProvenance: object(usage.pricingProvenance),
|
|
model: text(usage.model) ?? "unknown", billingType,
|
|
costStatus: (costUsd === null || usage.costStatus === "unpriced") && billingType !== "subscription_included" && hasBillableEvidence ? "unpriced" : usage.costStatus === "estimated" ? "estimated" : "reported",
|
|
inputTokens: amount(usage.inputTokens) ?? 0, cachedInputTokens: amount(usage.cachedInputTokens) ?? 0, outputTokens: amount(usage.outputTokens) ?? 0,
|
|
costCents, occurredAt: run.finishedAt ?? run.createdAt,
|
|
};
|
|
const parts = Array.isArray(usage.usageByModel) ? usage.usageByModel.map(object) : [];
|
|
const tokensMatch = ["inputTokens", "cachedInputTokens", "outputTokens"].every((key) =>
|
|
parts.reduce((sum, part) => sum + (amount(object(part.usage)[key]) ?? 0), 0) === (amount(usage[key]) ?? 0));
|
|
const costMatches = costUsd !== null && parts.reduce((sum, part) => sum + usdToUnits(amount(part.costUsd) ?? 0), 0n) === usdToUnits(costUsd);
|
|
const validParts = parts.length > 0 && tokensMatch && costMatches
|
|
&& parts.every((part) => text(part.model) && amount(part.costUsd) !== null)
|
|
&& new Set(parts.map((part) => part.model)).size === parts.length;
|
|
if (validParts) {
|
|
let allocated = 0n;
|
|
for (const [index, part] of parts.entries()) {
|
|
const partUsage = object(part.usage);
|
|
const remainder = costUnits - allocated;
|
|
const reported = usdToUnits(amount(part.costUsd) ?? 0);
|
|
const partUnits = billingType === "subscription_included" ? 0n : index === parts.length - 1 ? remainder : reported < remainder ? reported : remainder;
|
|
allocated += partUnits;
|
|
const partCents = unitsToCents(partUnits);
|
|
await createCostEventInTransaction(tx, run.companyId, {
|
|
...receipt, idempotencyKey: `heartbeat:${run.id}:model:${index}`, model: text(part.model)!,
|
|
inputTokens: amount(partUsage.inputTokens) ?? 0, cachedInputTokens: amount(partUsage.cachedInputTokens) ?? 0,
|
|
outputTokens: amount(partUsage.outputTokens) ?? 0, costCents: partCents,
|
|
}, publications, undefined, { deferBudgetEvaluation: true });
|
|
}
|
|
} else {
|
|
await createCostEventInTransaction(tx, run.companyId, receipt, publications, undefined, { deferBudgetEvaluation: true });
|
|
}
|
|
await budgetServiceInTransaction(tx, publications).evaluateAffectedScopes(run.companyId, run.agentId, text(scope.projectId));
|
|
const [event] = await tx.select({
|
|
inputTokens: sql<string>`coalesce(sum(${costEvents.inputTokens}),0)::text`,
|
|
cachedInputTokens: sql<string>`coalesce(sum(${costEvents.cachedInputTokens}),0)::text`,
|
|
outputTokens: sql<string>`coalesce(sum(${costEvents.outputTokens}),0)::text`,
|
|
costCents: sql<string>`coalesce(sum(${costEvents.costCents}),0)::text`,
|
|
}).from(costEvents).where(and(eq(costEvents.companyId, run.companyId), eq(costEvents.heartbeatRunId, run.id)));
|
|
await tx.insert(agentRuntimeState).values({ agentId: run.agentId, companyId: run.companyId, adapterType: agent.adapterType }).onConflictDoNothing();
|
|
await tx.execute(sql`insert into accounting_runtime_baselines (agent_id,company_id,cost_cents,input_tokens,cached_input_tokens,output_tokens)
|
|
select agent_id,company_id,total_cost_cents,total_input_tokens,total_cached_input_tokens,total_output_tokens
|
|
from agent_runtime_state where agent_id = ${run.agentId} on conflict do nothing`);
|
|
await tx.update(agentRuntimeState).set({
|
|
totalInputTokens: sql`${agentRuntimeState.totalInputTokens} + ${event.inputTokens}`,
|
|
totalCachedInputTokens: sql`${agentRuntimeState.totalCachedInputTokens} + ${event.cachedInputTokens}`,
|
|
totalOutputTokens: sql`${agentRuntimeState.totalOutputTokens} + ${event.outputTokens}`,
|
|
totalCostCents: sql`${agentRuntimeState.totalCostCents} + ${event.costCents}::numeric`,
|
|
updatedAt: new Date(),
|
|
}).where(eq(agentRuntimeState.agentId, run.agentId));
|
|
await tx.update(heartbeatRuns).set({ costAccountingPending: false, costAccountedAt: new Date(), accountingProjectionVersion: "v2", accountingLastError: null, accountingLastAttemptAt: new Date() }).where(eq(heartbeatRuns.id, run.id));
|
|
return true;
|
|
}));
|
|
for (const file of recoveredFiles) {
|
|
try { await fs.rm(file, { force: true }); }
|
|
catch (error) { logger.warn({ err: error, runId }, "Accounting committed; recovered receipt cleanup will retry"); }
|
|
}
|
|
return accounted;
|
|
}
|
|
|
|
function actionableRunAccounting() {
|
|
return and(
|
|
eq(heartbeatRuns.costAccountingPending, true), inArray(heartbeatRuns.status, terminalStatuses),
|
|
or(sql`${heartbeatRuns.costAccountedAt} is not null`, and(
|
|
sql`${heartbeatRuns.usageJson}->>'accountingCaptureFailed' is distinct from 'true'`,
|
|
sql`(${heartbeatRuns.resultJson}->'executionRecovery'->>'providerWorkStarted' = 'false'
|
|
or ${heartbeatRuns.usageJson}->>'accountingProviderWorkStarted' = 'false'
|
|
or not exists (select 1 from ${nativeRunFinalizations} where ${nativeRunFinalizations.runId} = ${heartbeatRuns.id}
|
|
and ${heartbeatRuns.runtimeMode} = 'native' and ${nativeRunFinalizations.resultId} is null
|
|
and ${nativeRunFinalizations.phase} <> 'terminal_failure'))`,
|
|
sql`(${heartbeatRuns.usageJson}->>'accountingReceiptReady' is distinct from 'false' or ${heartbeatRuns.resultJson}->'executionRecovery'->>'providerWorkStarted' = 'false' or ${heartbeatRuns.usageJson}->>'accountingProviderWorkStarted' = 'false')`,
|
|
)),
|
|
);
|
|
}
|
|
|
|
/** Only unfinished, actionable debt warrants retries. Incomplete provider
|
|
* receipts retain their accounting/idle hold and wake when evidence arrives. */
|
|
export async function readCostAccountingWork(db: Db, now = Date.now(), receiptDirectory?: string) {
|
|
const [pending] = await db.select({ id: heartbeatRuns.id }).from(heartbeatRuns).where(actionableRunAccounting()).limit(1);
|
|
const [deadline] = await db.execute<{ at: Date | string | null }>(sql`
|
|
select min(started_at) + interval '120 seconds 1 millisecond' as at from (
|
|
select ${decisionInvocations.startedAt} as started_at from ${decisionInvocations}
|
|
where ${decisionInvocations.status} = 'running'
|
|
union all
|
|
select ${promptInjectionInvocations.startedAt} from ${promptInjectionInvocations}
|
|
where ${promptInjectionInvocations.status} = 'running'
|
|
) running_service_invocations`);
|
|
const nextRunAt = deadline?.at == null ? null : new Date(deadline.at).getTime();
|
|
const receipts = await indexPendingUsageReceipts(receiptDirectory);
|
|
return {
|
|
pending: !!pending || receipts.size > 0 || (nextRunAt !== null && nextRunAt <= now),
|
|
nextRunAt,
|
|
};
|
|
}
|
|
|
|
export async function reconcileRunCosts(db: Db, hooks: BudgetServiceHooks = {}) {
|
|
const pending = await db.select({ id: heartbeatRuns.id }).from(heartbeatRuns).where(actionableRunAccounting())
|
|
.orderBy(asc(heartbeatRuns.updatedAt), asc(heartbeatRuns.id)).limit(100);
|
|
let accounted = 0;
|
|
const receiptIndex = pending.length > 0 ? await indexPendingUsageReceipts() : undefined;
|
|
for (const run of pending) {
|
|
try { if (await accountRunCost(db, run.id, hooks, receiptIndex)) accounted++; }
|
|
catch (error) {
|
|
// Move failed attempts behind other pending work so a poisoned receipt
|
|
// cannot monopolize the bounded batch on every recovery tick.
|
|
await db.update(heartbeatRuns).set({ updatedAt: new Date(), accountingLastAttemptAt: new Date(), accountingAttemptCount: sql`${heartbeatRuns.accountingAttemptCount} + 1`, accountingLastError: error instanceof Error ? error.message.slice(0, 1000) : "Accounting failed" }).where(eq(heartbeatRuns.id, run.id));
|
|
logger.error({ err: error, runId: run.id }, "Run accounting remains pending for retry");
|
|
}
|
|
}
|
|
return { scanned: pending.length, accounted };
|
|
}
|
|
|
|
/** Share recovery across overlapping signals. The owning delivery worker
|
|
* schedules retries only while a durable receipt or actionable debt remains. */
|
|
export function createCostAccountingReconciler(db: Db, hooks: BudgetServiceHooks = {}, recoverServices?: () => Promise<void>) {
|
|
let inFlight: Promise<Awaited<ReturnType<typeof reconcileRunCosts>>> | undefined;
|
|
return () => {
|
|
if (!inFlight) {
|
|
inFlight = (async () => {
|
|
try {
|
|
let serviceRecoveryFailure: { error: unknown } | undefined;
|
|
try { await recoverServices?.(); }
|
|
catch (error) { serviceRecoveryFailure = { error }; }
|
|
await replayUsageReceipts(db);
|
|
const result = await reconcileRunCosts(db, hooks);
|
|
if (serviceRecoveryFailure) throw serviceRecoveryFailure.error;
|
|
return result;
|
|
} finally {
|
|
inFlight = undefined;
|
|
}
|
|
})();
|
|
}
|
|
return inFlight;
|
|
};
|
|
}
|