mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-23 17:33:51 +02:00
DottaandPaperclip
f329b24ee1
Give tasks durable company-scoped workspace bindings independent of project assignment, channel defaults and authorized repository preparation. Reuse verified input seeds and sparse output recovery while preserving trust, privacy and controller provisioning boundaries.
Full CI and E2E, Superagent, legacy checks and Greptile Apex 5/5 passed on reviewed head 753680b61c. All review findings are resolved; the PR records focused verification and historical acceptance limits.
Co-Authored-By: Paperclip <noreply@paperclip.ing>
38 lines
2.7 KiB
TypeScript
38 lines
2.7 KiB
TypeScript
import fs from "node:fs/promises";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { ensurePersistedExecutionWorkspaceAvailable } from "../services/workspace-runtime.js";
|
|
import { describe, expect, it } from "vitest";
|
|
import { canApplyTaskWorkspaceSelectionAtAdmission, taskWorkspaceRuntimeSelectionEnabled, parseIssueExecutionWorkspaceSettings, resolveExecutionWorkspaceMode } from "../services/execution-workspace-policy.js";
|
|
|
|
describe("task workspace admission authority", () => {
|
|
it.each([{ hasTypedSelection: true, hasBinding: false }, { hasTypedSelection: false, hasBinding: true }])("keeps isolated intent authoritative with the legacy UI disabled: %j", flags => {
|
|
const enabled = taskWorkspaceRuntimeSelectionEnabled({ legacyUiEnabled: false, ...flags });
|
|
const settings = enabled ? parseIssueExecutionWorkspaceSettings({ mode: "isolated_workspace" }) : null;
|
|
expect(resolveExecutionWorkspaceMode({ projectPolicy: null, issueSettings: settings, legacyUseProjectWorkspace: null })).toBe("isolated_workspace");
|
|
});
|
|
it.each([
|
|
{ admittedInput: { schema: "paperclip.native-execution-input.v3", binding: { executionWorkspaceId: "old-projectless-run" } }, restarting: false, hasLeaseOwner: false },
|
|
{ admittedInput: null, restarting: true, hasLeaseOwner: false },
|
|
{ admittedInput: null, restarting: false, hasLeaseOwner: true },
|
|
])("defers pending root changes while immutable execution/recovery owns the root", admission => {
|
|
expect(canApplyTaskWorkspaceSelectionAtAdmission(admission)).toBe(false);
|
|
});
|
|
it("keeps a persisted task-owned source projectless when current organizational defaults have a project", async () => {
|
|
const cwd = await fs.mkdtemp(path.join(os.tmpdir(), "paperclip-source-authority-"));
|
|
try {
|
|
const restored = await ensurePersistedExecutionWorkspaceAvailable({
|
|
base: { baseCwd: cwd, source: "project_primary", projectId: "org-project", workspaceId: "org-source", repoUrl: null, repoRef: null },
|
|
workspace: { mode: "shared_workspace", strategyType: "project_primary", cwd, providerRef: cwd,
|
|
projectId: null, projectWorkspaceId: null, repoUrl: null, baseRef: null, branchName: null },
|
|
issue: { id: "task", identifier: null, title: "Retain files" },
|
|
agent: { id: "agent", companyId: "company", name: "Agent" },
|
|
});
|
|
expect(restored).toMatchObject({ cwd, projectId: null, workspaceId: null });
|
|
} finally { await fs.rm(cwd, { recursive: true, force: true }); }
|
|
});
|
|
it("permits new admission to apply explicit pending intent", () => {
|
|
expect(canApplyTaskWorkspaceSelectionAtAdmission({ admittedInput: null, restarting: false, hasLeaseOwner: false })).toBe(true);
|
|
});
|
|
});
|