mirror of
https://github.com/paperclipai/paperclip.git
synced 2026-10-29 04:25:52 +01:00
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - External agents keep their own tools and app connections. > - The Paperclip assignment catalog controls the Paperclip bridge. > - Dot treated a qualification test restriction as a rule for later work. > - Existing prompts did not clearly separate these two tool sources. > - This pull request tells agents to use their own capabilities and return results to Paperclip. > - The benefit is that a missing Paperclip app does not block an available native capability. ## Linked Issues or Issue Description Related work: #15722 and #15691. I searched open PRs for Dot tool guidance and found no duplicate. **What happened?** After a qualification test, Dot refused a Slack request because the test Paperclip agent had no assigned Slack app. Dot already had a working Slack connection in ChatGPT. It carried the test's plugin restriction into a later task message. **Expected behavior** An external agent uses its own available tools, apps, plugins, skills, and capabilities to complete the current request. It then returns the result through Paperclip's task reporting and completion tools. The assignment catalog limits Paperclip calls. It does not disable the agent's native tools. **Steps to reproduce** 1. Connect a Dot that has a native Slack connection. 2. Complete a Paperclip qualification task with a restriction scoped to that test. 3. Send a later task message that requires Slack. 4. Observe that Dot can mistake the Paperclip catalog for its full tool inventory. **Deployment mode** Observed on Cloud staging with the Dot Runner. ## What Changed - Add shared tool-use guidance for external-agent onboarding and Dot setup. - Include it in the server onboarding document, pairing response, event instructions, and capability response. - Clarify the tool descriptions on both Dot bridge paths. - Include the same guidance in each Dot Runner assignment without adding a shared-package dependency to the standalone Runner. - Document native tool use and the scope of test restrictions. ## Verification - The 49 relevant onboarding, Dot invitation, and Runner context tests passed. The final UI run passed 29 tests. The updated plain-text renderer run passed all 4 tests. - Full workspace typecheck, full workspace build, and design token gates passed. All current-head CI gates passed, including full tests, Runner verification, and browser E2E. Greptile is 5/5 on the exact final commit, and the one review finding is resolved. - The real Dot received the standing correction and confirmed that it will use its relevant tools and connections, return results through Paperclip, and stop carrying the test restriction forward. - Extended the existing plain-text renderer test to check native Slack access, qualification-test scope, and the Paperclip denial boundary. This covers agents that receive only the onboarding.txt URL. - The full Vitest suite passed in CI. The earlier local Cloud qualification run encountered failures in unchanged suites; this follow-up uses focused local tests for the instruction changes. ## Risks This changes instructions, not access checks. Native tools retain their own permissions and approval requirements. Paperclip operations remain scoped to the authorized company, agent, and task. Agents must not use another connection or identity to bypass a denial. There is no database migration or new permission grant. ## Model Used OpenAI GPT-6 through Codex. Used reasoning, repository tools, and browser control. The runtime does not expose a more specific model ID or context window size. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
212 lines
8.1 KiB
TypeScript
212 lines
8.1 KiB
TypeScript
import os from "node:os";
|
|
import { describe, expect, it } from "vitest";
|
|
import { vi } from "vitest";
|
|
import type { Request } from "express";
|
|
import { buildInviteOnboardingTextDocument } from "../routes/access.js";
|
|
|
|
function buildReq(host: string): Request {
|
|
return {
|
|
protocol: "http",
|
|
header(name: string) {
|
|
if (name.toLowerCase() === "host") return host;
|
|
return undefined;
|
|
},
|
|
} as unknown as Request;
|
|
}
|
|
|
|
describe("buildInviteOnboardingTextDocument", () => {
|
|
it("renders a plain-text onboarding doc with expected endpoint references", () => {
|
|
const req = buildReq("localhost:3100");
|
|
const invite = {
|
|
id: "invite-1",
|
|
companyId: "company-1",
|
|
inviteType: "company_join",
|
|
allowedJoinTypes: "agent",
|
|
tokenHash: "hash",
|
|
defaultsPayload: null,
|
|
expiresAt: new Date("2026-03-05T00:00:00.000Z"),
|
|
invitedByUserId: null,
|
|
revokedAt: null,
|
|
acceptedAt: null,
|
|
createdAt: new Date("2026-03-04T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-04T00:00:00.000Z"),
|
|
} as const;
|
|
|
|
const text = buildInviteOnboardingTextDocument(req, "token-123", invite as any, {
|
|
deploymentMode: "local_trusted",
|
|
deploymentExposure: "private",
|
|
bindHost: "127.0.0.1",
|
|
allowedHostnames: [],
|
|
});
|
|
|
|
expect(text).toContain("Paperclip Agent Onboarding");
|
|
expect(text).toContain("use your existing Slack connection");
|
|
expect(text).toContain("Setup or test restrictions apply only to their stated scope");
|
|
expect(text).toContain("Never use another Paperclip connection or identity to bypass a denial");
|
|
expect(text).toContain("/api/invites/token-123/accept");
|
|
expect(text).toContain("/api/join-requests/{requestId}/claim-api-key");
|
|
expect(text).toContain("/api/invites/token-123/onboarding.txt");
|
|
expect(text).toContain("/api/invites/token-123/skills/paperclip");
|
|
expect(text).toContain("Suggested Paperclip base URLs to try");
|
|
expect(text).toContain("http://localhost:3100");
|
|
expect(text).toContain("host.docker.internal");
|
|
expect(text).toContain("paperclipApiUrl");
|
|
expect(text).toContain('"adapterType": "openclaw_gateway"');
|
|
expect(text).toContain("headers.x-openclaw-token");
|
|
expect(text).toContain("Do NOT use /v1/responses or /hooks/*");
|
|
expect(text).toContain('adapterType: "hermes_gateway"');
|
|
expect(text).toContain('"adapterType": "hermes_gateway"');
|
|
expect(text).toContain("API_SERVER_ENABLED=true");
|
|
expect(text).toContain("API_SERVER_KEY");
|
|
expect(text).toContain("Set agentDefaultsPayload.apiKey to the exact same value as API_SERVER_KEY");
|
|
expect(text).toContain("hermes gateway run --replace --accept-hooks");
|
|
expect(text).toContain("Default Hermes API server port: 8642");
|
|
expect(text).toContain("agentDefaultsPayload.apiBaseUrl");
|
|
expect(text).toContain("agentDefaultsPayload.paperclipApiUrl");
|
|
expect(text).toContain("hermes_local");
|
|
expect(text).toContain("Hermes-originated Paperclip API usage");
|
|
expect(text).toContain("http://127.0.0.1:8642");
|
|
expect(text).toContain("http://127.0.0.1:9119");
|
|
expect(text).toContain("http://127.0.0.1:9119/chat");
|
|
expect(text).toContain("map to /api");
|
|
expect(text).toContain("/chat and the dashboard root are browser UI routes");
|
|
expect(text).toContain("/api/v1/runs");
|
|
expect(text).toContain("Do not rotate or invent a Paperclip key manually");
|
|
expect(text).toContain("http://192.168.1.25:8642");
|
|
expect(text).toContain("tailnet-name.ts.net:8642");
|
|
expect(text).toContain("http://host.docker.internal:8642");
|
|
expect(text).toContain("https://hermes-gateway.example");
|
|
expect(text).toContain("set the first reachable candidate as agentDefaultsPayload.paperclipApiUrl");
|
|
expect(text).toContain("PAPERCLIP_API_KEY");
|
|
expect(text).toContain("Store the parsed token field from the raw HTTP JSON response");
|
|
expect(text).toContain("A token value containing literal ... or [redacted]");
|
|
expect(text).toContain("The response body includes the full token exactly once");
|
|
expect(text).toContain("Do not persist displayed previews containing literal ... or [redacted]");
|
|
expect(text).toContain("Use your runtime's normal skill or instruction installation path.");
|
|
expect(text).toContain("Decide which Paperclip adapter type matches your runtime.");
|
|
});
|
|
|
|
it("includes loopback diagnostics for authenticated/private onboarding", () => {
|
|
const req = buildReq("localhost:3100");
|
|
const invite = {
|
|
id: "invite-2",
|
|
companyId: "company-1",
|
|
inviteType: "company_join",
|
|
allowedJoinTypes: "both",
|
|
tokenHash: "hash",
|
|
defaultsPayload: null,
|
|
expiresAt: new Date("2026-03-05T00:00:00.000Z"),
|
|
invitedByUserId: null,
|
|
revokedAt: null,
|
|
acceptedAt: null,
|
|
createdAt: new Date("2026-03-04T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-04T00:00:00.000Z"),
|
|
} as const;
|
|
|
|
const text = buildInviteOnboardingTextDocument(req, "token-456", invite as any, {
|
|
deploymentMode: "authenticated",
|
|
deploymentExposure: "private",
|
|
bindHost: "127.0.0.1",
|
|
allowedHostnames: [],
|
|
});
|
|
|
|
expect(text).toContain("Connectivity diagnostics");
|
|
expect(text).toContain("loopback hostname");
|
|
expect(text).toContain("If none are reachable");
|
|
});
|
|
|
|
it("includes inviter message in the onboarding text when provided", () => {
|
|
const req = buildReq("localhost:3100");
|
|
const invite = {
|
|
id: "invite-3",
|
|
companyId: "company-1",
|
|
inviteType: "company_join",
|
|
allowedJoinTypes: "agent",
|
|
tokenHash: "hash",
|
|
defaultsPayload: {
|
|
agentMessage: "Please join as our QA lead and prioritize flaky test triage first.",
|
|
},
|
|
expiresAt: new Date("2026-03-05T00:00:00.000Z"),
|
|
invitedByUserId: null,
|
|
revokedAt: null,
|
|
acceptedAt: null,
|
|
createdAt: new Date("2026-03-04T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-04T00:00:00.000Z"),
|
|
} as const;
|
|
|
|
const text = buildInviteOnboardingTextDocument(req, "token-789", invite as any, {
|
|
deploymentMode: "local_trusted",
|
|
deploymentExposure: "private",
|
|
bindHost: "127.0.0.1",
|
|
allowedHostnames: [],
|
|
});
|
|
|
|
expect(text).toContain("Message from inviter");
|
|
expect(text).toContain("prioritize flaky test triage first");
|
|
});
|
|
|
|
it("includes LAN candidates when the advertised host is tailnet-only", () => {
|
|
const networkSpy = vi.spyOn(os, "networkInterfaces").mockReturnValue({
|
|
en0: [
|
|
{
|
|
address: "fe80::1",
|
|
family: "IPv6",
|
|
internal: false,
|
|
netmask: "ffff:ffff:ffff:ffff::",
|
|
cidr: "fe80::1/64",
|
|
mac: "00:00:00:00:00:00",
|
|
scopeid: 1,
|
|
},
|
|
{
|
|
address: "192.168.6.178",
|
|
family: "IPv4",
|
|
internal: false,
|
|
netmask: "255.255.252.0",
|
|
cidr: "192.168.6.178/22",
|
|
mac: "00:00:00:00:00:00",
|
|
},
|
|
],
|
|
utun0: [
|
|
{
|
|
address: "203.0.113.42",
|
|
family: "IPv4",
|
|
internal: false,
|
|
netmask: "255.255.255.255",
|
|
cidr: "203.0.113.42/32",
|
|
mac: "00:00:00:00:00:00",
|
|
},
|
|
],
|
|
});
|
|
|
|
try {
|
|
const req = buildReq("paperclip.example.test:3103");
|
|
const invite = {
|
|
id: "invite-4",
|
|
companyId: "company-1",
|
|
inviteType: "company_join",
|
|
allowedJoinTypes: "agent",
|
|
tokenHash: "hash",
|
|
defaultsPayload: null,
|
|
expiresAt: new Date("2026-03-05T00:00:00.000Z"),
|
|
invitedByUserId: null,
|
|
revokedAt: null,
|
|
acceptedAt: null,
|
|
createdAt: new Date("2026-03-04T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-04T00:00:00.000Z"),
|
|
} as const;
|
|
|
|
const text = buildInviteOnboardingTextDocument(req, "token-999", invite as any, {
|
|
deploymentMode: "authenticated",
|
|
deploymentExposure: "private",
|
|
bindHost: "0.0.0.0",
|
|
allowedHostnames: ["paperclip.example.test", "203.0.113.42"],
|
|
});
|
|
|
|
expect(text).toContain("http://192.168.6.178:3103");
|
|
expect(text).not.toContain("http://[fe80::1]:3103");
|
|
} finally {
|
|
networkSpy.mockRestore();
|
|
}
|
|
});
|
|
});
|